[#102652] [Ruby master Bug#17664] Behavior of sockets changed in Ruby 3.0 to non-blocking — ciconia@...
Issue #17664 has been reported by ciconia (Sharon Rosner).
23 messages
2021/02/28
[ruby-core:102610] [Ruby master Bug#17027] Connection leak possibility in Net::FTP#transfercmd
From:
merch-redmine@...
Date:
2021-02-25 23:20:30 UTC
List:
ruby-core #102610
Issue #17027 has been updated by jeremyevans0 (Jeremy Evans).
Status changed from Open to Closed
The original pull request was closed, but I committed a similar fix: https://github.com/ruby/net-ftp/pull/6
----------------------------------------
Bug #17027: Connection leak possibility in Net::FTP#transfercmd
https://bugs.ruby-lang.org/issues/17027#change-90597
* Author: koshigoe (Masataka SUZUKI)
* Status: Closed
* Priority: Normal
* ruby -v: ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-darwin19]
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
----------------------------------------
https://github.com/ruby/ruby/blob/bad7ab35d1e38f47b09f15fc5750387ac73b2286/lib/net/ftp.rb#L542-L556
https://github.com/ruby/net-ftp/blob/14d2544190f7e4b77b41a3fd0c676f5b8ebd238c/lib/net/ftp.rb#L542-L556
The connection `conn` may not release if exception occurred.
### Reproduce
```
$ docker run --rm \
--name vsftpd \
-p 20-21:20-21 \
-p 21100-21110:21100-21110 \
-e FTP_USER=user \
-e FTP_PASS=pass \
-e PASV_ADDRESS=localhost \
-e PASV_MIN_PORT=21100 \
-e PASV_MAX_PORT=21110 \
fauria/vsftpd
```
```
$ docker exec vsftpd ps aux | grep vsftp
root 1 0.0 0.0 11704 2580 ? Ss 09:44 0:00 /bin/bash /usr/sbin/run-vsftpd.sh
root 13 0.0 0.1 53296 3884 ? S 09:44 0:00 /usr/sbin/vsftpd /etc/vsftpd/vsftpd.conf
```
```
$ diff -u ~/.rbenv/versions/2.7.1/lib/ruby/2.7.0/net/ftp.rb.orig ~/.rbenv/versions/2.7.1/lib/ruby/2.7.0/net/ftp.rb.orig
--- /Users/koshigoe/.rbenv/versions/2.7.1/lib/ruby/2.7.0/net/ftp.rb.orig 2020-07-13 19:41:53.000000000 +0900
+++ /Users/koshigoe/.rbenv/versions/2.7.1/lib/ruby/2.7.0/net/ftp.rb 2020-07-13 19:42:46.000000000 +0900
@@ -549,6 +549,7 @@
end
end
resp = sendcmd(cmd)
+ raise
# skip 2XX for some ftp servers
resp = getresp if resp.start_with?("2")
if !resp.start_with?("1")
```
```
require 'net/ftp'
ftp = Net::FTP.new
ftp.passive = true
ftp.binary = true
ftp.connect('localhost')
ftp.login('user', 'pass')
begin
ftp.put(__FILE__, '/uploaded-bin')
rescue
ftp.close
sleep 300
end
```
```
$ docker exec vsftpd ps aux | grep vsftp
root 1 0.0 0.0 11704 2580 ? Ss 09:44 0:00 /bin/bash /usr/sbin/run-vsftpd.sh
root 13 0.0 0.1 53296 3884 ? S 09:44 0:00 /usr/sbin/vsftpd /etc/vsftpd/vsftpd.conf
nobody 191 0.0 0.1 75752 4420 ? Ss 10:43 0:00 /usr/sbin/vsftpd /etc/vsftpd/vsftpd.conf
ftp 193 0.0 0.1 75852 3768 ? S 10:43 0:00 /usr/sbin/vsftpd /etc/vsftpd/vsftpd.conf
```
--
https://bugs.ruby-lang.org/
Unsubscribe: <mailto:[email protected]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>