[ruby-core:114489] [Ruby master Misc#19772] API naming for YARP compiler
From:
"Eregon (Benoit Daloze) via ruby-core" <ruby-core@...>
Date:
2023-08-24 13:00:31 UTC
List:
ruby-core #114489
Issue #19772 has been updated by Eregon (Benoit Daloze). Why introduce `Ruby::Parser` as a different namespace if it does the same as `YARP`? It doesn't seem a good idea to have 2 APIs for the same thing (memory overhead, defining every node class twice, etc) and in fact it is problematic on JRuby & TruffleRuby where YARP uses FFI and so 2 APIs would mean 2 librubyparser.so loaded in the same process which would cause symbol conflicts. The solution to this is simple, single YARP version in a process by being a gem and single API: YARP. And also Ruby::Parser is extremely confusing with existing [RubyParser](https://github.com/seattlerb/ruby_parser). ---------------------------------------- Misc #19772: API naming for YARP compiler https://bugs.ruby-lang.org/issues/19772#change-104274 * Author: jemmai (Jemma Issroff) * Status: Open * Priority: Normal ---------------------------------------- We are working on the YARP compiler, and have [the first PR ready](https://github.com/ruby/ruby/pull/8042) which introduces the YARP compile method. Our only outstanding question before merging it is about naming. How should we expose the public API for YARP's compile method? Potential suggestions: 1. YARP.compile 2. RubyVM::InstructionSequence.compile(yarp: true) 3. RubyVM::InstructionSequence.compile_yarp 4. Any of the above options, with a name other than yarp (please suggest an alternative) Regarding option 1, which would mirror `YARP.parse`, is the top level constant `YARP` acceptable? cc @matz @ko1 -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- [email protected] To unsubscribe send an email to [email protected] ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/