[#50466] [ruby-trunk - Bug #7492][Open] Segmentation fault at DL::TestDL#test_call_double on x64 Windows 8 — "phasis68 (Heesob Park)" <phasis@...>

23 messages 2012/12/02

[#50558] [ruby-trunk - Feature #7511][Open] short-circuiting logical implication operator — "rits (First Last)" <redmine@...>

12 messages 2012/12/04

[#50575] [ruby-trunk - Feature #7517][Open] Fixnum::MIN,MAX — "matz (Yukihiro Matsumoto)" <matz@...>

20 messages 2012/12/05

[#50755] Becoming a committer — Charlie Somerville <charlie@...>

Hi ruby-core,

21 messages 2012/12/11
[#50759] Re: Becoming a committer — Yukihiro Matsumoto <matz@...> 2012/12/11

Hi,

[#50784] Re: Becoming a committer — Charles Oliver Nutter <headius@...> 2012/12/11

It's really this easy? If so, I'll send over my public key today :)

[#50795] Re: Becoming a committer — Yukihiro Matsumoto <matz@...> 2012/12/11

Hi,

[#50806] [ruby-trunk - Feature #7548][Open] Load and Require Callbacks — "trans (Thomas Sawyer)" <transfire@...>

12 messages 2012/12/12

[#50810] [ruby-trunk - Feature #7549][Open] A Ruby Design Process — "brixen (Brian Ford)" <brixen@...>

34 messages 2012/12/12

[#50867] [ruby-trunk - Bug #7556][Assigned] test error on refinement — "usa (Usaku NAKAMURA)" <usa@...>

14 messages 2012/12/13

[#50900] [ruby-trunk - Bug #7564][Open] r38175 introduces incompatibility — "tenderlovemaking (Aaron Patterson)" <aaron@...>

14 messages 2012/12/14

[#50951] [ruby-trunk - Bug #7584][Open] Ruby hangs when shutting down an ssl connection in gc finalization — "bpot (Bob Potter)" <bobby.potter@...>

12 messages 2012/12/17

[#51076] [ruby-trunk - Feature #7604][Open] Make === comparison operator ability to delegate comparison to an argument — "prijutme4ty (Ilya Vorontsov)" <prijutme4ty@...>

12 messages 2012/12/22

[ruby-core:50907] [ruby-trunk - Bug #6854] ruby-mode.el has radical changes in `ruby-deep-indent-paren' logic

From: "dgutov (Dmitry Gutov)" <dgutov@...>
Date: 2012-12-15 00:39:32 UTC
List: ruby-core #50907
Issue #6854 has been updated by dgutov (Dmitry Gutov).


> Use Emacs-bundled ruby-mode.el.

I'm maintaining it.

Should I stop merging changes from this ruby-mode into Emacs-bundled version?
----------------------------------------
Bug #6854: ruby-mode.el has radical changes in `ruby-deep-indent-paren' logic
https://bugs.ruby-lang.org/issues/6854#change-34756

Author: dgutov (Dmitry Gutov)
Status: Closed
Priority: Normal
Assignee: nobu (Nobuyoshi Nakada)
Category: misc
Target version: 
ruby -v: ruby 1.9.2p290 (2011-07-09) [i386-mingw32]


The following commits make a non-backward compatible change in how `ruby-deep-indent-paren' works:

https://github.com/ruby/ruby/commit/85df40e9ab4559cd4ddde3f106ab56c76a808cc8
https://github.com/ruby/ruby/commit/6b0dc7fd81b25bc66681548b8b82f38258f7e08c
https://github.com/ruby/ruby/commit/862048e28d26112af1e67205cfd1c16564590bce
https://github.com/ruby/ruby/commit/d9e6b7d6a5e81afb588d79ef923b70890cdec4ba

Basically, the change disables deep-indent in all types of parens in (almost?) all situations.
If disabling deep-indent was the idea, I think changing the default value of this variable to nil would be sufficient.

Personally, I adopted another approach: deep-indent is on by default, but it's disabled when the first array element/call argument is not on the same line as the paren. This is similar to how indentation works in js-mode, for example.
To implement that, I imagine we'd need to make this check in `ruby-deep-indent-paren-p' instead of (ruby-expr-beg) call.

I can make a patch that would do that, but first I'd really like to see an explanation and/or examples of what exactly the changes above were meant to accomplish.


-- 
http://bugs.ruby-lang.org/

In This Thread

Prev Next