Project

General

Profile

Actions
Copy link

Misc #11548

closed

FileUtils#remove_tailing_slash is a poor method name

Added by slash_nick (Ryan Hosford) over 9 years ago. Updated over 9 years ago.

Status:
Closed
Assignee:
hsbt (Hiroshi SHIBATA)
[ruby-core:<unknown>]

Description

One would expect this method to be called remove_trailing_slash

I asked around on IRC and the consensus is this is probably an unfortunate typo that's survived too long.

Tailing and Trailing mean similar things, but I think most would expect "trailing" to be the clear choice here.

http://ruby-doc.org/stdlib-2.2.3/libdoc/fileutils/rdoc/FileUtils.html#method-i-remove_tailing_slash

Files

bug11548.patch (1.83 KB) bug11548.patch willianveiga (Willian Veiga), 10/01/2015 01:17 PM
Actions
Copy link
 #1

Updated by duerst (Martin Dürst) over 9 years ago

I agree. We should probably introduce the new name now, and later deprecate the old one.

Actions
Copy link
 #2

Updated by nobu (Nobuyoshi Nakada) over 9 years ago

It's a private method, we can replace it immediately.

Actions
Copy link
 #3

Updated by willianveiga (Willian Veiga) over 9 years ago

I have created a patch. This is my first contribution here. Sorry if I am doing something wrong.
Thank you very much.

Actions
Copy link
 #4 [ruby-core:71188]

Updated by hsbt (Hiroshi SHIBATA) over 9 years ago

  • Status changed from Open to Closed
  • Assignee set to hsbt (Hiroshi SHIBATA)
Actions
Copy link

Also available in: Atom PDF

Like0
Like0Like0Like0Like0