Project

General

Profile

Actions

Feature #2595

closed

Add crc32_combine and adler32_combine to zlib API

Added by tenderlovemaking (Aaron Patterson) over 15 years ago. Updated about 14 years ago.

Status:
Closed
Target version:
-
[ruby-core:27551]

Description

=begin
zlib is missing the crc32_combine and adler32_combine methods.

I've attached a patch which implements them. zlib has no maintainer, may I apply this patch?
=end


Files

zlib.patch (2.82 KB) zlib.patch zlib patch tenderlovemaking (Aaron Patterson), 01/12/2010 07:36 AM
Actions #1

Updated by naruse (Yui NARUSE) over 15 years ago

=begin
Wait 3days or 1 week as the importance and the size of the patch, and no objection,
you can apply the patch.
=end

Actions #2

Updated by Anonymous over 15 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

=begin
This issue was solved with changeset r26352.
Aaron, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

=end

Actions #3

Updated by nahi (Hiroshi Nakamura) over 15 years ago

=begin
Hi Aaron,

I'm just working zlib for JRuby now. Just out of curiosity, what are
you using crc32_combine and adler32_combile for?

// NaHi

=end

Actions #4

Updated by nahi (Hiroshi Nakamura) over 15 years ago

=begin
Hi Aaron,

On Thu, Jan 21, 2010 at 02:07, Aaron Patterson
wrote:

I'm just working zlib for JRuby now. Just out of curiosity, what are
you using crc32_combine and adler32_combile for?

I have a process that feeds me checksums and chunks of data, but those
chunks are getting buffered to be sent later (without the previously
mentioned process's knowledge).  Since the data is getting buffered, the
checksum must be recalculated.

Since my process has access to the checksums and length, it's easier to
use crc32_combine rather than recalculate the checksums for each string
(again).

Thanks for the explanation. It's definitely the functions you need.

And it sounds your usage does not depend on 'zlib' general purpose
compression library. It's good to have crc32 lib instead of extending
zlib I think.

Regards,
// NaHi

=end

Actions #5

Updated by headius (Charles Nutter) over 15 years ago

=begin
On Thu, Jan 21, 2010 at 7:46 AM, NAKAMURA, Hiroshi wrote:

And it sounds your usage does not depend on 'zlib' general purpose
compression library. It's good to have crc32 lib instead of extending
zlib I think.

Agreed..this ought to move to a separate lib.

  • Charlie

=end

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0