Activity
From 08/18/2015 to 08/24/2015
08/24/2015
- 09:35 PM Revision b4b848e6 (git): * 2015-08-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51675 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:34 PM Revision 2e5c105f (git): win32.c: symlink
- * win32/win32.c (w32_symlink): implement symlink().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51674 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:34 PM Bug #11485 (Closed): Ripper parser generates nil tokens for ignored_nl event during parse errors
- This seems to be a regression in the Ripper parser where the `on_ignored_nl` event is passed a nil value for the token parameter in the event when a syntax error occurs. I'm not entirely sure of the details, but this is the most minimal ...
-
07:29 PM Feature #11484 (Feedback): add output offset for readpartial/read_nonblock/etc
- ~~~
Specifying a destination offset will allow allocating less garbage
strings to improve performance when reading partial data off a pipe
or socket.
For example:
tmp = "".b
buf = "".b
case rv = io.read_nonblock(81... -
06:55 PM Bug #11483 (Closed): internal.h included after math.h in complex.c
- r51313 modified complex.c to include internal.h after math.h, so that ruby/missing.h (included from internal.h) can test whether `M_PI` is defined or not in math.h. Unfortunately, ruby/config.h, which is included from internal.h, defines...
-
06:30 PM Feature #11473: Immutable String literal in Ruby 3
- As a ruby user since 2001, I'd agree with Yusuke Endoh, when he suggests the long-term design preference of Ruby should be:
-
06:09 PM Feature #11473: Immutable String literal in Ruby 3
- Yusuke Endoh wrote:
> Oh, PHP-like attitude. I've always trusted Ruby so far. Is Ruby dying?
I'm not sure you mean.
-
05:13 PM Feature #11473 (Open): Immutable String literal in Ruby 3
- Akira Tanaka wrote:
> I think changing Ruby is easier than educating people.
Oh, PHP-like attitude. I've always trusted Ruby so far. Is Ruby dying?
--
Yusuke Endoh <[email protected]> -
- Yusuke Endoh wrote:
> Akira Tanaka wrote:
> ...
The social problem currently happen seems that not everyone thinks as you.
Your cleverness doesn't solve the social problem, unfortunately.
I think changing Ruby is easier than educat... -
- I often write `[a, b].max`. This idiom is easy to read and write. But it is slow, especially in the core loop, because it creates an Array object every times.
For the reason, do you replace all `[a, b].max` with `a < b ? b : a`, not... -
- Akira Tanaka wrote:
> This issue tries to solve more than performance.
> ...
Adding `.freeze` blindly is stupid. It should be added only when it is really needed, i.e., only when a string literal in a core loop was proved to be the bo... -
- Yusuke Endoh wrote:
>
> ...
This issue tries to solve more than performance.
As Matsuda-san explained, it solves a social problem.
I disagree the usability problem.
I think it is acceptable.
I agree the compatibility problem.
... -
- Akira Tanaka wrote:
> This can be considered better usability.
I agree with a useful feature for easily and elegantly improving performance, as long as it does not hurts any other usability and compatibility. Even if it hurts to som... -
- Yusuke Endoh wrote:
> > "immutable by default" is a way to solve the ambivalent with matz's preference.
> ...
I think it is not a problem.
"immutable by default" solves the ambivalent.
It makes developers happy.
This can be consider... -
- > "immutable by default" is a way to solve the ambivalent with matz's preference.
So, you mean:
* because the magic comment is not accepted as-is,
* we suppose "immutable by default" as a future goal, and
* the magic comment can ... -
08:18 AM Feature #11473: Immutable String literal in Ruby 3
- As for a "finer-grained range than a whole file" directive, it reminds me of the `using` method. Their scope look similar to me. Can we have built-in modules named as `FrozenString` and `UnfrozenString`, which give special interpretation...
-
- Yusuke Endoh wrote:
>
> ...
We have the most fine-grain notation already: "foo".freeze.
Unfortunately, this notation causes developer's ambivalent: fast code or clean code.
matz don't like the magic comment.
So the issue is not a... -
04:26 PM Bug #10871: Sclass thread unsafe due to CREF sharing
- Hello,
I've applied ko1's workaround patch for this issue to `ruby_2_2` branch at r51673.
I'm worried about the wrong side effects of this patch.
Please test on `ruby_2_2` branch HEAD.
If you use rbenv/ruby-build, you can install `... -
- Applied in changeset backport22:r51673.
----------
* insns.def (defineclass): introduce an ad-hoc patch to avoid
an issue reported on [Bug #10871].
This patch does not fix completely. For example, method definition
in a block (li... -
- an issue reported on [Bug #10871].
This patch does not fix completely. For example, method definition
in a block (like 1.times{def ...; end}) still causes same issue.
To solve all, we need a huge patch and it seems difficult for
... -
03:43 PM Bug #11482 (Closed): Multiple versions of Ruby crashing with simple threaded client/server test
- Using the attached client and server scripts, I have been able to quickly crash every version of Ruby I tested from 1.9.3 to 2.2.3. Sometimes only the client crashes, sometimes only the server, and a few times I've seen both crash at the...
-
12:51 PM Bug #11481 (Closed): Segmentation fault when thread is killed during `require`.
- One of a library used by us executes `open` from `uri-open` in multiple thread in parallel under a timeout.
`open-uri` implicitly `require`s `net/http`. When the import machinery is killed during performing an import this will lead to a... -
09:12 AM Bug #11480 (Closed): killed by SIGIOT (signal 6) on fork
- bootstraptest/test_fork.rb failed sometimes on my environment ("Ubuntu 14.04.3 LTS" Linux 3.13.0-62-generic x86_64).
```
#253 test_fork.rb:24:in `<top (required)>':
Thread.new { sleep 0.01 until main.stop?; Thread.kill main }
... -
- * win32/win32.c (rb_w32_wreadlink, rb_w32_wopen): add missing
licenses. [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51672 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:01 AM Revision 510ef98b (git): * 2015-08-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51671 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * encoding.c (rb_locale_encindex): find encoding index without
making a string object every time. [ruby-core:58160] [Bug #9080]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51670 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:11 AM Bug #11461: Remove backtracing cleaning on Delegator methods
- OK, I accept.
Matz.
08/23/2015
-
09:10 PM Bug #11478: symlinks support broken on win32
- FWIW, this is how we implemented File.symlink? in win32-file: https://github.com/djberg96/win32-file/blob/ffi/lib/win32/file.rb#L241-L271
Note that we use CreateSymbolicLink for our own File.symlink method, however. I'm not sure why c... -
- r51640 doesn't fix it too?
-
- Thank you for the explanation and references.
I'm neutral to the magic comment. It would be better if it could specify finer-grained range than a whole file, but I have no strong objection. But "immutable by default" is completely a... -
- Yusuke Endoh wrote:
> Why do matz and akr want to make String literals immutable, at first? Please explain use case.
My first intent is explained at:
https://bugs.ruby-lang.org/issues/8976
This is refered from this issue as a rela... -
02:18 PM Bug #11244: [BUG] rb_gc_mark(): 0x00000001f34020 is T_NONE
- こんにちは。
この [BUG] が、2.2 で何かの拍子に起こったりはしないだろうか、ということが気になっています。
このチケットは今後バックポート対象になるでしょうか？
それとも、2.2（や 2.1）では起こらない現象なのでしょうか。
-
07:19 AM Feature #10600: [PATCH] Queue#close
- You misread about Go channel:
> **Sending to or closing** a closed channel causes a **run-time panic**.
> (on empty channel) **receive** operations will return the **zero value** for the channel's type without blocking. The multi-v... -
07:00 AM Bug #11479 (Closed): gcc warning variable may be used uninitialized
- build ruby-2.2.3 on Windows XP using gcc-5.1.0 generates tow warnings:
compiling signal.c
compiling sprintf.c
In file included from sprintf.c:1255:0:
vsnprintf.c: In function 'BSD_vfprintf':
vsnprintf.c:1074:15: warning: 'uqval' m... -
- > It needs to be painful to use libraries that don't support frozen string literals, in order to encourage people to fix those libraries. For those people who must use libraries that still don't support frozen string literals when ruby ...
08/22/2015
-
11:17 PM Bug #11478 (Closed): symlinks support broken on win32
- The symlink support is completely broken on win32 because it thinks ALL reparse points are symlinks.
~~~
/* License: Ruby's */
static unsigned
fileattr_to_unixmode(DWORD attr, const WCHAR *path)
…
if (attr & FILE_ATTRIBUTE_RE... -
10:09 PM Feature #11477: NameError#qualified_name
- That actually makes more sense and is what we talked about at the last Ruby developers meeting. According to Nobu it requires a lot of work, though. But in terms of the interface, I'm 👍 on `NameError#receiver` returning the receiving mod...
-
03:05 PM Feature #11477: NameError#qualified_name
- To clarify, make it so that NameError#receiver returns the receiving module in a "uninitialized constant" NameError.
-
- Is NameError#receiver (#10881) not enough and better/easier to use?
-
- Hi,
This is a followup issue to #11252. I'd like to add a method that basically does the same thing as [NameError#missing_name](https://github.com/rails/rails/blob/ebe73abea0ae02094ddc28f8fd60ae92373b6113/activesupport/lib/active_supp... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51669 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:12 PM Revision 8ba98ee5 (git): * 2015-08-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51668 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51667 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Why do matz and akr want to make String literals immutable, at first? Please explain use case.
For performance? Is it more important than usability, in the recent Ruby design?
--
Yusuke Endoh <[email protected]> -
-
- Thank you for your great survey. I want to introduce Queue#close in Ruby 2.3.
Just now I'm not sure it is okay to provide think Queue#close(token) API because there are no similar examples in Ruby.
The followings are summary of you... -
- We've discussed this at the Ruby developers meeting on Thursday and made several decisions(but still subject to change).
* We are not going to rename the gem (we'll just use `did_you_mean`)
* It'll be a bundled gem (Yuki will be ... -
- New constructor is a good thing.
But it is better to allow construction
"".b
to be mutable string. `"".force_encoding(Encoding::ASCII_8BIT)` is used for compatibility with Ruby 1.9.3 (cause `"".b` were not backported :( )
-
01:22 AM Feature #8976: file-scope freeze_string directive
- Colin Kelley wrote:
> Akira Tanaka wrote:
> ...
Adding support for this magic comment will ensure that this problem will remain a problem far in the future. We should encourage people to fix the problem, not sweep the problem under th... -
12:06 AM Feature #8976: file-scope freeze_string directive
- Akira Tanaka wrote:
> We can't update all libraries at once.
> ...
I completely concur. We will need to work through many projects and libraries and gems to make this change. The comment directive is perfect for that because we can... -
- * string.c (sym_inspect): move common statement and change
variable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51666 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_eval.c (check_funcall_failed, check_funcall_missing): cache
results of respond_to? and respond_to_missing?, and search a
pulibc method only for compatibility with rb_respond_to.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk... -
- * vm_eval.c (check_funcall_missing): pass same thread to call.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51664 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_eval.c (check_funcall_missing): reuse found method entry
instead of searching same entry repeatedly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51663 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:44 AM Bug #11237: サブスレッドがすべて終了するとメインスレッドが割り込まれる。
- r50900 を 2.0.0, 2.1, 2.2 にバックポートしてもらえませんか?
-
- * ChangeLog: fix a usual typo, thraed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51662 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:04 AM Feature #11476 (Closed): Methods defined in Refinements cannot be called via send
- ~~~
class C end
module M
refine C do
def a() p:hello end
def b() p:world end
end
end
using M
C.new.a
C.new.send :b
~~~
~~~
% ruby -v t.rb
ruby 2.3.0dev (2015-08-22 trunk 51660) [x86_64-darwin14]
:hello
...
08/21/2015
-
- Now, thread.rb is ported to thread_tools.c.
-
- Continue on Feature #11420.
-
- I have no idea such magic comment is acceptable or not.
Matz's issue? -
-
- Please reopen if you feel it is worth to fix.
-
- gcc のバージョンが変わったからか、
でなくなったんでしょうか。
http://fb32.rubyci.org/~chkbuild/ruby-trunk/log/20150821T230303Z.log.html.gz
-
- Applied in changeset r51660.
----------
* ext/thread/thread.c: move definitions of Queue, SizedQueue
and ConditionalVariables to thread_tools.c. In other wowrds,
such classes are built-in.
[Feature #8919]
At first, I planned to ... - 11:36 PM Revision fc952dcb (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51661 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- and ConditionalVariables to thread_tools.c. In other wowrds,
such classes are built-in.
[Feature #8919]
At first, I planned to embed only a Queue class.
However, rubygems requires 'thread.rb' (rubygems are
required at first, wh... -
- Jeremy Evans wrote:
>
> ...
It makes that frozen string literal can not have escape sequences such as "\n".
I feel the magic comment name and command line option name,
frozen-string-literal, denotes that all string literals frozen... -
- r51659 introduced a way to try this feature.
Have fun.
-
- Applied in changeset r51659.
----------
* vm_opts.h, iseq.c, iseq.h: add compile option to force frozen
string literals.
[Feature #11473]
This addition is not specification change, but to try frozen
string literal world discusse... -
07:29 PM Feature #11473: Immutable String literal in Ruby 3
- Yusuke Endoh wrote:
> Objection, unless a bailout is provided.
> ...
Wow. Thanks for mentioning string building. It occurs to me I build
strings like this somewhat regularly:
sql = %{SELECT #{sec_id}, pt.path, st.doc_count }
... -
- Jeremy Evans wrote:
> +"" is not backwards compatible, "".dup is, as is String.new. I'm definitely against +"".
It will be backwards compatible, if we introduce it to Ruby 2.3 or 2.4. I don't think that Ruby 3.0 will be released be... -
- +"" is not backwards compatible, "".dup is, as is String.new. I'm definitely against +"".
One possible option would be to have "" be a mutable string, and '' be an immutable string. It doesn't make sense to have "" strings be immuta... -
- Objection, unless a bailout is provided.
`""` as a StringBuilder is acutally useful. `"".dup` is too tiring.
For example, how about make `String#+@` an alias to `String#dup`?
`+""` is also tiring, but better than nothing at all... -
03:57 PM Feature #11473: Immutable String literal in Ruby 3
- I see no reason why 2.3 cannot also have --error-frozen-strings. As an opt-in I think it will give people more of a chance to make sure their code works.
A second possible idea would be to add a lint to possibly flag interesting idio... -
03:28 PM Feature #11473: Immutable String literal in Ruby 3
- I would like to suggest a phased transition across several releases in Ruby 2.x (the specific version numbers and flag names are just examples):
1. In Ruby 2.3, it is possible to turn on warnings when mutating a String literal (--warn... -
- discussion on twitter:
https://twitter.com/yukihiro_matz/status/634386185507311616
-
- Matz said "All String literals are immutable (frozen) on Ruby 3".
This ticket is place holder to discuss about that.
-
- Jeremy Evans wrote:
> I don't think the magic comment approach for freezing string literals is a good idea. For ruby libraries that are maintained, the maintainers will change their code so that they work when string literals are froze... -
- I don't think the magic comment approach for freezing string literals is a good idea. For ruby libraries that are maintained, the maintainers will change their code so that they work when string literals are frozen by default (in ruby 3...
-
- Let us bring this two-year-aged very well matured feature proposal back to the table!
I would like to propose again to put this magic comment for freezing String literals into next version of Ruby.
## motivation
There are several ... -
- string literals.
[Feature #11473]
This addition is not specification change, but to try frozen
string literal world discussed on [Feature #11473].
You can try frozen string literal world using this magical line:
RubyVM::Instr... -
- 考えてみると GC.disable の場合もあると思うので ObjectSpace.trace_object_allocations_stop で常に GC.start するのもよくないかもしれませんね。テストのほうで修正するというので良いと思います。 あとテストでの対応は GC.start するのでなくて、逆に GC.disable しておいて ObjectSpace.trace_object_allocations_stop 後の GC を抑制するという方法のほうが...
-
- 私も気づいていたのですが、見ないことにしておりました。
私自身だと、「テスト変えて解決としよう」と思いたいんですが、
それで利用上、問題ないですかね？ - 05:56 PM Revision 42c3a677 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51658 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:55 PM Revision 226c6a1b (git): * ext/psych/*: update to Psych 2.0.14
- * test/psych/*: ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51657 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Ruby 2.1 solved this issue.
-
- こちら、随分間をあけてしまって申し訳ありません。
気になるのは、
* 「hook を出来ない状態にして（つまり、現状）、disable のまま実行」
* 「hook を出来る状態にして、disable のまま実行」
の比較なのですが（つまり、enable で遅くなるのは、まぁ気にしない）、こちらお願い出来ますでしょうか。
あと、attr だけでいいんかな。
-
- Joe Merante wrote:
> To update, after manually triggering GC in step 3 above after processing every Temp object, or after processing every 10 Temp objects, we did not get the Ruby error. Maybe it's Nokogiri after all, will cross-post th... -
- Please reopen if you got same error on 2.2.3.
- 03:31 PM Revision 2a1569d6 (git): * 2015-08-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51656 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_insnhelper.c (vm_invoke_block): use ci->argc updated by
CALLER_SETUP_ARG(). [Bug #11451]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51655 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Any opinion?
-
- Results on versions:
Without nakayoshi-fork:
```
ruby version 1.9.3
time pid message shared private
4.034s 25939 Parent pre GC 85 0
4.034s 25941 Child pre GC 85 0
8... -
- Sorry for long absent.
Could you try https://rubygems.org/gems/nakayoshi_fork ?
With this gem, your script shows on my environment:
```
ruby version 2.3.0
time pid message shared private
4.021s 25883 Pare... -
12:42 PM Feature #11348: TracePoint API needs events for fiber's switching
- Koichi Sasada wrote:
> I agree to add 'switching' events so I try to commit it.
> ...
I'm on vacation right now will play with ruby-head early next week. -
- I agree to add 'switching' events so I try to commit it.
Could you try it and could you tell me "what" is not enough?
(Actually, I don't increase the number of events)
For example, how about to provide a method to know resume ch... -
- Applied in changeset r51652.
----------
* include/ruby/ruby.h, cont.c, vm_trace.c: add a new event
fiber_switch. We need more discussion about this feature
so that I don't write it on NEWS.
[Feature #11348]
* test/ruby/test_settra... -
- Applied in changeset r51654.
----------
* ext/objspace/objspace.c: add a new method ObjectSpace.count_symbols.
[Feature #11158]
* symbol.c (rb_sym_immortal_count): added to count immortal symbols.
* symbol.h: ditto.
* test/objspace/te... -
- [Feature #11158]
* symbol.c (rb_sym_immortal_count): added to count immortal symbols.
* symbol.h: ditto.
* test/objspace/test_objspace.rb: add a test for this method.
* NEWS: describe about this method.
git-svn-id: svn+ssh://ci.ruby-l... -
11:14 AM Feature #11475: AST transforms
- Nobuyoshi Nakada wrote:
> Do you have any ideas for the API?
My API idea is loosely based on the Rubinius' transform API, but without explicitly generating bytecode in the transform (that wouldn't be very portable, and it makes trans... -
- Do you have any ideas for the API?
-
- Even though Ruby is in many ways an acceptable Lisp, extending the language itself is a hard endeavour. By using reflection/meta-programming and taking advantage of its rich grammar, it's certainly possible to bend the language in extrem...
-
- Applied in changeset r51653.
----------
Makefile.sub: link libraries for extensions
* win32/Makefile.sub ($(LIBRUBY_SO)): needs additional libraries
for extension libraries to link statically.
[ruby-core:70499] [Feature #9018] -
- So actually, it looks like there's a switch `--with-static-linked-ext` that can be used to link all the exts statically! The win32\Makefile.sub has a bug where it's not specifying all the libs needed by win32ole ext though.
I had to a... -
- It looks like for the latter point (dummy file) we can actually use rb_provide! Ruby uses it to "fake" a module for back compat; for modules that were once external, but are now builtin. Like Complex, Rational, Enumerator.
~~~
void
... -
- I agree with Lukas.
Nobu, only the builtin modules are linked into the binary and called at bootstrap:
inits.c:
~~~
void
rb_call_inits(void)
{
CALL(Method);
CALL(RandomSeed);
CALL(sym);
CALL(var_tables);... -
- * win32/Makefile.sub ($(LIBRUBY_SO)): needs additional libraries
for extension libraries to link statically.
[ruby-core:70499] [Feature #9018]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51653 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Okay, I'll fix it.
(I need to remember code about it...) -
- Sorry for long absence about this ticket.
Your explanation is great so please commit it.
(I expect computation complexity by O(1), O(n) or something like that)
(I hope it may be similar linked list i know)
-
09:59 AM Bug #10046: OpenSSL::TestSSLSession#test_ctx_server_session_cb and OpenSSL::TestSSLSession#test_ctx_client_session_cb test failures
- Actually r51649 is the fix. Sorry for the noise.
-
- Resolved by r51650
-
- fiber_switch. We need more discussion about this feature
so that I don't write it on NEWS.
[Feature #11348]
* test/ruby/test_settracefunc.rb: add tests.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51652 b2dd03c8-39d4-4d8f-98... -
- Thank you for your reproducible script!
-
- Applied in changeset r51651.
----------
* vm_insnhelper.c (vm_invoke_block): we should not expect ci->argc is
stable after invoking a block. [Bug #11451]
* test/ruby/test_yield.rb: add a test. This test script is given by
Alex Dowad. -
- stable after invoking a block. [Bug #11451]
* test/ruby/test_yield.rb: add a test. This test script is given by
Alex Dowad.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51651 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:25 AM Bug #11376: Stop using SSLv3 methods
- Is there any ETA of when I can expect this to be resolved? Do you need some help or more info?
I would like to see this fixed in Debian as soon as possible, because I would like to drop support for that and ruby is really my biggest ... -
- It's a spec.
-
- A patch is small.
```diff
Index: re.c
===================================================================
--- re.c (revision 51650)
+++ re.c (working copy)
@@ -2548,6 +2548,8 @@
if (!re->ptr) return -1;
RB_OBJ_WRITE(o... -
- There are two options:
1. Freeze only literal regexps
2. Freeze all of regexps
I like (2) because I have no idea to change regexp objects.
History of "Frozen":
* Ruby 2.0
* Integer (Bignum, Fixnum) https://bugs.ruby-lang.... -
05:46 AM Misc #11474: [META] Call for Feature Proposals for Ruby 2.3
- Koichi Sasada wrote:
> Yui NARUSE wrote:
> ...
I send the announce as a normal mail soon later. -
- Yui NARUSE wrote:
> This is meta ticket for Call for Feature Proposals for Ruby 2.3.
> ...
Deadline? -
- This is meta ticket for Call for Feature Proposals for Ruby 2.3.
After you attach your slide to the related ticket, write ticket number as a comment here to avoid I miss it. -
01:31 AM Bug #11471: min, min_by, max, max_by with optional parameter return a wrong value
- Here is my fix.
I also created a pull request:
https://github.com/ruby/ruby/pull/1005 -
12:39 AM Bug #11471: min, min_by, max, max_by with optional parameter return a wrong value
- I found the ticket which to request and discuss this feature. Thicket is #8887.
08/20/2015
-
- Yes, I was wrong. I missed this check in "nmin_filter":
~~~
if (data->curlen <= data->n)
return;
~~~
Which means that your patch will never execute the "nmin_filter" (that is where the bug lays) until it is called in... -
10:07 PM Bug #11471: min, min_by, max, max_by with optional parameter return a wrong value
- Helder Pereira wrote:
> Leo Correa, I think your patch will fail for this example:
> ...
I made a test case for that and passed with [2, 4, 6, 7]
-
- I suppose I found the problem. Taking the first example:
~~~
[20, 32, 32, 21, 30, 25, 29, 13, 14].min(2)
~~~
This will call the function "nmin_run" in the file "enum.c", which sets "bufmax" to 4 times the number of minimums (n) w... -
- Leo Correa, I think your patch will fail for this example:
~~~
[2, 4, 8, 6, 7].min(4) #=> [2, 4, 6, 8]
~~~ -
- I have made a patch that seems to fix the issue for these cases. I'm not entirely sure why there was a multiplier for data.bufmax in the first place but it seemed to be the cause.
-
- This is reported in StackOverflow: http://stackoverflow.com/questions/32121749/why-20-13-14-min2-13-20. Sometimes `min`, `min_by`, `max`, `max_by` with an optional parameter return a wrong value.
[20, 32, 32, 21, 30, 25, 29, 13, 1... -
09:41 PM
Bug #11367 (Closed): Use OP_NO_TICKET when testing SSL session cache callbacks
- Applied in changeset r51649.
----------
* test/openssl/test_ssl_session.rb: Fix tests so that they take in to
account OpenSSL installations that have SSLv3 disabled by default.
Thanks Jeremy Evans <[email protected]> for the patc... -
09:41 PM
Bug #11366 (Closed): Don't force SSLv3 in test, as it is insecure and may not be supported
- Applied in changeset r51649.
----------
* test/openssl/test_ssl_session.rb: Fix tests so that they take in to
account OpenSSL installations that have SSLv3 disabled by default.
Thanks Jeremy Evans <[email protected]> for the patc... - 09:40 PM Revision e5ffa438 (git): * 2015-08-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51650 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- account OpenSSL installations that have SSLv3 disabled by default.
Thanks Jeremy Evans <[email protected]> for the patches.
[Bug #11366] [Bug #11367]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51649 b2dd03c8-39d4-4d8f-98ff... -
08:26 PM Bug #11472 (Rejected): Some default gems are not installed if GEM_HOME is set during Ruby installation
- As of 2.2.3, the issue which I believe was fixed with [this commit](https://github.com/ruby/ruby/commit/ec171c45975b525bbe5d63b92f1521622aa05394) seems to be back: `minitest`, `test-unit`, and `power_assert` are not installed if `GEM_HOM...
-
04:27 PM Bug #11470 (Rejected): extra parens required for if/unless/rescue modifier expressions in single arg method invocations
- foo(1 if true) is not allowed requiring foo((1 if true))
also foo(1 unless true) foo(bar rescue 1)
-
- I check the response from https://www.hoveround.com .
~~~
$ openssl s_client -connect www.hoveround.com:443
~~~
Request header
~~~
GET / HTTP/1.1
Host: www.hoveround.com
Accept-Encoding: gzip,deflate
~~~
Response
~... -
01:22 PM Revision 777f319d (git): fix indent (tabify) [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51648 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_method.c (basic_obj_respond_to): call respond_to_missing?
only when redefined. [ruby-core:70460] [Bug #11465]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51647 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:04 AM Bug #11469 (Closed): ArgumentError: wrong number of arguments (-1 for 1)
- I got an exception saying `ArgumentError: wrong number of arguments (-1 for 1)`. Obviously, `-1` is not a valid number of arguments, so I consider this a bug.
Unfortunately, I could not find a way to reproduce the issue, but it happen... -
07:02 AM Feature #6373: public #self
- -1
For me it would be better to accept #47 - it improves good old #tap and introduces a new #itself with block.
Copied here:
~~~
def tap
yield self if block_given?
self
end
def itself
if block_given?
yield sel... -
- Sory my careless mistake.
I correct mistake in test case. -
- ~~~ruby
md = MyDate.new(28, 10, 2010)
~~~
I don't believe that 2010/28/10 is a valid date. -
- Applied in changeset r51646.
----------
vm_eval.c: share with rb_obj_respond_to
* vm_eval.c (check_funcall_respond_to): share the behavior with
rb_obj_respond_to. [ruby-core:70460] [Bug #11465]
* vm_method.c (vm_respond_to): extract... -
- * vm_eval.c (check_funcall_respond_to): share the behavior with
rb_obj_respond_to. [ruby-core:70460] [Bug #11465]
* vm_method.c (vm_respond_to): extract from rb_obj_respond_to and
merge r39881.
git-svn-id: svn+ssh://ci.ruby-lang.or...
08/19/2015
-
- * vm_method.c (rb_obj_respond_to): reuse found method entry
instead of searching same entry repeatedly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51645 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * dir.c (replace_real_basename), win32/win32.c (opendir_internal):
check reparse point tags and treat supported tags only as
symbolic links. [ruby-core:70454] [Bug #11462]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51644 b2d... -
- 48 bytes each.
~~~
native_mutex_initialize(&th->vm->thread_destruct_lock);
native_mutex_initialize(&th->interrupt_lock);
~~~
~~~
+ 48 ( 48 - 0) 1 allocs BackTrace9CB2F14B
+ 1 ( 1 - 0)... -
- 244 bytes leaked.
~~~
+ 244 ( 244 - 0) 1 allocs BackTrace9C86044B
+ 1 ( 1 - 0) BackTrace9C86044B allocations
ntdll!RtlpCallInterceptRoutine+40 (d:\blue\minkernel\ntos\rtl\heappriv.h, 3625)
ntdl... -
- Leak of 608 bytes in this stack:
~~~
+ 608 ( 608 - 0) 1 allocs BackTrace9BD0704B
+ 1 ( 1 - 0) BackTrace9BD0704B allocations
ntdll!RtlpCallInterceptRoutine+40 (d:\blue\minkernel\ntos\rtl\heappriv.... -
- Here's another big leak: This stack leaks nearly 1MB (~780K). When is Init_heap supposed to be undone?
~~~
+ 787080 ( 787080 - 0) 24 allocs BackTrace9BD000CB
+ 24 ( 24 - 0) BackTrace9BD000CB allocations
n... -
- Even with a trivial eval "1" Ruby leaks about 2 MB or so after ruby_cleanup.
I've attached the raw list of leaks as reported by the CRT (I took a snapshot before ruby_setup and again after ruby_cleanup).
I've also attacked a few sa... -
- Kenta Murata wrote:
> Alexey, please give me your script to produce this issue.
The script is running on a daily basis. I upgraged bigdecimal to 1.2.7 and have not seen the exception since. - 03:01 PM Revision 126eb641 (git): * 2015-08-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51643 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- existing options rather than just setting it. Some vendors apply
custom patches to their versions of OpenSSL that set default values
for options. This commit respects the custom patches they've
applied.
* test/openssl/test_ssl.r... -
- Seems a bug of RMagick2.
-
- Applied in changeset r51641.
----------
process.c: [DOC] env values in spawn [ci skip]
* process.c (rb_f_spawn): [DOC] elaborate environment variable
values. [ruby-core:70456] [Bug #11463] -
08:46 AM Bug #11463 (Closed): Process.spawn raises TypeError when passing hash with keys/vals other than strings
- ### expected:
~~~
head :001 > Process.spawn({"FOO" => 10}, "bash")
=> 13479
~~~
### got in reality:
~~~
head :001 > Process.spawn({"FOO" => 10}, "bash")
TypeError: no implicit conversion of Fixnum into String
~~~
This... -
- * process.c (rb_f_spawn): [DOC] elaborate environment variable
values. [ruby-core:70456] [Bug #11463]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51641 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r51640.
----------
win32.c: support known reparse points only
* win32/win32.c (winnt_lstat): check reparse point tags and treat
supported tags only as symbolic links.
[ruby-core:70454] [Bug #11462] -
- Command line
~~~
'.\miniruby.exe -I./lib -I. ./tool/mkconfig.rb -timestamp=./.rbconfig.time -arch=x64-mswin64_120 -version="2.3.0" -install_name=ruby -so_name=x64-msvcr120-ruby230_d rbconfig.rb'
~~~ -
- During build:
./tool/mkconfig.rb:13:in `require': Invalid argument @ rb_readlink - E:/dev/ruby/lib/fileutils.rb (Errno::EINVAL)
from ./tool/mkconfig.rb:13:in `<main>'
NMAKE : fatal error U1077: '.\miniruby.exe' : return code... -
- * win32/win32.c (winnt_lstat): check reparse point tags and treat
supported tags only as symbolic links.
[ruby-core:70454] [Bug #11462]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51640 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:43 AM Bug #11465 (Closed): `Array#flatten` calls `to_ary` on objects with `method_missing` even if `respond_to_missing?(:to_ary)` returns `false`.
- I noticed this behavior while working on an issue reported on the Rails tracker: https://github.com/rails/rails/issues/21296
I put up a reproduction along with some details about the issue in a Gist: https://gist.github.com/senny/02ee93... -
10:14 AM Bug #11464 (Closed): ERB trimming doesn't trim carriage returns
- ERB trimming doesn't work if the .erb file was written on Windows (because Windows uses \r\n as line ending, whereas Linux uses only \n)
The implementation apparently only trims \n
~~~
ruby erbCarriageReturnBug.rb
~~~
Expected o... -
10:09 AM Feature #11454: FTP client misbehaves in the block passed to FTP#list when using passive mode
- Please note that update URL of Git Diff is: https://github.com/srikanthps/ruby/commit/9b7f5d9bfd653bd2829620682eeef67f2e0bbdea
Srikanth Shreenivas wrote:
> I think in my proposed change:
> ...
- 07:57 AM Revision eb2d0cf8 (git): * 2015-08-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51639 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * io.c (rb_io_each_codepoint): fix use of uninitialized variable.
[Bug #11444]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51638 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:13 AM Bug #11461 (Closed): Remove backtracing cleaning on Delegator methods
- This improve the performance in 18 times when the delegated method raises some exception and in 15% for the success case.
Here a benchmark result with a simpler script: (The backtrace have less than 10 items)
require 'delegate'... -
01:51 AM Feature #11460 (Closed): Unhelpful error message when naming a module with the same name as an existing class
- # Summary
The error message when naming a module with the same name as an existing class causes more trouble then it helps.
# Steps to Reproduce
~~~
class X;end
module X;end
=> TypeError: X is not a module
~~~
# Expected Resu...
08/18/2015
-
- I think in my proposed change:
~~~
yield lines
~~~
should be
~~~
lines.each { |line| yield line }
~~~
I have prepared the changes in my fork - link given below -
https://github.com/srikanthps/ruby/commit/9b7f5d9bfd653b... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@51637 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:28 PM Bug #4487: require_relative fails in an eval'ed file
- This is actually very pertinent for Rack as well, because currently config.ru does not support require_relative which is very counterintuitive.
-
- * tool/downloader.rb: support old versions of ruby.
* tool/downloader.rb: now can download gems by http if openssl is not
available (this may be danger!)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@... -
01:22 PM Bug #11458 (Third Party's Issue): SEGMENTATION FAULT during Redmine Deploy
- Hi Everyone,
I'm trying to configure Redmine on production Windows Server running IIS 7. No problem with Web Platform Installer, no problem during Ruby installation.
When Redmine start for the first time, the DEPLOY return this error:
... - 01:02 PM Revision 0bdadc5b (git): * version.h: forgotten to update.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@51630 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:01 PM Revision 2d3a8b38 (git): * 2015-08-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@51629 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:01 PM Revision ec54e643 (git): merge revision(s) 50829: [Backport #11248]
- * lib/rubygems.rb: bump version to 2.0.14.1. this version fixed
CVE-2015-3900.
* lib/rubygems/remote_fetcher.rb: ditto.
* test/rubygems/test_gem_remote_fetcher.rb: added testcase for CVE-2015-3900
git-svn-id: svn+ssh://ci.ruby-lang... - 12:56 PM Revision 9ce1bf8f (git): merge revision(s) 50829: [Backport #11248]
- * lib/rubygems.rb: bump version to 2.4.5.1. this version fixed
CVE-2015-3900.
* lib/rubygems/remote_fetcher.rb: ditto.
* test/rubygems/test_gem_remote_fetcher.rb: added testcase for CVE-2015-3900
git-svn-id: svn+ssh://ci.ruby-lang... -
- Applied in changeset r51626.
----------
* thread_pthread.c (reserve_stack): ensure the memory is really
allocated. [Bug #11457] -
- minirubyがCentOS 5 (64bit) でSEGVするやつです。
http://rubyci.s3.amazonaws.com/centos5-64/ruby-trunk/log/20150818T093302Z.log.html.gz#miniversion
パッチ見ればわかりますが原因はr49452です。
2.1と2.2にはバックポートされているようだけど、2.0.0には入っていないと思う。 -
- allocated. [Bug #11457]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51626 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * numeric.c (Init_Numeric): Fix document for Float::MIN and
Float::EPSILON.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@51625 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- バックポート用メモ
`ruby_2_2` の HEAD ( ruby 2.2.3p171 (2015-08-17 revision 51619)) においては以下はいずれも syntax error になりません。
```ruby
{foo: ("" rescue "")}
{foo: (1 rescue 0)}
{foo: /=/}
```
#10653 の修正である r51617 によって表れる現象だと思われますので、r51617 の back... -
- Applied in changeset r51624.
----------
parse.y: fix labelarg
* parse.y (IS_BEG): include labeled argument state, which was
EXPR_LABELARG. [ruby-dev:49221] [Bug #11456] -
04:13 AM Bug #11456 (Closed): Hash リテラル中で rescue をもちいると SyntaxError になる
- ruby 2.3.0dev (2015-08-18 trunk 51622) にて、Hash リテラル中で rescue をもちいると SyntaxError になりました。
まず、ruby 2.2.0p0 (2014-12-25 revision 49005) [x86_64-darwin13] の実行結果です。
~~~ruby
% irb
irb(main):001:0> {foo: ("" rescue "")}
=> {:foo=>""}
~... -
- * parse.y (IS_BEG): include labeled argument state, which was
EXPR_LABELARG. [ruby-dev:49221] [Bug #11456]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51624 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * include/ruby/ruby.h (RClass): define only in C, `__attribute__`
between `struct` and the name can't compile with g++.
[ruby-core:70297] [Bug #11426]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51623 b2dd03c8-39d4-4d8f-98ff-8... -
04:30 AM Bug #10984: Hash#contain? to check whether hash contains other hash
- I didn't notice the notes from [DevelopersMeeting20150514Japan](https://docs.google.com/document/u/1/d/1kEsXwy0X046Z0RqsvWv6O-gJ-tLY91Mc0vDHYZoJE1M/pub) before so I'll link to my original musings about `Hash#include?` which later evolved...
-
- ~~~
3 libruby.2.1.0.dylib 0x0000000103cca499 sigsegv + 153
4 libsystem_platform.dylib 0x00007fff97e31f1a _sigtramp + 26
5 libruby.2.0.0.dylib 0x00000001042c00fa rb_newobj + 31
~~~
Y... -
-
- Applied in changeset r51621.
----------
ruby.h: adjust for g++
* include/ruby/ruby.h (RClass): move `__attribute__` after the
keyword `struct` for g++. [ruby-core:70297] [Bug #11426] -
- OK, `g++` does reject `__attribute__` between `struct` and a name, while `gcc` allows.
~~~
$ cat a.c
__attribute__((deprecated)) struct a;
$ gcc -c a.c
$ g++ -c a.c
a.c:1:36: warning: attribute ignored in declaration of 'struct a... - 02:41 AM Revision a3636753 (git): * 2015-08-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51622 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * include/ruby/ruby.h (RClass): move `__attribute__` after the
keyword `struct` for g++. [ruby-core:70297] [Bug #11426]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51621 b2dd03c8-39d4-4d8f-98ff-823fe69b080e