Activity
From 02/27/2016 to 03/04/2016
03/04/2016
-
11:11 PM Feature #12142: Hash tables with open addressing
- Vladimir Makarov wrote:
> Thanks for the numbers. Is it a real world scenario?
I can imagine many cases: loading big data such as JSON and YAML, some kind of data structures such as Trie, data processing/aggregation, etc.
And I c... -
06:13 PM Feature #12142: Hash tables with open addressing
- Yusuke Endoh wrote:
> Great, but it seems to need more work. It consumes nearly 2 times much memory.
> ...
Thanks for the numbers. Is it a real world scenario? I mean using huge
numbers of only small tables. I can imagine this whe... -
- Yura Sokolov wrote:
> Small note: there is no need in pertrubation and 'python like' secondary hash cause ruby uses strong hash function. Better stick with quadrating probing.
Sorry, it is hard for me to understand why is it better.
... -
- Yura Sokolov wrote:
> Great!
> ...
Thanks.
> Notes:
> ...
Thanks for pointing this out.
> - do not change formatting of a code you do not change, it is awful to read and check that part of your patch.
I'll restore it. It is ... -
- Nobuyoshi Nakada wrote:
> Koichi Sasada wrote:
> ...
Ok. I rethink the terminology to keep meaning the entries. -
- Koichi Sasada wrote:
> Thank you for your great contribution.
> ...
Thanks you for your quick response. I am not a Rubyist but I like MRI
code.
> Do you compare memory usages?
> ...
Sorry, I did not. Although I evaluated it. On... -
- Great, but it seems to need more work. It consumes nearly 2 times much memory.
~~~~
# trunk
$ /usr/bin/time -f %Mkb ./miniruby -e '(0..1000000).map { { 1 => 1 } }'
280108kb
# hash_tables_with_open_addressing branch
$ /usr/bin/... -
09:00 AM Feature #12142: Hash tables with open addressing
- Small note: there is no need in pertrubation and 'python like' secondary hash cause ruby uses strong hash function. Better stick with quadrating probing.
-
- Great!
Notes:
- num_entries should remain num_entries. It is easier for you to change naming than fix all rubygems.
- do not change formatting of a code you do not change, it is awful to read and check that part of your patch.
- sp... -
05:50 AM Feature #12142: Hash tables with open addressing
- Koichi Sasada wrote:
> * at first, you (or we) should introduce `st_num_entries()` (or something good name) to wrap to access `num_entries`/`num_elements` before your patch.
It seems unnecessary for me to rename `num_entries`.
-
03:59 AM Feature #12142: Hash tables with open addressing
- Thank you for your great contribution.
Do you compare memory usages?
There are good and bad points.
* Good
* removing fwd/prev pointer for doubly linked list
* removing per bucket allocation
* Bad
* it requires more "e... -
- ~~~
Hello, the following patch contains a new implementation of hash
tables (major files st.c and include/ruby/st.h).
Modern processors have several levels of cache. Usually,the CPU
reads one or a few lines of the cach... -
10:48 PM Bug #12144 (Closed): Segfault in Ruby 2.3.0p0
- Greetings,
I've recently started getting a segfault when running our integration test suite against Rails 3.1.12.
The segfault happens very often, so it is easy to reproduce, but complicated to set up. It does not segfault 100% of ... - 10:43 PM Revision adde0a94 (git): * test/-ext-/float/test_nextafter.rb: In AIX,
- nextafter(+0.0,-0.0)=+0.0, and nextafter(-0.0,+0.0)=-0.0,
but they should return -0.0 and +0.0, respectively. This is
a known bug in nextafter(3) on AIX, so skip related tests.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54003... - 10:20 PM Revision 1ec6bb95 (git): * test/zlib/test_zlib.rb (test_adler32_combine, test_crc32_combine):
- Skip two tests on AIX because zconf.h in zlib does not correctly
recognize _LARGE_FILES in AIX. The problem was already reported
to zlib, and skip these tests until it is fixed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@5400... - 06:14 PM Revision 2819add5 (git): * 2016-03-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54001 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:14 PM Revision a2594be7 (git): * thread_pthread.c (getstack): __pi_stacksize returned by
- pthread_getthrds_np() is wrong on AIX. Use
__pi_stackend - __pi_stackaddr instead.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54000 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:40 PM Bug #12143 (Closed): [DOC] Fix RDoc markup in doc/extension*.rdoc
- This patch fixes broken RDoc in extension.rdoc and extension.ja.rdoc.
E.g. fixing labelled lists, comments (# -> -- / ++),
escaping (ary[offset] would else be a link, #to_str would not render correctly,
(c) would render as copyright... -
- Do you mean same template with different contexts, a name is a variable one time, but a method call next time?
I doubt that it is a common use case. -
- I can't understand this issue. You know there is `__send__` because `send` is often overridden. Then, why do you think `invoke` is okay? We can easily find a lot of cases that `invoke` is defined.
https://github.com/ruby/rake/blob/... -
12:49 PM Feature #12141: send and __send__
- Thanks for your feedback. :-)
I agree, it's a minor (cosmetic) issue. For example, Rails uses `__send__` only 17 times in its huge codebase. :-)
I don't suggest removing `send`, but just replacing `__send__` with `invoke` to have a... -
07:03 AM Feature #12141: send and __send__
- Hmm the second send that appears in bold is a `__send__` - it seems
as if rubymine interpretes this as bold, sorry. -
- I think this could only be done in ruby 3.x
But I believe that `.send` will remain because it is super short. :)
In the later ruby days, people added `.public_send` but `.send` is still so
much shorter to use and write; `.invoke` ... -
- * lib/securerandom.rb (gen_random): Array#join returns a String,
no to_s is needed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53999 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ruby.c (load_file_internal): warn if shebang line ends with a
carriage return.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53998 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- because it always returns 0 to 2 (non-negative value).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53997 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:57 AM Bug #12136: OpenStruct.new(format: :bar).send :format # => too few arguments
- Marc-Andre Lafortune wrote:
> Sadly, there's no way to know from `method_missing` if that method is called privately or publicly, so this would effectively make all private methods become public which is not acceptable.
There is a wa... -
12:45 AM Bug #12136: OpenStruct.new(format: :bar).send :format # => too few arguments
- Indeed, latest optimization of `OpenStruct` now allows conflicts with Object private methods.
I didn't realize it, but conflicts with public methods are already ignored (i.e. `OpenStruct.new(hash: 'code').hash` does not return 'code)
... -
- because there is a same name (no related) function gc_stat().
Also gc_stat_* are renamed to gc_mode_*,
gc_stat_transition() to gc_mode_transition(),
rb_objspace::flags::stat is renamed to rb_objspace::flags::mode.
Change rb_obj... -
08:48 AM Feature #11547: remove top-level constant lookup
- Scott Bronson wrote:
> Corin, I completely agree. Recently, Rails's nondeterministic autoload made it very hard for me to discover this problem. Without the insightful warning, I would have been sunk.
> ...
The behavior change might ... -
07:24 AM Bug #12044 (Closed): net/ftp.rb: add NullSocket#closed? to fix closing not yet opened connection
- fixed at r53810
-
- +1 for the spirit of the suggestion
Perhaps ruby 3.x will also feature some more advanced import-like system
fitting to ruby. :) Manipulating environments or objects-in-environments
would be nice.
I have no particular strong feel... -
- * ruby.c (load_file_internal): simplify by local variables instead
of repeating RSTRING macros.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53995 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_rubyoptions.rb (test_shebang): use encoding
option to assert_in_out_err.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53994 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ruby.c (load_file_internal): remove a magic number, which means
the length of ruby_engine but the value is unknown in this file
since the variable is in a different file now. instead, strstr
should deal with it well, as far as r... -
12:29 AM Revision 5a90f9e8 (git): * lib/rubygems.rb, lib/rubygems/*, test/rubygems/*: Update rubygems-2.6.1.
- Please see entries of 2.6.0 and 2.6.1 on
https://github.com/rubygems/rubygems/blob/master/History.txt
[fix GH-1270] Patch by @segiddins
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53992 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/03/2016
-
11:27 PM Bug #12139: return OpenSSL::Random.random_bytes(n) call takes to long. OpenSSL:: bug on windows.
- Sorry, I've forgotten to note that `Random.raw_seed` is Ruby 2.3 feature.
-
- `Random.raw_seed` is an alternative to `OpenSSL::Random.random_seed`.
This calls `CryptGenRandom` internally.
BTW, I could not reproduce the problem on my environment (x64-mswin64, Win7, OpenSSL 1.0.2f).
Calling `OpenSSL::Random.ran... -
10:11 PM Bug #12139: return OpenSSL::Random.random_bytes(n) call takes to long. OpenSSL:: bug on windows.
- Yui NARUSE wrote:
> Your issue sounds related with https://wiki.openssl.org/index.php/Random_Numbers#Windows_Issues
> ...
CryptGenRandom would be an excellent solution in my opinion :) -
- Nobuyoshi Nakada wrote:
> Maybe the entropy pool exhausted?
> ...
In the 22 seconds it takes rails to load i am usually writing code, so OpenSSL does not get woken up by keyboard or mouse activity.
-
- Your issue sounds related with https://wiki.openssl.org/index.php/Random_Numbers#Windows_Issues
But [Bug 2100 the heap walk issue](https://rt.openssl.org/Ticket/Display.html?id=2100&user=guest&pass=guest) is closed.
Anyway maybe Secu... -
- Maybe the entropy pool exhausted?
Does moving mouse or typing keyboard wake up OpenSSL? -
- I have been a windows dev for a while now. I have never solved this rails startup issue. Running one Rspec test takes rails 22 seconds to load on my PC. When I (temporarily) comment out the line in securerandom.rb and replace it with a h...
-
- Sorry, hard time editing/formating my post !
:-(
But I hope you understand what I mean ! -
- [deleted by author]
-
- Hi guys !
We have this concept of sending messages to objects with `Object#send`, and that's fine, but often a child class defines its own send method, so that's why we have this ugly `Object#__send__` hack.
So, I suggest dropping ... - 09:05 PM Revision f1321bd6 (git): * 2016-03-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53991 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:05 PM Revision e5fc06cd (git): * test/ruby/test_io_m17n.rb (test_each_codepoint_need_more): Bump
- timeout up to 10s for slower platforms and impls.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53990 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:03 PM Bug #11844: Please update unicode-licensed files (license issue)
- Another thing - you're saying your copies of the files were modified. If the -data- inside them was modified, does that mean you're not compliant because you're not "supporting the Unicode Standard" as defined back then?
-
- The non-free problem is with this line: "supplied in this file in the creation of products supporting the Unicode Standard" - which implies that you can't use this file to produce stuff not supporting / not complying with "the Unicode St...
-
- Indeed, it's a dupe of #11884.
-
04:13 PM Bug #12140: Serialization of OpenStruct objects with YAML fails
- Maybe it's a dup of https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/53366
-
- When deserializing a serialized YAML open-struct object, it fails with an exception `NoMethodError: undefined method `key?' for nil:NilClass`.
This breaks `serialized` attributes in Rails 3.2 with Ruby 2.3.
To reproduce:
~~~
re... -
- Just I remind,
Ruby's Makefile must support nmake.
I know automake can generate Makefile which runs with bsdmake, but don't know with nmake. -
- * parse.y (parser_nextline, parser_cr): split less frequent paths
from parser_nextc.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53989 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (parser_params): turn last_cr_line into cr_seen flag.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53988 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:22 AM Feature #11666: IPAddr#private?
- As far as I understand RFC4193 never defines its range being "private". There also are other private-ish address ranges e.g. fd00::/8. And what about v4-mapped v6 addresses? IPv6's situation is complicated (at least to me). I'd sugge...
-
- closing as per request
-
- "ISeq#compile's need of binding" means a template engine cannot cache compiled ISeqs for later invocation, right? I doubt the benfit of compile's taking bindings.
-
- Applied in changeset r53987.
----------
ostruct.rb: make internal methods private
* lib/ostruct.rb (modifiable?, new_ostruct_member!, table!):
rename methods for internal use with suffixes and make private,
[ruby-core:71069] [Bug #... -
- * lib/ostruct.rb (modifiable?, new_ostruct_member!, table!):
rename methods for internal use with suffixes and make private,
[ruby-core:71069] [Bug #11587]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53987 b2dd03c8-39d4-4d8f-9... -
- Do you still need this? We now have grep_v which resembles your reject example.
- 03:08 AM Revision 09fefc2e (git): * 2016-03-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53986 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/lib/test/unit.rb (update_status): do not return the cursor
if verbose mode, not results and times to overwrite test names.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53985 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/02/2016
-
06:08 PM Feature #12138 (Feedback): Support `Kernel#load_with_env(filename, cbase: SomeMod, cref: someMod, binding: SomeMod) # => obj`
- Ruby's `require` and `load` methods currently only return `true`, which means that any code being loaded must affect the global namespace, or have the global namespace affected for it to interact with.
This means that to load data, li... -
- The following code raises an ArgumentError on 2.2. On 2.3, it crashes in binding.
~~~ruby
def repro(&blk)
blk.binding
nil
end
repro(&:succ)
~~~
Output 2.2:
~~~
crash.rb:2:in `binding': Can't create Binding from C le... -
- What is "C's OptParse"?
-
10:57 AM Bug #12135 (Closed): OptParse rejects --longopt= with a zero-length argument.
- OptParse diverges from C's OptParse by rejecting a zero-length argument given to a long option.
C accepts it:
~~~
$ ./a.out --delete=
option delete with arg ''
~~~
Ruby fails:
~~~
OptionParser::InvalidArgument: invalid ar... -
02:07 PM Bug #12127 (Third Party's Issue): LANG environment is not respected
- Yui NARUSE wrote:
> I can't reproduce it.
> ...
~~~
$ ruby -ve "p Encoding.find('locale');puts ''.encoding"
ruby 2.3.0p0 (2015-12-25 revision 53290) [x86_64-linux]
#<Encoding:US-ASCII>
US-ASCII
~~~
Actually, I suspect this my h... -
12:53 PM Bug #12136: OpenStruct.new(format: :bar).send :format # => too few arguments
- It's this commit: https://github.com/ruby/ruby/blob/7fa21558051e5412dcb790f528e392476edd4389/lib/ostruct.rb
By defining the getters and setters lazily the Kernel, Object and BasicObject instance methods shine through and #method_missi... -
- #send(:format) to an OpenStruct with a field named :format raises an ArgumentError in Ruby 2.3.0:
~~~
OpenStruct.new(format: :bar).send :format
ArgumentError: too few arguments
~~~
It works as expected in ruby 2.2.1p85 (2015-02-... -
12:27 PM Feature #11527: IPAddr#mask_addr isn't a method
- There is a proposal for a fix on https://github.com/ruby/ruby/pull/1269 (see https://bugs.ruby-lang.org/issues/11210)
-
- Assigning this to the official maintainer of ipaddr.
Or should it be assigned to matz?
Could this be decided at the next Developer meeting or sooner?
See https://github.com/ruby/ruby/pull/1269 for the patch. -
11:16 AM Feature #12134: Comparison between `true` and `false`
- for the first case you can use #partition
```ruby
[7, 6, 5, 4, 3, 2, 1].partition{|e| Prime.prime?(e) }.flatten
# => [7, 5, 3, 2, 6, 4, 1]
``` -
10:56 AM Feature #12134 (Open): Comparison between `true` and `false`
- There are some needs to sort elements depending on whether they satisfy certain condition expressed as a predicate. For example, to place prime numbers before others:
~~~RUBY
require "prime"
[7, 6, 5, 4, 3, 2, 1].sort_by{|e| Prime.p... -
-
-
- * vm_eval.c (method_missing): call by found method entry and get
rid of searching the same method entry twice.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53984 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_eval.c (vm_call0_body): calling method_missing method is
method_missing().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53983 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/lib/test/unit.rb (update_status): keep the cursor to the
beginning of the line for each update, so that unexpected output
like an error message will overwrite but not be concatenated to
the status.
git-svn-id: svn+ssh://ci.... -
- Applied in changeset r53981.
----------
* lib/xmlrpc.rb: Removed broken parser named XMLScanStreamParser.
It's not works with current Ruby version.
[fix GH-1271][ruby-core:59588][Bug #9369]
* lib/xmlrpc/config.rb: ditto.
* lib/xmlrp... -
- It's not works with current Ruby version.
[fix GH-1271][ruby-core:59588][Bug #9369]
* lib/xmlrpc/config.rb: ditto.
* lib/xmlrpc/parser.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53981 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
- Applied in changeset r53980.
----------
* lib/xmlrpc.rb: Removed broken parser named XMLTreeParser.
Required gem of its parser didn't compile on newer Ruby versions.
[fix GH-1271][ruby-core:59590][Bug #9370]
* lib/xmlrpc/config.rb: ... -
- Required gem of its parser didn't compile on newer Ruby versions.
[fix GH-1271][ruby-core:59590][Bug #9370]
* lib/xmlrpc/config.rb: ditto.
* lib/xmlrpc/parser.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53980 b2dd03c8... -
- cf https://docs.google.com/document/u/2/d/1rj7ODOCSfcsQeBd6-p-NiVwqxDUg05G66LwDOkKOGTw/pub
Matz is negative to this.
03/01/2016
-
08:31 PM Feature #12133 (Feedback): Ability to exclude start when defining a range
- An intuitive, approach would be to allow defining ranges like so:
~~~
[1..10]
[1..10)
(1..10]
(1..10)
~~~
... where a square bracket indicates boundary inclusion and a parenthesis represents boundary exclusion. The syntax ther... -
- 2.2.2 is outdated.
-
02:48 PM Bug #12088: Segmentation fault at 0x00000000000000 ruby 2.2.1p85 (2015-02-26 revision 49769) [x86_64-linux]
- Upgraded to 2.2.2
BTW. We'r using CentOS 6.6. libc2.12
Just faced with problem again:
~~~
*** glibc detected *** ruby: double free or corruption (fasttop): 0x00007f9ea5118d30 ***
======= Backtrace: =========
/lib64/libc.so.6(+... - 03:00 PM Revision a400386d (git): * 2016-03-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53979 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:00 PM Revision 6d2c4e7b (git): Fix pull request number [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53978 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_method.c (prepare_callable_method_entry): assert same
condition only once for each case, not twice for module instance
method.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53977 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:32 PM Bug #12132 (Closed): Crash during tests
- After updating a rails application to 2.3 I am experiencing intermittent crashes when I run `bundle exec rspec`
-
11:00 AM Feature #10617: Change multiple assignment in conditional from parse error to warning
- I find this really unintuitive and share some of 'bug hit's exasperation. It's clear that the return value, like everything, is either truthy or falsey, why treat this differently to everything else in Ruby?
It's particularly annoying... -
- This seems surprising:
~~~
obj = Object.new
def obj.singleton_method_added(n)
p n
end
def obj.new_singleton_method; end
~~~
outputs
~~~
:singleton_method_added
:new_singleton_method
~~~ -
06:45 AM Bug #12130 (Closed): WEBrick::HTTPProxy closes connection when the socket is not writable temporally
- `WEBrick::HTTPProxy#do_CONNECT` closes connection when `Errno::EAGAIN` or `Errno::WOULDBLOCK` occurred.
These exceptions will raise when the socket is not writable temporally.
I expect that the proxy will wait until the socket will be ... -
- For a similar proposal, please cf. #10394.
-
- Yes, `&:to_s(16)` is exactly my (rejected) proposal.
-
- I can't reproduce it.
Could you show `ruby/ruby -ve "p Encoding.find('locale');puts ''.encoding"`? -
02:41 AM Bug #12127 (Feedback): LANG environment is not respected
- Can you explain what the problem is with
$ LANG=en_US.utf-8 ruby -e "puts ''.encoding"
US-ASCII
As far as I understand, strings with an encoding of US-ASCII can be used wherever an UTF-8 string can be used, so this shouldn't creat... -
03:13 AM Feature #12129: syntactic sugar for dynamic method dispatch `object_expression:method_name_expression(1, 2)`
- Yukihiro Matsumoto wrote:
> Describe more concretely and preferably tell us why do you need it, please.
`object_expression:method_name_expression(1, 2)`
would be sugar for
`object_expression.__send__(method_name_expression, arg... -
03:00 AM Feature #12129: syntactic sugar for dynamic method dispatch `object_expression:method_name_expression(1, 2)`
- Describe more concretely and preferably tell us why do you need it, please.
Matz. - 02:26 AM Revision ab1a8045 (git): * 2016-03-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53976 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/fileutils.rb: use keyword arguments instead of option
hashes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53975 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Stefan Merettig wrote:
> * Using `.>`: `the_object.>a_method`
> ...
These two conflict with existing syntax and break compatibility.
Note that `object.>(other)` is a valid method call.
-
-
- Correction: the infinite recursion was a bug in the patch, and fixed the branch.
The trick of `Kernel` for [Bug #9155] is for the case a global method is called *before* the target object is set.
It is for the backward compatibility ... -
01:41 AM Bug #12126: [PATCH] openssl: accept moving write buffer for write_nonblock
- [email protected] wrote:
> Before this, a Rubyist would need to remember the exact object
> which failed to write and reuse it later when the socket became
> writable again. This causes problems when the buffer is given
> by an...
02/29/2016
-
11:06 PM Feature #12020: Documenting Ruby memory model
- I understand your point, I would like explore how it could be solved in MRI before relaxing the constant and method redefinition though. The relaxation could lead to undesirable unpredictable behaviour for users.
As you've mentioned t... -
-
09:34 PM Feature #12115: Add Symbol#call to allow to_proc shorthand with arguments
- Although I don't understand the Japanese, the linked issue, with a similar syntax to what Shel vacu proposed above, was rejected by Matz. So probably not too much hope on getting this into core…
-
- I think there have been many other similar proposals. Nobu linked to other
discussions.
From what I have seen, I think the major problem is coming up with a nice
syntax proposal.
```ruby
.map(&:foo)
```
is ok because it is s... -
06:35 PM Feature #12115: Add Symbol#call to allow to_proc shorthand with arguments
- I agree that there should be some syntax for doing this, but I don't think this is the proper way to do it.
Personally, the syntax is confusing to me. I would prefer something like:
~~~ruby
[1,2,16].map(&:to_s(16))
~~~
This wa... -
- I think the `&File->basename` looks confusing since we also have
`->` standalone now.
`object->method` reminds me a lot of php/perl and ruby uses the
prettier `.` instead, `object.method`.
I also think that :
```ruby
.map{F... -
- Please don't do this!!! No need to make the language more complex just to solve such small issue!!!
If you want to do something pretty, then whole closure syntax should be simplified, not just call to '#method'.
````ruby
Dir["*/*.... -
02:29 PM Feature #12125: Proposal: Shorthand operator for Object#method
- How about this one?
~~~ruby
class UnfoundMethod
def initialize(receiver)
@receiver = receiver
end
def method_missing(name, *args, &block)
@receiver.method(name)
end
end
module UnfoundMethodAttacher
def ... -
02:14 PM Feature #12125: Proposal: Shorthand operator for Object#method
- Yukihiro Matsumoto wrote:
> but I don't think `->` is a good idea.
Other options I can think of are:
* Using `.>`: `the_object.>a_method` While its look is nearer to a normal method call (Which I think is a plus), I fear that the... -
12:58 PM Feature #12125: Proposal: Shorthand operator for Object#method
- For this kind of "conceptual" methods I sometimes define just one-letter shortcuts in core_ext.rb, like `.map(&File.m(:basename))`. I'm not sure, though, if any of existing/popular libraries will struggle from such kind of solution (or m...
-
- I like the idea of short hand notation for `Object#method()`, but I don't think `->` is a good idea.
Matz. -
- I believe that this is actually how ruby may have behaved before the transition into frozen strings
already; at the least, I seem to distinctly remember that, if I write a method such as:
---
~~~ruby
require 'pp'
def foo(i = A... -
07:35 PM Bug #12128: Strings in `ARGV` are frozen
- Be advised that you can say `ARGV.map!(&:+@)` if you really want to modify the elements in-place, but that's probably not the best idea.
-
- Sorry, I found that it is indeed a feature that they are frozen. Please reject this.
-
- It is not clear how the frozen status of strings in `ARGV` are to be described, but regardless of what I try to do (i.e. set frozen string pragma as false, which is probably irrelevant because the strings are already created at the time ...
-
08:13 PM Bug #11962: Ruby 2.3.0 causing compile failure on extensions using a C++ compiler
- We are trying to transition Debian unstable to ruby2.3, it would be very helpful to have this applied to the 2.3 branch.
-
- ext/digest should use OpenSSL, which has many optimizations.
But old ruby's ext/digest/sha1 was buggy.
Through r52694, r52695, and r52755, I fixed it.
Now it correctly uses openssl (if you give --with-openssl-dir or something on OS ... -
- Ruby 2.2:
~~~
$ ruby -v
ruby 2.2.4p230 (2015-12-16 revision 53155) [x86_64-linux]
$ ruby -e "puts ''.encoding"
US-ASCII
$ LANG=en_US.utf-8 ruby -e "puts ''.encoding"
UTF-8
~~~
Ruby 2.3:
~~~
$ ruby -v
ruby 2.3.0p0 ... -
- ~~~
By setting the SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER flag.
This flag was introduced at the same time as
SSL_MODE_ENABLE_PARTIAL_WRITE in OpenSSL 0.9.4 and makes usage
with non-blocking sockets much easier.
Before this, a Rubyist... -
- Benoit Daloze wrote:
> Would this patch allow to remove the special case for Kernel dispatch then? Or should it be kept for compatibility if `!target.is_a?(Kernel)` and most likely a `BasicObject`?
It's necessary to avoid infinite re... -
- Nobuyoshi Nakada wrote:
> Benoit Daloze wrote:
> ...
Ah, right, because in this case the method would be found on target since target is an `Object` (a `Fixnum` actually).
Would this patch allow to remove the special case for Kernel... -
- Benoit Daloze wrote:
> Would that solve the OP example code since `some_func` is defined in `Object`, not `Kernel`?
It is because of the private method of the target, in `Object` or in `Kernel` or in target itself is not the point.
-
- * lib/fileutils.rb (LowMethods): make alias methods instead of
eval for each methods.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53974 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/fileutils.rb (Verbose, NoWrite, DryRun): make overridden
methods private by each one calls.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53973 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/fileutils.rb (Verbose, NoWrite, DryRun): make extended
methods public by each one calls.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53972 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/fileutils.rb: Unify to coding-style for method definition.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53971 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- On 02/29/2016 03:17 PM, Eric Wong wrote:
> [email protected] wrote:
>> - I'm afraid automake contaminates this project with GPL.
>
> Not true, automake gives something like the following:
>
> # This Makefile.in is free soft... -
- I generally for this, but ...
C.J. Collier wrote:
> It looks like there is a lot of duplicate code that could be removed by making use of automake.
> ...
Just because Ruby was born before automake (and matz seems not be familiar wit... -
- [email protected] wrote:
> - I'm afraid automake contaminates this project with GPL.
Not true, automake gives something like the following:
# This Makefile.in is free software; the Free Software Foundation
# gives unlimited... -
- - I'm afraid automake contaminates this project with GPL.
- I'm afraid this world is not built on top of GNU. AFAIK automake forces us to use GNU make, which breaks compatibility. -
- * array.c (rb_ary_push_m): [DOC] Remove trailing comma from
Array#push example, as other Array examples doesn't put trailing
comma. [Fix GH-1279]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53970 b2dd03c8-39d4-4d8f-98ff-823fe... -
- * common.mk, tool/mkconfig.rb: set cross_compiling option from
Makefile, but not from rbconfig.rb, which is just going to be
created by this command.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53969 b2dd03c8-39d4-4d8f-98ff-82... -
- Could you show failed messages?
- 05:54 AM Revision 06efc1da (git): * 2016-02-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53968 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53967 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- r53524 is the revision in the trunk, not 2.3.
And #11928's backport status to 2.3 is still REQUIRED. -
- What constraints does `DTRACE_PROBE4` macro have?
-
- On 02/28/2016 12:22 PM, Eric Wong wrote:
> Keep in mind the equivalent Perl terminates just fine:
Yes. But,
> So I prefer we acknowledge cases like these as bugs to at least
> encourage someone to fix them.
Ruby's (and Perl's...
02/28/2016
-
- > The & operator lets one pass a #call-able object as block.
I meant `#to_proc`-able objects, sorry for the confusion. -
- Hello,
The `&` operator lets one pass a `#call`-able object as block.
Really useful feature, but at the moment, if you want to pass a `Method` this way the syntax is not really concise:
```ruby
Dir["*/*.c"].map(&File.method(:ba... -
- * configure.in: fold long lines in configuration summary
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53966 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * configure.in: Add summary to end of configure output.
[Fix GH-1277]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53965 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * configure.in (cflags, cppflags): remove unnecessary leading
spaces.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53964 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I also got a similar bug with Ruby 2.3.0p7 revision 53608. As the poster writes, this version is later than revision 53524, in which a similar (alleged duplicate) bug has been supposed to be fixed. But the bug retains, and the present is...
-
11:41 AM Bug #12121: 異なる名前空間にある同名の定数により Module.constans の結果の並びが変わる
- 問題が起きたライブラリは dotenv というライブラリです。
https://github.com/bkeepers/dotenv
Module.constants の戻り値として `[Substitutions::Variable, Substitutions::Command]` だった
並び順が `[Substitutions::Command, Substitutions::Variable]` に変わっておりました。
https://g... -
- ちなみにどういうライブラリでどういう問題が起きたのでしょうか。
-
- `Module#constants`に順序の保証はありません。
- 11:28 AM Revision 1b34bf19 (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53963 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:28 AM Revision 018f0812 (git): * lib/drb/drb.rb (error_print): Add verbose failure messages and
- avoid infamous DRb::DRbConnError. [Feature #12101]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53962 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:28 AM Feature #12101 (Closed): Add verbose failure messages and avoid infamous DRb::DRbConnError
- Applied in changeset r53962.
----------
* lib/drb/drb.rb (error_print): Add verbose failure messages and
avoid infamous DRb::DRbConnError. [Feature #12101] -
- Would that solve the OP example code since `some_func` is defined in `Object`, not `Kernel`?
Using `Kernel.method` would be wrong, because the receiver would be the `Kernel` class, and not the delegated object `(Klass.new(0).inspect` ... -
- It's the current spec that delegator cannot call private method of the target, because it was impossible to tell it was called as function call form, (without the receiver).
https://github.com/ruby/ruby/compare/trunk...nobu:feature/12... -
08:24 AM Misc #12124 (Closed): Use Automake
- It looks like there is a lot of duplicate code that could be removed by making use of automake.
Are there any reasons why this should not be done?
I've got some patches up for review here:
https://github.com/ruby/ruby/compare/tr... -
- * error.c (nometh_err_initialize): add private_call? parameter.
* error.c (nometh_err_private_call_p): add private_call? method,
to tell if the exception raised in private form FCALL or VCALL.
[Feature #12043]
* vm_eval.c (make_no_me... -
- Applied in changeset r53961.
----------
NoMethodError#private_call?
* error.c (nometh_err_initialize): add private_call? parameter.
* error.c (nometh_err_private_call_p): add private_call? method,
to tell if the exception raised in p... -
- [email protected] wrote:
> Status changed from Open to Rejected
>
> I simplified this as follows:
> regex = /\(a+( ?a*)*\)/
> detail = "(aaaa aaaaaaa aaaaa aaaaaaaaa aaaaa"
Keep in mind the equivalent Perl terminates just ... -
03:00 AM Bug #12123 (Closed): FileUtils.ln_s create a '.symlink' file not a symbolic link on windows
- when building ruby, 'test_cp_r_symlink' fail on make test-all
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53960 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Martin Dürst wrote:
> Andrew Vit wrote:
> ...
In natural language, universal quantification carries a presupposition that the domain is non empty; the meaning of "for all x in A, p(x)" is undefined when A is empty, just like "the king ... -
- Andrew Vit wrote:
> This is still surprising to me, it looks like a contradiction:
> ...
It's the way it works in Mathematics. But I'll try to explain it without using too much Mathematical terminology.
all? doesn't ask "at least ... - 01:20 AM Revision 60c8bfb3 (git): * 2016-02-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53959 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * array.c (rb_ary_and): clarify that set intersection returns the
unique elements common to both arrays.
* array.c (rb_ary_or): clarify that union preserves the order from
the given arrays.
- Most know what intersection means, but ...
02/27/2016
-
- **Set Intersection**
* Most know what intersection means, but saying the operation excludes duplicates could be misleading (`[1] & [1]`, duplicates excluded, might mean a result of `[]`).
* Instead, saying intersection returns the un... -
- Ruby 2.4.0-dev で、Ruby 2.3.0 以前と変わっている振る舞いについてです。
自身のモジュール定義の前に、異なる名前空間で同名の定数が定義されていると
Module.constants の結果の並びに影響を与える振る舞いに変わっているように見えます。
```ruby
module M1
module A end
end
module M2
module B end
module A end
end
... -
02:23 PM Bug #12120 (Closed): [target/sh4] error: 'asm' operand requires impossible reload
- Hello!
ruby2.3 fails to build from source on sh4 (Hitachi/Renesas SuperH), the build fails with [1]:
```
gcc -mieee -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -fPIC -D_FORTIFY_SOURCE=2 -fstack-protector -fno... -
01:59 PM Feature #12110: Create a method to avoid vacuous truth?
- Waldyr de Souza wrote:
> I often find myself running into unexpected results when using #all? for example
> ...
If you expect all false, then why not use `none?`, is it not sufficient?
> Even though it's logically correct could we h... -
01:53 PM Feature #12119 (Closed): next_prime for lib/prime.rb
- cf. https://github.com/ruby/ruby/pull/1272
## Rationale
To me, integer-without-limit is one of the greatest features of Ruby. I am currently working on my own implementation of arbitrary precision number system (https://github.com... -
- Update: It seems the suggested patch by Andreas Schwab does not help on ruby2.3 anymore. So, for ruby2.3, something different needs to be done.
-
- Hello!
On Motorola 680x0, ruby2.2 and ruby2.3 segfault when running the Ruby interpretor:
./miniruby -I./lib -I. -I.ext/common ./tool/runruby.rb --extout=.ext -- --disable-gems -r./m68k-linux-gnu-fake ./tool/rbinstall.rb --make="... -
- I simplified this as follows:
regex = /\(a+( ?a*)*\)/
detail = "(aaaa aaaaaaa aaaaa aaaaaaaaa aaaaa"
It still hangs. But it's easier to see why: The part (a+( ?a*)* allows many different ways to match the same thing, and all these are... -
- table by eliminating duplicates.
(with Kimihito Matsui)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53957 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/lib/test/unit.rb (Test::Unit::StatusLine#jobs_status): show
status of only changed woker, not to show same lines repeatedly,
in normal job_status mode.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53956 b2dd03c8-39d4-4d8... -
- * test/lib/test/unit.rb (_run_parallel): make sure retrying
message is a separate line.
* test/lib/test/unit.rb (_prepare_run): do not add Output if
testing.
* test/lib/test/unit.rb (Skipping#failed): defer showing reports
when s... -
- [email protected] wrote:
> I do not plan to commit the test change since OpenSSL behavior
> ...
I just discovered `SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER`,
which might've saved me plenty of headaches earlier this month:
```diff
-... -
- * test/lib/test/unit.rb (Test::Unit::StatusLine#_prepare_run): add
StatusLine::Output even if job_status is not replace, to filter
extra outputs and newlines.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53954 b2dd03c8-39d4-4d8... -
- * test/lib/test/unit.rb (Test::Unit::StatusLine#setup_options):
add :none to --jobs-status option.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53953 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:56 AM Revision 97d90a7e (git): * 2016-02-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53952 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/lib/test/unit.rb (Test::Unit::StatusLine::Output#print):
matched part never contains a newline to be chomped.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53951 b2dd03c8-39d4-4d8f-98ff-823fe69b080e