Activity
From 08/03/2016 to 08/09/2016
08/09/2016
-
08:09 PM Feature #12665: Faster prime? method for prime.rb std lib
- The current version of the method `prime?` in the `prime.rb`
std lib replaced the older version starting with 2.3.0... -
- The current version of the method `prime?` in the `prime.rb`
std lib replaced the older version starting with 2.3.0... -
07:05 PM Feature #12512: Import Hash#transform_values and its destructive version from ActiveSupport
- Yukihiro Matsumoto wrote:
> `#map_v` accepted.
At first I thought it was an "adapted form" of Hash#map like Enume... -
08:54 AM Feature #12512 (Closed): Import Hash#transform_values and its destructive version from ActiveSupport
- Applied in changeset r55847.
----------
hash.c: implement Hash#map_v and Hash#map_v!
* hash.c (rb_hash_map_v, rb_ha... -
-
07:14 AM Feature #12512: Import Hash#transform_values and its destructive version from ActiveSupport
- `#map_v` accepted.
Matz.
-
- I don't persist with the name `transform_value`.
`map_v` or `map_values` are also acceptable for me. -
06:23 PM Feature #12664 (Closed): Multiline pretty-printing of multiline strings
- With following addition
~~~ ruby
class String
def pretty_print(q)
lines = self.lines
if lines.size >... -
05:42 PM Feature #8895: Destructuring Assignment for Hash
- the closest you can get to hash destructuring is via block params:
~~~ ruby
{a: 1, b: 2}.tap do |a:, b:|
end
~~~
... -
04:41 PM Feature #12299: Add Warning module for customized warning handling
- I've added a gem for lib/warning.rb (https://rubygems.org/gems/warning).
-
- Here is a patch that uses Warning instead of Exception::Warning, and only includes the error.c change (and a test for...
-
- I accept the mechanism.
I prefer `Warning` to `Exception::Warning`.
Besides that, the basic should be included in... -
- Probably you want an isolated loading system like Java's or Python's. That's fine. It must be a good idea.
But I don... -
02:51 PM Bug #12662 (Rejected): rb_hash_fetch() Segmentation fault on an empty hash table
- It's your bug.
`rb_hash_fetch()` raises an exception if the key is not found, and you must catch it by `rb_protect()`. -
08:55 AM Bug #12662 (Rejected): rb_hash_fetch() Segmentation fault on an empty hash table
- I am writing HTM (Hash Table Machine - a C benchmark program for hash table) and libruby aborts with
ruby: [BUG] S... -
- It should be named `exist?` to be consistent with other methods in the standard libraries.
Besides that, I don't see... -
- Having both `ceil` (backed by UNIX tradition) and `ceiling` (better for English natives? dunno) only introduces confu...
-
- The explicit use of `===` for type checking is against duck typing principle.
I don't accept syntax enhancement prop... -
12:00 PM Revision 41fe7e4e (git): Remove empty directories
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55848 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:24 AM Bug #12663 (Closed): Compilation error on cygwin
- I get the errors below when compiling on cygwin. The problem may already be two or three days old; I'm sorry I overlo...
- 08:54 AM Revision ea5184b9 (git): hash.c: implement Hash#map_v and Hash#map_v!
- * hash.c (rb_hash_map_v, rb_hash_map_v_bang): impelement Hash#map_v and
Hash#map_v! [Feature #12512] [ruby-core:760... -
- I don't think proposed `guard` syntax is more readable than `unless`.
Even if some may agree with you, I doubt it's ... -
- Ruby is not Scheme.
The rule is simple: every bang method should have its non-bang version, which does not modify ... -
-
- It should be consistent. Will be fixed.
Matz.
-
- Instead, I propose `pow(a)` and `pow(a,b)` where the latter works as `mod_pow()` here.
Matz.
-
- I am not sure what we gain comparing to
```ruby
def controller **context
if context.key?(:name)
...
en... -
07:52 AM Revision cb18d4ba (git): * vm_insnhelper.c (vm_getivar): use always_inline because
- gcc7 doesn't inline this without always_inline.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55846 b2dd03c8-39d... -
- This is kind of autoload that sometimes cause problems.
I think it can cause issues than solving problem.
If you ha... -
- * test/ruby/test_objectspace.rb (test_finalizer_with_super):
adjust number of arguments to get rid of errors in a f... -
- Accepted.
Matz.
-
-
- I consider this is a bug. They should be consistent.
But I am not sure we can fix the issue soon. When in doubt, put... -
- Applied in changeset r55844.
----------
* ext/tk: Tk is removed from stdlib. [Feature #8539]
https://github.com/r... -
- https://github.com/ruby/tk is the new upstream.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55844 b2dd03c8-39d... -
- This idea sounds nice, but we have to keep compatibility.
Matz.
-
- I think we are talking about two things at once.
First, adding reverse (or descending) option to `sort_by`.
I thi... -
- I don't think the idea itself is meaningless.
But its use-case is not clear to us yet.
(For the record, Singleton... -
- I accept the idea of `#clamp` as `Comparable#clamp(min, max)`.
It would not accept ranges (for now).
Matz.
-
- * ext/tk/tcltklib.c (ip_init): get rid of repeated checks and
conversions in StringValueCStr.
git-svn-id: svn+ssh:... -
- * ext/tk/tcltklib.c (set_max_block_time, tcl_protect_core,
ip_init, ip_create_slave_core, get_obj_from_str,
ip_ca... -
- * ext/tk/tcltklib.c (set_max_block_time): use PRIsVALUE to get rid
of dangling pointer.
git-svn-id: svn+ssh://ci.r... -
- * ext/tk/tcltklib.c (set_max_block_time): fix missing break.
TclTkLib.set_max_block_time(1) works but
TclTkLib.se... -
- * ext/tk/lib/tcltk.rb (TclTkWidget#initialize): suppress an
"assigned but unused variable" warning.
git-svn-id: sv... -
- * ext/tk/sample/tcltklib/sample2.rb (Othello::BoardView::Square):
use attr_accessor instead of attr with optional b... -
- * ext/tk/lib/tk/texttag.rb, ext/tk/sample/tcltklib/sample2.rb,
ext/tk/sample/tkline.rb, ext/tk/sample/tktimer.rb: u...
08/08/2016
-
03:59 PM Feature #9704: Refinements as files instead of modules
- It would be interesting to be able apply a refinement to a whole app (without its gems) or inside a single gem withou...
- 03:16 PM Revision dfc9cb40 (git): * 2016-08-09
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55836 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55835 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:04 PM Revision 44997130 (git): * ext/win32ole/sample/excel1.rb, ext/win32ole/sample/excel2.rb,
- ext/win32ole/sample/excel3.rb, ext/win32ole/sample/ie.rb,
ext/win32ole/sample/ienavi.rb, ext/win32ole/sample/ienavi... -
07:50 AM Bug #12421: Please backport r53816, r53817
- Tomoyuki Chikanaga wrote:
> usa san how do you judge this?
I agreed with you. -
01:21 AM Bug #12421: Please backport r53816, r53817
- In my opinion r53816 might be considered as spec fix but r53817 was feature change, even though there's no entry in N...
-
- Similar to #11928 ?
Could you try with 2.3.1 or trunk? -
- * internal.h (RBASIC_CLEAR_CLASS): fix compile error and size to
fill.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby... -
- * test/lib/test/unit.rb (Test::Unit::Parallel::Worker.launch):
disable verbose flag in worker processes, get rid of... -
04:20 AM Bug #12657 (Closed): [PATCH] ANSI aliasing fix for XL compiler
- Applied in changeset r55831.
----------
* internal.h (RBASIC_CLEAR_CLASS): Reroute ANSI C's strict
aliasing rule.... -
- `RBASIC_CLEAR_CLASS` doesn't use `RBASIC_CLEAR_CLASS_RAW`, and the former only is used with r-values.
Sorry for the ... -
- Nobuyoshi Nakada wrote:
> Does this patch really compile?
Yes, at least to me. -
- Does this patch really compile?
`cls` in `RBASIC_CLEAR_CLASS` sometimes isn't an l-value, and should not be able to ... -
01:46 AM Bug #12657: [PATCH] ANSI aliasing fix for XL compiler
- Shyouhei Urabe wrote:
> Thank you. I think we don't need the #else part because the memset/memcpy should just work ... -
- Thank you. I think we don't need the #else part because the memset/memcpy should just work for all ANSI-compliant co...
-
- Applied in changeset r55831.
----------
* internal.h (RBASIC_CLEAR_CLASS): Reroute ANSI C's strict
aliasing rule.... -
- aliasing rule.
[ruby-core:74427][Bug #12191][ruby-core:76747][Bug #12657]
git-svn-id: svn+ssh://ci.ruby-... -
03:39 AM Feature #9612 (Assigned): Gemify OpenSSL
-
- Rubygems に gem として push できるよう、リクエストをだしました
https://github.com/rubygems/rubygems.org/pull/1378 -
- Is there reason this is not loved? I'd like to have this.
08/07/2016
-
08:49 PM Feature #9999: Type Annotations (Static Type Checking)
- Might be worth looking at [RDL](https://github.com/plum-umd/rdl) for some inspiration.
-
05:18 PM Feature #12655: Accessing the method visibility
- Hi,
I'm the original author of looksee.
I agree that we don't need everything in the Looksee extension in ruby.... - 04:33 PM Revision 0c5fb7df (git): * 2016-08-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55830 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55829 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * basictest/runner.rb, bootstraptest/runner.rb: disable warnings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@... -
- * tool/vcs.rb (VCS#modified): get rid of set but unused variables.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk... -
- * ext/extmk.rb: get rid of shadowing outer local variable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55826 b... -
- * ext/extmk.rb (sysquote): removed. unnecessary since r52161.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@558... -
- Applied in changeset r55824.
----------
deprecate TRUE,FALSE,NIL
* object.c (InitVM_Object): deprecate toplevel con... -
- * object.c (InitVM_Object): deprecate toplevel constants TRUE,
FALSE, and NIL. [Feature #12574]
git-svn-id: svn+s...
08/06/2016
-
10:08 PM Bug #12660: [PATCH] openssl: avoid undefined behavior on empty SSL_write
- [email protected] wrote:
> Thanks! Looks fine to me. Please commit.
Thanks for quick review :> r55822 -
09:50 PM
Bug #12660 (Closed): [PATCH] openssl: avoid undefined behavior on empty SSL_write
- Applied in changeset r55822.
----------
openssl: avoid undefined behavior on empty SSL_write
SSL_write(3ssl) manpag... -
11:38 AM Bug #12660: [PATCH] openssl: avoid undefined behavior on empty SSL_write
- Thanks! Looks fine to me. Please commit.
-
- SSL_write(3ssl) manpage has this in the WARNINGS section:
When calling SSL_write() with num=0 bytes to be s... - 09:50 PM Revision f5f6859b (git): * 2016-08-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55823 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:50 PM Revision 7513d546 (git): openssl: avoid undefined behavior on empty SSL_write
- SSL_write(3ssl) manpage has this in the WARNINGS section:
When calling SSL_write() with num=0 bytes to be sen... -
- You can't make multiple requests on a Net::HTTP instance at the same time. You have to open an HTTP connection for ea...
-
02:00 PM Bug #12661: Multithreading http get doesn't work
- on stackoverflow:
http://stackoverflow.com/questions/38805052/download-files-asynchronously -
- Hi, I was making this script that was supposed to download all files from my favourite imageboard (2ch.hk)
Everythin... -
01:01 AM Feature #12659 (Closed): Readline: expose rl_char_is_quoted_p setting
- I maintain an interactive Git shell [1] built in Ruby, which made extensive use of the `Readline` module. We found we...
-
- * id_table.h (rb_id_table_iterator_result): add dummy sentinel
member because C standard prohibits a trailing comma... -
- Mathieu Jobin wrote:
> it uses the following macros to find the method visibility and if it has been redefined
>
> `...
08/05/2016
-
06:53 PM Bug #12658 (Closed): variable_name_checker
- (development) 15:45:10 ~/2016/cmdapi/collector $ rackup
[2016-08-05 15:45:12] INFO WEBrick 1.3.1
[2016-08-05 15:45... -
- This is related to Bug #12191.
Changing in internal.h:983-985
from :
```diff
-#define RBASIC_CLEAR_CLASS(ob... - 03:39 PM Revision b46a8a54 (git): * 2016-08-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55820 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * hash.c (env_enc_str_new): make string for an environment
variable name or value.
* hash.c (env_name_new): make en... -
03:25 PM Feature #12654: On Windows use UTF-8 as filesystem encoding
- Usaku NAKAMURA wrote:
> If filesystem encoding is fixed to UTF-8, it causes other (but similar) problems.
UTF-8 c... -
- Premises:
1. We don't introduce such breakage of compatibility until Ruby 3.
2. At Ruby 3, on Windows, we're plan... -
- Nobuyoshi Nakada wrote:
> Dāvis Mosāns wrote:
> > That's not really needed. For example `File.read` works with any ... -
- Dāvis Mosāns wrote:
> That's not really needed. For example `File.read` works with any console's codepage. But `Dir.... - 02:19 PM Revision 549605c1 (git): * hasn.c (env_str_new): taint the string. get rid of a test failure
- introduced at r55811.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55818 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:52 PM Feature #12648: `Enumerable#sort_by` with descending option
- Taking a step back, we are using arrays simply because that is a object that allows sorting via multiple criteria (if...
-
- Nobuyoshi Nakada wrote:
> Greg L wrote:
> > Hence, a better solution might be adding a method like `sort_keys` or `... -
- Greg L wrote:
> Hence, a better solution might be adding a method like `sort_keys` or `sort_key`, where an array is ... -
- In concept, I agree, but, although it's common to return an array from the block, any object can be returned that sup...
-
- * win32/win32.c (getifaddrs, rb_w32_getppid): initialize the API
pointers with an impossible value not to try every... -
- * win32/win32.c (rb_w32_inet_ntop, rb_w32_inet_): make the
API pointers static not to get the address everytime.
g... -
- * win32/win32.c (get_final_path): initialize this pointer without
further comparisons.
git-svn-id: svn+ssh://ci.ru... - 08:04 AM Revision ad9d8468 (git): * 2016-08-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55814 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * hash.c (w32_getenv): call rb_w32_getenv and rb_w32_ugetenv via
this pointer without further comparisons.
git-svn... -
-
- I think it should be possible to implement locksee in pure-ruby. To me it seems OK to have a way to access visibilit...
08/04/2016
-
- Currently File.expand_path expands short path only if it's last part.
~~~ruby
puts File.expand_path('C:/VERYLO~1'... -
- Nobuyoshi Nakada wrote:
> Try `chcp.com 65001`.
That's not really needed. For example `File.read` works with any ... -
- Try `chcp.com 65001`.
-
- Windows (NTFS) supports Unicode and there can be paths/filenames with other characters than current ANSI/OEM codepage...
-
- Thanks for reminding me.
I've just fixed the remaining at ruby/openssl (GitHub):
https://github.com/ruby/openss... -
07:58 AM Bug #12381: ext/openssl classes' dup/clone don't work well
- SSLContext#dup is not fixed yet?
```
$ RBENV_VERSION=2.4.0-dev ruby -v -ropenssl -e 'c = OpenSSL::SSL::SSLContext... -
11:26 AM Feature #12655 (Closed): Accessing the method visibility
- I took on the task to make the looksee gem work with ruby 2.3 and 2.4. Unfortunately, some features were not directly...
-
- On 2016/08/04 04:23, [email protected] wrote:
> http://www.redmine.org/projects/redmine/wiki/RedmineIssues
> ... -
- Hmm.. Thank you for the check. It is complicated than I thought. Closing this one anyway.
-
-
- Anyway, although on Windows, use `'*'` to prevent globbing.
-
-
-
-
-
-
-
-
- Closing duplicated issue. Please continue discussing at Issue #7882.
-
-
- 02:54 AM Revision dd96e0c7 (git): * 2016-08-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55812 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * hash.c (env_assoc): the encoding of the value should be the
locale, as well as other methods, [], fetch, values, ...
08/03/2016
-
- Ronald Fischer wrote:
> The documentation of the JSON stdlib class (i.e. http://ruby-doc.org/stdlib-2.2.5/libdoc/jso... -
07:46 PM Feature #12650: Use UTF-8 encoding for ENV on Windows
- Hi,
Usaku NAKAMURA wrote:
> We don't want to break compatibility.
> Wait Ruby3.
We always invoke ruby with -E... -
- We don't want to break compatibility.
Wait Ruby3. -
- Windows environment variables supports Unicode (same wide WinAPI) and so there's no reason to limit ourselves to any ...
-
07:41 PM Feature #8643: Add Binding.from_hash
- It seems this feature is not related at all to #8439, could you please review it and remove the related feature? Plea...
-
- Nobuyoshi Nakada wrote:
> Rodrigo Rosenfeld Rosas wrote:
> > The other one suggested ERB to accept also a hash, ins... -
- I'm not sure I understand that link. What is 1, 2, 3 and 4? What are the bugs?
-
- If I understood it correctly, this issues currently duplicates #7882 which means closing this one would keep the othe...
-
- http://www.redmine.org/projects/redmine/wiki/RedmineIssues
"duplicates - Links issues so that closing one, will cl... -
- This is not really about Integer handling +=. there's no "+=" method. It's a short-hand syntax: a += 1 is currently e...
-
01:58 PM Feature #12607: Ruby needs an atomic integer
- Sorry, I do not clearly understand why the original Integer class cannot be made atomic. If it is not possible or if ...
-
- Use wide WinAPI for rb_w32_getcwd.
This will be needed so that Dir.pwd can support Unicode current directory on Wind... -
- Akinori MUSHA wrote:
> Maybe the shorter forms `:asc` / `:desc` like in SQL would sound more familiar.
Actually, ... -
03:17 AM Feature #12648: `Enumerable#sort_by` with descending option
- Maybe the shorter forms `:asc` / `:desc` like in SQL would sound more familiar.
-
- Currently Dir.home(user) expects that passed user will be already in appropriate encoding but if it's not it will fai...
-
- Applied in changeset r55810.
----------
parse.y: reg_fragment_enc_error
* parse.y (reg_fragment_enc_error): compile... -
- I can reproduce this.
```
(lldb) run
Process 47463 launched: './ruby' (x86_64)
Process 47463 stopped
* thread ... -
- I encountered SEGV in ripper.
OS: Ubuntu 16.04.01 LTS (xenial)
How to reproduce:
```
$ rbenv version
2.4.0-d... -
- * parse.y (reg_fragment_enc_error): compile_error is different
between parser and ripper. [ruby-core:76397] [Bug #... -
- * NEWS (Kernel#clone): mention freeze flag. [Feature #12300]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@5580... -
- * object.c (rb_obj_clone2): restrict freeze option to true other
than false which only has the effect. [Feature #1... -
- * object.c (rb_obj_clone2): remove set but not used variable to
suppress unused-but-set-variable warning.
git-svn-... -
05:20 AM Feature #12637: Unified and consistent method naming for safe and dangerous methods
- Thomas Sawyer wrote:
> It would more interesting if there were a way to declare an object mutable or not, then when ... -
03:55 AM Feature #12637: Unified and consistent method naming for safe and dangerous methods
- It would more interesting if there were a way to declare an object mutable or not, then when immutable destructive me...
-
05:06 AM Feature #9704: Refinements as files instead of modules
- Thomas Sawyer wrote:
> Has any more thought been given to this? I had a recent request to have Ruby Facets to work a... -
- Has any more thought been given to this? I had a recent request to have Ruby Facets to work as refinements, but I hes...
-
- So...
~~~
Object..singleton_class.instance_of?(SingletonClass) #=> true
~~~
-
- * vm_insnhelper.c (CHECK): remove extra semicolon and fold too
long line.
git-svn-id: svn+ssh://ci.ruby-lang.org/r... - 01:50 AM Revision dba03c38 (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55805 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:50 AM Revision 03cad835 (git): * vm_core.h: introduce VM_FRAME_RUBYFRAME_P()
- and VM_FRAME_CFRAME_P().
Most of case, RUBY_VM_NORMAL_ISEQ_P() is no
longer needed.
* vm_core.h: introduce rb_ob... -
01:28 AM Feature #12635: Shuffling/Reassigning "namespaces" more easily
- We can call the private method with `class Object; remove_const :Konsole; end`
Your technique for moving Konsole i... -
- * rename VM_FRAME_TYPE_FINISH_P() to VM_FRAME_FINISHED_P().
* rename VM_FRAME_TYPE_BMETHOD_P() to VM_FRAME_BMETHOD_... - 12:16 AM Revision 1cc78637 (git): * 2016-08-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55802 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- type.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55801 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Also available in: Atom