Activity
From 07/22/2018 to 07/28/2018
07/28/2018
-
11:43 PM Bug #14948 (Closed): MinGW Failure - r64072 - test_jit.rb: test_compile_insn_putspecialobject_putiseq
- Starting with r64076, every subsequent build has failed, both in parallel & retry, on `TestJIT#test_unload_units`.
Finally ran it locally, below is the log of running the whole test file/suite.
Thanks again, Greg
```
1) Ski... -
- @normalperson
Eric,
Passed all tests using r64094. TestJIT#test_unload_units has been failing (both in parallel & retry) since it was added. Been meaning to post an issue/bug report about it...
Thanks, Greg
```
———————————... -
08:32 PM Misc #14937: [PATCH] thread_pthread: lazy-spawn timer-thread only on contention
- > https://bugs.ruby-lang.org/issues/14937
OK, new patch to eliminate timer-thread completely. It seems to pass
repeated "make exam" and introduce no regressions. So far I have found
and fixed two bugs while working on this.
[B... -
06:35 PM Feature #14717: [PATCH] thread: allow disabling preempt
- normalperson (Eric Wong) wrote:
> Giving control to other threads still happens with Thread.pass
> ...
At that point I wouldn't call them threads anymore,
I think threads usually imply preemption (not just on blocking actions but als... -
- [email protected] wrote:
> Is this the same as `Thread.new { Thread.handle_interrupt(Exception => :never) { ... } }`?
> What's the difference?
No, current thread switching does not use interrupts in the same
sense (no Exception o... -
04:23 PM Bug #14634: Queue#push seems to crash after fork
- Hi, we've also been running into this at work. Thanks for the fix and backport! We look forward to a 2.5.2 release.
-
04:15 PM Bug #14490 (Closed): MJIT slows down Rails applications
- Applied in changeset trunk|r64094.
----------
mjit.c: introduce JIT compaction [experimental]
When all compilation finishes or the number of JIT-ed code reaches
--jit-max-cache, this compacts all generated code to a single .so file
and... -
- When all compilation finishes or the number of JIT-ed code reaches
--jit-max-cache, this compacts all generated code to a single .so file
and re-loads all methods from it.
In the future, it may trigger compaction more frequently and/or ... -
03:29 PM Bug #14942 (Closed): Windows7でコンソールに長い文字列を出力できない
- Applied in changeset trunk|r64092.
----------
win32.c: limit write size on console
* win32/win32.c (constat_parse): split long buffer and limit write
size on a console, as well as rb_w32_write.
[ruby-dev:50597] [Bug #14942] - 03:29 PM Revision 2a9cae33 (git): * 2018-07-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64093 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * win32/win32.c (constat_parse): split long buffer and limit write
size on a console, as well as rb_w32_write.
[ruby-dev:50597] [Bug #14942]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64092 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/fiddle/test_function.rb (test_nogvl_poll): fix messages as
failed conditions, with errno description.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64091 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64090 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:00 AM Revision a832dc0f (git): Fix filename in comment [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64089 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64088 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:58 AM Bug #14946 (Closed): ./win32/mkexports.rb:112: warning: flip-flop is deprecated
- I get the warning in the subject. I think it's better to get rid of this
in our own build code. -
- Closed. Because there is no actual bug, there is no need to backport this.
-
- I committed the tests adapted from Python and the fix of the comparison operator, because it's technically correct and we never know when this would lead to an actual bug if something somewhere else in the code gets changed.
@MaLin, t... -
03:16 AM Bug #14934: Unicode: Hangul normalize bug
- Get it. :)
-
- * lib/unicode_normalize/normalize.rb: Fix the range check for trailing
Hangul jamo characters in Unicode normalization. Different from
leading or vowel jamos, where LBASE and VBASE are actual characters,
a value equal to TBASE expr... -
- * test/test_unicode_normalize.rb: extract tests that do not depend
on NormalizationTest.txt data file from conditionally constructed
part of TestUnicodeNormalize class, to always run them even if
the data file isn't found.
git-svn... -
- * test/test_unicode_normalize.rb: search ucd directory
first if it exists. This change follows r61415.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64085 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:34 AM Revision 3943dcd1 (git): use https:// instead of git:// when possible
- Avoid MitM when downloading from insecure networks.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64084 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r64083.
----------
thread.c (blocking_region_end): clear ubf before unregister_ubf_list
If we keep ubf set after unregistering, there is a window for
other threads (including timer thread) to put this thread ... -
- thread.c (blocking_region_end): clear ubf before unregister_ubf_list
If we keep ubf set after unregistering, there is a window for
other threads (including timer thread) to put this thread back
on the ubf_list right away. Entering ... - 03:10 AM Revision 856bd77a (git): thread.c (blocking_region_end): clear ubf before unregister_ubf_list
- If we keep ubf set after unregistering, there is a window for
other threads (including timer thread) to put this thread back
on the ubf_list right away. Entering ubf_list unexpectedly
after GVL acquisition may cause spurious wakeup and ... -
01:14 AM Feature #14912: Introduce pattern matching syntax
- shyouhei-san:
I changed my mind. We should be able to avoid such "fragile" case.
Though duck typing is important, it should be designed by another approach.
akr-san:
> I think Ruby's pattern matching should support this style.
...
07/27/2018
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64082 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:28 PM Revision efee3033 (git): Include Hash#size in the examples
- Both methods Hash#length and Hash#size share the same source code in
Ruby, but they also share the same documentation. Now when you look at
the documentation of Hash#size you only see examples for Hash#length,
which is confusing. This co... - 05:19 PM Revision ecf4641b (git): * 2018-07-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64080 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Co-authored-by: Brad Landers <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64079 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:59 PM Feature #14944 (Closed): Support optional inherit argument for Module#method_defined?
- Module has many introspection methods for methods and constants that
either return an array or return true or false for whether the method
or constant is defined. Most of these methods support an optional
argument that controls whethe... -
-
01:57 PM Revision ffb09d8e (git): eval.c: rename "rb_frozen_class_p" to "rb_class_modify_check"
- Just refactoring. Despite its name, the function does NOT return a
boolean but raises an exception when the class given is frozen.
I don't think the new name "rb_class_modify_check" is the best, but
it follows the precedeint "rb_ary_mod... -
- Btw, I can probably improve on this by making GVL waiter perform
timeslice; so it would eliminate timer-thread completely. Will
work on it tomorrow (too tired, now) -
- [email protected] wrote:
> With jemalloc 5.1.0, ruby 2.4.4 failed to initalize timer thread and it causes broken runtime, e.g. signals are ignored.
> This problem has been reported in jemalloc issue. See
> https://github.com/jem... -
10:00 AM Bug #14943 (Closed): ruby 2.4 doesn't work with jemalloc 5.1.0 properly.
- With jemalloc 5.1.0, ruby 2.4.4 failed to initalize timer thread and it causes broken runtime, e.g. signals are ignored.
- ruby 2.4.4
~~~
$ LD_PRELOAD=~/jemalloc_lib/5.1.0/lib/libjemalloc.so.2 ruby print_version.rb
<main>: warni... -
- Is this the same as `Thread.new { Thread.handle_interrupt(Exception => :never) { ... } }`?
What's the difference?
Is preemption as in threads giving control (and the GIL) to another still possible with `Thread#preemptible = true` or ... -
- [email protected] wrote:
> `Thread.exclusive` ?
No, this is different from that old method because thread
switching still happens from blocking regions. -
- `Thread.exclusive` ?
-
- and lazily delete them on termination.
This will be needed to create a large so file later.
The large number of .o files will be probably compacted before the large so
file is created.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@... -
- units, renaming it from NOT_COMPILABLE_JIT_ISEQ_FUNC.
NOT_READY_JIT_ISEQ_FUNC is for ones being compiled, so
mjit_get_iseq_func treats it specially and it shouldn't be used for the
purpose.
I renamed it instead of adding a new one beca... -
08:26 AM Bug #14942 (Closed): Windows7でコンソールに長い文字列を出力できない
- WindowsのRubyは、WriteConsoleWでコンソールに文字を出力していますが、
Windows7では、WriteConsoleで書き出せるバッファのサイズは61KB程度が限界のようです。
(WriteConsoleWで"あ"が31366文字まで、WriteConsoleAで"a"が62733文字まででした。)
長い文字列を出力する時は、小分けにして書き出してくれるとありがたいです。
※ Windows10では問題ありません。 -
- `xfree(unit)` was missing.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64075 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64074 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- which was originally NULL before r62221
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64073 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64072 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r64071.
----------
ruby.c: taint ARGV on Windows
* ruby.c (external_str_new_cstr): strings come from the external
should be tainted. [ruby-dev:50596] [Bug #14941] -
- WindowsのRuby2.2以降で、コマンドライン引数の文字列に汚染マークを付け忘れてます。
~~~
$ ruby -e "p ARGV[0].tainted?" arg
false
~~~ -
- * ruby.c (external_str_new_cstr): strings come from the external
should be tainted. [ruby-dev:50596] [Bug #14941]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64071 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I think I have figured things out:
The patch is technically correct. While LBASE and VBASE are the values of the first actual leading and vowel jamos, the value of TBASE is one smaller than the first actual trailing jamo at 0x11A8. Th... -
04:24 AM Misc #14921: DevelopersMeeting20180809Japan
- [Feature #11076] Enumerable method count_by
As mentioned in the discussion, Nobu was kind enough to update this to work with current master for Ruby: https://github.com/ruby/ruby/compare/trunk...nobu:feature/11076-Enumerable%23count_b... -
- Why don't you use ripper?
```ruby
#!/usr/bin/ruby
require 'ripper'
class Lint < Ripper
def warn(*s)
@results << [:warning, lineno, column, *s]
end
alias warning warn
def results
unless defined?(@results) and...
07/26/2018
-
- nobu (Nobuyoshi Nakada) wrote:
> How about `Enumerable#just(num=1)` or `Enumerable#only(num=1)`?
Or maybe a slightly more verbose `Enumerable#first_and_only(num = 1)`? -
- I've released a string-crypt gem based on the previous patch: https://github.com/jeremyevans/ruby-string-crypt
The gem has some minor differences in `extconf.rb`, because it needs to avoid overlap with macros defined in `ruby/config.h... -
06:51 PM Feature #14718: Use jemalloc by default?
- > vo.x (Vit Ondruch) wrote:
> ...
I am a glibc developer, and project steward.
We have no plans to merge jemalloc.
We have plans to look into glibc's RSS usage under certain workloads including a ruby application which has issues ... - 06:46 PM Revision c0e478ed (git): * 2018-07-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64070 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:46 PM Revision 5219adf4 (git): lib/ostruct: Remove unnecessary `__send__`
- Patch by yuuji.yaginuma [Fix GH-1890]
Since `remove_method` is public.
Ref: https://bugs.ruby-lang.org/issues/14133
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64069 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:32 PM Feature #14183: "Real" keyword argument
- @shevegen Of course, we will take plenty of time to migrate before making it a keyword.
If we made the decision, we will make it warn you first for a year or two before the actual change.
Matz.
-
10:38 AM Feature #14183: "Real" keyword argument
- I don't want to write too much, so just one comment - I would also prefer foo(kw: 1)
to retain being a Hash rather than to be assumed to be a keyword argument. I think
that it may surprise people when it would become a keyword suddenly. -
03:21 PM Feature #14938: Provide API to get same result as ruby -wc
- I want to get 3 things.
1. Type (warning or error)
2. Message
3. Location
I think location interface should be the same as RubyVM::AST::Node
https://ruby-doc.org/core-2.6.0.preview2/RubyVM/AST/Node.html
My proposal is the f... -
06:25 AM Feature #14938: Provide API to get same result as ruby -wc
- Good idea. Do you have an idea about API and implementation?
Maybe parse.y should be modified (== difficult). -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64068 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * dir.c (do_stat, do_lstat, do_opendir): need the length of the base
path for fstatat() when fd is valid.
* dir.c (glob_helper): fix for platforms where DT_UNKNOWN is not
available, e.g. Solaris.
git-svn-id: svn+ssh://ci.ruby-lang.... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64066 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * process.c (before_fork_ruby, after_fork_ruby): used only if fork()
or daemon() is available.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64065 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:07 AM Bug #14096 (Assigned): Psych allows invalid single quote escape character
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64064 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64063 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [email protected] wrote:
> Good point. Seems good. Thank you!
OK, commited as r64062
> BTW, I forget that why the trap handler is limited to main thread.
I can think of at least three reasons:
1) Similar to this bug: other thre... -
- Applied in changeset trunk|r64062.
----------
cont.c (ec_switch): prevent delayed/missed trap interrupt race
timer-thread may set trap interrupt with rb_threadptr_check_signal
at any time independent of GVL. This means timer-thread ma... -
- Oops, sorry forget about `sleep` lines.
-
- Good point. Seems good. Thank you!
BTW, I forget that why the trap handler is limited to main thread.
```
trap(:INT) do
p Thread.current
end
Thread.new{
sleep 1
Process.kill :INT, $$
p [:child, Thread.current]
}... -
- Applied in changeset trunk|r64062.
----------
cont.c (ec_switch): prevent delayed/missed trap interrupt race
timer-thread may set trap interrupt with rb_threadptr_check_signal
at any time independent of GVL. This means timer-thread ma... - 08:30 AM Revision 97538e81 (git): cont.c (ec_switch): prevent delayed/missed trap interrupt race
- timer-thread may set trap interrupt with rb_threadptr_check_signal
at any time independent of GVL. This means timer-thread may set
the trap interrupt flag on the previous execution context; causing
the flag to be unnoticed until a futur... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64061 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Thanks, applied as r64060.
I needed to add RUBYLIB=/path/to/bcrypt/lib to my make command
line to test bcrypt; but I suppose that's fine -
- Applied in changeset trunk|r64060.
----------
webrick: Support bcrypt password hashing
This adds a password_hash keyword argument to
WEBrick::HTTPAuth::Htpasswd#initialize. If set to :bcrypt, it
will create bcrypt hashes instead of cr... - 03:21 AM Revision 9749bfbf (git): webrick: Support bcrypt password hashing
- This adds a password_hash keyword argument to
WEBrick::HTTPAuth::Htpasswd#initialize. If set to :bcrypt, it
will create bcrypt hashes instead of crypt hashes, and will
raise an exception if the .htpasswd file uses crypt hashes.
If :bcr... -
-
-
-
-
07/25/2018
-
- Related to #14915, this adds bcrypt password hash support when using htpasswd files with Webrick basic auth, allowing a migration path away from the current String#crypt usage.
- 10:32 PM Revision 1516b85d (git): test/ruby/test_io.rb (test_select_leak): skip with MJIT
- We need better ways to test for leaks :<
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64059 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ko1: I noticed this while working on timer-thread elimination/lazy-spawning.
However, it looks like a bug we introduced in 2.5 with `ec'.
Can you check this patch? Thanks.
cont.c (ec_switch): prevent delayed/missed trap interrupt ... -
- This may also be useful for irb/pry add-ons, I think.
Perhaps Koichi-san can comment on the issue if he has time. -
- I'm the author of an implementation of Ruby Language Server.
Currently, it uses `RubyVM::InstructionSequence.compile` to get the result of `ruby -wc` and parses message and location by regexp.
https://github.com/mtsmfm/language_serve... -
- `trunk@42862` dropped example's last line.
https://github.com/ruby/ruby/commit/e334bb2ce5d8876b020ab681f21595e2e1c9d601#diff-8783a9b452e430bcf0d7b0c6e34f1db0L144
https://github.com/ruby/ruby/commit/e334bb2ce5d8876b020ab681f21595e2e1c9d6... -
- Since 2.5, Module#define_method is public. (feature #14133)
Co-Authored-By: Miguel Landaeta <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64057 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Co-Authored-By: Matias Korhonen <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64056 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:00 PM Revision a818fca3 (git): * 2018-07-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64055 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Co-Authored-By: Robert Mosolgo <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64054 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Hi, we've been hitting this bug at work too. I tested these commits (backported them on to Ruby 2.5) and they seem to clear up the issue. Naruse, could we have these backported to the ruby_2_5 branch? I made backport commits here: htt...
-
- (Sorry for this short comment but I think the issue here is filed under
"Bug" presently, but should perhaps be moved towards "Misc" instead,
like the two prior dev-meetings.) -
- because it's more suitable to describe the current behavior now.
tool/ruby_vm/models/bare_instructions.rb: ditto.
tool/ruby_vm/views/_insn_entry.erb: ditto.
tool/ruby_vm/views/_mjit_compile_insn_body.erb: ditto.
tool/ruby_vm/views/_mjit... -
- I'm going to build a large .so file that combines multiple .o files.
For that change, I want to confirm the impact to performance by this
change. So far, I haven't seen the significant change on the max
performance.
* before
$ for i in ... -
- by whether on mswin or not.
This is needed because I'm going to renew the compilation process for
unix, keeping mswin builds as it is, at first.
This commit is not changing the behavior at all.
git-svn-id: svn+ssh://ci.ruby-lang.org/r... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64050 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64049 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/mutex_m.gemspec: Added initial gemspec.
* lib/mutex_m.rb: Added Mutex_m::VERSION for gemspec.
* tool/sync_default_gems.rb: Support Mutex_m.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64048 b2dd03c8-39d4-4d8f-98ff-823fe6... - 12:26 PM Revision 27785eec (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64047 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/e2mmap.gemspec: Added initial gemspec.
* lib/e2mmap/version.rb: Added Exception2MessageMapper::VERSION for gemspec.
* tool/sync_default_gems.rb: Support Exception2MessageMapper.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trun... -
- @normalperson
Eric,
In addition to the build mentioned above, there have been two more ruby-loco builds, both with all three patches, and both passed all tests
> Thanks for testing; I guess 47 minutes is not unusual for a busy ... -
- On 2018/07/25 17:20, Eric Wong wrote:
> I don't know, current behavior seems intentional and documented
> in RDoc:
>
> * Note that this method can wakeup without explicit Thread#wakeup call.
> * For example, receiving ... -
- Koichi Sasada <[email protected]> wrote:
> I need to read your proposal with more concentrations, but one thing:
Thanks. I noticed a bug where it sometimes still get
stuck when I run "make exam" in a loop. Will have to dig deeper
to... -
- [email protected] wrote:
> Tested with the attached patch. When Appveyor is busy, and
> with test-all using retry, and something in MJIT failing or
> erroring, the test took 47 minutes.
>
> Anyway, all good, ran with r64038, an... -
- @normalperson
Eric,
Tested with the attached patch. When Appveyor is busy, and with test-all using retry, and something in MJIT failing or erroring, the test took 47 minutes.
Anyway, all good, ran with r64038, and all tests p... -
- > > git repository also available at:
> > https://80x24.org/ruby.git tt-lazy
> > (commit a2990cefccba55300ad44275ee4adf18e6f95ece)
>
> Now up to commit 6fb72ad7334a61e3c4341aa5fa17749671cbb867
Sorry, didn't finish testing th... -
- > git repository also available at:
> https://80x24.org/ruby.git tt-lazy
> (commit a2990cefccba55300ad44275ee4adf18e6f95ece)
Now up to commit 6fb72ad7334a61e3c4341aa5fa17749671cbb867
[PATCH 2/1] thread.c (rb_threadptr_execut... -
- > https://bugs.ruby-lang.org/issues/14937
Hi Greg, Can you try the patch in this ticket? It shouldn't
affect win32, but maybe I made typos. I couldn't add you
as a watcher to this ticket from Redmine (since that requires
JavaSc... - 12:15 PM Revision ddb6e1f7 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64045 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/thwait.gemspec: Added initial gemspec.
* lib/thwait/version.rb: Added ThWait::VERSION for gemspec.
* tool/sync_default_gems.rb: Support ThWait.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64044 b2dd03c8-39d4-4d8f-98ff-82... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64043 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/forwardable.rb: Added Forwardable::VERSION and re-use it.
* lib/forwardable/forwardable.gemspec: Added initial gemspec.
* tool/sync_default_gems.rb: Support forwaradable repository.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64041 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64040 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * net-telnet-0.2.0
* power_assert-1.1.3
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64039 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- http://ci.rvm.jp/results/trunk-test@frontier/1153126
doesn't fixed yet :( -
07:44 AM Feature #14922 (Assigned): Resolv getaddresses ignores AAAA records for IPv6
- Mmm, I think this is a real bug.
RUBYOPT does not work well in this case because resolve.rb is a library while RUBYOPT is for the process. Adding parameter to the constructor is an option though. -
- I have quickly looked at the tests. I understand what issue they are checking (NFC in case of a mix of current Hangul and old-style-only Hangul jamos). I think Ruby should pass these tests.
Ruby has tests for this case, see
https://s... -
- jeremyevans0 (Jeremy Evans) wrote:
> So there are no security issues in the `sub(/\A\$2y\$/, '$2a$')`.
Great. Thank you for confirmation. -
- normalperson (Eric Wong) wrote:
> Allowing options which other servers do not support is not
> ...
Fair enough, I'll work on adding support for `:password_hash=>:bcrypt|:crypt` (currently defaulting to :crypt if not given for backword... -
- shyouhei (Shyouhei Urabe) wrote:
> Off topic but,
> ...
There is only a difference between `$2a$` and `$2b$` on OpenBSD if the password length is 256 characters or longer. Such passwords are very rare. The `bcrypt` gem currently only... -
- [email protected] wrote:
> normalperson (Eric Wong) wrote:
> > Can you do it as a single option which doesn't involve having
> > users copy+paste code? Something like:
> >
> > :password_hash => (:bcrypt|:crypt|:b... -
- Off topic but,
jeremyevans0 (Jeremy Evans) wrote:
> Apache htpasswd generates passwords using `$2y$`, but the hashes are the same as `$2a$` format, and Apache handles `$2a$` format just fine. The bcrypt gem does not consider `$2y$` ... -
- It is 2.2, which has reached the EOL.
https://www.ruby-lang.org/en/news/2018/06/20/support-of-ruby-2-2-has-ended/ -
07/24/2018
-
- [ruby-core:87773]
```
thread_pthread: lazy-spawn timer-thread only on contention
To reduce resource use and reduce CI failure; lazy spawn
timer-thread only in processes which use Ruby Threads AND those
Ruby Threads hit contention.... -
- normalperson (Eric Wong) wrote:
> Can you do it as a single option which doesn't involve having
> ...
One issue with that is it doesn't offer a way to specify the password hash cost. For example, the bcrypt gem defaults to cost 10, a... -
- <snip> Thanks for the research on this matter
[email protected] wrote:
> Should I prepare a patch to Webrick to accept
> :create_password_hash and :check_password_hash options, and
> add documentation with an example u... -
- jeremyevans0 (Jeremy Evans) wrote:
> .htpasswd is an Apache-specific format, and Apache currently supports only 5 password formats: bcrypt, MD5, SHA1, crypt, plain text (https://httpd.apache.org/docs/2.4/misc/password_encryptions.html).... -
- Here's an alternative proposal, with the basic idea that behavior for historical ruby 1.6+ code that doesn't use keyword arguments remains the same.
## OK: Historical ruby 1.6+ (maybe before) usage (hash argument with omitted braces)
... -
08:24 PM Revision f1186a3d (git): Revert "dir.c: fix glob with base when no DT_UNKNOWN"
- This reverts commit r63982.
It breaks build on Solaris 11.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64038 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:22 PM Feature #14922: Resolv getaddresses ignores AAAA records for IPv6
- Greetings. I work behind Donovan (this bug's reporter) and am also dealing with this same issue. I tracked down the source of this behavior by looking through the Ruby resolv.rb source code. Apparently the DefaultResolver only resolves I...
-
05:13 PM Bug #14935: Inconsitent behaviour with puts and enumerator with different block format.
- I think this is because `do ... end` blocks has lower precedence than `{...}` blocks. As documented in [1]. So, probably, not a bug.
~~~
method1 method2 { ... } # method2's block
method1 method2 do ... end # method1's block
~~... -
- #puts returns `nil`, so when you're mapping you end up with `[nil, nil, nil]`, which prints with #puts as three blank lines. If you use `p` instead of `puts` inside the block, the block will return `i` instead of `nil` and you'll see the...
-
12:29 PM Bug #14935 (Rejected): Inconsitent behaviour with puts and enumerator with different block format.
- ### Case: 1
```
➜ ~ ruby
puts [1,2,3].map do |i|
puts i
end
#<Enumerator:0x007ffe930b76d0>
➜ ~
# block does get evaluated.
```
Case 2:
```
➜ ~ ruby
puts [1, 2, 3].map { |i| puts i }
1
2
3
➜ ~
# Block gets ... -
05:01 PM Bug #14936 (Rejected): Ruby 2.5.1 crahes when running on Mac OS X High Sierra 10.13.6
- When attempting to run Arachni 1.5.1 on my Mac OS X High Sierra, I get a Ruby crash every time. I am attaching the Ruby crash report.
-
- which was missing in r64033.
Prior to r64033, memory allocation failure had been checked by
TRY_WITH_GC and handled by rb_memerror. But calling rb_memerror on MJIT
worker is problematic since it does EC_JUMP_TAG in the end. Threads
exce... - 03:17 PM Revision 461c79f1 (git): * 2018-07-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64036 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- because such inconsistency may result in the regression fixed in r64034.
vm_exec is not touched since renaming it may be controversial...
vm_args.c: ditto.
vm_eval.c: ditto.
vm_insnhelper.c: ditto.
vm_method.c: ditto.
git-svn-id: svn+... -
- on r64031. Compiling vm_search_method_slowpath is very slow.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64034 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- mjit_compile.c: ditto.
REALLOC_N, ALLOC_N and xmalloc trigger GC but it's not expected.
Other allocation calls in mjit.c are executed on Ruby's main thread and
thus fine.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64033 b2dd03c8... -
- in a short term, and add retries to prevent random CI failures by it.
I remember this and will address it later for sure.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64032 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > Can you provide some test case(s)?
That is what frustrated me. I simply translated Python's test-cases for this issue[1] to Ruby.
[1] https://github.com/python/cpython/commit/d134809cd3764c6a634eab7bb8995e3e2eff14d5
But them pas... -
- @MaLin: Can you provide some test case(s)?
All the test data provided by Unicode (e.g. https://www.unicode.org/Public/10.0.0/ucd/NormalizationTest.txt) is used for testing. But I know that there are some corner cases in Hangul that ar... -
- I'm not a expert of Ruby, I would suggest to examine the code of Hangul normalize, it looks too simple than the Unicode Standard's demonstration code.
-
- I was involved to fix a similar bug in Python, I found Ruby also has bug code.
We should fix this line[1] like this:
[1] https://github.com/ruby/ruby/blob/96db72ce38b27799dd8e80ca00696e41234db6ba/lib/unicode_normalize/normalize.rb#L7... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64031 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64030 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- http://ci.rvm.jp/results/trunk-asserts-nopara@silicon-docker/1149270
```
/home/ko1/ruby/src/trunk-asserts-nopara/process.c: In function 'assert_close_on_exec':
/home/ko1/ruby/src/trunk-asserts-nopara/process.c:298:9: warning: ignoring re... -
- Applied in changeset trunk|r64028.
----------
time.rb: yday support
* lib/time.rb (Time.make_time): added yday support.
[ruby-core:87545] [Bug #14860] -
- Applied in changeset trunk|r64028.
----------
time.rb: yday support
* lib/time.rb (Time.make_time): added yday support.
[ruby-core:87545] [Bug #14860] -
- * lib/time.rb (Time.make_time): added yday support.
[ruby-core:87545] [Bug #14860]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64028 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64027 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:38 AM Revision 8099b927 (git): * 2018-07-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64026 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * include/ruby/ruby.h (UNREACHABLE_RETURN): UNREACHABLE at the end
of non-void functions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64025 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- egi (Satoshi Egi) wrote:
> Let me propose you to import the functions for non-linear pattern matching with backtracking that I have implemented as a Ruby gem in the following repository.
Open a new issue for that, please. Don't hija... -
04:49 AM Feature #14912: Introduce pattern matching syntax
- Let me propose you to import the functions for non-linear pattern matching with backtracking that I have implemented as a Ruby gem in the following repository.
https://github.com/egison/egison-ruby/
This pattern-matching system all... -
- normalperson (Eric Wong) wrote:
> Maybe Sequel and AR can have add optional PID checks
> ...
My problem with doing this by default is that it penalizes knowledgeable users just to avoid problems for users that don't read the documenta... -
- [email protected] wrote:
> normalperson (Eric Wong) wrote:
> > [email protected] wrote:
> > > I want to help protect future programmers from such bugs, if at all possible.
> > > And I believe it's possible.
> > >
... -
- tenderlovemaking (Aaron Patterson) wrote:
> I think library authors can make things easier though. Web frameworks, like Rails for example, are expected to handle this situation for the user. In addition, say a library author provided ... -
02:02 AM Feature #10982: Clarify location of NoMethod error
- I just ran into a `SyntaxError` on heapy today (in Ruby 2.1.6) and it did exactly what I wish would occur for `NoMethodError`:
```
$ heapy read ruby-heap-2018-07-24\ 01\:29\:05.dump
/Users/olivierlacan/.rbenv/versions/2.1.6/lib/rub...
07/23/2018
-
- normalperson (Eric Wong) wrote:
> [email protected] wrote:
> ...
I've experienced a data leak similar to this. Saying the impact was "catastrophic" would be an understatement. :(
> fork is full of caveats; using atfork hook to wo... -
- normalperson (Eric Wong) wrote:
> Can you provide pre-defined, accepted-as-secure implementations
> ...
.htpasswd is an Apache-specific format, and Apache currently supports only 5 password formats: bcrypt, MD5, SHA1, crypt, plain tex... -
- [email protected] wrote:
> shyouhei (Shyouhei Urabe) wrote:
> > - Basic authentication itself does not require DES. It is an
> > implementation detail. You can safely migrate to another
> > hash function at will. R... -
- shyouhei (Shyouhei Urabe) wrote:
> Maybe this was my misunderstanding. Are BasicAuth and DigestAuth
> ...
No, basic auth and digest auth are very different, you can't just substitute one for the other. Digest auth requires MD5 for o... -
- On Fri, Jul 20, 2018 at 5:51 PM, Eric Wong <[email protected]> wrote:
> "Urabe, Shyouhei" <[email protected]> wrote:
>> normalperson (Eric Wong) wrote:
>> > It's only the BasicAuth code and I have no idea how many people
>... -
- > https://bugs.ruby-lang.org/issues/14921
[Feature #14717] thread: allow disabling preempt -
03:06 PM Bug #14933 (Closed): Time.strptime with ordinal dates
- Using `Time`, I cannot parse an ordinal date (https://en.wikipedia.org/wiki/ISO_8601#Ordinal_dates).
It should work with `%j` according to the documentation: https://ruby-doc.org/stdlib-2.5.1/libdoc/time/rdoc/Time.html#method-c-strptime... - 09:56 AM Revision c7894575 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64024 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64023 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64022 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64021 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:22 AM Revision 7ca648e9 (git): 60 sec is not enough at all
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64020 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_io.rb (test_select_leak): increase timeout seconds
to pass this test on a high-load machine.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64019 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Closing this ticket as per OP's request. Thank you for your understanding.
-
- Jeremy, thank you for discussing this issue seriously.
jeremyevans0 (Jeremy Evans) wrote:
> If that was the only change, it wouldn't be a big deal. However, in addition to `foo(:key => val)` calls, there are also `foo(hsh)` calls. S... -
- mame (Yusuke Endoh) wrote:
> jeremyevans0 (Jeremy Evans) wrote:
> ...
If that was the only change, it wouldn't be a big deal. However, in addition to `foo(:key => val)` calls, there are also `foo(hsh)` calls. So all callers that pass ... -
- Sorry, it seems my original description was unclear. I think it can be rephased very simply:
* keyword argument MUST be always received as a keyword parameter
* non-keyword argument MUST be always received as a non-keyword parameter... -
- jeremyevans0 (Jeremy Evans) wrote:
> For a method definition like:
> ...
No, it will not work. You need to rewrite the definition to `def foo(**hsh)`.
> One performance issue with keyword arguments is that keyword splats allocate... -
01:54 AM Feature #14912: Introduce pattern matching syntax
- ktsj (Kazuki Tsujimoto) wrote:
> Thanks for the feedback.
> ...
Hm. I didn't explan my intent well.
My intent is deconstructing pattern is not well correspondence to
pattern matching of functional languages.
In functional langu... -
- ktsj (Kazuki Tsujimoto) wrote:
> > - Deconstruction seems fragile; For instance the following case statement matches, which is very counter-intuitive.
> ...
Do you really think they are worth trading off?
What is, then, the purpose... - 01:07 AM Revision 8a3ed368 (git): Revert "thread.c (rb_thread_fd_select): remove unnecessary rb_fd_resize calls"
- This reverts commit r64017
(git commit 2ff85621690f4f5b0dff9226ac68418a950a6919).
Nevermind, haven't had enough coffee, yet :x
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64018 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:51 AM Revision 2ff85621 (git): thread.c (rb_thread_fd_select): remove unnecessary rb_fd_resize calls
- There's no need to resize each rb_fdset_t to match the size of
the biggest one. This can allow some small memory savings if
watching several sets of FDs simultaneously.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64017 b2dd03c8-3...
07/22/2018
-
10:55 PM Feature #12306: Implement String #blank? #present? and improve #strip and family to handle unicode
- > I've proposed String#space_only?, like String#ascii_only?.
I very much support `#space_only?`, it still fills the original goal of the ticket which is to eliminate the the fast_blank gem! -
- I am not sure exactly how we can pull this off, but this very much fits into our mission of making Ruby fast
http://engineering.appfolio.com/appfolio-engineering/2018/7/18/rubys-global-method-cache
https://engineering.shopify.com/1... -
09:59 PM Bug #14928: [BUG] Segmentation fault | Fiddle with Windows APIs
- > The second argument of RtlMoveMemory is source pointer, not the size.
> ...
While troubleshooting, I tried to allocate a memory, returns a pointer as the following:
~~~ ruby
buf = Pointer.malloc(Fiddle::SIZEOF_CHAR * shellcode.size... -
-
- This is a bug in your code, not ruby's.
```
rtl_move_memory.call(ptr.to_i, buf.size.to_i, shellcode_calc.size.to_i)
```
The second argument of `RtlMoveMemory` is source pointer, not the size.
And, `buf` is an array of single cha... -
06:42 PM
Feature #14924: // floor division operator
- > Out of curiosity what are you doing that needs integer division? :)
For example in my window manager I have some rules to determine how
windows should be sized and positioned (tiling).
~~~ ruby
# how many windows with 484px wi... - 04:03 PM Revision 0c32ffc7 (git): * 2018-07-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64016 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * object.c (rb_f_integer): prefer `base` optional argument over
keyword arguments. this issue should be resolved more generally
by separating keyword arguments from hashes in the future.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/... -
- Applied in changeset trunk|r64014.
----------
fix sum on infinity
* array.c (rb_ary_sum): consider non-finite floats.
[ruby-core:88024] [Bug #14926]
* enum.c (sum_iter): ditto. -
- * array.c (rb_ary_sum): consider non-finite floats.
[ruby-core:88024] [Bug #14926]
* enum.c (sum_iter): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64014 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- `nacl` support already removed by https://github.com/ruby/ruby/pull/1726.
[Fix GH-1920]
From: yuuji.yaginuma <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64013 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Some methods accept exception keyword argument since 2.6.0, but it is not documented in rdoc yet.
In NEWS,
* Kernel.#Complex takes :exception option to specify the way of error handling [Feature #12732]
* Kernel.#Float take... -
- [email protected] wrote:
> normalperson (Eric Wong) wrote:
> > Yes. The "timeout scheduler" is the same idea I used for auto-fiber.
> > It uses ccan/list to manage a sorted list of timeouts.
>
> Still wonder, why you don't... -
- sample/trick2018/03-tompng ですが、trunk では動かないようです。
* `Gemfile` で `ruby '2.5.0'` に固定されているので、そのままだと trunk で bundle install できない
* `source 'https://rubygems.org'` がないので `bundle install` できないことがある (bundler の挙動がよくわかっていなくてできる場合とできない場合の違いがよくわ... - 02:53 AM Revision 0cc4bb7d (git): * 2018-07-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64012 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- with --jit.
`./ruby --jit -Itest/lib test/ruby/test_rubyoptions.rb -n "TestRubyOptions#test_verbose"`
has failed without -DMJIT_FORCE_ENABLE like:
1) Failure:
TestRubyOptions#test_verbose [/home/travis/build/k0kubun/mjit-test/test/ru...