Activity
From 08/30/2018 to 09/05/2018
09/05/2018
-
11:15 PM Bug #14885 (Closed): Is documenting-ruby a dead project?
- Applied in changeset trunk|r64647.
----------
[DOC] Remove link to dead project
[Bug #14885] [ci skip] -
- [Bug #14885] [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64647 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:02 PM Bug #15078: Hash splat of empty hash should not create a positional argument.
- It is not so trivial what it should be. If you look at only `foo(**{}) #=> [{}]` itself, it might be non-intuitive, indeed. However, IMO, this is a consequence of the current weird spec of keyword arguments (a keyword hash is passed as...
-
04:22 PM Bug #15078 (Closed): Hash splat of empty hash should not create a positional argument.
- Looks like #10856 is not completely fixed, but I can't reopen it
```
def foo(*args); args; end
foo(**{}) # => []
foo(**Hash.new) # => [{}], should be []
``` -
10:28 PM Bug #15080 (Closed): Work on Benchmark::Tms documentation
- Fixes a couple issues with "+param+ is not documented" in lib/benchmark.rb
I would like to contribute more to the documentation, so if there's something I should be doing differently in these tickets, please let me know. -
09:52 PM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
- [email protected] wrote:
> Issue #13618 has been updated by MSP-Greg (Greg L).
>
>
> @normalperson Eric,
>
> I applied the two patches in 'note 139', and three test suites stopped.. With test-all running parallel, it's diff... -
09:34 PM Revision 4204eacf (git): fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64646 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r64645.
----------
enumerator.c: [DOC] Enumerator::Lazy#force [ci skip]
added documentation of Enumerator::Lazy#force, just to clarify that it
is an alias of an inherited method. [ruby-core:88872] [Bug #15079] -
07:22 PM Bug #15079 (Closed): Documentation missing for Enumerator::Lazy#force
- This isn't a bug with the ruby language, but rather with the documentation. (At http://ruby-doc.org/core-2.5.1/Enumerator/Lazy.html)
Expected behavior:
There is documentation for the `#force` method for lazy enumerators.
Actual be... -
- added documentation of Enumerator::Lazy#force, just to clarify that it
is an alias of an inherited method. [ruby-core:88872] [Bug #15079]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64645 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:39 PM Revision ebff0059 (git): Add platform guards for AIX
- * Most of these seem OS bugs.
* See https://rubyci.org/logs/rubyci.s3.amazonaws.com/aix71_ppc/ruby-trunk/log/20180905T103302Z.fail.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64644 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64643 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * include/ruby/backward.h (rb_complex_set_real, rb_complex_set_imag):
removed useless declarations which have been deprecated from the
beginning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64642 b2dd03c8-39d4-4d8f-98ff-823fe6... -
07:06 PM Feature #14473 (Closed): Add Range#subrange?
- Applied in changeset trunk|r64640.
----------
range.c: Range#cover? accepts Range object. [Feature #14473]
* range.c (range_cover): add code for range argument.
If the argument is a Range, check it is or is not
covered b... - 07:06 PM Revision de13863a (git): * 2018-09-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64641 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:06 PM Revision 9ca73892 (git): range.c: Range#cover? accepts Range object. [Feature #14473]
- * range.c (range_cover): add code for range argument.
If the argument is a Range, check it is or is not
covered by the reciver. If it can be treated as a
sequence, this method treats it that way.
* t... -
05:17 PM Bug #15070: configure fails with (probably spurious) 'something wrong with CFLAGS="-g -O2 "' on macOS High Sierra
- Thanks for the clue -- it looks like I had `CPPFLAGS=-L /usr/local/opt/[email protected]/include` set globally for some reason (probably having to do with building the mysql gem). Removing that allows `configure` to succeed.
That said, it see... -
- Let me add my voice to that of Benoit and Jeremy: the incompatibility is absolutely not worth it.
I believe that if we fix the few remaining corner cases, improve the error messages and explicitly document how Ruby handles keyword par... -
- mame (Yusuke Endoh) wrote:
> Braced hash and bare one are inconsistent, even in the current spec.
> ...
The fact that `foo(**h) #=> {}` is a bug. Note that `foo(**{}) # => :default`, as I believe it should. Both should have same res... -
- mame (Yusuke Endoh) wrote:
> > BTW, `p foo: 1` will no longer work then, and `p({foo: 1})` would be required, which feels very *unlike* Ruby, and is just impractical when debugging.
> ...
Half-joking: I'm not fully satisfied with `p fo... -
- Eregon (Benoit Daloze) wrote:
> I would think the number of methods like debug() is a tiny fraction of the number of places we'd need to change if hash-without-braces is no longer supported.
> ...
I think you are too familiar with the ... -
- First, `foo(b: 1)` has been exactly the same as `foo({b: 1})` since Ruby 1.8 at least. It is parsed exactly the same way. It's syntax sugar.
```
require 'ripper'
Ripper.sexp('foo(a : 1)') == Ripper.sexp('foo({a : 1})') # => true
``... -
- When last argument is hash-like but has keys that are not symbols, we could output instead "wrong number of arguments (2 for 1); note that the last argument has keys that are not symbols and thus was not considered as keyword parameters"
-
- This is a bug.
```
test1('River name' => 'Mississippi', length: 2000, 'Country' => 'USA')
# 3. SOURCE: {"River name"=>"Mississippi", "Country"=>"USA"}, OPTS: {:length=>2000} -- It is already a bit weird
```
My understanding is t... -
- nobu (Nobuyoshi Nakada) wrote:
> Just an idea to keep the original argument, if something left.
> ...
I agree that if the conversion of a hash-like argument to keyword parameter fails because the keys aren't all symbols, the original o... -
- This is a duplicate of #12717, so closing this.
-
- I believe this is as designed.
As I stated previously (https://bugs.ruby-lang.org/issues/11967#note-3), my understanding is that:
* after all mandatory unnamed arguments are filled
* if the last remaining argument is hash-like
* ... - 01:33 PM Revision 19dec2a1 (git): * append newline at EOF.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64639 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:33 PM Revision 60ebd4e2 (git): Merge csv-3.0.0 from ruby/csv repository.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64638 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:16 PM Revision 21ce539f (git): fix typo
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64637 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/aix71_ppc/ruby-trunk/log/20180904T103302Z.fail.html.gz
https://www.ibm.com/support/knowledgecenter/ja/ssw_aix_72/com.ibm.aix.commtrf2/getsockopt.htm
git-svn-id: svn+ssh://ci.ruby-lang.org/... -
- @larskanis Thanks for the report.
I also noticed it happens on RubyCI for Ruby 2.4 and earlier
(example: https://rubyci.org/logs/rubyci.s3.amazonaws.com/arch/ruby-2.4/log/20180905T105615Z.fail.html.gz)
I'm not sure what's best.
@... -
07:05 AM Bug #14999: ConditionVariable doesn't reacquire the Mutex if Thread#kill-ed
- > > So it seems it doesn't happen in Ruby <= 2.5 due to thread
> ...
I get this error on ruby-2.4.4 [i386-mingw32] and [i386-mingw32] while nightly builds of RubyInstaller: https://ci.appveyor.com/project/larskanis/rubyinstaller2-hbu... -
11:58 AM Feature #15076: Struct to raise error when keyword arguments used but not enabled
- > Will it be clearer if a error is raised instead rather than assigning data incorrectly ?
With the current keyword arguments implementation (see also: [Feature #14183]), we can't distinguish the mistaken situation with one that we re... -
- ```ruby
Info = Struct.new(:name, :country, keyword_init: true)
c = Info.new(name: "myname", country: "Japan")
p c #=> #<struct Info name="myname", country="Japan">
``` -
08:29 AM Feature #15076 (Rejected): Struct to raise error when keyword arguments used but not enabled
- When Struct is used to instantiate object with keyword arguments disabled and yet if instantiated using keyword arguments, the instance fields will be set incorrectly.
Will it be clearer if a error is raised instead rather than assig... -
- v0dro (Sameer Deshmukh) wrote:
> > Isn't it enough to just use rb_funcall() to call Ruby methods on Complex numbers?
> ...
The existing Ruby methods should already be fast enough for most cases.
C macros/functions for accessing the re... -
- v0dro (Sameer Deshmukh) wrote:
> > Isn't it enough to just use rb_funcall() to call Ruby methods on Complex numbers?
> ...
What APIs do you need?
A concrete list, please.
> > RCOMPLEX_SET_REAL and RCOMPLEX_SET_IMAG are internal mac... -
04:54 AM Feature #15066: Documentation and providing better API for accessing Complex numbers functions in C extensions
- > Isn't it enough to just use rb_funcall() to call Ruby methods on Complex numbers?
Calling Ruby methods in C extensions defeats the purpose of writing a C extension since a non-trivial number of Ruby method calls take up significant ... -
11:00 AM Feature #15074: Create 'official' C API documentation on ruby-doc.org
- I think this would be nice to have. Matz often said that nobody minds if ruby
becomes faster :) - and I think nobody will mind if the documentation becomes
better (qualitatively; but also somewhat more documentation in general).
The... -
- Currently working with Ruby C API is basically reading a bunch of random
blogs and coming up with a solution based on inputs from various sources
(some of which can be out of date).
The only relevant resource for C API docs with pra... -
06:18 AM Bug #15072 (Closed): thread.c:4356:5: error: implicit declaration of function ‘ubf_list_atfork’
- That fix worked, thanks! Committed with r64635, okay on travis, not sure about other CIs.
-
- [email protected] wrote:
> https://bugs.ruby-lang.org/issues/15072
I think copying the macro for win32 for the !USE_UBF_LIST
case should work(*). Can you test and commit if it works?
(too tired and might not be back online s... -
- When compiling on cygwin, I get the following error:
```
compiling thread.c
thread.c: In function ‘rb_thread_atfork_internal’:
thread.c:4356:5: error: implicit declaration of function ‘ubf_list_atfork’ [-Werror=implicit-function-de... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64635 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:32 AM Bug #15069 (Closed): Backport "suppress warning: 'const' attribute on function returning 'void' "
- (Changing status to closed; it triggers backporting process. This doesn't mean rejection.)
09/04/2018
-
11:57 PM Bug #15071 (Closed): RubyVM::MJIT.pause may cause deadlock after compaction
- Sometimes I met thread-deadlock while waiting `RubyVM::MJIT.pause`.
Here is a terminal log.
```
$ ruby --disable-gems --jit --jit-verbose=1 --jit-max-cache=3 -e '100.times do |i| eval("def foo#{i}; end; " + "foo#{i}; " * 5); end; Ru... -
- dmolesuc3 (David Moles) wrote:
> ```
> ...
From where does this `-L` option come?
It is a linker option and doesn't need to be in `CFLAGS`.
(and `include` path doesn't seem a library directory). -
- Oops, the `config.log` I linked there was from the rvm attempt. But the tarball version [here](https://gist.github.com/dmolesUC3/97f2e20514a68de099d1b23db2b6a5e0) is basically identical.
-
- ## Description
`./configure` fails for Ruby 2.5.1 on macOS High Sierra (10.13.6) with Xcode 9.4.1 (clang-902.0.39.2).
(**Note:** I've seen the same error trying to install 2.4.1 and 2.4.4 with rvm, but haven't bothered downloading ... - 11:10 PM Revision 0401099c (git): * 2018-09-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64634 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * random.c (fill_random_bytes_syscall): check if the version macro is
defined, for very old Mac OS X development tools.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64633 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I agree with Jeremy here, the current idea seems too incompatible and will require too many changes (no matter the gain).
And those changes cannot easily be automated either, they need careful considerations.
I think we need to compr... -
09:36 PM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
- @normalperson Eric,
I applied the two patches in 'note 139', and three test suites stopped.. With test-all running parallel, it's difficult to tell what caused the issue.
btest - stopped on `#354 test_insns.rb`
spec - the log ... -
- The files `include/ruby/intern.h` and `include/ruby/ruby.h` are used for extension builds, and when a recent gcc is called with -Wall, the build fails. This can cause failures with mkmf for instance in pkg_config() lookup.
The resolvi... -
02:24 PM Bug #15057 (Rejected): REXML::Text#value returns a double unescaped string in non-raw mode
- > 了解しました。atomutil の方にはこちらから報告しておきます。
ありがとうございます。では、このチケットはクローズしておきます。 -
07:08 AM Bug #15057: REXML::Text#value returns a double unescaped string in non-raw mode
- >> This ignores the 'raw' attribute setting
> ...
なるほど。`REXML::Element#text` も同様のコメントがあってセマンティクスを変えられないと。残念ですが仕方がないですかね… メジャーバージョンアップの際は再検討していただけると幸いです。
> 互換性は壊したくないので、現状ではatomutilでは次のように使ってもらいたいです。
了解しました。atomutil の方にはこちらから報告し... -
- ありがとうございます。確認できました。
現状の動きが変だという気持ちはわかるのですが、`Text#value`のドキュメントに
> This ignores the 'raw' attribute setting
と書いているので、`raw`のときもそうじゃないときも期待した挙動にするのは、互換性を維持したままではムリなんですよねぇ。
なので、`element1.text = element2.text`という使い方がよくないんですよねぇ。ただ、... -
- * rational.c (RRATIONAL_SET_{NUM,DEN}): also defined in internal.h
since r53887.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64632 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * include/ruby/ruby.h (RCOMPLEX_SET_REAL, RCOMPLEX_SET_IMAG): removed
macros for internal use, which have been exposed by accident.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64631 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:22 PM Feature #14594: Rethink yield_self's name
- And I like pipe too, maybe even more.
-
- I liked to_be as well.
-
02:48 AM Feature #14594: Rethink yield_self's name
- This looks **to_be** perfect, I really like this idea!
-
- Isn't it enough to just use rb_funcall() to call Ruby methods on Complex numbers?
-
- `RCOMPLEX_SET_REAL` and `RCOMPLEX_SET_IMAG` are internal macros, and so I think they should not be used outside.
-
- Currently there is absolutely no documentation for working with Complex numbers at the level of the C API.
Apart from two macros defined [[here](https://github.com/ruby/ruby/blob/trunk/include/ruby/ruby.h#L1079)] for setting the real ... -
09:10 AM Misc #14981: DevelopersMeeting20180913Japan
- * [Bug #14908] Enumerator::Lazy creates unnecessary Array objects
* Proposed solution is to change arity of Enumerator::Yielder#<< to 1 from -1 and use it internally for lazy enum instead of Enumerator::Yielder#yield. Generally, metho... -
- [Bug #13496]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64630 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:47 AM Bug #15067 (Closed): library/socket/socket/getnameinfo_spec.rb always errors with multiple IP addresses hostname
- If the hostname is bind with multiple IP addresses, `Socket.getnameinfo` raises `SocketError`.
It's the spec of this method.
```
irb(main):001:0> require "socket"
=> true
irb(main):002:0> Socket.getnameinfo(['AF_INET', 21, 'multi'... -
- From: MSP-Greg <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64629 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r64628.
----------
Spec updates [Bug #15060] [Fix GH-1495]
From: MSP-Greg <[email protected]> -
- From: MSP-Greg <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64628 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- based on the patch by MSP-Greg at #1945.
Co-authored-by: MSP-Greg <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64627 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * appveyor.yml (environment): separate matrix factors by `build` (`vs`
or `msys2`), and `build` (and `vs` version if VS build).
now `MSYS2_ARCH` and `MSYSTEM` are derived from `Platform` if msys2
build.
git-svn-id: svn+ssh://ci.ru... -
- Applied in changeset trunk|r64625.
----------
avoid fork-unsafe arc4random implementations
Some old implementaions of arc4random_buf(3) were ARC4 based, or
unsafe when forked, or both. Resort to /dev/urandom for those
known problemati... -
- Some old implementaions of arc4random_buf(3) were ARC4 based, or
unsafe when forked, or both. Resort to /dev/urandom for those
known problematic cases. Fix [Bug #15039]
Patch from Thomas Hurst <[email protected]>
git-svn-id: svn+ssh://ci.r... - 12:12 AM Revision 183ac396 (git): * 2018-09-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64624 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- From: MSP-Greg <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64623 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/03/2018
-
- shyouhei (Shyouhei Urabe) wrote:
> @naruse Are you willing to provide a fix for this? Or can I commit the proposed #if guard?
Could you commit it? -
- @naruse Are you willing to provide a fix for this? Or can I commit the proposed #if guard?
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64622 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:08 PM Misc #15053: Using -fstack-protector-strong instead of -fstack-protector conditionally.
- Thank you for fixing this issue quickly!
-
11:07 AM Bug #14966: 2.5 branch - Appveyor failures - backport missed line
- Hello Greg,
Thank you very much for your notice.
I have applied your patch at r64621 in ruby_2_5 branch.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@64621 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:07 AM Bug #14880: Time#localtime doesn't always seem to respect TZ
- nobu (Nobuyoshi Nakada) wrote:
> I feel it'd be better to accept a timezone object as `utc_offset` like [Feature #14850], than setting `ENV`.
I completely agree but the problem is how to compute utc offset for a given time and timezo... -
- I feel it'd be better to accept a timezone object as `utc_offset` like [Feature #14850], than setting `ENV`.
-
09:07 AM Bug #15027: When Struct#each method is overriden Struct#select and Struct#to_a use wrong collections
- @matz: is the patch from Nobu good enough?
-
- Applied in changeset trunk|r64620.
----------
Declare as gnu_printf on mingw
[Bug #13496]
From: MSP-Greg <[email protected]> -
- [Bug #13496]
From: MSP-Greg <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64620 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * [Feature #14850] Add official API for setting timezone on Time (nobu)
* a patch posted. -
- * https://github.com/ruby/ruby/pull/1943
* I want a review by other core devs. -
- > atomutilでそうなるケースを試してみたいので再現するAtomとサンプルコードを提供してもらえませんか？
これでどうでしょう?
~~~
require 'atomutil'
entry = Atom::Entry.new
entry.content = "<br>"
puts entry.to_s
~~~
entry.to_s は実際に投稿する場合 HTTP の request body になります(参照: Atom::C... -
- なるほど。
atomutilでそうなるケースを試してみたいので再現するAtomとサンプルコードを提供してもらえませんか？ -
- jeremyevans0 (Jeremy Evans) wrote:
> mame (Yusuke Endoh) wrote:
> ...
I think the amount of changes from Ruby 1.8 to Ruby 1.9 depended a lot on what kind of processing your application did, and what kind of data was involved. If you ... -
- Currently, the MinGW build is broken. See https://github.com/ruby/ruby/pull/1945
Comparing the build summaries, there were some things that differed between the build and ruby-loco. Both ruby-loco & RubyInstaller2 (RI2) builds use t...
09/02/2018
-
- Applied in changeset trunk|r64618.
----------
Readline: expose rl_completion_quote_character variable
[Feature #13050]
From: georgebrock (George Brocklehurst) <[email protected]> - 11:27 PM Revision 5cde9a39 (git): * 2018-09-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64619 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [Feature #13050]
From: georgebrock (George Brocklehurst) <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64618 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > DOMでもnodeValueの値は実体参照を解決した値になるので今の挙動で問題ないように思うんですが、
JavaScript の DOM でも `Text` のコンストラクタ引数で渡した文字列はパースの対象にならずにそのままテキストノードが表す文字列になります。
~~~
<p id="p"></p>
<script>
t = new Text("< <");
console.log(t.nodeValue); // コンソールに「< ... -
- DOMでも`nodeValue`の値は実体参照を解決した値になるので今の挙動で問題ないように思うんですが、どんなユースケースで使おうとして今の挙動は間違っていると考えたか教えてもらえますか？
> 非rawモードではコンストラクタの第一引数に渡された文字列はテキストノードが表す文字列そのものを意味するはずです。
こうするべきだと考えた理由というか。 -
- `REXML::Text` オブジェクトが非rawモードの場合、`REXML::Text#value` がエスケープ済みのテキストを二重にエスケープ解除された文字列を返します。
例:
~~~
require 'rexml/document'
t = REXML::Text.new("< <", false, nil, false)
t.to_s # => "&lt; <"
t.value # => "< <" (expected... -
- Here is a [patch] to extend `Time.new` and `Time#getlocal` for timezone support.
A timezone object should have `local_to_utc`, `utc_to_local` and `utc_offset` methods, like [timezone gem].
[patch]: https://github.com/nobu/ruby/tree/f... -
02:35 PM Feature #14594: Rethink yield_self's name
- I suggest aliasing `#yield_self` with **#to_be**. The `to_` prefix suggest returning a value while [the word "be"](https://gist.github.com/RichOrElse/452e5f9f35f16c3fb6ef6d3ab41a173c) connotes both identity (`#itself`) and it's new condi...
-
- たしかにその通りですね。
そうなるようにしておきました。
近いうちにこの修正が入ったrexml gemをリリースしておきます。 -
- `REXML::Text#clone` で生成したオブジェクトが元のオブジェクトと異なる値を持ったテキストノードになります。clone されたテキストノードの `to_s` の値は、元のテキストノードが表現する文字列を二重にエスケープしたものになります。
例:
~~~
require 'rexml/document'
t = REXML::Text.new("< <", false, nil, false)
t2 = t.clone
t.to_s ... -
- ruby_2_5 r64617 merged revision(s) 64092.
-
- win32.c: limit write size on console
* win32/win32.c (constat_parse): split long buffer and limit write
size on a console, as well as rb_w32_write.
[ruby-dev:50597] [Bug #14942]
git-svn-id: svn+ssh://ci.ruby... -
- ruby_2_5 r64616 merged revision(s) 64071.
-
- ruby.c: taint ARGV on Windows
* ruby.c (external_str_new_cstr): strings come from the external
should be tainted. [ruby-dev:50596] [Bug #14941]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@64616 b2dd... -
- > https://bugs.ruby-lang.org/issues/13618
>
> I have at least one more preparatory change which should be fairly
> straightforward; but unfortunately makes some of the current code
> more verbose (because of `container_of'):
>
>... -
07:10 AM Feature #15049: [Request] Easily access all keyword arguments within a method
- @duerst
> Maybe I'm totally confused, but what's wrong with using `**keyword_arguments`?
I am not the ticket's authors, but I understand the demand and met with the same requirement in some real-life projects. The most expressive e... -
- Maybe I'm totally confused, but what's wrong with using **keyword_arguments?
-
- Applied in changeset trunk|r64614.
----------
configure.ac: -fstack-protector-strong
* configure.ac: use -fstack-protector-strong if available instead of
-fstack-protector conditionally. [ruby-core:88788] [Misc #15053] - 03:49 AM Revision f7717185 (git): * 2018-09-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64615 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * configure.ac: use -fstack-protector-strong if available instead of
-fstack-protector conditionally. [ruby-core:88788] [Misc #15053]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64614 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@64613 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/01/2018
-
04:19 PM Bug #15039: Random.urandom and SecureRandom arc4random use
- shyouhei (Shyouhei Urabe) wrote:
> While I'm not against these points, I feel it is not a good idea to wait for such new API. Can we focus on fixing FreeBSD first? Maybe the OpenBSD issue should be handled separately in another thread... -
- Freaky (Thomas Hurst) wrote:
> jeremyevans0 (Jeremy Evans) wrote:
> ...
While I'm not against these points, I feel it is not a good idea to wait for such new API. Can we focus on fixing FreeBSD first? Maybe the OpenBSD issue should b... -
04:14 PM Bug #15027: When Struct#each method is overriden Struct#select and Struct#to_a use wrong collections
- Thank you for the code @nobu. I have applied Nobu's suggestion, please find updated patch in the attach.
> If you can override each, you can override other methods.
This is true, but doing this is very un-ruby-ish. Also, I don't t... -
- > https://bugs.ruby-lang.org/issues/13618
Greg, do you think you can try this change for portability?
No rush, though, I will be mostly AFK and Queue/SizedQueue
changes will be trivial with the prep work so far...
Future chang... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@64612 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@64611 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * complex.c (f_divide): canonicalize rationals to simplify integer
complex results.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64610 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ```
.../ext/psych/lib/psych/versions.rb:4: warning: already initialized constant Psych::VERSION
.../.ext/common/psych/versions.rb:4: warning: previous definition of VERSION was here
```
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64608 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64607 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64606 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_5 r64605 merged revision(s) 64007,64019,64020.
-
- thread.c (do_select): fix leak on exception
When do_select is interrupted and raise happens from
RUBY_VM_CHECK_INTS_BLOCKING, the original FD sets we copied
do not get freed, leading to a memory leak. Wrap up al... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64604 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_5 r64603 merged revision(s) 64014.
-
- fix sum on infinity
* array.c (rb_ary_sum): consider non-finite floats.
[ruby-core:88024] [Bug #14926]
* enum.c (sum_iter): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@64603 b2dd03c8-... -
- ruby_2_5 r64602 merged revision(s) 63994.
-
- reduce tzset
* time.c (rb_localtime_r): call tzset() only after TZ environment
variable is changed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@64602 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64601 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- jeremyevans0 (Jeremy Evans) wrote:
> Changing the callee side will not fix all cases. The `where` method supports more than just symbols keys in hashes. `where('table.id'=>1)` is supported, for example. Accepting a keyword args splat ...
08/31/2018
-
- jeremyevans0 (Jeremy Evans) wrote:
> As the maintainer of the OpenBSD ruby port, I'm requesting that ruby continue to use arc4random_buf(3) on OpenBSD. The OpenBSD getentropy(2) man page states:
> ...
I think there's a reasonable argu... -
06:56 PM Bug #15039: Random.urandom and SecureRandom arc4random use
- naruse (Yui NARUSE) wrote:
> I finally agree that
> ...
As the maintainer of the OpenBSD ruby port, I'm requesting that ruby continue to use arc4random_buf(3) on OpenBSD. The OpenBSD getentropy(2) man page states:
~~~
getentr... -
- Freaky (Thomas Hurst) wrote:
> naruse (Yui NARUSE) wrote:
> ...
As you mentioned, it's actually urandom.
I misunderstood.
> > > > But the size of those entropy is limited.
> ...
Yeah, it should block if there's no entropy.
> > ... -
- naruse (Yui NARUSE) wrote:
> Freaky (Thomas Hurst) wrote:
> ...
As far as I know getentropy(2) behaves as urandom, just with a size limit.
> > > But the size of those entropy is limited.
> ...
Yes, with the caveat that it should bl... -
- Freaky (Thomas Hurst) wrote:
> naruse (Yui NARUSE) wrote:
> ...
Even if /dev/random is not accessible, it can use getentropy(2).
> > But the size of those entropy is limited.
> ...
Yes.
But Random.urandom shouldn't be limited.
... -
05:38 PM Bug #14883 (Third Party's Issue): Ruby 2.5 Fails to Build on PowerPC 32-bit (BE)
- Issue with systemd containers, not with Ruby.
-
- When running a code analysis tool for ruby, I got a warning `Insufficient stack protection: -fstack-protector`, it seems setting "-fstack-protector-strong" is better than "-fstack-protector".
Currently in `configure.ac`, "-fstack-prot... -
- This reverts commit a5e5cfa3f650d4e78fb50e2df15c102ab56fca3c.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64600 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ```
.../ext/psych/lib/psych/versions.rb:4: warning: already initialized constant Psych::VERSION
.../.ext/common/psych/versions.rb:4: warning: previous definition of VERSION was here
```
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@... - 03:05 PM Revision 50cb77f2 (git): * 2018-09-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64598 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64597 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- mame (Yusuke Endoh) wrote:
> jeremyevans0 (Jeremy Evans) wrote:
> ...
Changing the callee side will not fix all cases. The `where` method supports more than just symbols keys in hashes. `where('table.id'=>1)` is supported, for example... -
- Here is a scenario where allowing "hash argument with omitted braces" causes a problem. Assume that we write a method "debug" which is equal to "Kernel#p".
```
def debug(*args)
args.each {|arg| puts arg.inspect }
end
```
Pas... -
- jeremyevans0 (Jeremy Evans) wrote:
> Having to change all calls from `where(:id=>1)` to `where({:id=>1})` makes the code uglier and is going to make most Ruby programmers less happy. Does this argument for explicitness lead to requirin... -
- mame (Yusuke Endoh) wrote:
> Jeremy, thank you for investigating the examples. I'd like to discuss this issue at the next developers' meeting.
> ...
I disagree. I migrated many applications and libraries from Ruby 1.8 to Ruby 1.9 (an... -
- Jeremy, thank you for investigating the examples. I'd like to discuss this issue at the next developers' meeting.
This is my personal current opinion: this change indeed requires users' action, however, I believe that the problem is ... -
- A keyword rest argument with empty hash, `**{}`, is removed during parsing phase. However, under the current spec of keyword parameters, this leads to a problem:
```
def foo(opt = "opt", **hsh)
p [opt, hsh]
end
foo({}, **{}) ... -
- * random.c (fill_random_bytes_syscall): use SecRandomCopyBytes in
Security framework on macOS 10.7 or later.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64596 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- @nobu That doesn’t seem to align with what the documentation says:
> Converts time to local time (using the local time zone in effect for this process) modifying the receiver.
-
- I think it should be fixed at the creation time.
-
- * [Feature #14183] "Real" keyword argument
* I'd like to hear matz's current opinion and other committers' ones. -
- Use `RB_INTEGER_TYPE_P()`.
-
07:22 AM Bug #15050: GC after forking with fibers crashes
- On 2018/08/31 15:14, Eric Wong wrote:
>> What is the problem [Bug #15041] want to solve?
>
> Switching fiber can crash in child process. r64589 test change
> shows it:
>
> ```
> - Fiber.new{ pid = fork {} }.resume
> + ... -
- Koichi Sasada <[email protected]> wrote:
> On 2018/08/31 12:50, Eric Wong wrote:
> > > [Bug #15041] hits something wrong?
> > > (sorry I needed to ask earlier)
> >
> > No, it's not wrong; but it is an incomplete fix. There
> > seem... -
- On 2018/08/31 12:50, Eric Wong wrote:
>> [Bug #15041] hits something wrong?
>> (sorry I needed to ask earlier)
>
> No, it's not wrong; but it is an incomplete fix. There
> seems to be several problems related to fork + Fiber
... -
- Koichi Sasada <[email protected]> wrote:
> On 2018/08/31 12:30, Eric Wong wrote:
> > Yes, fix one bug, hit another :< Story of my life
>
> [Bug #15041] hits something wrong?
> (sorry I needed to ask earlier)
No, it's not wrong; bu... -
- [email protected] wrote:
> Is this because [Bug #15041]?
Yes, fix one bug, hit another :< Story of my life
(I found these while working on auto-fiber) -
- Is this because [Bug #15041]?
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64595 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
08/30/2018
-
- To give an example of how much code this would break, let's use Redmine as an example, since it runs this bug tracker. For simplicity, let's limit our analysis to the use of a single method, ActiveRecord's `where` method. ActiveRecord'...
-
08:11 PM Feature #15049: [Request] Easily access all keyword arguments within a method
- shevegen (Robert A. Heiler) wrote:
> I have had a somewhat related idea in that I wanted a way to access all
> ...
Tbh I hadn't thought too much about naming... Was just trying to get something mocked up quickly. Either way, glad to s... -
- I have had a somewhat related idea in that I wanted a way to access all
parameters in a simple, short manner. A bit similar to $1 $2 etc... for
regexes, just that we could do so programmatically for the arguments
passed into a method ... -
- As a developer, I'd like to leverage the power of keyword arguments (requirements, defaults, etc) and then be able to access a hash of all the arguments supplied.
~~~ ruby
def foo(bar:, baz: 1, qux: 2...)
post('/', body: kargs)
e... -
- [email protected] wrote:
> https://bugs.ruby-lang.org/issues/15050
This fixes the immediate bug, but I think there's other problems
with stack management
```
diff --git a/cont.c b/cont.c
index 7bc1724176..ab42dfb27a 100644... -
- Not sure when to work on this, so leaving this here for now...
The management of stacks for root fiber and regular
fibers is different and confusing. Perhaps unifying
thread and fiber stack cache is the best way to go.
Is a sepa... - 07:14 PM Revision cec21388 (git): * 2018-08-31
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64594 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:14 PM Revision 13f49235 (git): cont.c (rb_fiber_atfork): th->root_fiber may not exist
- Otherwise, bootstraptest/test_fork.rb fails with -DVM_CHECK_MODE=2
[Bug #15041]
Fixes: r64589 "cont.c: set th->root_fiber to current fiber at fork"
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64593 b2dd03c8-39d4-4d8f-98ff-823fe6... -
05:09 PM Misc #15007: Let all Init_xxx and extension APIs frequently called from init code paths be considered cold
- normalperson (Eric Wong) wrote:
> [email protected] wrote:
> ...
Yes, explains behaviour observed through smaps - correct, `MAP_HUGETLB` works. Will clean it up during the week and submit as a new issue. -
- [email protected] wrote:
> * `MADV_HUGEPAGE` - fallback option, implicit request, kernel
> will map it implicit if not aligned to hugepage boundary, or
> right away if aligned to hugepage boundary (I implemented with
> the 2MB al... -
- ko1 (Koichi Sasada) wrote:
> I agree to introduce COLD attribute.
> ...
Somewhat off topic, but fits with the general direction here.
I have a proof of concept going with mapping the text section to hugepages after a few evenings of... -
- Can I submit the documentation for this as a GitHub PR? I just to make updates to README.EXT.
Also, thank you for the help I will make a note of that in my patch. -
12:57 PM Feature #15047: Documentation and more functions for Hash functions in C API
- > Also, including more functionality like getting the size a Hash directly through
> ...
Use RHASH_SIZE macro. -
- More documentation would always be very helpful. It makes "entry" into the
ruby world easier when there is good documentation. Perhaps after ruby 3x3
we could add a new meme - four times as good documentation. :D -
- Currently the C API supports various Array functions like `rb_ary_new()` and String
functions like `rb_str_new2()` I could hardly find any documentation in the README.EXT
for working with hashes. Instead, I relied on this blog: http://... -
- naruse (Yui NARUSE) wrote:
> Freaky (Thomas Hurst) wrote:
> ...
... but you've just described concerns over situations where such APIs are unavailable. If you have no /dev/urandom why would you have a /dev/random? If you have no non-... -
- naruse (Yui NARUSE) wrote:
> > > On Darwin, there seems similar issue as OpenBSD.
> ...
As far as I investigated, it's implemented with CCRandomCopyBytes() and fork safe. We should use this.
https://stackoverflow.com/a/21736905/515572 -
- Freaky (Thomas Hurst) wrote:
> naruse (Yui NARUSE) wrote:
> ...
There's /dev/random and getentropy.
But the size of those entropy is limited.
> > And as Jeremy already pointend, OpenBSD doesn't have urandom alternative syscall beca... -
- I'm now for the addition. By the way, don't you need `Array#intersection`?
-
08:51 AM Feature #14097: Add union and difference to Array
- As @mame already said, I gave a talk at Euruko about this issue:
https://youtu.be/jUc8InwoA-E?t=2m54s
I did an standing up voting. As in the video you can not see the audience, here is the picture I took during the talk with the re... -
- * [Feature #14097] Add union and difference methods to Array (@ana06)
* Addition of two new methods in aim of readability, ease of use, efficiency and consistence. There are already PR for both methods.
* @matz told me to add this ... -
- On 2018/08/29 17:09, Eric Wong wrote:
> Shows me: `resume': fiber called across stack rewinding barrier (FiberError)
Yes, I tried similar code.
Not sure why...
Nobu?
--
// SASADA Koichi at atdot dot net - 03:24 AM Revision 3bcb4ff8 (git): hrtime.h: fix typo in non-builtin overflow check
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64592 b2dd03c8-39d4-4d8f-98ff-823fe69b080e