Activity
From 03/12/2019 to 03/18/2019
03/18/2019
-
10:48 PM Feature #4475: default variable name for parameter
- Is there a reason to do this other than to save some typing? I'm not sure we've proposed any terribly real-world cases here where this made code better.
I feel like we already have some single-character patterns around blocks with one... -
05:12 PM Feature #4475: default variable name for parameter
- I also dislike the use of `@` for this. It looks very weird and evokes strong references to instance variables in my mind. I'm not sure which characters exactly are an option, but I think we should avoid the use of `@`. Will something li...
-
03:43 PM Feature #4475: default variable name for parameter
- Would it be possible to make this more inline with other "magic" variables? Such as $1 and $2 for regex. Maybe $blockarg1 and $blockarg2?
-
11:42 AM Feature #4475: default variable name for parameter
- I think @1 @2 is ok, syntax-wise; it reminds me of $1 $2 for regex matching.
The main two advantages I see is that it is short to type; and also easy
to remember.
There is only one thing that I would like to add and this came from... -
10:12 PM Feature #9758: Allow setting SSLContext#extra_chain_cert in Net::HTTP
- I would also love to know about this. I'm running into an issue right now where I'm trying to use ruby (specifically with rest-client, but it's just a wrapper around Net::HTTP) to call out to an API with a client certificate and need a c...
-
08:51 PM Feature #15626: Manual Compaction for MRI's GC (`GC.compact`)
- > Can we introduce it just after every major (full) gc?
I agree. If the necessary steps are Full GC -> Update -> Move -> Full GC, then it would be faster to just compact automatically after a full GC which is already occurring. I unde... -
08:24 PM Feature #15632: Dynamic method references
- Okay, in that case this can be closed.
-
- I think I found it. I've attached a patch file. Please forgive me if I'm doing this wrong, this is my first contribution.
-
- Some more investigation yields that `compile_error` is called with:
identifier false is not valid to get -
- To be clear, I mean that:
``` ruby
require 'ripper'; Ripper.new('[1, 2, 3].map { @1 * 2 }').tap(&:parse).error?
```
returns true
-
- Hi there -
Love the new number args for blocks. When I run
``` ruby
[1, 2, 3].map { @1 * 2 }
```
everything works. However, when I run:
```ruby
require 'ripper'; Ripper.new('[1, 2, 3].map { @1 * 2 }').parse
```
it retu... -
07:22 PM Feature #14183: "Real" keyword argument
- mame,
Thanks for your continued work on this.
I still agree that for methods that accept keyword arguments, we should make changes to avoid the problems that currently exist for keyword arguments.
I still believe that breaking a... -
09:21 AM Feature #14183: "Real" keyword argument
- Sorry for leaving this ticket. Matz, akr and I talked about this issue several times since the last year, and we have never reached a perfect solution. But I try to re-summarize the problem, current proposal, and migration path.
... - 06:30 PM Revision f86e5dae (git): Applied security patches for RubyGems
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@67303 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:45 PM Revision 92b0331b (git): Use designated initializers for compile_status
- to make it easier to understand what values are grouped.
Just cosmetic changes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67302 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- to eliminate necessity of error check and `free`
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67301 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- by changing interface of `mjit_copy_cache_from_main_thread`.
This is also fixing deadlock introduced by r67299.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67300 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I noticed that r67287 was illegal because memory allocated by `alloca`
was used after the stack is expired.
So I just replaced that with `malloc` and `free` for now.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67299 b2dd03c8-39d4... - 04:14 PM Revision 08e9c58d (git): * 2019-03-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67298 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This reverts commit ba51ae0109ee1d1fa7ca90b43da115ea68d7214a.
CI is failing again...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67297 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Originally I opened this up as an issue in memory profiler https://github.com/SamSaffron/memory_profiler/issues/67, however I was able to isolate the issue to just Ruby 2.6.
ObjectSpace.allocation_sourceline is reporting the line wher... -
- Take 2 of r67287.
For some reasons, passing pointer of pointer on stack to a function
and assigning an addresse to a pointer dereferenced from the pointer
seems not working on mswin.
So I achieved to return multiple values by returning... -
12:48 PM Bug #15672 (Closed): Lambda implicit arguments, differences between lambda {} and -> {} specifications
- Applied in changeset trunk|r67295.
----------
parse.y: numbered parameter in lambda
* parse.y (lambda): support numbered parameters, only when no
argument list including empty parentheses, like empty vertical
bars. [ruby-core:9185... -
- Koichi said it will be fixed. :)
(I guess this was never intentional, thus a bug.) -
06:12 AM Bug #15672: Lambda implicit arguments, differences between lambda {} and -> {} specifications
- Duplicate of #15620
-
03:34 AM Bug #15672 (Closed): Lambda implicit arguments, differences between lambda {} and -> {} specifications
- Hi
Are the following differences intentional?
```
$ ruby -v
ruby 2.7.0dev (2019-03-18 trunk 67291) [x86_64-darwin18]
```
```
$ cat ptn1.rb
a = -> { p @1 }
a.call(1)
$ ruby ptn1.rb
Traceback (most recent call last):
... -
- * parse.y (lambda): support numbered parameters, only when no
argument list including empty parentheses, like empty vertical
bars. [ruby-core:91859] [Bug #15672]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67295 b2dd03c8-39d4... -
- This reverts commit 6b136a044205f6e6b66df68cd2da2a9c3e952a7d.
This does not seem to work:
https://travis-ci.org/ruby/ruby/jobs/507646193#L2478
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67294 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- to make CI stable. See the PR for details.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67293 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (set_yylval_noname): continue after an invalid global,
instance, class variable name, without "unexpected end-of-file"
error.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67292 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:12 AM Misc #15459: DevelopersMeeting before/after RubyKaigi2019
- Schedule on 4/17 (Wed)
* 12:00- door open
* 13:00-18:30 meeting w/Matz.
* topics is welcome. please comment on this issue.
* 18:30 close
There are several pre-RubyKaigi parties. pls check them.
-
- Further note:
"RubyKaigi 2019 After Hack by Fukuoka.rb!!" https://fukuokarb.connpass.com/event/124406/ is open event.
Anyone can attend! Enjoy.
Thanks,
Koichi -
- "After RubyKaigi hack meeting" is merged with "RubyKaigi 2019 After Hack by Fukuoka.rb!!"
https://fukuokarb.connpass.com/event/124406/
Please sign-up this party if you want to attend it even if you already sign-up on doorkeeper.
Det... -
- This reverts commit 4161674b2fbea6bdd01783ac5d3b39d88db22972.
Revert "Eliminate mjit_copy_job_t reference from mjit_worker"
This reverts commit d86a1aa045959dfbf5cd472eae0d043180259727.
Reverting them because of CI failures
git-svn-i... -
- [Fix GH-2099]
From: Lourens Naudé <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67290 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (parser_numbered_param): hoisted out the contextual
check for numbered parameters.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67289 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/17/2019
-
08:56 PM Bug #15662 (Closed): Fix CSV delegation to missing StringIO
- Thanks!
-
09:13 AM Bug #15662: Fix CSV delegation to missing StringIO
- We resolved it in https://github.com/ruby/csv/pull/80. Thank you @kou 🙇♂️!
-
- rather than preparing beforehand.
By having this change, implementing inlining by calling
`mjit_copy_cache_from_main_thread` for inlined methods was made
possible.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67288 b2dd03c8-39d4-4... -
- and make `copy_cache_from_main_thread` easier to use.
For implementing inlining later, I'll use `copy_cache_from_main_thread`
inside `mjit_compile`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67287 b2dd03c8-39d4-4d8f-98ff-823fe6... -
- and guard iseq from GC by marking iseq in mjit_copy_job.
This is a refactoring for implementing inlining later and
should not be fixing or introducing any bugs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67286 b2dd03c8-39d4-4d8f... -
04:35 PM Revision cebc6407 (git): Fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67285 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:32 PM Revision 5bd10603 (git): * 2019-03-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67284 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67283 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67282 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- to check if it resolves "Permission denied" problem.
https://travis-ci.org/ruby/ruby/jobs/507381339
https://travis-ci.org/ruby/ruby/jobs/507392198
TBH I'm not exactly sure why it happens, but I don't have infinite time
to understand thi... -
- because --depth=1 may randomly break checkout:
https://dev.azure.com/rubylang/ruby/_build/results?buildId=208&view=logs&jobId=7ded14dc-7a77-59da-f40a-71e137ad96c0&taskId=2045950f-1dcd-54a4-4c23-fae2521239c1&lineStart=1554&lineEnd=1555&co... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67279 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r67278.
----------
Numbered parameters [Feature #4475] -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67278 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * --jit-min-calls: 5 -> 10000
--jit-min-calls=5 obviously can compile non hotspot. This was not a
problem for MJIT-benchmarks and Optcarrot because the former has very
few hot optimiziable methods and the latter is likely to trigger
com... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67276 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/16/2019
-
10:11 PM Bug #15671 (Third Party's Issue): Segfault
- We hit a segfault in wpscan (https://github.com/wpscanteam/wpscan) using docker (https://hub.docker.com/r/wpscanteam/wpscan) with alpine linux with ruby 2.6.2.
The command line used:
`docker run -it --rm wpscanteam/wpscan --url https... -
04:56 PM Bug #15490: socket.rb - recurring segmentation faults
- We're seeing this issue as well, on Ruby 2.6.1. For us, it occurs towards the end of a fairly large test suite when running one of our legacy Cucumber tests. When we only run the Cucumber section of our test suite (not the whole thing) t...
-
- ktsj-san recognizes this issue and it's intentionally left failing now.
As failure notification of this task is NOT indicating ruby is broken,
let's stop notifying the failure fo rnow.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@6... - 04:26 PM Revision 5b0bcb0b (git): * 2019-03-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67274 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- For 2 reasons:
* bundled_gems tend to be left broken (like now)
* We don't want Slack notification for pull request and it can't be
disabled on Azure Pipelines
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67273 b2dd03c8-39d4-4d8... -
09:52 AM Feature #11741: Migrate Ruby to Git from Subversion
- http://15news.ir
http://9news.ir
http://afexo.ir
http://aloofile.ir
http://aminpayam.ir
http://andishmes.ir
http://arikehvip.ir
http://azargo.ir
http://bassirat.ir
http://belton.ir
http://birligh.ir
http://brmm.ir
http://chag... -
- and simplified config by using dedicated webhook URL.
Sadly AppVeyor YAML does not support alias and so we need to copy-paste
the request body.
memo:
https://slack-files2.s3-us-west-2.amazonaws.com/bot_icons/2018-02-10/314363543719_48.p... -
04:00 AM Bug #15670 (Closed): Ripper treats :"sym" as xstring
- Applied in changeset trunk|r67270.
----------
dsym should be treated as string [ruby-core:91852] [Bug #15670] -
- Ripperで `:"sym"` をパースするとxstringとして扱われるようになっていますが、
`{"sym": ...}` と同様にstringとして扱われるべきだと思います。
~~~
$ ruby -rripper -e '_, (_, _, s) = Ripper.sexp_raw(%q{:"sym"}); p s'
[:dyna_symbol, [:xstring_add, [:xstring_new], [:@tstring_content, ... - 04:00 AM Revision f044cc10 (git): * 2019-03-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67271 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67270 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/15/2019
-
- Are there plans to backport the Rubygems security patches to Ruby 2.3? Ruby 2.3 is still in security maintenance status until the end of the month, so I think this would qualify, but I'm not sure.
-
06:37 PM Bug #15087: Segmentation fault with splat and block
- **Hurray**! Confirmed that this no longer crashes and works as expected on _2.5.4_ and _2.6.2_
-
04:04 PM Bug #15669 (Third Party's Issue): This issue was marked as resolved in 2.5.5 release note but I'm still experiencing it
- Users/richardsondackam/.rvm/rubies/ruby-2.5.5/lib/ruby/2.5.0/timeout.rb:86: [BUG] Segmentation fault at 0x00000001085b8a52
ruby 2.5.5p157 (2019-03-15 revision 67260) [x86_64-darwin18]
-- Crash Report log information -----------------... -
- Because retrying 5 times failed.
https://ci.appveyor.com/project/ruby/ruby/builds/23063048/job/k9lykaagfaex74gg
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67269 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:39 PM Feature #15477: Proc#arity returns -1 for composed lambda Procs of known arguments
- For what it is worth, this appears to be an issue when dealing with curried procs as well.
``` ruby
curried_proc = ->(a, b) { a + b }.curry # => <Proc:0x00007fa7698e7700 (lambda)>
first = curried_proc.(1) # => <Proc:0x00007fa76991a0... -
11:32 AM Revision b33a168e (git): bump up teeny version to 2.5.6
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67268 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:21 AM Bug #15384: ssl_certs are duplicated in RubyGems and Bundler
- There is even `Gem::Request.get_cert_files`
-
- vo.x (Vit Ondruch) wrote:
> Is the patch correct? Will it work when RubyGems are updated via `gem update --system`? I have not tested it, just wondering ...
`Gem::RUBYGEMS_DIR` should be probably used to initialize the `rubygems_cert... -
- Is the patch correct? Will it work when RubyGems are updated via `gem update --system`? I have not tested it, just wondering ...
Moreover, I don't understand why Bundler does not use RubyGems facilities for such functionality (but I u... -
- The error message could indeed be improved.
As for the functionality, I think matz may have to decide whether this
may fit to duck typing or not. In my opinion the distinction between
a "date" and a "time" is a bit arbitrary when we... -
01:41 AM Feature #15668 (Open): stdlib: Date - Time should return the difference in days
- Hi at the ruby/stdlib,
Computing with times and dates is very complicated.
There are so many pitfalls lurking there.
I stumbled about a seemingly simple computation,
involving Date and Time
try:
Date.today - Time.now
=> Type... -
06:54 AM Feature #14759: [PATCH] set M_ARENA_MAX for glibc malloc
- Hongli Lai's [What causes Ruby memory bloat?](https://www.joyfulbikeshedding.com/blog/2019-03-14-what-causes-ruby-memory-bloat.html) post is most-interesting indeed.
That article has given rise to a new issue, opened by Sam Saffron, [... -
- Outstanding research by Hongli Lai, and superbly presented in a post & video that all of us can easily digest.
Sam's new [15667](https://bugs.ruby-lang.org/issues/15667) issue will be very interesting. I tend to agree, if all goes wel... - 05:19 AM Revision d4f7fac6 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67267 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- NODE_HASH#nd_brace is a flag that is 1 for `foo({ k: 1 })` and 0 for
`foo(k: 1)`.
nd_alen had been abused for the flag (and the implementation is
completely the same), but an explicit name is better to read.
git-svn-id: svn+ssh://ci.rub... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67265 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67264 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/14/2019
-
11:50 PM Feature #15667: Introduce malloc_trim(0) in full gc cycles
- Relevant code in glibc
https://github.com/bminor/glibc/blob/c2d8f0b704c2b828bcd8d517a2376c0240c73c09/malloc/malloc.c#L4448-L4539
https://github.com/bminor/glibc/blob/c2d8f0b704c2b828bcd8d517a2376c0240c73c09/malloc/malloc.c#L4805
-
- Per Hongli's excellent article it looks like malloc_trim can help tremendously with memory bloat issues.
https://www.joyfulbikeshedding.com/blog/2019-03-14-what-causes-ruby-memory-bloat.html#a-magic-trick-trimming
I would like... -
- tool/make-snapshot: Use 6-spaces indent for SIZE and digests
to align with release note markdown.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67263 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:43 PM Revision bf4bcaf0 (git): * 2019-03-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67262 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- to align with release note markdown.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67261 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- r62934 was already backported into ruby_2_5 at r66912.
r63309 was already backported into ruby_2_5 at r67259.
-
- thread_sync.c (condvar_ptr): reset fork_gen after forking
Otherwise the condition variable waiter list will always
be empty, which is wrong :x
[Bug #14725] [Bug #14634]
git-svn-id: svn+ssh://ci.ruby-lang.org/ru... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67258 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:42 PM Bug #15661: Disallow concurrent Dir.chdir with block
- @nobu I actually considered that my first preference, except for the introduction of a new global lock.
I worry about suddenly introducing deadlocks into someone's code, though that code would have to be doing some locking as well as ... -
- Why not blocking until another block terminates?
-
- I created https://bugs.ruby-lang.org/issues/15667 to track malloc_trim, please post any results you have regarding to production performance there
-
08:02 PM Feature #14718: Use jemalloc by default?
- Came here to find out if indeed ```malloc_trim()``` would be integrated into the garbage collector. If Hongli's findings are true, this is indeed a game changer. Looking forward to seeing the bloat in my apps disappear!
-
- Does Hongli Lai's article _What causes Ruby memory bloat?_ shed any potential light here?
https://www.joyfulbikeshedding.com/blog/2019-03-14-what-causes-ruby-memory-bloat.html#a-magic-trick-trimming
After investigation, he discovered... -
05:25 PM Feature #15438: Threads can't switch faster than TIME_QUANTUM_(NSEC|USEC|MSEC)
- > -5 would still mean "the highest priority", yes, but then e.g. -4 or -3 which starts to mean "high but not highest priority" on MRI would have a different meaning on other implementations, which I believe is undesirable.
-5 means "g... -
04:56 PM Feature #15438: Threads can't switch faster than TIME_QUANTUM_(NSEC|USEC|MSEC)
- > It does not have to know. It will use, say -5 because it is meaningful on MRI. The value is then clamped to -3 by e.g. JRuby where -5 is not meaningful.
-5 would still mean "the highest priority", yes, but then e.g. -4 or -3 which ... -
05:21 PM Bug #15582: default/bundler-1.17.2.gemspec has no file list
- Hi @hsbt!
I assumed this fix would also fix the incorrect file list for the etc gem's gemspec but I didn't try it to make sure and it looks like it didn't fix it actually. On the default ruby 2.6.2 release, the file list is `["etc.so... -
- r63215 is backported to ruby_2_5 in r66912 but its bug fix r63309 is not backported to ruby_2_5 yet. I confirmed that https://github.com/sorah/repro254stuck stucks with ruby_2_5 branch (r67242) and it's fixed by cherry-picking r63309.
@... -
- Possible fix would be https://github.com/bundler/bundler/pull/7038,
but Ruby script ending with `^~~` could be wrongly stripped by that?
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67257 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This is a ticket for backport management.
r67247 fixes an issue of the test under root permission. -
- Applied in changeset trunk|r67256.
----------
compile.c: fix the corner case of rest and keyword arguments
See https://bugs.ruby-lang.org/issues/10856#note-20 . [Bug #10856] -
- Another presentation of the bug:
```
def foo; end
foo(*[], {}) #=> does not raise an exception in 2.6
``` -
- marcandre (Marc-Andre Lafortune) wrote:
> This is not actually fixed.
> ...
This is not completely fixed yet:
```
$ ruby -v
ruby 2.6.0p0 (2018-12-25 revision 66547) [x86_64-linux]
$ ruby -e 'def foo; end; options = {}; args = [];... -
- See https://bugs.ruby-lang.org/issues/10856#note-20 . [Bug #10856]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67256 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- For unknown reason, setup_args processed the arguments from the last to
the first. This is not only difficult to read, but also inefficient in
some cases. For example, the arguments of `foo(*a1, *a2, *a3)` was
compiled like `a1.dup << ... -
- * parse.y (parse_atmark): exclude punctuation follows @ marks,
whereas it is inclusive after $ mark as some punctuation global
variables exist.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67254 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
07:30 AM Bug #15649: Dir.glob regression with braces and Windows drive letters
- Seeing the same here. Seems like its the braces that are broken on Windows in Ruby 2.6. Rails autoloading feature combines a number of glob patterns into a string for reason, instead of passing in an array.
https://github.com/rails/r... -
06:45 AM Feature #14145: Proposal: Better Method#inspect
- Eregon (Benoit Daloze) wrote:
> My understanding is `#inspect` shows useful information for debugging, so then the source location is very useful, and gives me more than the parameters (e.g., I can find the code, documentation, etc from... - 06:43 AM Revision 277af37b (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67253 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- compile_array function had three usages: array literal, hash literal,
and method arguments. I think the third is completely different than the
first and second. For example, method arguments and popped are
meaningless; keywords_ptr and ... -
- * parse.y (parse_gvar): show the source line erred by invalid
global variable, and indicate the variable including the wrong
punctuation.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67251 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (ruby_show_error_line): hoisted out from parser_yyerror.
* parse.y (regx_options): revert r67226 and show the error line
separately.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67250 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:03 AM Feature #15665 (Closed): Cannot compile socket extension on Mojave
- The `mkmf.log` is reporting that it cannot find `netinet6/in6.h`. I guess that previously it’s finding it in `/usr/include`, but as we all know Apple removed that path since Mojave. On my machine the current path is:
```
/Application... -
02:48 AM Bug #15384: ssl_certs are duplicated in RubyGems and Bundler
- I made a patch that unifies both certificates. I propose it to bundler upstream.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67249 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:04 AM Revision e20aa14a (git): * 2019-03-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67248 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67247 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:31 AM Bug #15664 (Closed): File.executable returns incorrect results in Windows 10
- Calling File.executable? <path> in Windows 10 return false for a file with execute permissions set.
03/13/2019
-
- > I think it's important, otherwise how is Ruby code supposed to know what are the limits and which value it can use for Thread#priority= ?
It does not have to know. It will use, say -5 because it is meaningful on MRI. The value is th... -
- > the semantic of 'priority' right now is very platform-specific anyways
The specific semantics maybe, but the range is platform-agnostic and has always been -3..3 so far.
> ...
I think it's important, otherwise how is Ruby code s... -
- `RUBY_THREAD_PRIORITY_MIN` is changed to give the developer the choice to make some threads really low priority, at the cost of switching overhead. Unless I'm mistaken, the semantic of 'priority' right now is very platform-specific anywa...
-
- Why is RUBY_THREAD_PRIORITY_MIN changed? This should be discussed in this thread.
Other implementations have to follow this change (e.g. TruffleRuby & JRuby already handle negative priorities AFAIK),
so we need a good spec to ensure ... -
09:55 PM Revision a3cbff05 (git): bump up teeny version to 2.6.3
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67246 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- May explain why matz wants to remove autoload in the long run. :)
-
- The semantics of autoload are extremely complicated.
As far as I can see, they are unfortunately not documented.
ruby/spec tries to test [many aspects](https://github.com/ruby/spec/blob/master/core/module/autoload_spec.rb) of it, `... -
- My understanding is `#inspect` shows useful information for debugging, so then the source location is very useful, and gives me more than the parameters (e.g., I can find the code, documentation, etc from a file and line).
I'm not aga... -
- Could you use https://github.com/ruby/csv instead of ruby/ruby?
ruby/csv is the upstream repository. -
- I have opened a PR on GitHub's tracker with the changes: https://github.com/ruby/ruby/pull/2094
-
- If you create a CSV from raw content like:
csv = CSV.new("h1,h2")
You'll get method missing when calling `csv.path` but still, get `true` when you call `csv.respond_to?(:path)`.
This tricks 3rd party libraries like carrier... -
- I sort of agree with headius. I also can not really think of a possible and
deliberate use case for concurrent `Dir.chdir` with a block. Perhaps something
is missing (someone has a use case?) but otherwise I sort of agree with him
here. -
- `Dir.chdir` with a block should disallow concurrent use, since it will almost never produce the results a user expects.
In https://bugs.ruby-lang.org/issues/9785 calls for `Dir.chdir` to be made thread-safe were rejected because the u... -
- I'm sorry the link in previous post was for Japanese.
English version is here.
https://www.ruby-lang.org/en/news/2019/03/13/ruby-2-5-4-released/ -
- Ruby 2.5.4 was released!
https://www.ruby-lang.org/ja/news/2019/03/13/ruby-2-5-4-released/
Thank you for your patience. -
- FWIW we did just get a json 2.2.0 release. The base problem stands, however.
- 01:44 AM Revision 0d6910df (git): * 2019-03-13
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67244 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- newline is always "\n" when it is used.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67243 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_5 r67242 merged revision(s) 67200.
-
- Add ignored_sp event
* ext/ripper/lib/ripper/lexer.rb (Ripper::Lexer): add ignored_sp
event which will be fired from Ripper::Lexer#on_heredoc_dedent
method. [ruby-core:91727] [Bug #15648]
git-svn-id: svn+ss... -
- I couldn't reproduce it.
```
~ > mkdir .gem_home
~ > set -x GEM_HOME ~/.gem_home
~ > rbenv install 2.5.0-dev
ruby-build: use openssl from homebrew
Cloning https://github.com/ruby/ruby.git...
Installing ruby-2.5.0-dev...
ruby-bu... -
- ruby_2_5 r67241 merged revision(s) 66909.
-
- tmpdir.rb: permission of user given directory
* lib/tmpdir.rb (Dir.mktmpdir): check if the permission of the
parent directory only when using the default temporary
directory, and no check against user given d... -
- ruby_2_5 r67240 merged revision(s) 66779.
-
- configure: refuse to build with jemalloc when header is missing
[ruby-core:90964] [Bug #15520]
Freom: Misty De Meo <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67240 b2dd03c8-39... -
- I have a little concern that this could be an imconpatibility issue. I will skip this change for the next teeny.
03/12/2019
-
- MEMO: backporting r64485 and r64635 cause some make test failures on my environment.
I give up to fix these for just now.
```
#257 test_fork.rb:31:in `<top (required)>':
begin
r, w = IO.pipe
if pid1 = fork
... -
- Backporting was done at r66111.
-
- ruby_2_5 r67239 merged revision(s) 66618.
-
- This is a ticket for backport management.
r66618 could stabilize AIX CI.
-
- test_io.rb: increase timeout for RubyCI
to stabilize AIX powerpc CI
https://rubyci.org/logs/rubyci.s3.amazonaws.com/aix71_ppc/ruby-trunk/log/20181227T113302Z.fail.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/bra... -
- ruby_2_5 r67238 merged revision(s) 66436.
-
- should use defined_class.
* vm_insnhelper.c (vm_call_method_each_type): we should use me->defined_class
instead of me->owner because me->owner doesn't has correct ancestors list.
[Bug #15427]
git-svn-id: sv... -
- ruby_2_5 r67237 merged revision(s) 64234,64252.
-
- net/http, net/ftp: fix session resumption with TLS 1.3
When TLS 1.3 is in use, the session ticket may not have been sent yet
even though a handshake has finished. Also, the ticket could change if
multiple session... -
- ruby_2_5 r67236 merged revision(s) 66832.
-
- st.c (rb_hash_bulk_insert_into_st_table): avoid out-of-bounds write
"hash_bulk_insert" first expands the table, but the target size was
wrong: it was calculated by "num_entries + (size to buld insert)", but
it wa... -
09:56 PM Feature #15563: #dig that throws an exception if a key doesn't exist
- I would suggest `#retrieve`. It's just a **stronger** `#fetch`, and the dictionary definition reflects its meaning:
> retrieve (verb)
> ...
The name is still short and simple, but also idiomatic and meaningful at the same time.
``` ... -
- The patch was merged at r67235.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67235 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- The patch for 2.5.3 was merged at r67234.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67234 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_5 r67233 merged revision(s) 67201.
-
- eval.c: clear internal errinfo
* eval.c (ruby_cleanup): clear internal error info when invoking
end procs. [ruby-core:91731] [Bug #15650]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67233 b2dd03c8-3... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67231 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_5 r67228 merged revision(s) 64636,64637.
-
- r64636 and r64637 could related related with test failures on AIX.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/aix71_ppc/ruby-2.5/log/20190311T200224Z.fail.html.gz -
- AIX doesn't set OptionLength for boolean options
https://rubyci.org/logs/rubyci.s3.amazonaws.com/aix71_ppc/ruby-trunk/log/20180904T103302Z.fail.html.gz
https://www.ibm.com/support/knowledgecenter/ja/ssw_aix_72/com.ibm.ai... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67227 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I'll check appveyor out
I've `push --mirror` from the current ruby git repo to remove all dead references, and re-pushed the branch. I didn't realize it would force me to re-create the pull request, which is now https://github.com/rub... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67226 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:11 AM Revision 60bddf58 (git): * 2019-03-12
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67225 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67224 b2dd03c8-39d4-4d8f-98ff-823fe69b080e