Activity
From 04/06/2019 to 04/12/2019
04/12/2019
-
10:42 PM Bug #15515: OpenStruct raising NoMethodError instead of ArgumentError
- Sorry I missed this.
I'm positive on this patch and will commit it shortly unless there's any objection. -
10:38 PM Misc #15723: Reconsider numbered parameters
- jeremyevans0 (Jeremy Evans) wrote:
> The behavior changes if `foo` is a local variable:
> ...
Good catch, I forgot about that case.
Indeed, that's confusing.
This case can be worked around with parentheses if there is a local variab... -
09:11 PM Misc #15723: Reconsider numbered parameters
- Eregon (Benoit Daloze) wrote:
> headius (Charles Nutter) wrote:
> ...
The behavior changes if `foo` is a local variable:
```ruby
foo = 1
proc{foo &1}.call
# => 1
proc{foo & 1}.call
# => 1
```
This proposal has the followin... -
- headius (Charles Nutter) wrote:
> Conflicts with bitwise AND, doesn't it?
No, binary operators already care about spacing to clarify which one it is, and this syntax "conflict" already exists anyway:
~~~ ruby
irb(main):001:0> cl... -
08:10 PM Misc #15723: Reconsider numbered parameters
- > Another idea for syntax, already mentioned in https://bugs.ruby-lang.org/issues/4475#note-12 : &1, &2, etc.
Conflicts with bitwise AND, doesn't it?
```ruby
foo &1
```
Is it `foo() & 1` or `foo(&1)`? -
- Another idea for syntax, already mentioned in https://bugs.ruby-lang.org/issues/4475#note-12 : &1, &2, etc.
`&` associates much better with blocks than `@`: `map(&:name)`, `foo(&block)`, etc.
In fact, I think many previous suggestion... -
- Oh, another simplication... if user code in 2.7+ attempts to read `_1` before writing it in a block, that can be an indication that it's expected to be an argument offset. If it's assigned first it's just a normal local variable.
-
- What about using `_1`, `_2`? These are value variable names that could be reserved for argument offsets. This would mimic some golfed block code like `{|_| ...}` (though I know there's some debate about whether `@1` should map to `|x|` o...
-
- mame (Yusuke Endoh) wrote:
> However, akr and I think that "2.7 is completely compatible with 2.6 except warnings" approach is not good enough. We need to provide a migration path that allows users to rewrite their code for 3.0 gradual... -
01:52 PM Feature #14183: "Real" keyword argument
- @jeremyevans0,
You registered this ticket for pre-RubyKaigi [Misc#15459]. Do you have an idea how to discuss the issue?
@ko1 is now creating an agenda, and maybe 30 minutes will be allotted to this issue. The agenda is not decide... -
- Jeremy, thank you for working on this issue.
> I believe the expected behavior in Ruby 2.7 is to warn but return the same results as Ruby 2.6 in all three cases, is that correct?
I had intended the incompatibility, as I said in "Mi... - 02:32 PM Revision 95a82766 (git): * 2019-04-12
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67518 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:32 PM Revision 39b04bc6 (git): [DOC] Add `ifnone` example to `find` documentation [ci skip]
- [Fix GH-2110]
From: OKURA Masafumi <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67517 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:59 AM Bug #15708: Implicit numbered argument decomposes an array
- jeremyevans0 (Jeremy Evans) wrote:
> Attached is a patch that will turn off destructuring if the only implicit block variable is `@1`:
```diff
- args->nd_ainfo->rest_arg = excessed_comma;
+ if (max_numparam > 1) {
+ args->nd_a... -
04:17 AM Feature #15765: [PATCH] Module#name without global constant search
- This is for #11119 and #15625.
-
- Hello!
The current implementation of `Module#name` is known for having sub-optimal performance when it comes to anonymous modules. (see #11119 and #15625)
I have put together a reimplementation of `Module#name`, which works by eagerl... -
01:13 AM Misc #15459: DevelopersMeeting before/after RubyKaigi2019
- * new built-in class/method definition features in Ruby and C (will be talked at RubyKaigi 2019, my talk) (ko1)
04/11/2019
-
11:16 PM Bug #15300: rb_frame_method_id_and_class deprecated in 2.6
- I just noticed that Rice works perfectly under Ruby 2.6.2! Thank you so much.
-
- Attached is a patch that will turn off destructuring if the only implicit block variable is `@1`:
```ruby
# equivalent to proc{|x| x}
proc{@1}.call([1,2])
# => [1, 2]
# equivalent to proc{|_,x| x}
proc{@2}.call([1,2])
# => 2
... -
08:59 PM Bug #15764 (Assigned): Whitespace and control characters should not be permitted in tokens
- As of Ruby 2.5.1p57, it appears that all valid Unicode code-points above 128 are permitted in tokens. This includes whitespace and control characters.
This was demonstrated here: https://gist.github.com/qrohlf/7045823
I have attach... -
03:17 PM Bug #15360: "ThreadError: deadlock; recursive locking" error when recursive lock shouldn't be possible
- `git bisect` shows the problem occurs frequently since r58604.
But I don't know it can occur before the commit.
https://bugs.ruby-lang.org/projects/ruby-trunk/repository/trunk/revisions/66489/entry/thread_sync.c#L267
`do_mutex_lock(... -
12:09 PM Bug #15755: [BUG] Unnormalized Fixnum value on Enumerator::ArithmeticSequence#hash.to_s on Windows
- ruby_2_6 r67516 merged revision(s) 67466.
-
- enumerator.c: force hash values fixable
* enumerator.c (arith_seq_hash): force hash values fixable on
LLP64 environment. [ruby-core:92190] [Bug #15755]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67... -
- ruby_2_6 r67515 merged revision(s) 67467.
-
- range.c: force hash values fixable
* range.c (method_hash): force hash values fixable on LLP64
environment. [ruby-core:92191] [Bug #15756]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67515 b2dd03c8-... -
- ruby_2_6 r67514 merged revision(s) 67468.
-
- range.c: force hash values fixable
* range.c (range_hash): force hash values fixable on LLP64
environment. [ruby-core:92194] [Bug #15757]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67514 b2dd03c8-3... - 10:36 AM Revision 6f866fd9 (git): * 2019-04-11
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67513 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67512 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [Fix GH-2115]
From: Lourens Naudé <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67511 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:33 AM Misc #15723: Reconsider numbered parameters
- I very much like the feature itself, esp. for one liners you can come up with on a pry prompt. What I very much dislike though is the use of `@` which is a glorious hack if there is any since currently `@` tokenizably resolves to 'instan...
-
07:04 AM Bug #15761: File::Statfs documentation still exists on ruby-doc.org/core-trunk/
- Sorry, I didn't notice it's not official.
I'll report to them.
I didn't know docs.ruby-lang.org is a thing, it never shows up in Google search, maybe it needs some SEO.
Thanks for the reply!
 -
06:53 AM Bug #15746: 11 test cases run failed
- nobu (Nobuyoshi Nakada) wrote:
> Run with `make test-all` or test/runner.rb:
> ...
Thanks! -
- This might be the same issue as:
* https://bugs.ruby-lang.org/issues/15490
* https://bugs.ruby-lang.org/issues/15639
* https://github.com/hanami/hanami/issues/993
The common points are:
* macOS (darwin17 or 18)
* uses multipl... -
01:37 AM Bug #15763: Segmentation fault in timeout.rb / sleep
- Additionally, the issue does not seem to happen on every build. If I rebuild the same version of ruby, the issue may go away. (until another few rebuilds)
-
- I'm running into crashes on both ruby 2.6.1 and 2.6.2 (2.5.x is all good).
I'm on OSX / mojave with ruby installed via rbenv / ruby-build. Confirmed on two different machines.
The crash happens through the parallel gem, but it happen...
04/10/2019
-
10:39 PM Bug #15761: File::Statfs documentation still exists on ruby-doc.org/core-trunk/
- http://documenting-ruby.org is dead project.
Can you report ruby-doc.org administrator? Its website is not an official document resource. -
- Please report at http://documenting-ruby.org.
-
12:44 PM Bug #15761: File::Statfs documentation still exists on ruby-doc.org/core-trunk/
- Agree that it is confusing.
In my opinion, if it were easily possible so, it would be best to have only one
central repository including the documentation, e. g. something like
doc.ruby-lang.org or a sub-page like that.
As it is ... -
- Hi
I found File::Statfs still exists in core-trunk web documentation.
But this feature no longer exists.
http://ruby-doc.org/core-trunk/File/Statfs.html
Google search leads me to this page, which is a bit confusing. -
06:17 PM
Bug #15360: "ThreadError: deadlock; recursive locking" error when recursive lock shouldn't be possible
- Is there a plan to fix this? We have been noticing this bug occasionally in production.
-
- No error occurred, maybe OpenSSL headers have changed since the previous build?
Could you try `make -C ext/openssl clean`? -
11:00 AM Bug #15762 (Closed): Error compiling OpenSSL on Cygwin
- This is an error that only showed up today. I have been able to compile without problems on Cygwin until very recently. The only file recently changed in ext/openssl seems to be:
https://svn.ruby-lang.org/cgi-bin/viewvc.cgi/trunk/ext/op... -
02:56 PM Revision cf781b08 (git): Set a meaningful name to all Azure jobs
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67510 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67509 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67508 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- trying to fix
https://dev.azure.com/rubylang/ruby/_build/results?buildId=363
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67507 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- OpenSSL::BN.new(nil, 2) dumped core.
[ruby-core:92231] [Bug #15760]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67506 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67505 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67504 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y (rb_parser_fatal): fix "parser" in the message which was
replaced accidentally. it is not the argument name.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67503 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67502 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:16 AM Revision 37994bc5 (git): * 2019-04-10
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67501 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:16 AM Revision 481481b8 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67500 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:15 AM Revision 25c1fd3b (git): Reverting all commits from r67479 to r67496 because of CI failures
- Because hard to specify commits related to r67479 only.
So please commit again.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67499 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r67497.
----------
ext/openssl/ossl_bn.c (ossl_bn_initialize): get rid of SEGV
OpenSSL::BN.new(nil, 2) dumped core.
[ruby-core:92231] [Bug #15760] -
- ext/openssl/ossl_bn.c
```
221 if (!BN_bin2bn((unsigned char *)StringValuePtr(str), RSTRING_LENINT(str), bn)) {
222 ossl_raise(eBNError, NULL);
223 }
224 break;
```
This code depends on t... - 08:03 AM Revision 0cc2ffbc (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67498 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- OpenSSL::BN.new(nil, 2) dumped core.
[ruby-core:92231] [Bug #15760]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67497 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67496 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67495 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_method.c (rb_add_method_iseq): use rb_method_iseq_t, as
rb_method_definition_set refers, with a cast to suppress a
warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67494 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67493 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Ruby includes rubygems, but this is imported, see e.g. https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=67415. So improvements to rubygems should be proposed and discussed upstreams.
-
- I can not speak for the ruby core team; it may be best to actually ask matz directly,
but let's ignore this for the moment. I think, viewed objectively, there would be no
reason to avoid/ignore Rust. Ruby's primary internal focus is on... -
02:37 AM Feature #15759: Support Rust/Cargo in Gem::Ext::Builder
- ### Notable Gems using Rust
1. https://github.com/danielpclark/faster_path
2. https://github.com/ianks/fast_woothee -- shameless plug
3. https://github.com/tildeio/helix -- a framework for building Rust extensions
4. https://github... -
- Over the past few years, Rust has proven to be an incredibly stable and accessible option for those wishing to write native extensions for Ruby. Rust is particularly well-suited for Ruby for a few reasons:
1. Integration is straight-... -
- * parse.y (rb_parser_fatal): fix "parser" in the message which was
replaced accidentally. it is not the argument name.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67492 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67491 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67490 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
04/09/2019
-
11:48 PM Revision d099eabb (git): Set a write barrier between iseq and mark objects
- ISeq pins references in the mark array during compile, so it manually
marks references in the mark_ary. This was causing write barrier
misses, so we need to add a write barrier when pushing on the mark
array.
git-svn-id: svn+ssh://ci.r... -
11:35 PM Feature #15594 (Closed): [PATCH] net/imap: support SNI
- Applied in changeset trunk|r67488.
----------
Support SNI
This fixes connecting using TLS 1.3 to imap.gmail.com
[Fix GH-2077] [Feature #15594]
From: Marc-Antoine Perennou <[email protected]> -
11:27 PM Feature #15594: [PATCH] net/imap: support SNI
- Here's a possible workaround:
```ruby
require 'net/protocol'
class Net::Protocol
module ForceSNI
def ssl_socket_connect(*)
@sock.hostname = @host if @sock.respond_to? :hostname=
super
end
end
pre... -
- Maybe POP3 & SMTP need this too.
-
- I think this is necessary for the library to be able to connect to the Gmail server which now requires SNI.
-
- This fixes connecting using TLS 1.3 to imap.gmail.com
[Fix GH-2077] [Feature #15594]
From: Marc-Antoine Perennou <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67488 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67487 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67486 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Weak map references can't move because the st_table needs their address
as a key. But, we also need to remove T_NONE from the map so they
aren't reused.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67485 b2dd03c8-39d4-4d8f-98ff-82... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67484 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- JSON gem is referencing constants defined in Ruby then keeping a
reference as a global. We need to register these globals so they stay
pinned.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67483 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This commit tries to make compaction more likely by allocating some
objects and then throwing them away
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67482 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r67479.
----------
Adding `GC.compact` and compacting GC support.
This commit adds the new method `GC.compact` and compacting GC support.
Please see this issue for caveats:
https://bugs.ruby-lang.org/issue... -
- Hi,
Here are some statistics I gathered. I'll present a few more at RubyKaigi using our application.
https://gist.github.com/tenderlove/99112e9fcc85d9c6c7d9d0ea40063fc6 - 08:32 PM Revision ca9733dc (git): * 2019-04-10
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67481 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:32 PM Revision 2d912017 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67480 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This commit adds the new method `GC.compact` and compacting GC support.
Please see this issue for caveats:
https://bugs.ruby-lang.org/issues/15626
[Feature #15626]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67479 b2dd03c8-39d... -
- FWIW, the replies on my tweet above is some good sign that very few Rubyists expect this behavior and it breaks the basics assumptions of how the feature can be used.
-
- For some reason, a reply on the tracker seems to have been lost, or removed.
I think it is highly relevant, so I'll quote it here:
sholden (Scott Holden) wrote:
> This is definitely not the behavior I would expect. In everything tha... -
03:18 PM Bug #15708: Implicit numbered argument decomposes an array
- This is what happens when one syntactic sugar(*) collides with another.
(*) `a.map { |x,| x }` being a shorthand for `a.map { |(x)| x }` , and sometimes not, depending on the runtime values.
Neither of these are good, IMO (one for ... -
- * NEWS: [DOC] markup command line options, not to convert
successive hyphens to an en-dash unintentionally.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67478 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * NEWS: [DOC] fold lines not to make the BTS refereces wrong
links, without a backslash.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67477 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Run with `make test-all` or test/runner.rb:
```
$ make test-all TESTS=test_extlibs.rb TESTOPTS=-v
../src/revision.h unchanged
Run options: "--ruby=./miniruby -I../src/lib -I. -I.ext/common ../src/tool/runruby.rb --extout=.ext -- ... -
- nobu (Nobuyoshi Nakada) wrote:
> Run these tests under the build tree.
Hi,
I don't think this is problem where I run the test. Can you explain more? Thanks.
Besides, I run the test on target since cross compile.
1. for error l... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67476 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:39 AM Misc #15723: Reconsider numbered parameters
- Marc, okay, I agree with you. But if not in the form of `&:first` or `&:last`, I still frequently see the methods `first` and `last` used in blocks, and I see that those can be accessed as `_.first`, `_.last` according to your proposal, ...
-
- I have updated my branch (https://github.com/jeremyevans/ruby/commits/keyword-argument-separation) to restore backwards compatibility for methods using keyword arguments when calling with a final positional hash with mixed Symbol and non...
-
- Applied in changeset trunk|r67474.
----------
date: support for Reiwa, new Japanese era
[Feature #15742] - 01:27 AM Revision 49255fd7 (git): * 2019-04-09
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67475 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [Feature #15742]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67474 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67473 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
04/08/2019
-
- akr (Akira Tanaka) wrote:
> > Maybe, we should await next JIS X 0301?
> ...
As Japanese government has claimed that only one month is enough for the transition, the new standard will be issued in this month at latest :) -
05:34 AM Feature #15742: Add Date#jisx0301 support new Japanese era
- - Unicode CLDR 35.1 alpha uses "R".
https://www.unicode.org/repos/cldr/tags/release-35-1-alpha/common/main/ja.xml
- OpenJDK also uses "R".
https://bugs.openjdk.java.net/browse/JDK-8205432
http://hg.openjdk.java.net/jdk/jdk/rev/... -
- sawa (Tsuyoshi Sawada) wrote:
> Marc, regarding `|x, |`, I see plenty of cases like `map(&:first)` (or `map(&:last)`). Probably taking care of these cases is more important than the explicit `|x, |` cases. If you are going to count, you... -
07:17 PM Misc #15723: Reconsider numbered parameters
- Eregon (Benoit Daloze) wrote:
> @sawa Thank you for think link, I missed that issue.
> ...
Even more confusion ahead.
I don't see that this feature adds any benefit besides saving some chars in an ideal case.
On the downside it wil... -
- @sawa Thank you for think link, I missed that issue.
I stand by my opinion though, and expressed it there too. -
- Eregon (Benoit Daloze) wrote:
> @sawa The `|x,|` behavior for `@1` can only be considered a bug. It prevents `array_of_arrays.each { p @1 }` to work correctly.
> ...
@Eregon I think you better check the relevant threads before dumping ... -
- FWIW, I would bet >99% of Rubyists would agree this is a bug: https://twitter.com/eregontp/status/1115318993299083265
-
- As I said in #15723,
I believe the `|x,|` behavior for `@1` can only be considered a bug.
It prevents `array_of_arrays.each { p @1 }` to work correctly.
Why would we want to prevent that and make this pattern not general, dangerou... -
06:11 PM Bug #15754: MinGW build/compile failure with Ruby 2.5.5, but 2.6.2 & trunk ok
- As to commits, see:
r64620 - Declare as gnu_printf on mingw
https://github.com/ruby/ruby/commit/c115b39e033979bac7cfd2db5735549430dc14f7
and
r64630 - use mingw ANSI stdio
https://github.com/ruby/ruby/commit/1cf2bb4b20857581125... -
- @nobu
Thanks for the reply. Stupid on my part, I overlooked the changes re `gnu_printf` in configure.ac, and it's compiling fine.
I found the patch for it looking in an old copy of ruby-loco (using 'makepkg'). Back when Appveyor ... -
- `PRI_LL_PREFIX` should be defined in config.h by configure.ac.
```sh
$ grep '#define PRI_LL_PREFIX' .ext/include/x64-mingw32/ruby/config.h
#define PRI_LL_PREFIX "I64"
``` -
- Applied in changeset trunk|r67472.
----------
object.c: fix searching nested const paths
* object.c (rb_mod_const_get, rb_mod_const_defined): nested const
paths should not search from toplevel constants.
[ruby-core:92202] [Bug #15758] -
11:30 AM Bug #15758 (Closed): Object.const_defined?(name) falsely returns true on classes that are not defined
- in short https://i.imgur.com/qvIIBuu.png
Object.const_defined?('Baz::Bar') -> true
yet Baz::Bar -> class not found!
test to run, all ok on ruby 2.6.0, bug in 2.6.2
~~~ruby
class Foo
end
class Bar
end
class Baz
cla... -
- * object.c (rb_mod_const_get, rb_mod_const_defined): nested const
paths should not search from toplevel constants.
[ruby-core:92202] [Bug #15758]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67472 b2dd03c8-39d4-4d8f-98ff-823fe6... -
- * test/ruby/test_module.rb (TestModule#test_nested_get): fix a
typo. nested module's name is a qualified path.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67471 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- shevegen (Robert A. Heiler) wrote:
> But having a situation where changes to MRI could possibly be delayed due to difficulties
> ...
I am not proposing anything like that.
Practically, whenever MRI decides to add an experimental featu... -
- naruse (Yui NARUSE) wrote:
> Web browsers showed us that it cannot achieve at once both experimental and portable.
I will dare to challenge that.
Why would `ExperimentalFeatures.resolve_feature_path` not be portable?
Portable here ... -
- One worry that I have here is that this change may add bureaucratic overhead to MRI in
particular. I have nothing against alternative ruby implementations at all, quite the
opposite - the easier it is to implement ruby/rubies the bette... -
- Web browsers showed us that it cannot achieve at once both experimental and portable.
-
- ioquatix (Samuel Williams) wrote:
> I think it's a good idea. Might I suggest two potential ideas?
Go ahead :)
> ...
This is equivalent to my proposition of `ExperimentalFeatures` with a different name, right?
I don't understan... -
01:26 AM Feature #15752: A dedicated module for experimental features
- I think it's a good idea. Might I suggest two potential ideas?
Firstly, maybe have a shared `Ruby` module for common but interpreter specific functionality.
Then, interpreter specific modules e.g. `CRuby`, `MRuby`, `JRuby`, `Truffl... -
- Run these tests under the build tree.
-
- As far as I remember, the name "RubyVM" is introduced because the name of the implementation which is called as CRuby or MRI cannot be decided, and also its VM's name is not actually YARV. To rename it to something, it needs to reopen th...
-
- * struct.c (rb_struct_hash): force hash values fixable on LLP64
environment.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67470 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I **STRONGLY** object removal of flip-flop, in "-e" option at least.
It is too tiresome to rewrite with a flag variable in one-liners. -
- Applied in changeset trunk|r67468.
----------
range.c: force hash values fixable
* range.c (range_hash): force hash values fixable on LLP64
environment. [ruby-core:92194] [Bug #15757] -
02:36 AM Bug #15757 (Closed): [BUG] Unnormalized Fixnum value on Range#hash.to_s on Windows
- To reproduce:
```
ruby -e "(0..1).hash.to_s"
```
Result:
```
-e:1: [BUG] Unnormalized Fixnum value 0x8fa800e97a8f86b7
ruby 2.6.1p33 (2019-01-30 revision 66950) [x64-mingw32]
-- Control frame information ------------------... -
- Applied in changeset trunk|r67467.
----------
range.c: force hash values fixable
* range.c (method_hash): force hash values fixable on LLP64
environment. [ruby-core:92191] [Bug #15756] -
- To reproduce:
```
ruby -e "method(:p).hash.to_s"
```
Result:
```
-e:1: [BUG] Unnormalized Fixnum value 0xd258e532a3942665
ruby 2.6.1p33 (2019-01-30 revision 66950) [x64-mingw32]
-- Control frame information --------------... -
- Applied in changeset trunk|r67466.
----------
enumerator.c: force hash values fixable
* enumerator.c (arith_seq_hash): force hash values fixable on
LLP64 environment. [ruby-core:92190] [Bug #15755] -
- To reproduce:
```
ruby -e "0.step.hash.to_s"
```
Result:
```
-e:1: [BUG] Unnormalized Fixnum value 0xb3735f03e7a21893
ruby 2.6.1p33 (2019-01-30 revision 66950) [x64-mingw32]
-- Control frame information ------------------... - 03:26 AM Revision b29f55c5 (git): * 2019-04-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67469 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * range.c (range_hash): force hash values fixable on LLP64
environment. [ruby-core:92194] [Bug #15757]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67468 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * range.c (method_hash): force hash values fixable on LLP64
environment. [ruby-core:92191] [Bug #15756]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67467 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * enumerator.c (arith_seq_hash): force hash values fixable on
LLP64 environment. [ruby-core:92190] [Bug #15755]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67466 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I believe this is the same issue as #12717. We are trying to address this issue in #14183.
-
- I have updated my GitHub branch (https://github.com/jeremyevans/ruby/commits/keyword-argument-separation) to fix the issues in mame's branch that I identified in my previous comment.
Now, my branch keeps compatibility with Ruby 2.6 in...
04/07/2019
-
- As many of you may recall, I'm not a c type, especially regarding build errors. Recently tried to build 2.5.5 locally, and I get errors similar to the below. I do not have any errors using the same build code (ruby-loco) when building ...
-
08:24 PM Bug #15753 (Closed): unknown keyword when passing an hash to a method that accepts a default argument and a named argument
- e.g.
```ruby
>> def a(b = {}, c: 1); p [b, c]; end; a(a: 1)
Traceback (most recent call last):
3: from (irb):3
2: from (irb):3:in `rescue in irb_binding'
1: from (irb):3:in `a'
ArgumentError (unknown keyw... -
- BTW, @bozhidar discussed relevant points about Ripper and `RubyVM::AbstractSyntaxTree` in
https://metaredux.com/posts/2019/03/30/the-missing-ruby-code-formatter.html#the-impact-of-the-parser
He makes good points there. -
- mame (Yusuke Endoh) wrote:
> As far as I understand, RubyVM module is completely different than other builtin modules.
> ...
@mame Could you summarize this in the documentation of `RubyVM::AbstractSyntaxTree`?
Currently, it doesn't ... -
- It's kind of interesting that in this issue, I can count only 4 people which seem happy with the current state, and all the 25 others think the syntax should be changed or be removed.
Maybe it's time to rethink this feature and acknow... -
- jeremyevans0 (Jeremy Evans) wrote:
> But of the other proposals considered, I think only `\1` wouldn't present backwards compatibility issues, and that is associated with string escaping, newline continuation, and regexp backreferences,... -
- I completely agree with @marcandre here.
The cases using `@2` and higher are extremely rare, all feel pretty hard to read to me and force the simple case of a single argument to be more complicated and look more weird (`@1` instead of... -
- * [Misc #15723] Reconsider numbered parameters (eregon)
* We should address this soon. I think it's good to collect opinions within MRI committers. -
- The patch looks good to me.
I will let @nobu commit it.
A nice extra would be specs in `spec/ruby/core/exception/frozen_error_spec.rb` (similar to `spec/ruby/core/exception/name_error_spec.rb`) but this is not a requirement. -
- nobu (Nobuyoshi Nakada) wrote:
> I haven't look C-API well, the additional argument would be ok.
> ...
OK, v3 of the patch is attached, based off the initial patch with the positional argument, with the function renamed to `rb_frozen_e... -
- I haven't look C-API well, the additional argument would be ok.
`rb_raise_frozen_error` should be `rb_frozen_error_raise` like `rb_name_err_raise`?
As for the test, `assert_same` would be better for the equality of the receiver.
-
- waheedi (Waheed Barghouthi) wrote:
> The pull request you just created does not really reflect what you are saying, `The RubyVM module only exists on MRI. +RubyVM+ is not defined in`
I'm just trying to clarify as much as possible the... -
02:56 PM Feature #15743: RubyVM should be renamed to CRuby
- Eregon (Benoit Daloze) wrote:
> waheedi (Waheed Barghouthi) wrote:
> ...
I totally agree on your point
> There is more than one VM that can execute Ruby code, so I think "the Ruby VM" is simply confusing.
The pull request you just ... -
- waheedi (Waheed Barghouthi) wrote:
> @Eregon, I do believe there is a sense in what you are trying to do, but what makes more sense to me is that Matz Ruby was named "Ruby".
I believe "Ruby" refers to the programming language and fro... -
- Eregon (Benoit Daloze) wrote:
> I made a PR on GitHub to discuss the proposed documentation changes, please take a look and review:
> ...
@Eregon, I do believe there is a sense in what you are trying to do, but what makes more sense to... -
- I made a PR on GitHub to discuss the proposed documentation changes, please take a look and review:
https://github.com/ruby/ruby/pull/2113 -
- I just noticed `RubyVM.resolve_feature_path`.
This is a portable API, and as such should not be mixed with MRI-specific APIs (by being under `RubyVM`).
This shows the need for a common namespace for experimenting with portable experi... -
- mame (Yusuke Endoh) wrote:
> If you think so, you have to implement the feature in any way, regardles of whether it is renamed to CRuby or not? I don't see at all what the renaming will solve.
I think the rename will solve the probl... -
- I believe we should introduce a module for experimental features portable across Ruby implementations.
An example of such a portable experimental feature is `RubyVM.resolve_feature_path`.
This feature has nothing MRI specific in it, ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67465 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * gc.c (obj_memsize_of): T_RATIONAL and T_COMPLEX cannot be an
imemo.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67464 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- We often see test-all worker crash on test_rinda, but for now we even
can't know which test is unstable from this output:
http://ci.rvm.jp/results/trunk_gcc5@silicon-docker/1926481
Let me print `caller` on the timeout failure.
git-svn-...
04/06/2019
-
- Eregon (Benoit Daloze) wrote:
> In the patch in `rb_raise_frozen_error`, `exc` is used for both the message and the exception object, could you use different variables?
> ...
Sure, I can make that change. Can you and nobu come to an a... -
- `NameError#initialize` uses a keyword argument for `receiver`, so I it makes some sense to be consistent.
OTOH, keyword arguments often imply extra processing, especially if the caller is not Ruby code, so I actually find the position... -
- nobu (Nobuyoshi Nakada) wrote:
> Seems reasonable, but shouldn't `FrozenError#initialize` use a keyword argument as well as `NameError#initialize`?
`NameError#initialize` uses an additional positional argument for the `name` argument... -
- Seems reasonable, but shouldn't `FrozenError#initialize` use a keyword argument as well as `NameError#initialize`?
-
- Similar to `NameError#receiver`, this returns the object on which
the modification was attempted. This is useful as it can pinpoint
exactly what is frozen, as in many cases when a `FrozenError` is
raised, you cannot determine from th... - 04:03 PM Revision 93ecb9a1 (git): * 2019-04-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67462 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67461 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67460 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * internal.h (rb_imemo_tmpbuf_auto_free_pointer_new_from_an_RString):
create tmpbuf to keep the pointer before xmalloc which can raise
a NoMemoryError exception. extracted from
https://github.com/bear-metal/ruby/tree/transient-ime... -
- Marc, regarding `|x, |`, I see plenty of cases like `map(&:first)` (or `map(&:last)`). Probably taking care of these cases is more important than the explicit `|x, |` cases. If you are going to count, you better count these in. And if di...
-
- jeremyevans0 (Jeremy Evans) wrote:
> Marc,
> ...
I showed it is *much less* useful. The cases `|x, y|`, `|x, y, z|` and `|w, x, y, z|` are making only 3.26 % of the block signatures (14.8% of signatures with arguments).
That is not ... -
- Marc,
Thank you for your analysis, I think you have raised a number of good points.
marcandre (Marc-Andre Lafortune) wrote:
> Let's first agree that a shorthand notation would only simplify `{|x| foo(x) }` and no other block signa... -
- I would like a notation to replace `{|x| ...}`, and *only* to replace this.
I strongly disagree with current implementation:
1) that allows multiple unnamed parameters
2) where `{@1}` actually doesn't replace `{|x| ...}` but `{|x, |... -
-
- The final version of Unicode 12.1.0 will be published on May 7 (May 8 Japanese timezone). We should make sure that we switch from `UNICODE_BETA = YES` back to `UNICODE_BETA = NO`.
However, this has to be done very carefully. We have t... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67458 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67457 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67456 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Trying to fix
https://ci.appveyor.com/project/ruby/ruby/builds/23639998/job/0hm9v79xlryod1ff
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67455 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67454 b2dd03c8-39d4-4d8f-98ff-823fe69b080e