Project

General

Profile

Activity

From 09/11/2019 to 09/17/2019

09/17/2019

11:41 PM Bug #16169: rescue in a method argument
I agree that Ruby syntax is very subtle. Ruby's parser is a unspeakable monolith of compromise between human intuiti... mame (Yusuke Endoh)
06:49 PM Bug #16169: rescue in a method argument
mame explained that the behaviour is correct (in the context).
Perhaps the documentation could explain that, becau...
shevegen (Robert A. Heiler)
04:09 PM Bug #16169: rescue in a method argument
This is the same thing as #16092, where I submitted a documentation patch a little while ago. Dan0042 (Daniel DeLorme)
11:38 AM Bug #16169 (Closed): rescue in a method argument
At 2.4, #12686 was introduced, allowing code like this:
```ruby
foo (Integer(ENV['FOO']) rescue nil)
```
Thou...
zverok (Victor Shepelev)
11:23 PM Revision c170e23d (git): * 2019-09-18 [ci skip]
git[bot]
11:22 PM Revision 775365cb (git): Fix keyword argument separation issues with sym procs when using refinements
Make sure that vm_yield_with_cfunc can correctly set the empty keyword
flag by passing 2 as the kw_splat value when c...
jeremyevans (Jeremy Evans)
11:22 PM Revision 9b35dc38 (git): Pass keyword argument flag when rb_call_super_kw calls method_missing
This makes method_missing take a flag for whether keyword arguments
were passed.
Adds tests both for rb_call_super_k...
jeremyevans (Jeremy Evans)
09:50 PM Feature #11473: Immutable String literal in Ruby 3
> I suspect that the vast majority of Ruby code out there would work out of the box or
> require only minor changes ...
shevegen (Robert A. Heiler)
04:28 PM Feature #11473: Immutable String literal in Ruby 3
I regret missing this "final" decision, but I believe we should reconsider.
> I am sure introducing this could cau...
headius (Charles Nutter)
09:37 AM Bug #16158: "st" Character Sequence In Regex Look-Behind Causes Illegal Pattern Error When Combined With POSIX Bracket Expressions And Case Insensitivity Flag
Some more information: The onigmo documentation says (https://github.com/k-takata/Onigmo/blob/master/doc/RE#L270):
`...
duerst (Martin Dürst)
08:48 AM Bug #16158: "st" Character Sequence In Regex Look-Behind Causes Illegal Pattern Error When Combined With POSIX Bracket Expressions And Case Insensitivity Flag
I've had a hunch, and have now been able to confirm this hunch:
The problem must be related to the fact that there...
duerst (Martin Dürst)
09:02 AM Revision 0785469a (git): `brew install` may fail, so try to use `tool/travis_retry.sh`
https://github.com/ruby/ruby/runs/224877570#step:3:1008
```
Error: No such file or directory @ dir_s_rmdir - /Users/r...
znz (Kazuhiro NISHIYAMA)
06:16 AM Revision 68ffb679 (git): Undefine DSUSP key
Enable `Ctrl+Y`, which is bound with it by default on BSD-like
systems, for editing.
nobu (Nobuyoshi Nakada)
06:15 AM Revision b49c1380 (git): * 2019-09-17 [ci skip]
git[bot]
06:14 AM Revision f9332ad8 (git): Fix previous history in vi_insert mode
Adam Cammack
06:14 AM Revision a3533bc9 (git): Fix history navigation in vi_insert mode
Adam Cammack

09/16/2019

12:51 PM Revision 3bb1162c (git): Folded files in gemspec
nobu (Nobuyoshi Nakada)
12:37 PM Revision 2a39de19 (git): * 2019-09-16 [ci skip]
git[bot]
12:36 PM Revision 70f57287 (git): Fix a typo [ci skip]
znz (Kazuhiro NISHIYAMA)
12:20 PM Feature #7639: More freedom for location of comments
It looks like this feature has been realized by https://bugs.ruby-lang.org/projects/ruby-trunk/repository/git/revisio... sawa (Tsuyoshi Sawada)

09/15/2019

09:02 PM Misc #16152: DevelopersMeeting20190919Japan
* [Feature #16168] Add keyword argument separation to C functions using rb_scan_args
* I would like to commit the ...
jeremyevans0 (Jeremy Evans)
05:58 PM Misc #16152: DevelopersMeeting20190919Japan
* [Feature #16155] Add an `Array#intersection` method
* Is this an acceptable method name?
* Should this be a s...
connorshea (Connor Shea)
08:59 PM Feature #16168 (Closed): Add keyword argument separation to C functions using rb_scan_args
Most Ruby methods implemented as C functions that accept a variable number of arguments use rb_scan_args for argument... jeremyevans0 (Jeremy Evans)
02:22 PM Revision 4a403e3f (git): oops [ci skip]
Fixing typo. It seems I failed to press the shift key. shyouhei (Shyouhei Urabe)
02:12 PM Revision 3a3f48fb (git): Comment lines can be placed between fluent dot now
nobu (Nobuyoshi Nakada)
12:55 PM Revision 751d4ab9 (git): Refine Timezone fixture
nobu (Nobuyoshi Nakada)
07:24 AM Bug #16167 (Closed): make-snapshot does not work from fresh checkout
Applied in changeset commit:git|6cad0644248d5acbaf3a2e8de4ff6d88b3dd2cb4.
----------
Try to fetch commits notes to t...
nobu (Nobuyoshi Nakada)
07:23 AM Bug #16167: make-snapshot does not work from fresh checkout
vo.x (Vit Ondruch) wrote:
> So this is in line with the changes referred here, but I somehow fail to see why the ref...
nobu (Nobuyoshi Nakada)
07:23 AM Revision 6cad0644 (git): Try to fetch commits notes to the source tree automatically
[Bug #16167] nobu (Nobuyoshi Nakada)
04:29 AM Revision 44d59418 (git): rb_scan_args_count_lead: use arguments instead of magic numbers
nobu (Nobuyoshi Nakada)
02:22 AM Revision 585b15d7 (git): make-snapshot: no merge commits in ChangeLog
Parents commit hashs in logs of merge commits are abbreviated to
necessary length depending on the repositories. Exc...
nobu (Nobuyoshi Nakada)
02:22 AM Revision df4a4bd8 (git): make-snapshot: export ChangeLog from srcdir
nobu (Nobuyoshi Nakada)

09/14/2019

09:49 PM Feature #10344: [PATCH] Implement Fiber#raise
NEWS is updated. ioquatix (Samuel Williams)
08:57 PM Revision 1edcfd61 (git): Issue a warning if invalid kw_splat is passed to *_kw function
This should only happen if the API is misused. It's much better
to warn here and fix the problem, versus to try to d...
jeremyevans (Jeremy Evans)
07:46 PM Bug #16167 (Assigned): make-snapshot does not work from fresh checkout
nobu (Nobuyoshi Nakada) wrote:
> I'm going to deprecate `-exported` option because it can't make stable-checksum tar...
vo.x (Vit Ondruch)
02:53 PM Bug #16167: make-snapshot does not work from fresh checkout
I'm going to deprecate `-exported` option because it can't make stable-checksum tarballs. nobu (Nobuyoshi Nakada)
02:51 PM Bug #16167 (Closed): make-snapshot does not work from fresh checkout
Applied in changeset commit:git|e9c7fc7ca9bc15a9f84bdc356f7b6fac12988ccb.
----------
Continue to export even if no n...
nobu (Nobuyoshi Nakada)
05:15 PM Revision 395e5f51 (git): * 2019-09-15 [ci skip]
git[bot]
05:07 PM Revision 1ad4be13 (git): make-snapshot: deprecated -exported option [Bug #16167]
nobu (Nobuyoshi Nakada)
02:50 PM Revision e9c7fc7c (git): Continue to export even if no notes/commits
Just exporting may not imply exporting ChangeLog which needs
notes/commits. [Bug #16167]
nobu (Nobuyoshi Nakada)
02:27 PM Revision 6d2dcf96 (git): [ruby/io-console] Added `intr:` option to IO#raw
Enters raw-mode but enable interrupts.
https://github.com/ruby/io-console/commit/7cba76561a
nobu (Nobuyoshi Nakada)
12:38 PM Revision 82634596 (git): Keep the reference of imemo while argv may be used
To prevent the `v` reference from being eliminated before argv is used,
calling `rb_free_tmp_buffer` against `v` expl...
k0kubun (Takashi Kokubun)
12:09 PM Revision f41cd4ba (git): Fixed one-off error
Needs another room to append an empty hash. nobu (Nobuyoshi Nakada)
10:43 AM Revision 9699a5c5 (git): Update news regarding `Fiber#raise`.
Samuel Williams
09:21 AM Revision 39c37acf (git): Fix memory leak when adding empty keyword hashes
nagachika pointed out that ALLOC_N is actually just malloc, so
this memory wasn't being freed. This shouldn't be a p...
jeremyevans (Jeremy Evans)
08:49 AM Revision b78a345b (git): Only set RB_PASS_CALLED_KEYWORDS in C functions called directly from Ruby
It is not safe to set this in C functions that can be called from
other C functions, as in the non argument-delegatio...
jeremyevans (Jeremy Evans)
07:23 AM Bug #16162: Resque::DirtyExit - Child process received unhandled signal (You may have encountered a bug in the Ruby interpreter or extension libraries)
It happens inside “grpc” extension library.
Have you asked them?
nobu (Nobuyoshi Nakada)
02:25 AM Bug #16136: String corruption in 2.6.4
ruby_2_6 r67803 merged revision(s) ade1283ca276f7d589ffd3539fbc7b9817f682d5. nagachika (Tomoyuki Chikanaga)
02:24 AM Revision a165a066 (git): merge revision(s) ade1283ca276f7d589ffd3539fbc7b9817f682d5: [Backport #16136]
Fix a use-after-free bug by avoiding rb_str_new_frozen
`str2 = rb_str_new_frozen(str1)` seems to make str1 a...
nagachika (Tomoyuki Chikanaga)

09/13/2019

11:54 PM Revision b2c29bba (git): * remove trailing spaces. [ci skip]
git[bot]
11:42 PM Revision 3cfbfa96 (git): Consolidate empty keyword handling
Remove rb_add_empty_keyword, and instead of calling that every
place you need to add empty keyword hashes, run that c...
jeremyevans (Jeremy Evans)
05:54 PM Misc #16157: What is the correct and *portable* way to do generic delegation?
Dan0042 (Daniel DeLorme) wrote:
> In that case I'd like to make one last suggestion.
>
> For a method with `*args...
jeremyevans0 (Jeremy Evans)
05:00 PM Misc #16157: What is the correct and *portable* way to do generic delegation?
In that case I'd like to make one last suggestion.
For a method with `*args`, if the method is called with keyword...
Dan0042 (Daniel DeLorme)
03:15 PM Misc #16157: What is the correct and *portable* way to do generic delegation?
Dan0042 (Daniel DeLorme) wrote:
> With 2.7, people will be asked to migrate their generic delegations to use `pass_k...
jeremyevans0 (Jeremy Evans)
02:55 PM Misc #16157: What is the correct and *portable* way to do generic delegation?
There's something I'd like to clarify.
With 2.7, people will be asked to migrate their generic delegations to use ...
Dan0042 (Daniel DeLorme)
05:25 PM Bug #16167 (Closed): make-snapshot does not work from fresh checkout
So far, I was using this sequence to get Ruby snapshot:
~~~
git clone https://github.com/ruby/ruby ~/ruby
cd ~/r...
vo.x (Vit Ondruch)
04:53 PM Revision 24b1b339 (git): Correctly handle keywords for Method#call for cfuncs, send, and attr_*
This sets the correct VM frame flags when using Method#call to
call funcs, and handles empty keyword hashes for cfunc...
jeremyevans (Jeremy Evans)
03:45 PM Feature #16166: Remove exceptional treatment of *foo when it is the sole block parameter
Actually that reminds me - mame mentioned that the ruby core team needs a
motivation/impetus if a change is necessar...
shevegen (Robert A. Heiler)
03:44 PM Feature #16166: Remove exceptional treatment of *foo when it is the sole block parameter
> We need an evidence that the behavior actually confuses
> many people, at least.
It does not confuse me because...
shevegen (Robert A. Heiler)
10:16 AM Feature #16166: Remove exceptional treatment of *foo when it is the sole block parameter
I agree that Ruby's arguments are insanely complex. In the basic case, `"a"` and `["a"]` are distinguished.
```
...
mame (Yusuke Endoh)
08:17 AM Feature #16166 (Closed): Remove exceptional treatment of *foo when it is the sole block parameter
In the parameter signature of a code block for a method that is not involved in method definition or creation of lamb... sawa (Tsuyoshi Sawada)
03:16 PM Revision 98f919ed (git): The stdlib readline should raise Interrupt when pressing C-c
aycabta (aycabta .)
03:12 PM Revision 70fe473c (git): * 2019-09-14 [ci skip]
git[bot]
03:11 PM Revision 83ef23bd (git): Revert "Use IO#getch to read one char in raw mode"
This reverts commit 805b0a481132938638dbd32830cf5dca3910efb1. aycabta (aycabta .)
03:10 PM Revision e8fff0ec (git): Revert "Use IO#getbyte"
This reverts commit 685f12bbca50ff9b7a16b3016b3b8b3f2ac8b796. aycabta (aycabta .)
03:10 PM Revision 06bbacc0 (git): Revert "Support multibyte input"
This reverts commit 6d9e54816f828983bcf383ce6fce287bd3ca05b9. aycabta (aycabta .)
11:21 AM Revision 55650f71 (git): merge revision(s) 547887138f19959f649b1c0dbcde5659ae3878ed:
test/ruby/test_fiber.rb: reduce the count of object creation to cause
GC
The test consistently fail...
nagachika (Tomoyuki Chikanaga)
11:17 AM Revision 9899e669 (git): merge revision(s) b0b0ded5aa2cf7c4574b057d8326ed4e1c172c12:
webrick/test_utils.rb: loosen timeout severity
to stabilize CI failure like:
https://rubyci.org/logs...
nagachika (Tomoyuki Chikanaga)
10:48 AM Revision 7e0f56fb (git): Name dynamically defined methods with line numbers
nobu (Nobuyoshi Nakada)
08:20 AM Revision 5f5aca1b (git): Moved ruby_node_name declaration to node.h
nobu (Nobuyoshi Nakada)
07:24 AM Revision 2da6b328 (git): introduce IBF_(MAJOR|MINOR)_VERSION.
RubyVM::InstructionSequence.to_binary generates a bytecode binary
representation. To check compatibility with binary ...
ko1 (Koichi Sasada)
04:44 AM Revision 3c162df9 (git): Dump some information
znz (Kazuhiro NISHIYAMA)

09/12/2019

07:57 PM Misc #16157: What is the correct and *portable* way to do generic delegation?
Ok, I misunderstood what `pass_keywords` was doing; I thought it would only apply to `baz(*args)` in this case. Dan0042 (Daniel DeLorme)
03:40 PM Misc #16157: What is the correct and *portable* way to do generic delegation?
Dan0042 (Daniel DeLorme) wrote:
> After some more thinking I believe the `pass_keywords` behavior would be appropria...
jeremyevans0 (Jeremy Evans)
12:53 PM Misc #16157: What is the correct and *portable* way to do generic delegation?
After some more thinking I believe the `pass_keywords` behavior would be appropriate for 100% of methods with an argu... Dan0042 (Daniel DeLorme)
02:05 AM Misc #16157: What is the correct and *portable* way to do generic delegation?
> Then if you call `foo` with keywords, keywords will be passed to `bar`. This should allow for more backwards compa... Dan0042 (Daniel DeLorme)
03:35 PM Revision 69acf40b (git): * 2019-09-13 [ci skip]
git[bot]
03:34 PM Revision bcd49a46 (git): Upgrade benchmark_driver to v0.15.5
Fixed new Struct-related keyword argument warnings k0kubun (Takashi Kokubun)
11:19 AM Feature #14781 (Closed): Enumerator.generate
Applied in changeset commit:git|775037613bffe6f90e7af510b7f46a2ac10610be.
----------
Implement Enumerator.produce [F...
Anonymous
11:18 AM Revision ac3e8834 (git): Document and test Enumerator.produce
Co-authored-by: Victor Shepelev <[email protected]> Akinori MUSHA
11:18 AM Revision 77503761 (git): Implement Enumerator.produce [Feature #14781]
Akinori MUSHA
09:43 AM Bug #16161: tailcall_optimization may be disabled after r67315
How about adding `vm_call_iseq_setup_tailcall_opt_start` as same as `vm_call_iseq_setup_normal_opt_start`?
(Copy-and...
wanabe (_ wanabe)
09:28 AM Revision 9f86e5ec (git): Moved coverage.yml to https://github.com/ruby/actions [ci skip]
znz (Kazuhiro NISHIYAMA)
09:25 AM Feature #16102: `Symbol#call`
I propose this general solution.
diff --git a/array.c b/array.c
index 3717c3ff34..3809af01cf 100644
...
inopinatus (Joshua GOODALL)
06:47 AM Bug #16164: ENV.each with block returns ENV object itself, not Hash
I remember the old pickaxe having mentioned ENV as a hash-like
object. I guess the documentation could be updated to...
shevegen (Robert A. Heiler)
03:26 AM Bug #16164: ENV.each with block returns ENV object itself, not Hash
That is a documentation bug. sawa (Tsuyoshi Sawada)
01:04 AM Bug #16165: Endless ranges have inconsistency between #cover? and #include?
For the sake of archives & potential future search engine hits - this got fixed a few days ago and will be in whateve... adh1003 (Andrew Hodgkinson)

09/11/2019

11:41 PM Bug #16165 (Closed): Endless ranges have inconsistency between #cover? and #include?
Closing as per your request. Thank you for your investigation anyway. mame (Yusuke Endoh)
11:31 PM Bug #16165: Endless ranges have inconsistency between #cover? and #include?
Doh, this needs closing; my apologies. I had not realised that I was testing in an execution environment that had pul... adh1003 (Andrew Hodgkinson)
09:59 PM Bug #16165 (Closed): Endless ranges have inconsistency between #cover? and #include?
In an endless Range, I'd expect to be able to use `#include?` just as I do with a Range that has an end value. It wou... adh1003 (Andrew Hodgkinson)
11:20 PM Misc #16157: What is the correct and *portable* way to do generic delegation?
Dan0042 (Daniel DeLorme) wrote:
> Of course this is all *extremely* unconventional usage and doesn't really deserve ...
jeremyevans0 (Jeremy Evans)
09:25 PM Misc #16157: What is the correct and *portable* way to do generic delegation?
After discussion with some other committers, I have an alternative approach in https://github.com/ruby/ruby/pull/2449... jeremyevans0 (Jeremy Evans)
03:36 PM Misc #16157: What is the correct and *portable* way to do generic delegation?
> Prior to the keyword argument separation branch merge, it was not even possible for a C method to tell if it was ca... Dan0042 (Daniel DeLorme)
09:58 PM Revision 515b1989 (git): Make NODE_ARYPTN layout consistent between Ripper and AST
We are seeing SEGVs in CI:
http://ci.rvm.jp/results/trunk-gc-asserts@ruby-sky1/2253563
This is happening because ...
tenderlovemaking (Aaron Patterson)
09:30 PM Bug #16154: lib/delegate.rb issues keyword argument warnings
I added an alternative approach for handling delegate keyword warnings in https://github.com/ruby/ruby/pull/2449. Th... jeremyevans0 (Jeremy Evans)
09:24 PM Bug #16164 (Closed): ENV.each with block returns ENV object itself, not Hash
My code:
x = ENV.each { |name, value| }
puts "Return value class: #{x.class}"
puts "Return value is a Hash? #{x....
[email protected] (Burdette Lamar)
09:23 PM Revision 21994b7f (git): Avoid rehashing keys in transform_values
Previously, calling transform_values would call rb_hash_aset for each
key, needing to rehash it and look up its locat...
jhawthorn (John Hawthorn)
06:57 PM Revision 14e37310 (git): Make sure WB executes after object is reachable
tenderlovemaking (Aaron Patterson)
06:21 PM Revision 1febb6f4 (git): * 2019-09-12 [ci skip]
git[bot]
06:20 PM Revision ed96c9f2 (git): Emit missing keyword argument separation warnings for define_method
Previously, the warning functions skipped warning in these cases.
This removes the skipping, and uses a less descript...
jeremyevans (Jeremy Evans)
05:35 PM Bug #16159: rubyspec about time fails in Asia/Kuala_Lumpur timezone
Also, I ran it multiple times between 11pm - 1.30am jimmynguyc (Jimmy Ngu)
05:07 PM Bug #16159: rubyspec about time fails in Asia/Kuala_Lumpur timezone
GMT+8
```
$ date +%z
+0800
```
jimmynguyc (Jimmy Ngu)
03:59 PM Bug #16158: "st" Character Sequence In Regex Look-Behind Causes Illegal Pattern Error When Combined With POSIX Bracket Expressions And Case Insensitivity Flag
Thank you both.
I can confirm the encoding being a factor. It's an issue even if it is not the default.
```
...
michaeltomko (Michael Tomko)
01:28 PM Bug #16158 (Open): "st" Character Sequence In Regex Look-Behind Causes Illegal Pattern Error When Combined With POSIX Bracket Expressions And Case Insensitivity Flag
This appears to be an issue if the default encoding is UTF-8:
```
$ ruby -ve 'pat = /(?<!a st)\p{Space}/i'
ruby ...
jeremyevans0 (Jeremy Evans)
01:09 PM Bug #16158: "st" Character Sequence In Regex Look-Behind Causes Illegal Pattern Error When Combined With POSIX Bracket Expressions And Case Insensitivity Flag
I can reproduce the bug in all versions of ruby.
```
$ 2.5 ruby -ve 'pat = /(?<!a st)\p{Space}/i'
ruby 2.5.6p167...
Dan0042 (Daniel DeLorme)
03:03 PM Misc #16152: DevelopersMeeting20190919Japan
- [Feature #16131] Remove $SAFE, taint and trust
- What do you think about the proposed schedule?
- I am askin...
alanwu (Alan Wu)
02:48 PM Feature #14737: Split default gems into separate directory structure
I opened PR [1] implementing this.
[1]: https://github.com/rubygems/rubygems/pull/2909
vo.x (Vit Ondruch)
02:39 PM Revision fba5bbc6 (git): Moved doxygen.yml to https://github.com/ruby/actions [ci skip]
znz (Kazuhiro NISHIYAMA)
02:10 PM Feature #16146: Array .difference allow custom comparison
What you're asking for is a O(n²) operation. I'm not sure it's a good idea to make that so easy and transparent as a ... Dan0042 (Daniel DeLorme)
12:36 PM Revision fc3bfd52 (git): Fixed the function signature to rb_rescue2
nobu (Nobuyoshi Nakada)
09:03 AM Feature #16163 (Closed): Reduce the output of `RubyVM::InstructionSequence#to_binary`
## Abstract
The output of `RubyVM::InstructionSequence#to_binary` is extremely large.
We have reduced the output ...
NagayamaRyoga (Nagayama Ryoga)
07:27 AM Revision 343b0a28 (git): Made a short-circuit expression w/o result into an `if`-statement
nobu (Nobuyoshi Nakada)
07:01 AM Revision 655c65d6 (git): &$$->nd_lit is uninitialized at this point
See also https://travis-ci.org/ruby/ruby/jobs/583031687#L1874 shyouhei (Shyouhei Urabe)
06:25 AM Feature #10238: todo: remove dependency on malloc_usable_size
Bump. I would like to revisit this. Do we need this many call to malloc_usable_size()? shyouhei (Shyouhei Urabe)
12:35 AM Revision 489676bd (git): Add `--no-progress` to `aws s3` [ci skip]
https://docs.aws.amazon.com/cli/latest/reference/s3/sync.html
> --no-progress (boolean) File transfer progress is not...
znz (Kazuhiro NISHIYAMA)
12:03 AM Bug #9242: Rdoc detection of aliases
This is still an issue in the master branch. I've added a pull request for rdoc that will treat `rb_define_method` t... jeremyevans0 (Jeremy Evans)
 

Also available in: Atom