Activity
From 11/27/2019 to 12/03/2019
12/03/2019
-
11:59 PM Misc #16393: DevelopersMeeting20191220Japan
- * [Feature #14183] "Real" keyword argument (jeremyevans0)
* Is it OK to merge branch to remove deprecated support for positional hash <-> keyword conversion after 2.7 released?
* [Bug #11022] opening an eigenclass does not change the... -
12:04 PM Misc #16393: DevelopersMeeting20191220Japan
- **NOTE: Please follow the comment format strictly!**
I've created a script to automatically create an markdown-style agenda.
https://gist.github.com/mame/b0390509ce1491b43610b9ebb665eb86
We may ignore a comment that violates the... -
- * [Bug #6087] How should inherited methods deal with return values of their own subclass? (mame)
* Matz said "We will fix this (to consistently return Arrays) in 3.0." seven years ago. Now is the time. Final confirmation. -
- Carry over:
* [Feature #16264] Real "callable instance method" object. .:method to be a first-class thing, instead of Symbol#to_proc trick (zverok)
* This proposal would make sense only if .: would not be reverted (which, to the be... -
- Please comment on your favorite ticket numbers you want to ask to discuss with your *SHORT* comment or summary.
(your summary/comment will help us because we don't need to read all of the ticket comments)
*DO NOT* discuss then on thi... -
- Shortly after the release of 2.7.0, I would like to merge the branch at https://github.com/jeremyevans/ruby/tree/r3, which fully separates positional and keyword arguments. I've been maintaining this branch for a couple months now and u...
-
- I've written a draft of a note about this change in https://github.com/ruby/www.ruby-lang.org/pull/2293.
-
11:35 PM Bug #15629 (Closed): super_method fails on binded/unbinded/cloned methods
- Applied in changeset commit:git|a91637c516779d9ecee5f323e211f0ed71eb06ad.
----------
Make {Method,UnboundMethod}#super_method handle clone/bind/unbind
This wasn't working previously because the iclass entry wasn't
being copied, and wit... -
- This wasn't working previously because the iclass entry wasn't
being copied, and without an iclass entry, super_method returns
nil.
Fixes [Bug #15629] -
- Use `for` instead of `while` to make it explicit that it is a traverse
of bytecode. -
- mame (Yusuke Endoh) wrote:
> I think of some options to fix:
> ...
My idea for a hacky workaround: As the correct result is shown when branch coverage is enabled, always run with branch coverage enabled, even if the branch results will... -
- Oops, I overlooked this issue. Sorry.
This is a tough problem. The compiler produces the following code:
```
0006 branchunless 13
...
0013 jump 17 (Line 2)
...
0017 putnil (Line 3)
```
The peephole opt... -
10:05 PM Bug #15980: Coverage shows while/until after raise if/unless as uncovered line
- Hello. This thing affects both `return`, `break` and `raise` guard clauses. I want to insist on covering this issue with tests, `test_line_coverage_for_multiple_lines` is too weak. I will try to prepare tests.
Unfortunately this bug w... -
- As ipaddr has been moved to a gem, I have submitted a pull request for this: https://github.com/ruby/ipaddr/pull/22
-
- Hello. I was working on [ruby gem](https://github.com/andrew-aladev/ruby-zstds) and received a bug with [simplecov](https://github.com/colszowka/simplecov/issues/764). See the following [coverage report](https://codecov.io/gh/andrew-alad...
-
09:41 PM Feature #13083 (Closed): Regexp#{match,match?} with a nil argument are deprecated and will raise a TypeError in Ruby 3.0
- Applied in changeset commit:git|8852fa876039ed177fd5e867f36177d8a9ff411c.
----------
Revert "Regexp#match{?} with nil raises TypeError as String, Symbol (#1506)"
This reverts commit 2a22a6b2d8465934e75520a7fdcf522d50890caf.
Revert [Fea... -
01:34 PM Feature #13083: Regexp#{match,match?} with a nil argument are deprecated and will raise a TypeError in Ruby 3.0
- It's not my intention to suffer users. Let's cancel the change.
Matz.
-
- Eregon (Benoit Daloze) wrote:
> > I believe many of us have got used to the original behavior, that is, methods of a Regexp object work permissively and accept nil, and we know we've migrated many pieces of code from `/re/ =~ nilable` /... -
- This reverts commit 2a22a6b2d8465934e75520a7fdcf522d50890caf.
Revert [Feature #13083] -
- This reverts commit 452bee3ee8d68059fabd9b1c7a75661b14e3933e.
-
- This reverts commit 31110d820cc1258cbc84b46ecc65b254c7d5529a.
-
- This reverts commit 782d1b8fb0a039cedef9ad9c94f432dad51901e6.
-
- Applied in changeset commit:git|a029b54ec716812ade37fef1f857c49f821a8cc8.
----------
Make Enumerator::Chain#each treat lambdas as lambda
Previously, lambdas were converted to procs because of how
rb_block_call works. Switch to rb_func... -
- Previously, lambdas were converted to procs because of how
rb_block_call works. Switch to rb_funcall_with_block, which
handles procs as procs and lambdas as lambdas.
Fixes [Bug #15613] -
- I tried the process on Ubuntu, but I couldn't reproduce the issue. Maybe it is already fixed? Tentatively closing. Let me know if you still see the issue.
AFAIK there is no committer that daily uses `lldb` for ruby. Contribution i... -
- See #15460. `String#setbyte` has accepted not only 0..255 but also any integers. Once it had been limited only to 0..255, but it caused a compatibility issue, and eventually was reverted.
I don't think that this is a good idea in te... -
- This happens while loading the mysql2 gem:
```
/opt/chef/embedded/lib/libruby.so.2.3(sigsegv+0x3e) [0x7f4ad936d22e] signal.c:890
/lib/x86_64-linux-gnu/libc.so.6 [0x7f4ad8e58f20]
/lib/x86_64-linux-gnu/libc.so.6 [0x7f4ad8f83d76]
/op... -
10:51 AM Bug #16394: libmysqlclient20 5.7.28-0ubuntu0.18.04.4 causes segmentation fault
- duthmanek (Tim Dithmer) wrote:
> OS: Ubuntu 18.04
> ...
Gem Versions:
mysql (2.9.1)
mysql2 (0.5.2) -
- OS: Ubuntu 18.04
Update from libmysqlclient20 to 5.7.28-0ubuntu0.18.04.4 causes segmentation fault while using mysql- and mysql2-gem.
Stacktrace is in attached log -
- Applied in changeset commit:git|47c97e1e843159c3c4d57f8c5e22daea57c3ffe1.
----------
Do not lose existing constant visibility when autoloading
This copies the private/deprecate constant visibility across the
autoload. It still is back... -
- This copies the private/deprecate constant visibility across the
autoload. It still is backwards compatible with setting the
private/deprecate constant visibility in the autoloaded file.
However, if you explicitly set public constant in... -
- Applied in changeset commit:git|5c2c3966851ed074eb468ad36d8d75e53b8eab6c.
----------
Check interrupts before starting thread
Fixes a hang when Thread.new calls Thread.new in a loop.
Fixes [Bug #13688] - 03:27 PM Revision b96d559c (git): * 2019-12-04 [ci skip]
-
- Fixes a hang when Thread.new calls Thread.new in a loop.
Fixes [Bug #13688] -
- I think that this is not a bug, but a request for a feature to set HTTP headers for a proxy server instead of endpoint.
My survey:
* golang has a dedicated API, ProxyConnectHeader, to specify HTTP headers for a proxy server: https:... -
03:09 PM Bug #16265: Test (spec) failure using current MSYS2 tools, related to -fstack-protector and possibly D_FORTIFY_SOURCE=2
- PR https://github.com/ruby/ruby/pull/2718 shows this issue, and also properly updates MSYS2/MinGW gcc.
-
01:52 PM Misc #16360: Enabling IBM PowerPC/Z cases in Travis CI
- shyouhei (Shyouhei Urabe) wrote:
> Hello. It is definitely a good idea to enhance our CI. But that alone does not improve the code quality. We need someone to fix issues.
> ...
Hello. I agree with it.
Someone, do you have any ide... -
01:26 PM Bug #16395: .any? and .all? methods, flawed.
- > The dynamics of the script is simple, no explanations needed, look for yourselves:
I do not think that this can be a useful issue description because there may be
secondary aspect to consider for when requesting changes, including ... -
- @Hanmac is right.
```
ary = [1, 2, 3, 4, 5]
result = ary.any? {|n| p n; n == 3 } #=> 1, 2, 3
p result #=> true
result = ary.all? {|n| p n; n != 3 } #=> 1, 2, 3
p result #=> false
```
You may want to use `each` instead of ... -
12:10 PM Bug #16395: .any? and .all? methods, flawed.
- your problem is that `.any?` and `.all?` wants a value returned for the block which is truly or falsely
puts returns nil which is falsely, in the second example count += 1 returns an integer which is truly
EDIT: it looks like yo... -
12:01 PM Bug #16395 (Rejected): .any? and .all? methods, flawed.
- The dynamics of the script is simple, no explanations needed, look for yourselves:
``` ruby
# 100E1 312A3 8B64 282F C4A B28F
result = '99E2E403100E1A685A63312A308B6478282F2B2C4A34B28F7E'
virus = ['100E1',... -
- When I have a script at `D:\Downloads\Ruby 2.5.3\rbL\comp\codeShort.rb` with few other files in the same folder, the following searches only the folder where the `.rb` script is located:
``` ruby
Find.find('D:')
```
When I have a... -
10:50 AM Revision 7f2cd2ae (git): fix typo
-
- ```
$ ./miniruby -e 'def foo(kw: 1); end; h = {kw: 1}; foo(h)'
-e:1: warning: The last argument is used as the keyword parameter
-e:1: warning: for `foo' defined here; maybe ** should be added to the call?
``` -
- いまmacOSで試してみましたが、特に刺さるようなことはありませんでした。閉じておきます。
-
- Applied in changeset commit:git|409e4ab740de3852c3667217bcf41b55040f638f.
----------
tool/lib/test/unit/parallel.rb: fail explicitly when failing to get io
`(ulimit -n 30; make test-tool)` fails with unexplicit message:
"undefined meth... -
- `(ulimit -n 30; make test-tool)` fails with unexplicit message:
"undefined method `write' for nil:NilClass" due to lack of stdout.
This change makes it explicit. [Bug #5577] -
05:51 AM Revision e42d9d8d (git): Fixed the inverted condition
-
-
- I think I've proposed `Object#not` (and `Object#!`) for this purpose.
-
- IMO, `[1, 2].nullify(&:empty?)&.then(&:join)` is just cryptic.
BTW, why do you write `&.then(&:join)`? I'm afraid you have been corrupted by `&:sym`. -
- ruby-loco build failed, so ran the test locally using runner.rb. Failed on both of the below builds. The new test is valid, but the fix in 14a17063a1 doesn't seem to be working...
```
ruby 2.7.0dev (2019-12-02T23:51:50Z master 14a1... -
04:02 AM Revision 027e847c (git): Fix auto-indent behavior correctly
-
- Applied in changeset commit:git|14a17063a11a01d518b4bbaf0eb967330aec3984.
----------
Fixed stack overflow [Bug #16382]
Get rid of infinite recursion in expanding a load path to the real
path while loading a transcoder. -
-
- You need to parenthesize the argument 15.
```
foo unless (@bar&.nil? && @baz&.>(15))
```
I don't think that your expectation is wrong, but due to parser limitation, we cannot place a non-parenthesized method call as an argument o...
12/02/2019
-
- Get rid of infinite recursion in expanding a load path to the real
path while loading a transcoder. -
- Coverity Scan found this issue.
-
09:20 PM Feature #12928: Use socket conect_timeout in net stdlib for open_timeout
- It looks like we can now use the `resolv_timeout` `Socket.tcp` option that was recently added by https://bugs.ruby-lang.org/projects/ruby-trunk/repository/git/revisions/0e9d56f5e73ed2fd8e7c858fdea7b7d5b905bb64.
The only complication w... -
08:23 PM Revision 424ad9a4 (git): Make more attempts to check for the precision of Process.times
- * Process.clock_getres specs use 10_000 but that's quite slow for
the Process.times spec. -
06:33 PM Bug #16391 (Closed): Dir.pwd, Dir[] pathname case inconsistency
- Directory globbing case sensitivity is os-dependent
(https://ruby-doc.org/core-2.6.5/Dir.html, glob,
"Case sensitivity depends on your system");
On Windows 10, directory globbing is case insensitive,
and may return glob matches that ... - 04:41 PM Revision c688487f (git): * 2019-12-03 [ci skip]
-
- In the incremental search by C-r, search word is saved when it's determined. In
the next incremental search by C-r, if a user presses C-r again with the empty
search word, the determined previous search word is used to search. -
-
- This crash happens inside the pg gem. It's either caused by the pg gem, libpq (PostgreSQL), or one of the internal Mac OS libraries listed.
```
/usr/lib/system/libsystem_platform.dylib(_sigtramp+0x1d) [0x7fff6e865b1d]
/usr/lib/syste... -
04:21 PM Bug #16390 (Third Party's Issue): Crash report for ruby2.6.4p104
- Hello, Ruby 2.6.4 just crashed for me while using [the apartment gem](https://github.com/influitive/apartment) to switch postgres search paths in Rails.
Attached is the console output in `crash-console-output.txt`, as well as the cras... -
03:55 PM Feature #16166: Remove exceptional treatment of *foo when it is the sole block parameter
- Eregon (Benoit Daloze) wrote:
> The `*rest` parameter will not splat either, or it would delegate arguments incorrectly.
Thanks! Finally I can see some meaning behind the madness. Normally I would expect `proc{ |*a| }.call([1,2])` to... -
- This crash happens inside the pg gem. It's either caused by the pg gem, libpq (PostgreSQL), or one of the internal Mac OS libraries listed.
```
3 libsystem_platform.dylib 0x00007fff64d62b1d _sigtramp + 29
4 libdispatc... -
01:30 PM Bug #16385 (Third Party's Issue): Segmentation fault when running a rails app with puma
- got a new machine and after reinstalling a dev env, i cannot run locally a functional rails app
seems to be linked to puma since the app can be booted and the database can be accessed from the rails console.
If somebody more competen... -
- I'm not sure that this is a bug, or simply an unexpected result of operator precedence, but I am seeing a result that appears to me to be an issue.
When putting a conditional expression after a command call using `unless`, I am seeing... -
08:17 AM Revision a47d6c25 (git): Fix random failure on getusage-missing environments
- `* 1e6` makes a spurious result about floating point number's precision.
```
irb(main)[01:0]> 16.028
=> 16.028
irb(main)[02:0]> (16.028 * 1e6)
=> 16027999.999999998
``` -
07:25 AM Revision 1a88adcd (git): Fix Leaked file descriptor in test/did_you_mean
- https://github.com/ruby/ruby/commit/de74d2c3b0005048a2c4433bde68b9be10c86f01/checks?check_suite_id=336910877#step:19:131
```
Leaked file descriptor: NameErrorExtensionTest#test_correctable_error_objects_are_dumpable: 7 : #<File:test_name... -
-
- This reverts commit 2615030c521afc822c66a7e139ccba3d2365ab56,
which doesn't work when cross compiling, except for mingw. -
-
- It causes a link error due to some `__*_chk` functions on mingw.
-
- Otherwise, the written data to pty before the reading started may
be just lost. -
-
- On the 2.6 branch, this causes a declaration-after-statement warning.
12/01/2019
-
11:13 PM Feature #16255: Make `monitor.rb` built-in
- > The latest google-cloud-pubsub breaks too because new_cond comes before initialization:
Rails encountered the same issue(related to https://github.com/rails/rails/pull/37822).
The error and backtrace of in this case are as follow... -
- Could you share the error and backtrace in both of these cases?
-
08:35 AM Feature #16255: Make `monitor.rb` built-in
- The latest `google-cloud-pubsub` breaks too because `new_cond` comes before initialization: https://github.com/googleapis/google-cloud-ruby/blob/google-cloud-pubsub/v1.1.2/google-cloud-pubsub/lib/google/cloud/pubsub/async_publisher.rb#L9...
-
- This change breaks the library that extends `Monitor` class.
For example, Rails has such class and it breaks in Ruby 2.7.
https://github.com/rails/rails/blob/461aae05f194f775e6367be9add4dda37746bd5c/activesupport/lib/active_support/c... -
-
- to fix test failure on trunk-no-mjit
https://gist.github.com/ko1/32ab982ffd7555988818773c08f97123 -
- it fails like
https://ci.appveyor.com/project/ruby/ruby/builds/29235837/job/v0apdjj4qx8afars -
-
-
- Akatsuki reported ENV['TZ'] = 'UTC' improved 7x-8x faster on following code.
t = Time.now; 100000.times { Time.new(2019) }; Time.now - t
https://hackerslab.aktsk.jp/2019/12/01/141551
commit 4bc1669127(reduce tzset) dramatically improved... - 03:05 PM Revision 43811cc3 (git): * 2019-12-02 [ci skip]
-
-
-
-
-
-
- https://github.com/ruby/spec/commit/51047687c0
https://github.com/ruby/spec/commit/2b87b467cc -
-
11:13 AM Feature #9602: Logic with `Enumerable#grep`
- I agree with sawa's opinion. `Enumerable#grep` and other methods using `===` internally should accept more than one arguments, following `when` conditions.
Yukihiro Matsumoto wrote:
> We should use #select for more complex filtering... -
-
-
- https://ci.appveyor.com/project/ruby/ruby/builds/29230976/job/c910t37313edb97k
-
- to fix failure like https://github.com/ruby/ruby/runs/327745536
-
- This is a secret feature for me. It's only for testing and any behavior
with this flag override is unsupported.
I needed this because I sometimes want to add debug options but do not
want to disable optimizations, for using Linux perf. -
08:43 AM Feature #15563: #dig that throws an exception if a key doesn't exist
- matz (Yukihiro Matsumoto) wrote:
> I am against `dig!` for this purpose. When we have two versions of a method (`foo` and `foo!`), the bang version should be more dangerous than the non-bang version. `dig!` is not the case.
> ...
I thi... -
- One of the requests is a duplicate of an already rejected request.
-
07:58 AM Feature #16095: 2 Features: remove (simplify) 'new' keyword and Property Shorthand
- Please, do not mix requests for multiple unrelated features in one feature request. It makes it impossible to properly address them. For example, what should happen with this feature request if one feature gets accepted and one gets reje...
-
-
04:26 AM Revision 9914d6e9 (git): Relax test strictness for error message from KeyError
-
-
03:24 AM Revision 56faa13a (git): remove spaces to pass a test.
- 23d7f4c5e1ce164e78d77de694dccc0c41f6de3d breaks a test which expect
to match error message. To avoid this failure, use #strip for expect
and actual results. - 02:08 AM Revision 23d7f4c5 (git): * remove trailing spaces. [ci skip]
-
- This will slow down the time that the +require+ method takes to load DYM,
but this has caused a build failure in a certain situation:
https://ci.appveyor.com/project/ruby/ruby/builds/29214253/job/r9u9c8p95tnlftt3#L24965
which is repo... - 02:08 AM Revision 171803d5 (git): Promote did_you_mean to default gem
- At the moment, there are some problems with regard to bundler + did_you_mean because of did_you_mean being a bundled gem. Since the vendored version of thor inside bundler and ruby itself explicitly requires did_you_mean, it can become d...
11/30/2019
-
11:23 PM Revision a2fc6a51 (git): [ruby/fileutils] Fix test failure under ruby 2.4
- `Exception#full_message` is only defined on ruby 2.5.0 and above.
https://github.com/ruby/fileutils/commit/a8968f41ed -
- `exception_details` is not defined anywhere.
This commit fixes the following test crash in ruby 2.4
```
Error: test_assert_output_lines(TestFileUtils): NoMethodError: undefined method `exception_details' for #<TestFileUtils:0x00005556e... -
- 1243255c3a36433041012b6107a5ac48658a0895 broke ci.rvm.jp tests like
http://ci.rvm.jp/results/trunk_clang_39@silicon-docker/2445098.
253232c028a5565dbeecc05fab5e81b35ab58bcc works only if getrusage is supported. -
-
-
- @nobu Thanks for the change! I'll adapt the specs.
-
- Applied in changeset commit:git|5e0479f26afe1505afd9014ea96a206a88845828.
----------
ENV.update should not call block on existing keys
[Bug #16192] -
- This is a clear bug, I'll merge @nobu's patch.
There are already specs for this from https://github.com/ruby/spec/pull/714, which I'll synchronize to MRI soon. - 05:18 PM Revision 93a51241 (git): * 2019-12-01 [ci skip]
-
- [Bug #16192]
-
- jeremyevans0 (Jeremy Evans) wrote:
> In regards to `pass_keywords`, this wouldn't even be a backport, this would be a brand new feature, as `pass_keywords` isn't implemented in the master branch.
It would be a new method in Ruby 2.7,... -
- I'm against backporting features (not just this particular feature) to already released ruby versions. For one, not everyone runs on the latest tiny release, and having different feature sets in tiny versions is likely to lead to user c...
-
09:27 AM Feature #16131: Remove $SAFE, taint and trust
- I released the new versions: fileutils, webrick, date, dbm, etc, gdbm, stringio, zlib.
@kou rexml, rss, fiddle, strscan
@nobu io-console
Can you release the new versions contained to drop taint support? and Can you import upstrea... -
- https://github.com/ruby/zlib/commit/5af77c1ee8
-
- https://github.com/ruby/gdbm/commit/ffb2b063a3
-
- https://github.com/ruby/etc/commit/78987ce56a
-
- https://github.com/ruby/fileutils/commit/da15e3ce06
-
- https://github.com/ruby/dbm/commit/163078359d
-
- This reverts commit eab88d20eaa925d5e61a2a65820a099b46ccf3f8.
The some CI was broken with this. -
- https://github.com/ruby/webrick/commit/79d7922de9
-
- Patch from Leonard Garvey.
Fixes Ruby Bug 9986.
https://github.com/ruby/webrick/commit/8cff7f3995 -
- https://github.com/ruby/webrick/commit/c5635fa5e2
-
- This way you don't need to escape each entry.
Implements Ruby Feature 15170.
https://github.com/ruby/webrick/commit/d8086e600c -
08:47 AM Revision f7cf5416 (git): [ruby/webrick] Document HTTPResponse#body callable option
- https://github.com/ruby/webrick/commit/d51836d03d
-
- https://github.com/ruby/fileutils/commit/f92145b10b
-
-
- `FileUtils#install` methed raises an unexpected `TypeError`, when
called with `mode:` option which has `"X"`.
```
$ ruby -rfileutils -e 'FileUtils.install("tmp/a", "tmp/b", mode: "o+X")'
/opt/local/lib/ruby/2.7.0/fileutils.rb:942:in `di... -
- https://github.com/ruby/fileutils/commit/bb10efe104
-
- Loading separate version.rb unnecessary increases every start-up
time. In the other hand, the gemspec file is parsed only when
building the gem file.
https://github.com/ruby/fileutils/commit/8359cf7cce -
-
- (windows.yml used `nmake up`)
-
-
- https://github.com/ruby/readline-ext/commit/e5b969215a
-
-
- Due to `each_builtin` existing only in miniruby, Ruby 2.7 cannot be built when configured for cross-compilation.
## Environment
```
$ ruby -v
ruby 2.7.0preview3 (2019-11-23 master b563439274) [x86_64-linux]
$ lsb_release -a
No ... -
- https://github.com/ruby/forwardable/commit/e56f0f83c6
-
- Do so in a way that is also compatible with previous versions.
https://github.com/ruby/forwardable/commit/b2dd340988 -
- https://github.com/ruby/stringio/commit/4c1e267e1a
-
- https://github.com/ruby/stringio/commit/1fed3aacd3
-
- https://github.com/ruby/date/commit/202b2dad93
-
-
- The meeting has been already ended. I'll create a new ticket DevelopersMeeting20191220Japan later.
-
03:17 AM Bug #16383 (Closed): TracePoint does not report calls to attribute reader methods
- TracePoint does not report calls to attribute reader methods (e.g. methods defined using `attr_accessor` or `attr_reader`.)
**Code sample to demonstrate:**
```ruby
class Person
attr_accessor :first_name
attr_accessor :last_n... -
- 2.6.5 seems to be working fine:
```
~/GitHub/ruby/did_you_mean/テスト$ ruby -v
ruby 2.6.5p114 (2019-10-01 revision 67812) [x86_64-darwin18]
~/GitHub/ruby/did_you_mean/テスト$ echo "puts 'ok'" > a.rb
~/GitHub/ruby/did_you_mean/テスト$ LC_AL... -
- ## Steps to reproduce
```
~/GitHub/ruby/did_you_mean/テスト$ LC_ALL="C" RUBYLIB=".:" ruby -E cp932:utf-8 aaa.rb
Traceback (most recent call last):
2: from <internal:gem_prelude>:5:in `<internal:gem_prelude>'
1: from /Users/yuki/.rb... -
- "IRB::InputMethod#eof?" requires eof status each user input but
"ReidlineInputMethod#eof?" used "Reline.eof?" what is singleton data.
"ReidlineInputMethod#eof?" is changed to use the result of user input.
11/29/2019
-
-
-
-
-
-
-
-
-
-
-
-
- This issue was exposed by recent commits to better support including
refined modules. -
04:38 PM Feature #16381: Accept resolv_timeout in Net::HTTP
- On second thought, I'm not thrilled about adding a new config option like this.
I think name resolution is logically part of opening a socket, so I would expect a `Net::OpenTimeout` if name resolution takes longer than the specified amo... -
01:33 PM Feature #16381 (Open): Accept resolv_timeout in Net::HTTP
- This is a follow-up to https://bugs.ruby-lang.org/issues/15553 and a successor of https://github.com/ruby/ruby/pull/1806 (the credit to Carl Hörberg).
Unlike https://github.com/ruby/ruby/pull/1806, this patch introduces a separate `re... - 03:21 PM Revision 8a1f313e (git): * 2019-11-30 [ci skip]
-
- Instead of returning `nil`, raise a syntax error if its value is
used. [Feature #16355] -
- I introduce general solution.
Notes:
* there are no "(1..).count" test. can anyone write it?
* My fix can introduce additional problems because it increases interrupt points. Please report us if you find a problem on your app.
* ... -
- Applied in changeset commit:git|36da0b3da1aed77e0dffb3f54038f01ff574972b.
----------
check interrupts at each frame pop timing.
Asynchronous events such as signal trap, finalization timing,
thread switching and so on are managed by "in... -
- Asynchronous events such as signal trap, finalization timing,
thread switching and so on are managed by "interrupt_flag".
Ruby's threads check this flag periodically and if a thread
does not check this flag, above events doesn't happen.
... -
- This reverts commit 5e275dd2af4d9d24cdb1cfc0f232f348dae9c2cd.
...The @1 type numberd parameter is reverted from Ruby syntax. -
- for https://github.com/ruby/ruby/security/policy
-
- Applied in changeset commit:git|191ce5344ec42c91571f8f47c85be9138262b1c7.
----------
Reduce duplicated warnings for the change of Ruby 3 keyword arguments
By this change, the following code prints only one warning.
```
def foo(**opt);... -
- Matz accepted this with #16345. I'll commit it soon.
-
- By this change, the following code prints only one warning.
```
def foo(**opt); end
100.times { foo({kw:1}) }
```
A global variable `st_table *caller_to_callees` is a map from caller to
a set of callee methods. It remembers that a war... -
- Applied in changeset commit:git|3a87826d0c3dd4c42e327e0cd4fb0806d898497f.
----------
vm_method.c: add top-level ruby2_keywords
This is a top-level version of Module#ruby2_keywords.
It can be used for functions (top-level methods) that ... -
- This is a top-level version of Module#ruby2_keywords.
It can be used for functions (top-level methods) that delegates
arguments. [Feature #16364] -
-
- `JSONGeneratorTest#test_remove_const_seg` is meaningful only for
the extension library version, but nonsense for pure ruby version. -
- [ci skip]
-
-
01:46 AM Feature #16345: Don't emit deprecation warnings by default.
- Matz,
We already have `RUBYOPT=-W0` so no change is needed here for a global suppression. Maybe add `RUBYOPT=--no-deprecation` or something like that.
The question is about the default here:
1. Should default be "warn once pe... -
11/28/2019
-
- This error occurs in Oracle Instant Client:
```
/usr/lib/system/libsystem_platform.dylib(_sigtramp+0x1d) [0x7fff6968cb1d]
/Users/rok/instantclient_18_1/libclntshcore.dylib.18.1(sltsqKeyDestructorInt+0x68) [0x1065864b8]
/Users/rok/i... -
- I don't see anything obvious in the crash logs.
As a shot in the dark, could you ask the people that have these troubles to run `gem pristine $gem_name` on all the gems they use? `gem pristine --all` works too, but might take longer.
I... -
05:09 PM Bug #16380 (Third Party's Issue): OSX Segmentation fault at 0x0000000106e67698 / illegal hardware instruction rake install_latest
- Since a while we have across our team 4 or 5 developers who run often into "Segmentation fault" on OSX machines when running a rake script.
Problem:
We start the rake task and sometimes it stops with a **Segmentation fault**.
Envi... -
-
- This reverts commit 2e6f1cf8b264f4c8499c4e5f18bf662fdade04ff.
-
- This reverts commit 27d0d7c0d39076d4bbacd3c3f3864322699db7b4.
- 06:18 PM Revision 27d0d7c0 (git): * remove trailing spaces. [ci skip]
-
- 06:11 PM Revision e5705c35 (git): * 2019-11-29 [ci skip]
- 06:11 PM Revision d104ebf2 (git): * remove trailing spaces. [ci skip]
-
- vm_getivar() provides fastpath for T_OBJECT by caching an index
of ivar. This patch also provides fastpath for FL_EXIVAR objects.
FL_EXIVAR objects have an each ivar array and index can be cached
as T_OBJECT. To access this ivar array, g... -
- duerst (Martin Dürst) wrote:
> I personally think that we should be restrictive in adding new methods to `Symbol`. Otherwise, this very quickly becomes a slippery slope, and the distinction between `Symbol` and `String` becomes less and... -
- Applied in changeset commit:git|b5fbefbf2c14742f6d46ecdf3ce712062dfb1d0a.
----------
Added Symbol#start_with? and Symbol#end_with? method. [Feature #16348] -
- there is also `symbol[string]` which can be used as replace for Symbol#include?
-
- I am OK with adding `start_with?` and `end_with?`.
I am a bit reluctant with adding `include?` since Symbol does not include any character. Persuade me further if you really need `Symbol#include?`.
Matz.
-
-
-
-
-
-
- Applied in changeset commit:git|a0579f3606561a74e323f6193b9504c06845236c.
----------
Make prepending a refined module after inclusion not break refinements
After the previous commit, this was still broken. The reason it
was broken is t... -
- Applied in changeset commit:git|5069c5f5214ce68df8b3954321ad9114c5368dc3.
----------
Honor refinements for modules that prepend other modules
This previously did not work, and the reason it did not work is
that:
1) Refining a module o... -
- After the previous commit, this was still broken. The reason it
was broken is that a refined module that hasn't been prepended to
yet keeps the refined methods in the module's method table. When
prepending, the module's method table is m... -
- This previously did not work, and the reason it did not work is
that:
1) Refining a module or class that prepends other modules places
the refinements in the class itself and not the origin iclass.
2) Inclusion of a module that prep... -
- matz (Yukihiro Matsumoto) wrote:
> I know trailing `...` can be very useful from C experience. But the primary purpose of Ruby `...` is method delegation. We are not going to extend the role of `...` in the language (at least for now).
... -
- I know trailing `...` can be very useful from C experience. But the primary purpose of Ruby `...` is method delegation. We are not going to extend the role of `...` in the language (at least for now).
Matz.
-
- * [Feature #16379] Backporting ... to Ruby 2.4 - 2.6 and pass_keywords (eregon)
* I'd like to have the opinion of the core team on this. -
06:40 AM Misc #16262: DevelopersMeeting20191128Japan
- * [Feature #16377] Regexp literals should be frozen (byroot)
* Previous discussion in [Feature #16345]
* Regexp literals always return the same mutable object, it can cause state to leak. -
- I've heard quite a few people saying that backporting `...` to Ruby 2.4-2.6 would be a good way to do migration for keyword arguments.
In fact, if we have `...` in Ruby 2.4+, I think `...` could be the way to do 90%+ of delegation in a ... -
- I like the idea of helpers in https://bugs.ruby-lang.org/issues/16122#note-18.
We need to discuss further the combination of attributes (immutable, enumerable, etc.)
Matz.
-
- * The name `zip_with` is too confusing with `zip`. We need a new name.
* The behavior can be described by the combination of `zip` and `map`.
* I am not sure how much we need this behavior (yet).
Matz.
-
- As far as I understand, the code with the proposal `[1, 2, 3].zip([4, 5, 6]).each_tuple.map(&:+)` can be written as following with numbered parameters:
```ruby
[1, 2, 3].zip([4, 5, 6]).map{_1 + _2}
```
which is quite plain and sh... -
06:24 AM Feature #16261: Enumerable#each_splat and Enumerator#splat
- I agree this feature would be a nice addition.
Actually I had exactly the same idea, presented at Rails Developer Meetup 2019: https://www.slideshare.net/akinorimushaevolution-of-enumerator (Japanese)
There's a subtle difference be... -
- Note: this is not a final decision:
* Having a method to retrieve the endpoint of a method/proc is OK for me.
* The name of the method should **not** be `code_range`, because the name is confusing.
* Making the return value as a speci... -
04:46 AM Feature #16142: Implement code_range in Proc and Method
- > Maybe we could change #source_location to return a `SourceLocation` and have `SourceLocation#to_a` so `file, line = proc.source_location` would still work?
I've spent some time thinking about this.
I wanted to understand why we h... -
- Accepted. Go ahead.
Matz.
-
- Apparently it's a duplicate of https://bugs.ruby-lang.org/issues/8948
-
-
- `Enumerable#count` should aware of interrupts. Besides this case, `#count` should return `Infinity` (we may need to define `Range#count`).
Matz.
-
- IRB completion logic always needed exponential notation for complex literal
such as 3e6i but it's bug. I fixed to support complex literal without
exponential notation such as 3i. -
- By default, it should emit (deprecation) warnings. It's a good idea to have an environment variable option to suppress deprecation warnings.
Matz.
-
- https://github.com/ruby/ruby/pull/2708
-
- Applied in changeset commit:git|8b4ee5d6ba92a385eedc9235ce0a2d5618deecf0.
----------
Raise `NoMatchingPatternError` when expr `in` pat doesn't match
* `expr in pattern` should raise `NoMatchingError` when unmatched
* `expr in pattern` ... -
- I accept this proposal for two reasons:
* as OP described, returning boolean values from `in` pattern matching masks match failure. This can cause serious problems.
* By this change, we cannot use `in` pattern matching in `if` conditio... -
- * `expr in pattern` should raise `NoMatchingError` when unmatched
* `expr in pattern` should return `nil`. (this is unspecified, but
this feature is experimental, at all)
[Feature #16355] -
- Since https://github.com/ruby/ruby/pull/2576,
`new_cond` uses the Monitor object, not the receiver. -
- It seems OK as the original proposal is same as the current behavior.
-
- Accepted.
Matz.
-
-
11/27/2019
-
- The above also shows we should avoid multiple calls to rb_warn* for a single logical warning.
E.g., `warning: The last argument is used as the keyword parameter` and `warning: for method defined here` should be part of a single (multi-l... -
- It's actually only 130 unique warnings:
```
$ wc -l run.txt
2439 run.txt
$ grep -v 'Setting up parallel test mode - starting' run.txt > run2.txt
$ wc -l run2.txt
2408 run2.txt
$ cat run2.txt | sort | uniq | wc -l
130
```
This ... -
- I tried Jeremy's patch results are here of running Discourse `bin/turbo_rspec` it runs our test suite using 16 threads on my computer.
2440 warning for every test run, suffice to say at Discourse we will absolutely turn warnings of... -
10:54 PM Feature #16345: Don't emit deprecation warnings by default.
- jeremyevans0 (Jeremy Evans) wrote:
> > However there are several situations that
> ...
Of course, we can enable deprecation warnings for
pry and other test libraries.
-
- sam.saffron (Sam Saffron) wrote:
> Even with @Eregon's proposed patch running our test suite with warnings is unusable cause of pages of:
Do you mean @mame's PR from #16289, that is https://github.com/ruby/ruby/pull/2458 ?
Could ... -
- sam.saffron (Sam Saffron) wrote:
> I agree 100% with akr here.
> ...
Note that the vast majority of the warnings listed are not keyword argument separation warnings, they are safe level and String#match? warnings. I think the patch yo... -
- When we consider the default verbosity of warnings, we should care about the "audience" of the warnings.
In the previous developers' meeting, the default warnings should target server operators (such as a SRE team) as a primary audien... -
- I agree 100% with akr here.
Even with @Eregon's proposed patch running our test suite with warnings is unusable cause of pages of:
```
/home/sam/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/ffi-1.10.0/lib/ffi/pointer.rb:97:... -
-
-
-
- https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners#windows-server-2016
> Note: The Windows Server 2016 virtual environment will be removed on December 3, 2019. -
- I think we should just return true for `lambda?`.
Proc has extra confusing behavior, e.g., #16166. - 06:03 PM Revision cdcaf041 (git): * 2019-11-28 [ci skip]
-
- Previously, the rest array was modified, but it turns out that is
not necessary. Not modifying the rest array fixes cases when the
rest array is used more than once. -
- @sawa wrote this in the dev-meeting ticket:
> Unintended arity. This must be fixed in an earlier stage before Ruby 3.
I think matz conclusion is all behavior shown in this bug so far is intended, except for `*foo, **bar`.
@Dan0042... -
- Maybe we could change #source_location to return a `SourceLocation` and have `SourceLocation#to_a` so `file, line = proc.source_location` would still work?
-
- Also I believe `...` could be a good way to do delegation in all versions for lexical cases (the majority):
```ruby
# Could be some constant in a gem
ARGS = RUBY_VERSION < "2.7" ? "*args, &block" : "..."
class_eval <<RUBY
def meth... -
- I think this is very important, otherwise `...` can be used only very rarely.
For instance, `method_missing` typically want to access the method name like:
```ruby
def method_missing(name, ...)
if name.to_s.end_with?('?')
se... -
- I filed #16378 for supporting leading arguments with `...`.
-
- @mame's measurements:
```ruby
def req(x)
x
end
hash = {a: 1}
arr = [hash]
100000000.times { req(*arr) }
```
gives
```
$ time ./miniruby.check bench.rb
real 0m5.726s
user 0m5.689s
sys 0m0.025s
$ time ./miniruby.nocheck b... -
- Eregon (Benoit Daloze) wrote:
> jeremyevans0 (Jeremy Evans) wrote:
> ...
After discussion with you and @mame , it appears my benchmarking was flawed and the performance difference is closer to your measurements.
> Your original diff... -
- jeremyevans0 (Jeremy Evans) wrote:
> Do all non-`ruby2_keywords` tests still pass with that? If so, what are the benchmark results with the patch?
Yes, all specs pass and test-all has just 2 expected failures:
```
1) Failure:
T... -
- jeremyevans0 (Jeremy Evans) wrote:
> There are a ton of other changes in 2.7 that could affect performance besides `ruby2_keywords`.
Any specific guess?
> ...
Your original diff kept quite a lot more complicated code in `setup_par... -
- Eregon (Benoit Daloze) wrote:
> https://github.com/ruby/ruby/compare/master...eregon:no-ruby2_keywords is a more extensive removal of `ruby2_keywords`, although not complete yet.
> ...
With that change applied I could see a slowdown of... -
04:10 PM Feature #16375: Right size regular expression compile buffers for literal regexes and on Regexp#freeze
- shevegen (Robert A. Heiler) wrote:
> > Would any further incremental work towards this be considered worthwhile from a
> ...
Yes this isn't focused on speed, but more so on being careful with auxiliary memory buffers and inferring wher... -
- > Would any further incremental work towards this be considered worthwhile from a
> ...
I can not answer for the ruby-core team, or anyone else, but matz has the motto of
3x3 for ruby 3.0 which is destined for next year.
Some time a... -
- References PR https://github.com/ruby/ruby/pull/2696
As a continuation of [type specific resize on freeze implementations of String and Array](https://bugs.ruby-lang.org/issues/16291) and looking into the `Regexp` type I found these m... -
- Attached is a patch that adds `Zlib::GzipReader.each_file` will which handle multiple concatenated gzip streams in the same file, similar to common tools that operate on `.gz` files. `Zlib::GzipReader.each_file` yields one `Zlib::GzipRe...
-
- I'm in favor of adding top level `ruby2_keywords`.
-
- Makes sense to me, and agreed it's going to be a lot less confusing with it.
I'm not particularly for `ruby2_keywords` in general, but if we have `Module#ruby2_keywords` then I agree `main.ruby2_keywords` makes sense. -
- Extending pattern variables to non-local variables would make pattern-matching more complex and confusing. I reject the idea (at least for now). There might be a chance to make pinned variables (`^a`) to pinned expression in the future.
... -
05:15 AM Feature #16372: Allow pattern matching to bind instance variables
- shevegen (Robert A. Heiler) wrote:
> If I understood you correctly then the suggestion is to allow both local and
> ...
Yes, correct. And people might want to use @@variables and $variables too (I rarely use them, though) . -
- We have discussed about in-line pattern matching and made a decision that it should cause an exception instead of returning false. So this issue will disappear.
We might need to talk about the precedence for e.g. `a = n in 99 rescue n... -
- Ugh, forgot one
* [Misc #16260] Symbol#to_proc behaves like lambda, but doesn't aknowledge it *(the title says it all)* -
- * [Feature #15605] json library needs more frequent releases
* Should we bump the json version to 2.2.1? -
- * [Misc #16375] Right size regular expression compile buffers for literal regexes and on Regexp#freeze (lourens)
* Builds on Misc #16291 , I think there's potential to apply this pattern to other types at hooks outlined at the end of ... -
12:38 PM Revision 6f27fa4f (git): prefer class_serial over m_tbl
- Decades ago, among all the data that a class has, its method
table was no doubt the most frequently accessed data. Previous
data structures were based on that assumption.
Today that is no longer true. The most frequently accessed fiel... -
- I submit the backport changes from ruby core to flori/json at https://github.com/flori/json/pull/388
We need to bump version to ruby repository like 2.2.1 because the same version of flori/json and ruby core confuse ruby users.
I h... -
- The following script:
```ruby
def mutate
re = /foo/
state = re.instance_variable_get(:@state)
re.instance_variable_set(:@state, state.to_i + 1)
state
end
3.times do
p mutate
end
```
Output this:
```
nil
1... -
05:32 AM Feature #16373: RDoc for some of the Kernel methods cannot be found in Kernel module
- I'd like to share the context. `ri` is not the true problem to me.
I'm working to import the RDoc documentation to RBS files. (https://github.com/ruby/ruby-signature/pull/84) I believe having documentations in RBS makes sense, at leas... -
03:47 AM Bug #16376 (Closed): Stack-buffer-overflow in renumber_by_map in regcomp.c
- I found this bug in ruby regex engine. I also reported this issue to Onigmo(https://github.com/k-takata/Onigmo/issues/144).
I reported this to [email protected], but there has been no reply for more than 2 weeks. So I decide to rep... -
- matz, the following is the current behaviors. Do you mean which should be fixed?
(1) 2.7, via variable
```
b = {"b" => "b"}; p({x: "x", **b}) #=> current behavior: {:x=>"x", "b"=>"b"}
```
(2) 2.6, via variable
```
b = {"b... -
- I think this inconsistency is a bug. Double splat in hash expressions needs to work as interpolation.
Matz.