Project

General

Profile

Activity

From 01/18/2021 to 01/24/2021

01/24/2021

10:52 PM Bug #17527: rb_io_wait_readable/writable with scheduler don't check errno
I checked the PR, I understand, thanks for the clear bug report.
I will review it in more detail, but it seems lik...
ioquatix (Samuel Williams)
07:58 PM Feature #17576: Partial Functions (procs, lambdas)
Kinda reminded me of Elixir's [guards] (https://hexdocs.pm/elixir/guards.html). matheusrich (Matheus Richard)
07:03 PM Bug #17577 (Closed): Segfault when sending some Exceptions to a Ractor
The following segfaults:
```ruby
r = Ractor.new { receive }
begin
foo # => raises a NoMethodError
rescue Ex...
marcandre (Marc-Andre Lafortune)
02:26 PM Revision 30f11e73 (git): Revert "Remove temporary directory properly"
This reverts commit 80bad36989bbc4ad6167fe9670327f95b78089ce,
because a few CI machines fail continuously.
nobu (Nobuyoshi Nakada)
10:30 AM Revision 80bad369 (git): Remove temporary directory properly
For each `make check`, rubygems test makes "tmp" directory and
some "gem_generate_index..." directories remain there....
nobu (Nobuyoshi Nakada)
09:34 AM Revision db80be3d (git): * 2021-01-24 [ci skip]
git[bot]
09:33 AM Revision 9aea4387 (git): Add 3.0 top sepc guards
* Needs WEBrick nobu (Nobuyoshi Nakada)
09:33 AM Revision 21340303 (git): Fix compile error of sockssocket
The patch is provided by PhobosK (Phobos Kappa).
This should be backported to Ruby 3.0.
[Feature #17187]
Glass_saga (Masaki Matsushita)
09:33 AM Revision 1ce4e90d (git): Remove check branch from ruby_3_0
naruse (Yui NARUSE)
09:31 AM Feature #17330: Object#non
@nobu
> This seems readable enough and more flexible.
```ruby
return Faraday.get(url).then {_1.body if _1.succ...
zverok (Victor Shepelev)
02:42 AM Feature #17330: Object#non
zverok (Victor Shepelev) wrote in #note-8:
> ```ruby
> return Faraday.get(url).when(&:successful?)
> # Note how li...
nobu (Nobuyoshi Nakada)
07:46 AM Revision 52ebaf71 (git): [ruby/rdoc] Skip non-date logs by git-log
`RDoc::Parser::ChangeLog` mis-parses ChangeLog generated by
git-log, because of too heuristic `Time.parse`.
For inst...
nobu (Nobuyoshi Nakada)
07:46 AM Revision d5d1c417 (git): [ruby/rdoc] Sort by CommitDate if available
https://github.com/ruby/rdoc/commit/455715e930 nobu (Nobuyoshi Nakada)
07:46 AM Revision fa048a0f (git): [ruby/rdoc] Add links to the commits
https://github.com/ruby/rdoc/commit/1821628076 nobu (Nobuyoshi Nakada)
07:46 AM Revision f3f1a666 (git): [ruby/rdoc] Shorten commit hashes
https://github.com/ruby/rdoc/commit/5d3e153963 nobu (Nobuyoshi Nakada)
07:46 AM Revision 127f735c (git): [ruby/rdoc] Tweak log entry markdown
* add 3 levels to headings
* prefix commit log to labels to make unique IDs
https://github.com/ruby/rdoc/commit/5074...
nobu (Nobuyoshi Nakada)
07:46 AM Revision b88d1e6b (git): [ruby/rdoc] Make each commit entries h3
https://github.com/ruby/rdoc/commit/11eefb2ae9 nobu (Nobuyoshi Nakada)
07:46 AM Revision bb570ce6 (git): [ruby/rdoc] Support ChangeLog generated by `git log`
https://github.com/ruby/rdoc/commit/5e0a123ca1 nobu (Nobuyoshi Nakada)
07:46 AM Revision 68e7dc53 (git): [ruby/rdoc] Fix failing test by adding gettext as a development dependency
The failing test was:
========================================================================================
rdoc/...
Dorian Marié
07:12 AM Feature #13750: Improve String#casecmp? and Symbol#casecmp? performance with ASCII string
When you avoid that case, you have a option around coderange: coderange is a cached information whether the string co... naruse (Yui NARUSE)
06:57 AM Revision 1bd27a78 (git): Add test for String#casecmp?
String#casecmp? also normalize upper case characters in legacy encodings. naruse (Yui NARUSE)
05:59 AM Revision d6e43e47 (git): Moved --verbose, --verbose and --help options to last [ci skip]
nobu (Nobuyoshi Nakada)
05:35 AM Revision 38816887 (git): * 2021-01-24 [ci skip]
git[bot]
05:35 AM Revision 743c44ee (git): [ruby/irb] Indent correctly with method calling with receiver
https://github.com/ruby/irb/commit/e7c68e74a0 aycabta (aycabta .)
05:35 AM Revision fc54af8a (git): [ruby/irb] Indent correctly with keyword "for" and "in"
https://github.com/ruby/irb/commit/47c83ea724 aycabta (aycabta .)

01/23/2021

04:41 PM Feature #17330: Object#non
@matz Thinking a bit more about it, what I frequently lack is a "singular reject": "drop this value if it doesn't mat... zverok (Victor Shepelev)
04:15 PM Feature #16978: Ruby should not use realpath for __FILE__
Eregon (Benoit Daloze) wrote in #note-10:
> vo.x (Vit Ondruch) wrote in #note-7:
> > In Fedora, to avoid duplication,...
vo.x (Vit Ondruch)
10:31 AM Feature #16978: Ruby should not use realpath for __FILE__
vo.x (Vit Ondruch) wrote in #note-7:
> In Fedora, to avoid duplication, we have openssl gem extracted into independe...
Eregon (Benoit Daloze)
02:38 AM Feature #16978: Ruby should not use realpath for __FILE__
Interestingly, ruby does _not_ use realpath for `__FILE__`, only for `__dir__` and `require_relative`
```
$ cat t...
Dan0042 (Daniel DeLorme)
02:52 PM Feature #17576: Partial Functions (procs, lambdas)
Is there any real-world use-case? I don't see any of them.
Besides that, proposed syntax does not work well with nor...
matz (Yukihiro Matsumoto)
11:23 AM Feature #17576 (Open): Partial Functions (procs, lambdas)
We already have pattern matching and functions. Let's combine them and introduce a "partial procs" as first-class cit... temabolshakov (Tema Bolshakov)
12:31 PM Bug #17534 (Closed): Pattern-matching is broken with find pattern
@palkan:
Thanks to fix!
@naruse:
Could you backport 1b89b99941548fdb65305dd9a412082e7fdba45a to 3.0?
ktsj (Kazuki Tsujimoto)
12:06 PM Revision 8cb999dd (git): Update power_assert to 2.0.0
ktsj (Kazuki Tsujimoto)
11:56 AM Revision 4de228b6 (git): Sort autogenerated dependencies [ci skip]
nobu (Nobuyoshi Nakada)
11:54 AM Feature #17472: HashWithIndifferentAccess like Hash extension
hcatlin (Hampton Catlin) wrote in #note-15:
> Would anyone here think the code below was acceptable?
Mixing symbo...
timcraft (Tim Craft)
11:03 AM Bug #17575 (Closed): deprecated style `respond_to?` warning with `-W:no-deprecated`
Applied in changeset commit:git|8dfae85adb96cf3da84bf38f2103969d4a7aed3f.
----------
Warn the defined location as de...
nobu (Nobuyoshi Nakada)
10:56 AM Bug #17575 (Closed): deprecated style `respond_to?` warning with `-W:no-deprecated`
When `respond_to?` is defined in deprecated style, arity == 1, is warned and the defined location is also reported.
...
nobu (Nobuyoshi Nakada)
10:58 AM Revision 8dfae85a (git): Warn the defined location as deprecation as well as the main message
[Bug #17575] nobu (Nobuyoshi Nakada)
10:42 AM Misc #17569: `uri` lib maintainership
Would using an `@ivar` on the URI module work?
https://github.com/ruby/uri/pull/15#discussion_r563082346
Eregon (Benoit Daloze)
03:15 AM Misc #17569: `uri` lib maintainership
I don't know of another approach that is as easy and performant than to store a mostly fixed config like this. What d... marcandre (Marc-Andre Lafortune)
09:56 AM Revision 62283f7a (git): coroutine/emscripten/: Experimentally support emscripten fiber API
mame (Yusuke Endoh)
08:38 AM Bug #17574: Hash#inspect segfault
It very much look like a duplicate of https://bugs.ruby-lang.org/issues/16689
@01wsmith you should try Ruby 2.7.2,...
byroot (Jean Boussier)
07:59 AM Bug #17574: Hash#inspect segfault
```
02:58:45|00|1~ irb
irb(main):001:0> x = {1 => {2 => 5}, 3 => {4 => 6}}
irb(main):002:0> y = x[1]
irb(main):00...
01wsmith (w smith)
06:44 AM Bug #17574 (Feedback): Hash#inspect segfault
I failed to reproduce this. Could you report your entire command logs and SEGV output to see a backtrace?
```
$ RUBY...
k0kubun (Takashi Kokubun)
12:12 AM Bug #17574 (Closed): Hash#inspect segfault
While working in irb, I encountered an issue:
``` ruby
x = {1 => {2 => 5}, 3 => {4 => 6}}
y = x[1]
y[11] = 3
x...
01wsmith (w smith)
07:07 AM Revision f12c33b6 (git): configure.ac: Add some compiler options for emscripten
"-lc" and "-s ALLOW_MEMORY_GROWTH=1" are needed mame (Yusuke Endoh)
07:05 AM Revision dd65aa95 (git): bignum.c: Make sure the argument of LONG2FIX is long
... because BDIGIT_DBL may be long long. POSFIXABLE and NEGFIXABLE
ensures that the value is representable as long, b...
mame (Yusuke Endoh)
04:24 AM Revision 05f89dd1 (git): thread_pthread.c: pthread_kill is not available on emscripten
mame (Yusuke Endoh)
04:24 AM Revision 33fb87cc (git): io.c: popen is not available on emscripten
mame (Yusuke Endoh)
02:36 AM Bug #17564: Source command in irb exits after reading and evaluating the file
I could reproduce the situation and I made a pull-request to fix this: https://github.com/ruby/irb/pull/177
Unexpe...
no6v (Nobuhiro IMAI)
02:13 AM Revision 9efd590a (git): Rationalize floats in coerce [Bug #17572]
nobu (Nobuyoshi Nakada)
01:52 AM Revision 9de68a52 (git): Fix a warning
```
.../ruby/test/net/http/test_httpresponse.rb:81: warning: constant RubyVM::MJIT is deprecated
```
znz (Kazuhiro NISHIYAMA)
01:32 AM Bug #17572 (Closed): coerceで作成した(0.0/1)を計算に用いるとコアダンプする
Applied in changeset commit:git|a55eb9a2af7950d180d9d31ffde2bce66710f44f.
----------
Make reciprocal properly of non...
nobu (Nobuyoshi Nakada)
12:01 AM Bug #17572 (Closed): coerceで作成した(0.0/1)を計算に用いるとコアダンプする
coerceで`(0.0/1)`等の値を作成することができ、こちらを計算に使用するとコアダンプして落ちます(出力は添付参照)
再現コード
``` ruby
1/0r.coerce(0.0+0i)[0]
```
よ...
freedom (free dom)
01:30 AM Revision a55eb9a2 (git): Make reciprocal properly of non-integral rational [Bug #17572]
nobu (Nobuyoshi Nakada)
01:20 AM Revision 37258b64 (git): [ruby/net-http] Replace "iff" with "if and only if"
iff means if and only if, but readers without that knowledge might
assume this to be a spelling mistake. To me, this ...
gmcgibbon (Gannon McGibbon)
01:11 AM Revision 47d6c557 (git): gc.c: stop overflow check on emscripten build
mame (Yusuke Endoh)
01:11 AM Revision 1dfddac3 (git): configure.ac: Stop -fstack-protector on emscripten build
mame (Yusuke Endoh)
01:07 AM Revision 6ef761a5 (git): vcs.rb: continue just with warning if failed to fetch notes
nobu (Nobuyoshi Nakada)
01:07 AM Revision ccd7b7ab (git): vcs.rb: include commit info in ChangeLog
nobu (Nobuyoshi Nakada)
12:50 AM Revision 1def8a60 (git): [rubygems/rubygems] Replace "iff" with "whether" and "if and only if"
iff means if and only if, but readers without that knowledge might
assume this to be a spelling mistake. To me, this ...
gmcgibbon (Gannon McGibbon)
12:08 AM Bug #17573 (Closed): Crashes in profiling tools when signals arrive in non-Ruby threads
Stackprof (and likely similar tools) works by setting up a timer to sends it a unix signal on an interval. From that ... jhawthorn (John Hawthorn)

01/22/2021

11:49 PM Bug #17571 (Closed): prependしたArray#[] が反映されない
Arrayクラスにprependを使い`[]`メソッドを差し込んでもprependした`[]`を呼び出しません
また、Hashを継承したクラス(以下HashB)のインスタンスでHash#[]を既に呼び出している場合
prepe...
freedom (free dom)
11:34 PM Misc #17569: `uri` lib maintainership
Yes, replacing the constant. nobu (Nobuyoshi Nakada)
11:17 PM Misc #17569: `uri` lib maintainership
@nobu which strategy is that? Do you mean the `register_scheme` API? marcandre (Marc-Andre Lafortune)
10:56 PM Misc #17569: `uri` lib maintainership
That strategy doesn’t feel nice to me. nobu (Nobuyoshi Nakada)
03:48 PM Misc #17569 (Closed): `uri` lib maintainership
I’d like to merge https://github.com/ruby/uri/pull/15 but it is an API change. I would release v1.0.0. @akr is the o... marcandre (Marc-Andre Lafortune)
11:32 PM Feature #17570: Move C heap allocations into GC heap for RVALUE object data
Thank you for the great work.
It is interesting idea.
At first glance, “GC Compaction” and “Incremental marking” ...
nobu (Nobuyoshi Nakada)
04:10 PM Feature #17570 (Closed): Move C heap allocations into GC heap for RVALUE object data
## Feature
Move C heap allocations into GC heap.
## Pull Request:
[4107](https://github.com/ruby/ruby/pull/4107)...
eightbitraptor (Matt V-H)
10:23 PM Feature #16978: Ruby should not use realpath for __FILE__
Why not put some special handling in to `require_relative` such that it checks both the pre-`realpath` and `realpath`... austin (Austin Ziegler)
09:28 PM Feature #16978: Ruby should not use realpath for __FILE__
I have problem with double loading because of symlinks resolving into real path. If there was ensured that `require "... vo.x (Vit Ondruch)
09:11 PM Feature #16978: Ruby should not use realpath for __FILE__
+1 for keeping the current behavior.
I remember in 1.8 we had so many problems with double-loading code because a ...
Dan0042 (Daniel DeLorme)
06:20 PM Feature #16978: Ruby should not use realpath for __FILE__
I think we should use realpath.
The location of actual file is more robust.
Also, ELF dynamic linker has a featur...
akr (Akira Tanaka)
04:46 PM Feature #16978: Ruby should not use realpath for __FILE__
Can this be resolved please? This is another scenario, which should work IMO, but it does not work:
~~~
$ mkdir a...
vo.x (Vit Ondruch)
09:01 PM Revision db7d0b89 (git): * 2021-01-23 [ci skip]
git[bot]
09:01 PM Revision 6e44de75 (git): What's Here for String RDoc (#4093)
* What's Here for String RDoc burdettelamar (Burdette Lamar)
06:30 PM Bug #17429: Prohibit include/prepend in refinement modules
I like @shugo's approach too.
For anyone interested, I released the `refine_export` gem that makes @jeremyevans' n...
marcandre (Marc-Andre Lafortune)
06:00 PM Bug #17543: Ractor isolation broken by `self` in shareable proc
I think conceptually sharing the self would be cleaner/simpler/consistent-with-captures-vars, but I agree in practice... Eregon (Benoit Daloze)
05:17 PM Bug #17543: Ractor isolation broken by `self` in shareable proc
MaxLap (Maxime Lapointe) wrote in #note-7:
> It's also quite possible that the Ractor on the other side would use th...
marcandre (Marc-Andre Lafortune)
04:23 PM Bug #17543: Ractor isolation broken by `self` in shareable proc
Warning: The following code examples can be ugly. This is low level stuff meant to build nicer blocks on top. Viewer ... MaxLap (Maxime Lapointe)
04:32 PM Bug #17494: ruby is hanged when using activesupport + rspec + rspec-parameterized
I investigated this issue deeply based on yhonda's example code. Then I succeeded to create tiny reproduction code.
...
alpaca-tc (Hiroyuki Ishii)
05:41 AM Bug #17494: ruby is hanged when using activesupport + rspec + rspec-parameterized
# Workaround
`require` only minimal files.
In this case, stop to require "active_support/all"
e.g.
``` ru...
sue445 (Go Sueyoshi)
02:41 PM Revision 07b4b1b1 (git): Support coroutine on universal binary
nobu (Nobuyoshi Nakada)
02:40 PM Revision e34eb58a (git): Keep ARCH_OPTION for arm64
nobu (Nobuyoshi Nakada)
02:21 PM Revision f1c36f2e (git): Added include guards to coroutine headers
nobu (Nobuyoshi Nakada)
01:29 PM Revision c3244a35 (git): Do not set target_alias if unset
nobu (Nobuyoshi Nakada)
09:37 AM Revision c8121b2e (git): Adjust CPU name as arm64-darwin
config.sub replaces arm64 with aarch64. nobu (Nobuyoshi Nakada)
09:37 AM Revision 899b9506 (git): Remove common output directory
nobu (Nobuyoshi Nakada)
09:15 AM Revision e586345b (git): check is_incremental_marking() again
is_incremental_marking() can be changed after checking the
flag without locking, especially on `GC.stress = true`.
ko1 (Koichi Sasada)
05:07 AM Revision a1bb110b (git): [ruby/bigdecimal] [Doc] Fix the comment of BigDecimal_div2 [ci skip]
https://github.com/ruby/bigdecimal/commit/a109d0984f Kenta Murata
04:59 AM Revision 887a1bfb (git): [ruby/bigdecimal] Stop using GetVpValue in rb_big_convert_to_BigDecimal
https://github.com/ruby/bigdecimal/commit/034fd2b25e Kenta Murata
03:16 AM Revision fff1edf2 (git): fix Ractor.yield(obj, move: true)
Ractor.yield(obj, move: true) and
Ractor.select(..., yield_value: obj, move: true) tried to yield a
value with move s...
ko1 (Koichi Sasada)
03:16 AM Revision d0d6227a (git): alen should be actions number on ractor_select()
alen was number of rs, but it should be actions number
(taking ractors + receiving + yielding).
ko1 (Koichi Sasada)

01/21/2021

11:15 PM Revision fb33ec01 (git): [ruby/irb] Delete a doodle-level memo comment...
https://github.com/ruby/irb/commit/fc3e1d9e0c aycabta (aycabta .)
08:52 PM Misc #17565: Prefer use of access(2) in rb_file_load_ok() to check for existence of require'd files
> I wonder how to reconcile such a caching with the other problem of Docker (which is often that you don't get relia... byroot (Jean Boussier)
05:23 PM Misc #17565: Prefer use of access(2) in rb_file_load_ok() to check for existence of require'd files
> Which system was this measured on? Is this only a Docker thing?
Yes, recent macbook pros, couple of different conf...
leehambley (Lee Hambley)
11:13 AM Misc #17565: Prefer use of access(2) in rb_file_load_ok() to check for existence of require'd files
> open(2) with a mean cost of 130µsec per call, where a call to access(2) has a cost around 5× lower (something aroun... byroot (Jean Boussier)
07:48 PM Bug #17568 (Rejected): Thread.handle_interrupt is per-Thread but should probably be per-Fiber
`Thread.handle_interrupt` and the pending interrupts is currently kept as state on the thread (`rb_thread_t`).
Howev...
Eregon (Benoit Daloze)
07:19 PM Revision 32b7dcfb (git): Fix more assumptions about the read barrier
This is a continuation of 0130e17a410d60a10e7041ce98748b8de6946971. We
need to always use the read barrier
tenderlovemaking (Aaron Patterson)
06:22 PM Revision 871b4612 (git): [ruby/matrix] Replace "iff" with "whether" [doc]
iff means if and only if, but readers without that knowledge might
assume this to be a spelling mistake. To me, this ...
gmcgibbon (Gannon McGibbon)
06:22 PM Revision e34f51fe (git): [ruby/matrix] Add `Matrix#rotate_entries` [#19]
Co-authored-by: Marc-André Lafortune <[email protected]> felix.wolfsteller (Felix Wolfsteller)
05:55 PM Revision 0130e17a (git): Always enabled read barrier even on GC.compact
Some objects can survive the GC before compaction, but get collected in
the second compaction. This means we could h...
tenderlovemaking (Aaron Patterson)
05:49 PM Revision a3efbda7 (git): * 2021-01-22 [ci skip]
git[bot]
05:48 PM Revision 03d1850b (git): use ractor_wakeup()
Use ractor_wakeup() for same code. ko1 (Koichi Sasada)
03:35 PM Bug #17567 (Closed): backport Apple Silicon patch
jeremyevans0 (Jeremy Evans)
12:52 PM Bug #17567 (Closed): backport Apple Silicon patch
Please backport https://github.com/ruby/ruby/pull/3272 to the 2.6 branch. Filed here per https://github.com/ruby/ruby... dtrodrigues (Dustin Rodrigues)
11:50 AM Revision d961f14d (git): [ruby/net-http] RubyVM::MJIT is deprecated, prefer RubyVM::JIT now
https://github.com/ruby/net-http/commit/abc6ea1877 nobu (Nobuyoshi Nakada)
06:29 AM Revision 724c289b (git): [ruby/erb] Version 2.2.2
https://github.com/ruby/erb/commit/3d84ea83bc k0kubun (Takashi Kokubun)
06:26 AM Revision b12bd451 (git): [ruby/erb] Let ERB.version just return a version
and deprecate ERB::Revision.
`'$Date:: $'` has not been working since Git
migration from S...
k0kubun (Takashi Kokubun)
06:02 AM Revision f766ba54 (git): Update NEWS.md about deprecation
k0kubun (Takashi Kokubun)
05:52 AM Revision e0d92d5e (git): [ruby/erb] Version 2.2.1
https://github.com/ruby/erb/commit/c8aa019c26 k0kubun (Takashi Kokubun)
05:45 AM Revision 3e8ca51b (git): Fix the relative path for Ruby core
k0kubun (Takashi Kokubun)
05:43 AM Revision 5f7df72b (git): [ruby/erb] Unify ERB version definitions
https://github.com/ruby/erb/commit/5df06b8473 k0kubun (Takashi Kokubun)
05:36 AM Revision 084662dc (git): [ruby/erb] Make styles consistent throught the project
https://github.com/ruby/erb/commit/c68c9470b0 k0kubun (Takashi Kokubun)
05:36 AM Revision c721998a (git): * 2021-01-21 [ci skip]
git[bot]
05:35 AM Revision 151e469a (git): Merge RubyGems 3.2.6 and Bundler 2.2.6 (#4103)
hsbt (Hiroshi SHIBATA)
04:52 AM Revision 922989fa (git): [ruby/erb] Warn safe_level and later args even without -w
because, when Ruby 3.1 is released, Ruby 2.5, the last version with the
old method signature, will have been EOL. The...
k0kubun (Takashi Kokubun)
04:12 AM Revision 47b43807 (git): [ruby/erb] Make sure erb.rb in this repository is tested
https://github.com/ruby/erb/commit/012faba2e5 k0kubun (Takashi Kokubun)

01/20/2021

08:25 PM Feature #17566 (Open): Tune thread QoS / efficiency on macOS
Hi, new Apple M1 processors have "performance" and "efficiency" cores. Apple provides a QoS API so threads can tune w... mperham (Mike Perham)
08:12 PM Misc #17565: Prefer use of access(2) in rb_file_load_ok() to check for existence of require'd files
There is also `eaccess` conditionally defined depending on the platform, which does a suite more tests, probably that... leehambley (Lee Hambley)
08:05 PM Misc #17565 (Open): Prefer use of access(2) in rb_file_load_ok() to check for existence of require'd files
When using Ruby in Docker (2.5 in our case, but the code is unchanged in 15 years across all versions) with a large $... leehambley (Lee Hambley)
06:50 PM Bug #17552 (Closed): [PATCH] Fix a NULL pointer crash in ObjectSpace.dump_all
This is fixed in 6ca3d1af3302f722aed530764d07c1cc83e95ecf tenderlovemaking (Aaron Patterson)
06:48 PM Revision 6ca3d1af (git): objspace_dump.c: Handle allocation path and line missing
byroot (Jean Boussier)
05:33 PM Revision 383685b5 (git): Explicit references to Enumerable
burdettelamar (Burdette Lamar)
04:03 PM Bug #17563 (Closed): FrozenError raised from Module#const_set when receiver is not frozen
Applied in changeset commit:git|565aeb81e0886c835888a425e5d05ed99fb03238.
----------
Skip freezing check on setting ...
nobu (Nobuyoshi Nakada)
04:03 PM Revision 709bed2a (git): * 2021-01-21 [ci skip]
git[bot]
04:03 PM Revision 3b631d0f (git): Support `i` command in log-fix
nobu (Nobuyoshi Nakada)
10:45 AM Bug #17429: Prohibit include/prepend in refinement modules
Having a Module subclass for Refinements seems nice and useful :+1: Eregon (Benoit Daloze)
07:43 AM Bug #17429: Prohibit include/prepend in refinement modules
Dan0042 (Daniel DeLorme) wrote in #note-12:
> shugo (Shugo Maeda) wrote in #note-11:
> > The behavior is similar to...
shugo (Shugo Maeda)
10:24 AM Revision 565aeb81 (git): Skip freezing check on setting temporary class path [Bug #17563]
Co-authored-by: ryannevell (Ryan Nevell) <[email protected]> nobu (Nobuyoshi Nakada)
09:10 AM Revision f4a556f4 (git): [ruby/irb] Remove pp-specific stub from TestColor
because it was for TestColorPrinter
https://github.com/ruby/irb/commit/7569206fd4
k0kubun (Takashi Kokubun)
09:07 AM Revision cea6814c (git): [ruby/irb] Undefine unused constants
https://github.com/ruby/irb/commit/eea9c16804 k0kubun (Takashi Kokubun)
09:03 AM Revision 328df007 (git): [ruby/irb] Split test files for IRB::Color and IRB::ColorPrinter
https://github.com/ruby/irb/commit/d95e8daab3 k0kubun (Takashi Kokubun)
08:46 AM Revision 10d12afa (git): [ruby/erb] Prefer __dir__ to reduce ../
https://github.com/ruby/erb/commit/cb59f11ec8 k0kubun (Takashi Kokubun)
08:21 AM Revision 718890aa (git): Pend erb command tests for Ruby 2.5 for now
k0kubun (Takashi Kokubun)
12:06 AM Bug #17564 (Assigned): Source command in irb exits after reading and evaluating the file
mame (Yusuke Endoh)

01/19/2021

11:43 PM Bug #17564 (Closed): Source command in irb exits after reading and evaluating the file
In the irb of ruby 2.3.7 (the version that comes with Macos) the “source“ command allows ruby code to be fed to irb a... rsharman (Richard Sharman)
11:36 PM Bug #17563: FrozenError raised from Module#const_set when receiver is not frozen
I’m afraid if it’s safe when multi-ractor. nobu (Nobuyoshi Nakada)
10:34 PM Bug #17563: FrozenError raised from Module#const_set when receiver is not frozen
Using `ivar_set` seems reasonable to me, but I'd like to get @nobu's input as to whether this is acceptable. jeremyevans0 (Jeremy Evans)
09:59 PM Bug #17563: FrozenError raised from Module#const_set when receiver is not frozen
Good bug hunting 👍
Your solution is sounds like the right one, I imagine @jeremyevans0 will confirm.
marcandre (Marc-Andre Lafortune)
09:52 PM Bug #17563: FrozenError raised from Module#const_set when receiver is not frozen
I've tried simply replacing `rb_ivar_set` with `ivar_set`, which skips the freeze check, but otherwise behaves the sa... ryannevell (Ryan Nevell)
08:03 PM Bug #17563 (Closed): FrozenError raised from Module#const_set when receiver is not frozen
The following code executed without error on Ruby 2.7.1 and many earlier 2.* versions. The behavior has changed on Ru... ryannevell (Ryan Nevell)
08:06 PM Revision 9e0075a3 (git): Replace "iff" with "if and only if"
iff means if and only if, but readers without that knowledge might
assume this to be a spelling mistake. To me, this ...
gmcgibbon (Gannon McGibbon)
05:38 PM Feature #17562: Update -E option in --help
I need to fix description because --help and -h should be less than 80 characters... ima1zumi (Mari Imaizumi)
04:42 PM Feature #17562 (Open): Update -E option in --help
I would like to propose explaining the arguments of the -E option specifically in --help.
The current explanation ...
ima1zumi (Mari Imaizumi)
05:01 PM Bug #17556: ruby 2.7.2 ::YAML.dump ArgumentError: invalid value for Integer(): "20210101_"
The fix was merged in https://github.com/ruby/psych/pull/438 byroot (Jean Boussier)
05:04 AM Bug #17556 (Closed): ruby 2.7.2 ::YAML.dump ArgumentError: invalid value for Integer(): "20210101_"
再現方法
ruby '2.7.2'
'rails', '~> 6.0.3'
- 利用している ruby のバージョン(ruby -v)
2.7.2
- 再現スクリプト
```ruby
$ bund...
zhang.shuttlerock (Yuki Snow)
04:58 PM Revision a8dc5156 (git): * 2021-01-20 [ci skip]
git[bot]
04:57 PM Revision 1f87725c (git): [ruby/irb] Rescue Errno::EINVAL on IRB pp
http://rubyci.s3.amazonaws.com/solaris11-gcc/ruby-master/log/20210119T070008Z.log.html.gz
is caused by:
/export/home...
k0kubun (Takashi Kokubun)
04:03 PM Bug #17560: Does `Module#ruby2_keywords` return `nil` or `self`?
Since ruby2_keywords is often used conditionally, I think there is little value for it to return Symbols:
https://gi...
Eregon (Benoit Daloze)
03:28 PM Bug #17560: Does `Module#ruby2_keywords` return `nil` or `self`?
zverok (Victor Shepelev) wrote in #note-4:
> Shouldn't it actually return method's name?.. For things like
>
> ``...
jeremyevans0 (Jeremy Evans)
03:08 PM Bug #17560: Does `Module#ruby2_keywords` return `nil` or `self`?
Shouldn't it actually return method's name?.. For things like
```ruby
private ruby2_keywords def my_method
# ....
zverok (Victor Shepelev)
03:03 PM Bug #17560: Does `Module#ruby2_keywords` return `nil` or `self`?
My intention was to return `nil`, so this is a documentation bug. jeremyevans0 (Jeremy Evans)
09:41 AM Bug #17560: Does `Module#ruby2_keywords` return `nil` or `self`?
I think either is fine. This is a weak opinion, but it looks safer to me not to change the actual return value. @jere... mame (Yusuke Endoh)
09:34 AM Bug #17560 (Closed): Does `Module#ruby2_keywords` return `nil` or `self`?
The RDoc says that it returns `self`:
```
ruby2_keywords(method_name, ...) -> self
```
This seems consiste...
nobu (Nobuyoshi Nakada)
02:40 PM Bug #17561 (Closed): The timeout option for Addrinfo.getaddrinfo is not reliable on Ruby 2.7.2
#15553 introduced a timeout option for Addrinfo.getaddrinfo, which uses getaddrinfo_a internally. It appears this has... smcgivern (Sean McGivern)
01:21 PM Bug #17559: Conflict with BasicSocket#send and Object#send
It's intentional. It's kind of a crash of cultures (message send from Lisp culture, data send from UNIX culture). The... matz (Yukihiro Matsumoto)
08:38 AM Bug #17559 (Closed): Conflict with BasicSocket#send and Object#send
`Object#__send__` nobu (Nobuyoshi Nakada)
08:14 AM Bug #17559 (Closed): Conflict with BasicSocket#send and Object#send
`Object#send` can be used in most objects like:
```
's'.send :class
=> String
```
But `BasicSocket` objects ...
sergioro (Sergio Romero)
10:01 AM Feature #14430: net/http: use Socket.tcp with connect_timeout, instead of TCPSocket.open wrapped in Timeout.timeout
The PR is updated, based on master and adds Net::HTTP#resolve_timeout, which delegates to Socket.tcp resolve_timeout,... carl.hoerberg (Carl Hörberg)
08:59 AM Bug #17558 (Closed): ruby2_keywords ignores arguments after a block defined method
Applied in changeset commit:git|eeacdcb9a073c7d8ad703e0dc9faf229a5ebbe3c.
----------
Fixed premature return
After s...
nobu (Nobuyoshi Nakada)
07:46 AM Bug #17558 (Closed): ruby2_keywords ignores arguments after a block defined method
The result of `foo_bar2` should be the same as `foo_bar1`.
```ruby
class C
def bar(*args, **kw)
[args, kw...
nobu (Nobuyoshi Nakada)
08:59 AM Revision eeacdcb9 (git): Fixed premature return
After setting ruby2_keywords for bmethod, the rest of arguments
had been ignored. [Bug #17558]
nobu (Nobuyoshi Nakada)
08:14 AM Revision e6af81bd (git): [ruby/irb] Stub a screen size for test_context
http://ci.rvm.jp/logfiles/brlog.trunk-random1.20210119-074232
https://github.com/ruby/irb/commit/ea87592d4a
k0kubun (Takashi Kokubun)
07:55 AM Revision 4da4ad69 (git): [ruby/irb] Support GitHub Actions
https://github.com/ruby/irb/commit/8e9e6c4037 k0kubun (Takashi Kokubun)
07:50 AM Bug #17557: IRB array returned in multiple lines
Thanks, (1) solved the issue. sergioro (Sergio Romero)
06:46 AM Bug #17557: IRB array returned in multiple lines
The point 2 was merged to IRB master https://github.com/ruby/irb/pull/174. It seems `'s'.methods` returns way more th... k0kubun (Takashi Kokubun)
06:18 AM Bug #17557 (Closed): IRB array returned in multiple lines
We changed the default IRB inspector from inspect-based one to pretty_inspect-based one, which prints a content in mu... k0kubun (Takashi Kokubun)
05:18 AM Bug #17557 (Closed): IRB array returned in multiple lines
Hi Rubysts. In previous versions of IRB an array was displayed in a single line like:
's'.methods
=> [:un...
sergioro (Sergio Romero)
07:35 AM Revision b2159f7c (git): [ruby/irb] Stub a screen size for tests
https://github.com/ruby/irb/commit/6663057083 k0kubun (Takashi Kokubun)
06:52 AM Revision 82386f21 (git): [ruby/irb] Use a real screen size for pp by default
https://github.com/ruby/irb/commit/9b9300dec2 k0kubun (Takashi Kokubun)
05:16 AM Revision a7d933e5 (git): fix conditon of vm_cc_invalidated_p()
vm_cc_invalidated_p() returns false when the cme is *NOT*
invalidated.
ko1 (Koichi Sasada)
04:44 AM Revision 4886535a (git): Avoid suppressing unrelated warnings
k0kubun (Takashi Kokubun)
04:40 AM Revision f12320cd (git): test/ruby/test_jit.rb: Avoid a warning
http://rubyci.s3.amazonaws.com/ubuntu2004/ruby-master/log/20210119T033003Z.log.html.gz
```
/home/chkbuild/chkbuild/tm...
mame (Yusuke Endoh)
04:34 AM Revision ff8c9235 (git): test/ruby/test_pattern_matching.rb: Avoid a warning
http://rubyci.s3.amazonaws.com/ubuntu2004/ruby-master/log/20210119T033003Z.log.html.gz
```
/home/chkbuild/chkbuild/tm...
mame (Yusuke Endoh)
04:27 AM Revision 41d0c708 (git): * 2021-01-19 [ci skip]
git[bot]
04:07 AM Feature #17551 (Closed): Pattern Matching - Default Object#deconstruct and Object#deconstruct_keys
marcandre (Marc-Andre Lafortune)
03:59 AM Feature #17551: Pattern Matching - Default Object#deconstruct and Object#deconstruct_keys
I believe this issue should be closed, as it has an alternative resolution available:
I will start to implement pa...
baweaver (Brandon Weaver)
04:01 AM Revision 58509767 (git): Backport lib/reline, ext/readline, and lib/irb for 3.0.1 (#4085)
* Get rid of inconsistent dll linkages against vcpkg readline
* [ruby/irb] Enhance colored inspect output
https://g...
aycabta (aycabta .)
02:51 AM Revision 5741236a (git): Use real-case version number for the result of `gem list`
hsbt (Hiroshi SHIBATA)
12:05 AM Feature #16806 (Assigned): Struct#initialize accepts keyword arguments too by default
k0kubun (Takashi Kokubun)

01/18/2021

11:47 PM Bug #17555 (Rejected): subclasses method in 2.7.2 is buggy
marcandre (Marc-Andre Lafortune)
09:31 PM Bug #17555: subclasses method in 2.7.2 is buggy
subclasses is provided by rails not Ruby.
Also it's not a bug, simply a known behavior. Rails's `subclass` method ...
byroot (Jean Boussier)
08:23 PM Bug #17555: subclasses method in 2.7.2 is buggy
mark@MacBook-Pro-2 my-project-rails5 % rvm use ruby-2.7.0
Using /Users/mark/.rvm/gems/ruby-2.7.0
mark@MacBook-Pro-2...
RedOne (Mark Morgan)
08:21 PM Bug #17555 (Rejected): subclasses method in 2.7.2 is buggy
I am finding that the subclasses method in 2.7.2 gives a faulty result, containing only one of the many subclasses in... RedOne (Mark Morgan)
11:34 PM Revision 1b89b999 (git): Mark pattern labels as unremoveable
Peephole optimization doesn't play well with find pattern at
least. The only case when a pattern matching could have
...
palkan (Vladimir Dementyev)
10:52 PM Revision 9d1475c6 (git): Fix JIT link failures
forgotten in https://github.com/ruby/ruby/pull/4018 k0kubun (Takashi Kokubun)
09:27 PM Bug #17534: Pattern-matching is broken with find pattern
As a quick fix I propose marking patterns as unremoveable: https://github.com/ruby/ruby/pull/4094 palkan (Vladimir Dementyev)
08:32 PM Bug #17534: Pattern-matching is broken with find pattern
So, what I found: the bug is caused by `iseq_peephole_optimize` and find patterns iseq incompatibility; `remove_unrea... palkan (Vladimir Dementyev)
04:59 PM Bug #17534: Pattern-matching is broken with find pattern
palkan (Vladimir Dementyev) wrote in #note-1:
> That could be related to https://github.com/ruby/ruby/pull/3104.
> ...
palkan (Vladimir Dementyev)
07:18 AM Bug #17534: Pattern-matching is broken with find pattern
zverok (Victor Shepelev) wrote:
> The minimal reproduction code:
>
> ```ruby
> case [1, 2, 3]
> in y
> puts ...
palkan (Vladimir Dementyev)
07:02 PM Revision e812b362 (git): Fix typo: invaldate -> invalidate
alanwu (Alan Wu)
06:11 PM Bug #17497: Ractor performance issue
I too have seen strange results testing ractors. I used the code at https://github.com/keithrbennett/keithrbennett-ra... keithrbennett (Keith Bennett)
05:16 PM Feature #17103 (Closed): Add a :since option to ObjectSpace.dump_all
jeremyevans0 (Jeremy Evans)
02:36 PM Feature #17103: Add a :since option to ObjectSpace.dump_all
This was merged in Ruby 3.0 and can now be closed. byroot (Jean Boussier)
04:59 PM Bug #17552: [PATCH] Fix a NULL pointer crash in ObjectSpace.dump_all
So with some extra debug code, I've managed to identify the object that causes this, it's only one object on a multi-... byroot (Jean Boussier)
09:30 AM Bug #17552 (Closed): [PATCH] Fix a NULL pointer crash in ObjectSpace.dump_all
Patch: https://github.com/ruby/ruby/pull/4078
I wasn't able to reproduce the issue in isolation just yet, but I co...
byroot (Jean Boussier)
04:19 PM Revision 21d2463f (git): Added empty ruby2_keywords gem to suffice dependencies
nobu (Nobuyoshi Nakada)
04:05 PM Revision fad9922d (git): Revert "[Document][Array] Add missing call-seq for Array#append"
This reverts commit ac1a4bccbda4358436a7a907a7f09d047f562740.
See https://github.com/ruby/ruby/pull/4088
Marc-Andre Lafortune
03:14 PM Revision 92e28842 (git): * 2021-01-19 [ci skip]
git[bot]
03:14 PM Revision 5cf6229e (git): Skip updating exts in also test-spec to reduce the turnaround time (#4089)
Co-authored-by: Nobuyoshi Nakada <[email protected]>
Partially reversing a4f3e1762aa195969ace000ac0dc8d300dda85cb l...
k0kubun (Takashi Kokubun)
02:39 PM Revision ac1a4bcc (git): [Document][Array] Add missing call-seq for Array#append
juanito (Juanito Fatas)
02:35 PM Bug #17554 (Closed): [PATCH] Fix ObjectSpace.dump to include singleton class name
Patch: https://github.com/ruby/ruby/pull/4087
This fixes a regression introduced in https://bugs.ruby-lang.org/iss...
byroot (Jean Boussier)
12:15 PM Revision dff74ee6 (git): Revert "Autoconf 2.70 no longer has -o option"
This reverts commit 331f0bc1cb7965bec9aed5d7278360c2e9fc8946.
It seems a mistake.
nobu (Nobuyoshi Nakada)
11:41 AM Revision bb5747e1 (git): Added ruby2_keywords for Ruby 2.5 and 2.6
hsbt (Hiroshi SHIBATA)
10:32 AM Bug #17553 (Closed): Rails CI shows infinite loop of method_missing since f4ce78d5c139a8825ee2d09f39aef03ef762dfc6
### Steps to reproduce
```
git clone https://github.com/rails/rails.git
cd rails/activerecord
bundle install
b...
yahonda (Yasuo Honda)
10:23 AM Feature #17551: Pattern Matching - Default Object#deconstruct and Object#deconstruct_keys
One issue if we use the calls to `attr_*` is we would consider private `attr_*` like `private attr_reader :foo`, whic... Eregon (Benoit Daloze)
05:51 AM Feature #17551: Pattern Matching - Default Object#deconstruct and Object#deconstruct_keys
Interestingly, the gem I immediately thought of (`ast`) needs a `deconstruct` that is different from `to_a`... marcandre (Marc-Andre Lafortune)
05:14 AM Feature #17551: Pattern Matching - Default Object#deconstruct and Object#deconstruct_keys
That is a very fair point, and I appreciate your insight there. I would be tempted to add it to `Enumerable` except i... baweaver (Brandon Weaver)
04:54 AM Feature #17551: Pattern Matching - Default Object#deconstruct and Object#deconstruct_keys
Your example would have `deconstruct*` methods had it subclassed `Struct.new(:name, :age, :children)` (even though th... marcandre (Marc-Andre Lafortune)
04:25 AM Feature #17551 (Closed): Pattern Matching - Default Object#deconstruct and Object#deconstruct_keys
Pattern Matching is a very powerful feature, but many classes are not able to enjoy its functionality due to the lack... baweaver (Brandon Weaver)
10:16 AM Bug #13671: Regexp with lookbehind and case-insensitivity raises RegexpError only on strings with certain characters
Unfortunately, the problem persists in Ruby 2.7.2 and 3.0.0 mauromorales (Mauro Morales)
08:57 AM Feature #17550: Why no function to get all subdirectories of a directory?
`Dir.glob("**/")`, if you don't mind trailing slashes. nobu (Nobuyoshi Nakada)
07:22 AM Revision 331f0bc1 (git): Autoconf 2.70 no longer has -o option
nobu (Nobuyoshi Nakada)
07:22 AM Revision 48bb0329 (git): Revert AC_PROG_CC_C99 for -std=gnu99 option to gcc 4.8
nobu (Nobuyoshi Nakada)
07:22 AM Revision c3237588 (git): Update for autoconf 2.70
nobu (Nobuyoshi Nakada)
07:22 AM Revision 41443868 (git): ruby_type_attribute is not used for now
nobu (Nobuyoshi Nakada)
06:55 AM Revision c3d6bac3 (git): Upcoming Struct#new behavior
nobu (Nobuyoshi Nakada)
06:33 AM Revision a3851d97 (git): Removed unused AC_CHECKING
nobu (Nobuyoshi Nakada)
03:43 AM Revision 6abf393e (git): OpenBSD has getentropy, but no sys/random.h
https://man.openbsd.org/getentropy
Try to fix https://rubyci.s3.amazonaws.com/openbsd-current/ruby-master/log/202101...
znz (Kazuhiro NISHIYAMA)
 

Also available in: Atom