Activity
From 06/01/2021 to 06/07/2021
06/07/2021
-
11:12 PM Revision 8c87efaa (git): [ruby/psych] Fix the test that does not work with libyaml-0.1.7
- https://github.com/ruby/psych/commit/542cf9754f
-
09:54 PM Bug #17941: POSIX timers are not fork-safe on 2.7.x
- Here is a small C program which aborts on Ruby 2.7+ on Linux but works on Ruby 2.5:
```
#include <ruby.h>
#include <... -
- I have an application which runs under a pre-fork-model web server (uwsgi).
When a worker exits, SIGCHLD will be d... -
08:14 PM Bug #17940: Bus Error
- There is too little information to judge now, but my prejudication is that this is the same issue as in #17922 (and a...
-
07:21 PM Bug #17940 (Feedback): Bus Error
- In general, if you are using FFI and get a Bus Error, it is unlikely to be a bug in Ruby. It is more likely this is a...
-
07:01 PM Bug #17940 (Closed): Bus Error
- /Library/Ruby/Gems/2.6.0/gems/ffi-1.15.1/lib/ffi/library.rb:275: [BUG] Bus Error at 0x00000001050bc000
ruby 2.6.3p62... - 06:47 PM Revision a49a08ab (git): * 2021-06-08 [ci skip]
-
06:47 PM Revision 459a9f82 (git): Don't create objects during GC
- If we crash during GC, allocating new objects in the segv handler can
cause an infinite loop. This commit is to avoi... -
- At the May 2021 developer meeting, it was decided that `ENV.dup` should raise and `ENV.clone` should warn, so I close...
-
04:51 PM Feature #17938: Keyword alternative for boolean positional arguments
- > This applies for any argument really. No other way than to read the docs (or know from a previous reading) to answe...
-
01:46 PM Feature #17938: Keyword alternative for boolean positional arguments
- We need to name keyword arguments consistently among similar methods. Otherwise, we will face confusion as you mentio...
-
01:13 PM Feature #17938: Keyword alternative for boolean positional arguments
- Another problem is
```ruby
object.respond_to?(:symbol, include_all: false)
object.methods(regular: true)
```
doe... -
- Although it requires migration complexity and ugliness for the time being, I think it's OK.
We may need to investig... -
- * [Bug #17561] The timeout option for Addrinfo.getaddrinfo is not reliable on Ruby 2.7.2 (jeremyevans0)
* Usage of... -
- * [Feature #12913] A way to configure the default maximum width of pp (mame)
* How about `pp(obj, pp_out: $stderr,... -
04:04 PM Misc #17936: Run Travis at push on forked repository
- I sent the PR here.
https://github.com/ruby/ruby/pull/4556
-
- This was discussed at the May 2021 developer meeting. @naruse is against breaking backwards compatibility for this i...
-
- The attached patch is essentially a cleanup of that by @Biswa96 from GitHub. With this `./configure rb_cv_msvcrt=ucrt...
-
- I agree with the idea too. Let's see how it works.
Matz.
-
11:44 AM Revision 26fcec5a (git): [DOC] fix metacharacter markups [ci skip]
-
-
-
10:24 AM Revision bb4a1020 (git): Do not use YAML module in tests of Psych
-
-
- https://github.com/ruby/psych/commit/4049939006
-
10:15 AM Revision fd6225c7 (git): [ruby/psych] Implement YAML.safe_dump to make safe_load more usable.
- In case where Psych is used as a two way serializers,
e.g. to serialize some cache or config, it is preferable
to hav... -
- YAML.load and YAML.safe_load are different a little; the former allows
Symbol by default but the latter doesn't. So Y... -
10:09 AM Feature #17853: Add Thread#thread_id
- Thank you, @naruse and @nobu!
-
- Some certificates on Unicode.org have expired.
-
- Unfortunately it often fails depending on the status of www.unicode.org.
https://github.com/mame/ruby/runs/276134616... -
- So, some people (including @ko1) have a custom to pass keyword arguments to Kernel#pp:
```
foo = 42
bar = 43
pp... - 01:23 AM Revision a9d76172 (git): * 2021-06-07 [ci skip]
- 01:22 AM Revision ad22e889 (git): Fix Typo
-
- This segfault issue looks like #17518, which has been already fixed in 3.0.1. I have no idea about the other issue (p...
06/06/2021
-
07:48 PM Bug #17939 (Rejected): Segmentation fault at Ruby 3.0.0 w/ CGI.escapeHTML
- It reproduces with 2.7, and it seems like the patched gem allocates a lot of memory. Because I'm still in the middle ...
-
- I tried to check if this reproduces with 3.0.1 as well, but it seems to hit another issue that puma hangs forever and...
-
- When I run https://github.com/k0kubun/gitstar-ranking with a Gemfile modified to use haml.gem at https://github.com/k...
-
- 01:45 PM Revision c9af563e (git): * 2021-06-06 [ci skip]
-
-
09:56 AM Bug #17835: Net::HTTP should automatically add Accept-Encoding request header on HEAD request as well
- Opened: https://github.com/ruby/net-http/pull/26
-
- I'm negative about this, because of the overhead and complexity it would introduce while supporting both forms, and b...
06/05/2021
-
- The test `TestEnv#test_huge_value` showed a difference between msvcrt and ucrt for x64-mingw32:
```
1) Failure:... -
11:33 AM Feature #17853: Add Thread#thread_id
- @nobu that looks great!
-
- ```diff
diff --git i/thread.c w/thread.c
index cbef44a9d4a..c627e5c8f2a 100644
--- i/thread.c
+++ w/thread.c
@@ ... -
- @ko1 Could you reply to this?
I feel C code in the middle of Ruby code is not so great, and if moving C code to st... -
- When you want to make arguments self-explanatory, I wonder if it is not sufficient to write as follows:
```ruby
obj... -
- AFAIK, there was no such message as "Beginless range is experimental, and the behavior may change in future versions ...
-
06:48 AM Misc #17683: Current status of beginless range (experimental or not)
- Hello, is there anyone who is responsible for this? I need this information for the book I'm writing now.
-
04:57 AM Feature #17135 (Closed): Improve performance of Integer#size method
- Applied in changeset commit:git|3208a5df2dfb429752a130a36274464e9924cf44.
----------
Improve perfomance for Integer#... -
- * Improve perfomance for Integer#size method [Feature #17135]
* re-run ci
* Let MJIT frame skip work for Integer#si... - 03:28 AM Revision 033e76e7 (git): * 2021-06-05 [ci skip]
-
03:27 AM Revision 67ca2cce (git): Update bundled_gems
06/04/2021
-
- Some Ruby methods accept optional boolean arguments. This kind of parameter is known to be confusing since you cannot...
-
05:47 PM Feature #17763: Implement cache for cvars
- This is the script/app I used to measure https://github.com/k0kubun/railsbench
-
- I ran benchmarks using railsbench and the branch with the CVAR cache is a lot faster, 657 requests per second over th...
-
- If this is already fixed in 2.7.3, I think we can close this. We cannot change 2.7.1.
-
03:16 PM Bug #17937 (Closed): Segmentation fault in Enumerator#next on Apple M1, Mac OS Big Sur 11.2.2
- A simple code in the irb console fails:
```
irb(main):003:0> [1,2,3].to_enum.next
[BUG] Segmentation fault at 0x... -
- It is a known restriction that the code is parsed as `case (expression in 42)`.
Let me consider if it is possible to... -
- I want to change the current condition to run Travis to improve developer's experience.
In my understanding, curre... -
08:37 AM Feature #12075: some container#nonempty?
- I want to mention that some of the method names proposed so far would break symmetry.
Note that "empty" is a propert... -
- I like `Array#some?` and `Hash#some?`. It is so frequent to write `!ary.empty?`.
I think the main concern is only ab... -
04:56 AM Feature #15567: Allow ensure to match specific situations
- Also there is a problem with the proposed work around:
```
begin
rescue Exception => exception
raise
ensure
... -
- Here are some examples of situations where `$!` is used inside `ensure` block. In every case, there is a potential bu...
-
- Note that there are two related issues, for which the solutions conflict with each other:
* #9710: no __builtin_s... -
- I have a similar problem with a recent 3.1.0dev version, in which the attached test case (named `x64-mingw32-callcc-t...
-
-
06/03/2021
- 08:57 PM Revision 9f3240d4 (git): * 2021-06-04 [ci skip]
-
- NUM_IN_PAGE(page->start) will sometimes return a 0 or a 1 depending on
how the alignment of the 40 byte slots work ou... -
12:18 PM Bug #17935: Backport 86c262541ad07528842d76dab4b9b34bd888d5f4 and 7e14762159643b4415e094f9d2a90afaf7994588 to Ruby 3.0
- ruby_3_0 2dd18df4a35a4b2dd0cf2dec7759898246fc6935 merged revision(s) 86c262541ad07528842d76dab4b9b34bd888d5f4,7e14762...
-
-
- Sorry, I made a follow-up fix commit:7e14762159643b4415e094f9d2a90afaf7994588 as well.
-
- Please consider backporting commit:86c262541ad07528842d76dab4b9b34bd888d5f4 and commit:7e14762159643b4415e094f9d2a90a...
-
- ruby_3_0 9680ee97e0b3e87c0fc9a65c01de1ee50a1a178b merged revision(s) 1aac0e88193a82ed36b43e852c46414181b66455.
-
- Fix a race condition around mjit_recompile
This fixes SEGVs like https://github.com/ruby/ruby/runs/271516662... -
- Mark inlined ISeqs during MJIT compilation (#4539)
[Bug #17584]
---
common.mk | 6 +++... -
-
10:15 AM Bug #17934: clipboard gem fail on Ruby 3.0.1
- In Windows x64, SIZE_T and HGLOBAL (and other handles) in Fiddle shoule be map to void*(64 bits), not uint(32 bits).
... - 08:47 AM Revision dc254120 (git): Expose `rb_fiber_transfer` and `rb_fiber_transfer_kw`.
-
- This is a follow-up of 86c262541ad07528842d76dab4b9b34bd888d5f4.
CRITICAL_SECTION_START/FINISH are not needed when it... -
- Following non-special_const literals:
* T_REGEXP -
- Following non-special_const literals:
* T_BIGNUM
* T_FLOAT (non-flonum)
* T_RATIONAL
* T_COMPLEX -
-
-
- This fixes SEGVs like https://github.com/ruby/ruby/runs/2715166621?check_suite_focus=true.
When mjit_recompile is ca... -
- because a SEGV might happen on an MJIT worker. As you can clearly see
from `if (vm && ec) {`, ec is not guaranteed to... -
- This changes "test/rubygems/test_case.rb" to "test/rubygems/helper.rb",
and "test/rubygems/test_utilities.rb" to "tes... -
- Applied in changeset commit:git|28b481938b5c8211aad53ba82fe4ddd978ffc00f.
----------
Implemented some NilClass metho... -
06/02/2021
-
-
- Thanks for the discussion. I'll try to summarise my position briefly.
> Maybe we should open a new issue so that T... -
- > A timeout error in my mind is more similar to a TERM signal, and Ruby handles that using an exception.
I think t... -
- Eregon (Benoit Daloze) wrote in #note-21:
> Thanks for the link.
>
> Is `throw` used for other things than `redir... -
- Thanks for the link.
Is `throw` used for other things than `redirect`?
If `redirect` would use a regular except... -
- Eregon (Benoit Daloze) wrote in #note-19:
> > Eregon (Benoit Daloze) throw should not abort the transaction, it shou... -
- > I suspect that there is existing buggy code which has ensure blocks and checks $! which fails in the case I mention...
-
-
07:49 PM Revision ad734a8c (git): Allocate exact space for objspace_each_objects
- We are only iterating over the eden heap so `heap_eden->total_pages`
contains the exact number of pages we need to al... -
- > Note that this failure was observed 4 days ago, at the build no #43628 - job number 509310540 first as far as I kno...
-
- Note that this failure was observed 4 days ago, at the build no `#43628` - job number `509310540` first as far as I k...
-
- I am trying to skip the test on Travis ppc64le for now.
https://github.com/ruby/ruby/pull/4546
-
- The failure happened on Travis ppc64le again yesterday.
https://travis-ci.com/github/ruby/ruby/jobs/510153529#L2250
- 03:07 PM Revision 2a685da1 (git): * 2021-06-03 [ci skip]
-
03:07 PM Revision e451f0f6 (git): Fix `_MSC_VER` warnings
-
-
- Indeed.
And this seems to be another instance of LLP64 issues which wrongfully assume `sizeof(long) == sizeof(void *... -
- More likely to be an issue of https://github.com/janlelis/clipboard
The error means the clipboard gem tries to write... -
- Feel free to report it to https://github.com/ffi/ffi/issues. (BTW it is reproducible for me.)
-
- gem install clipboard (Which was used well in Ruby 2.XX):
Fetching clipboard-1.3.5.gem
Successfully installed clipb... -
-
-
- 10:38 AM Revision 2048dfc5 (git): Skip a `File.atime` test randomly failing on Travis ppc64le.
- See <https://bugs.ruby-lang.org/issues/17926>.
-
10:06 AM Misc #17932: 90s design (please lets move to 21st century)
- hsbt (Hiroshi SHIBATA) wrote in #note-4:
> I always welcome to your improvement at https://github.com/ruby/b.r-l.o .... -
- xtkoba (Tee KOBAYASHI) wrote in #note-3:
> I do not understand what "search is broken" means. Could you explain what... -
- > It seems you missed to write the result.
It's in the first comment: https://bugs.ruby-lang.org/issues/17763#note... -
02:13 AM Feature #17763: Implement cache for cvars
- > We also benchmarked ActiveRecord::Base.logger since logger is a cvar and there are 63 modules in the inheritance ch...
-
- Agreed, but I think @Dan0042's `Process._fork_` proposal is better.
-
- Since there seems to be no agreement on what a better and high-level API would look like, would it be reasonable to g...
-
- It's been a way too much amount of ifdefs.
-
- and not for third-party libraries.
See: e6484a153038703447b50fcac26349249922ab28 -
- https://github.com/ruby/ruby/runs/2707566811#step:10:147
```
D:\a\ruby\ruby\src\mjit_worker.c(1212): warning C4090: '... -
02:35 AM Revision 9137caaf (git): [ruby/rdoc] Add a dependency on psych gem 4.0.0 or newer
- https://github.com/ruby/rdoc/commit/ebe185c877
-
- https://github.com/ruby/rdoc/commit/b8d68fdd87
06/01/2021
-
- @eregon `throw` should not abort the transaction, it should be committed.
-
- I suspect that there is existing buggy code which has ensure blocks and checks `$!` which fails in the case I mention...
- 10:25 PM Revision 04a5ee6a (git): * 2021-06-02 [ci skip]
-
- Instead of keeping track of the current bit plane, keep track of the
actual slot when compacting. This means we don'... -
04:40 PM Bug #17781: Resolv::DNS RequestID table allocations are never freed, causing DNS lookups to eventually hang
- ruby_2_7 87d02eacd26d0b2884016315baf2440d100f177e merged revision(s) 9edc162583a4f685332239f6249745ad9b518cbe.
- 04:40 PM Revision 87d02eac (git): merge revision(s) 9edc162583a4f685332239f6249745ad9b518cbe: [Backport #17781]
- [ruby/resolv] Fix confusion of received response message
This is a follow up for commit 33fb966197f1 ("Remov... -
- * [Feature #17930] Add column information into error backtrace (mame)
* I've resurrected @yui-knk's patch. What do... -
- > Are you talking about moving the write_timeout implementation from Net::BufferedIO to IO.copy_stream?
No. `IO.co... -
01:18 PM Bug #17933: `Net::HTTP#write_timeout` doesn't work with `body_stream`
- byroot (Jean Boussier) wrote in #note-2:
> Previous discussion where `write_timeout` was added and it was noted that... -
- Previous discussion where `write_timeout` was added and it was noted that `copy_stream` didn't have a timeout: https:...
-
- > it's unclear if it will break some existing functionality
Well, `copy_stream` can only use its optimizations wit... -
- Raise `NotImplementedError` on unsupported platforms regardless
the argument consistently. -
-
- * add static modifier for rb_hash_reject_bang func
* add static modifier for rb_hash_reject func
* add static modif... -
- * add static modifier for rb_reg_eqq func
* add static modifier for rb_check_regexp_type func -
-
-
-
-
-
-
- vm_sync.{c,h} don't have tabs
-
- This reverts commit e9e3b65d836b5796882b5bf28717e4586366ceec.
We were not ready for it
https://github.com/ruby/ruby/... -
- This is useful for large applications like Rails.
https://k0kubun.medium.com/ruby-3-jit-can-make-rails-faster-756310f... -
- I'm investigating SEGVs like https://github.com/ruby/ruby/runs/2715166621?check_suite_focus=true.
Because a lot of th... -
- 04:14 AM Revision 45651e80 (git): * 2021-06-01 [ci skip]
-
- Compiling everything seems to contributed to improving the final
performance in general. MJIT's compilation is slow a...
Also available in: Atom