Activity
From 05/10/2022 to 05/16/2022
05/16/2022
-
06:18 PM Bug #18787 (Closed): Use correct make rules
- Recently an improvement was made to the documentation adding some new files.
I was reading doc/contributing/buildi... -
05:09 PM Bug #18061: Execshield test: libruby.so.N.N.N: FAIL: property-note test because no .note.gnu.property section found
- On the current latest master `f2dc97294086c31604a45ee350c4fa5d51762f45`, here is the result on my Fedora 35. The Fedo...
-
- @nobu what is your intent for this commit, https://github.com/ruby/ruby/commit/a7577dbfd3ea53cccf7aaf94208069784ad177...
-
- @ioquatix My PR above was merged. Now after you rebase your PR on the latest master branch, you can test your PR with...
- 02:43 PM Revision f2dc9729 (git): [ruby/set] Fix a typo
- https://github.com/ruby/set/commit/71a876ae81
-
02:39 PM Bug #18786 (Closed): Rescuing NotImplementedError from `GC.verify_compaction_references` can lead to infinite loop on platforms
- `GC.verify_compaction_references` throws an NotImplementedError on platforms that do not support it as is expected.
... - 12:50 PM Revision f626998c (git): Delete autoload data from global features after autoload has completed. (#5910)
- * Update naming of critical section assertions macros.
* Improved locking for autoload. -
10:40 AM Bug #18780 (Rejected): Incorrect binding receiver for C API rb_eval_string()
- rb_eval_string() is used inside C code/C extensions, there is no "caller Binding" to use, C extension frames have no ...
-
10:27 AM Revision a7577dbf (git): `annobin` works only when targeting Fedora
- And hopefully for other Linux. Since it is not run on the build os,
`TEST_RUNNABLE` is not suitable for this case. -
- After fixing this issue, I hope you would delete the following part to test the fix. Thanks.
```
$ git diff
diff... -
09:09 AM Bug #18785 (Feedback): RbConfig::MAKEFILE_CONFIG["warnflags"] contains "-Wno-cast-function-type" which is not compatible with clang 13.0.0
- Hi,
I was having an issue installing the curses gem: https://github.com/ruby/curses/issues/41#issuecomment-1127293... -
09:04 AM Feature #18784 (Closed): `FileUtils.rm_f` and `FileUtils.rm_rf` should not mask exceptions
- In recent times, I've been having issues with these methods because they don't let you know when some issue happened ...
-
- On `rails/rails` repository Gemfile, running the following script
```
# script.rb
require "bundler/setup"
```
#### ... -
- On a different patch, it was noticed Ngam Pham that we are calling
`LazySpecification#hash` many times, and simply me... - 08:10 AM Revision dccfff94 (git): Add `make test-annocheck` to detect security issues.
- * Note that as the annocheck binary package is not available on Ubuntu, and it
is working in progress in Debian, th... - 03:24 AM Revision 36efb2a1 (git): * 2022-05-16 [ci skip]
-
- https://github.com/ruby/racc/commit/4ecc13c9cb
-
12:21 AM Bug #15790: Strange interaction between autoload and $LOADED_FEATURES
- > The behaviour described here does not seem strange to me
What do you mean Samuel?
You don't find strange that we ...
05/15/2022
-
11:36 PM Bug #18782: Race conditions in autoload when loading the same feature with multiple threads.
- Okay, so I suspected some issue with `autoload_delete` and finally found how to reproduce it.
```c
static void
a... -
- PR: https://github.com/ruby/ruby/pull/5898
-
- After debugging the above issue I found a use-after-free bug in
```c
static void
autoload_c_free(void *ptr)
{
s... -
02:58 PM Misc #16112: Reduce the possibility of "expand tabs" commit occurrences
- > cons: Pollute git blame result when -w option is not specified.
Not sure if this will ever be reconsidered, but ... -
- Another weird edge case we have now:
```
File.write("./empty.rb", "Y = 1")
autoload :X, "./empty.rb"
begin
... -
- Let me add, that I think it's also reasonable sequence of events/state transition:
```
before failed autoload aut... -
- The behaviour described here does not seem strange to me, at least, I'm not sure if it's problematic. @fxn what was t...
- 04:07 AM Revision 105609d3 (git): * 2022-05-15 [ci skip]
- 04:07 AM Revision 32de6097 (git): Fix various autoload race conditions. (#5898)
- * Add RUBY_VM_CRITICAL_SECTION for detecting unexpected context switch.
* Prevent race between GC mark and autoload ... -
03:46 AM Bug #18783 (Closed): OptionParser should recognize "-" as an optional argument
- ``` ruby
require 'optparse'
optarg = nil
OptionParser.new do |parser|
parser.on("-o", "--opt [ARG]", "Optio... -
03:36 AM Bug #18781 (Assigned): MJIT tests failing with Ubuntu focal with gcc-11 and some flags
05/14/2022
-
- @normalperson I've attached patch files. If you have time, I'd really appreciate your feedback on this. Specifically,...
-
- I have identified several race conditions in the autoload code.
1. It's possible to race on adding and then deleti... -
01:38 PM Revision 48002ff1 (git): [ruby/fileutils] [DOC] Enhanced RDoc for #ln (https://github.com/ruby/fileutils/pull/69)
- Enhanced RDoc for #ln
https://github.com/ruby/fileutils/commit/79fc67f03f
Co-authored-by: Peter Zhu <peter@peterzhu... -
- marcandre (Marc-Andre Lafortune) wrote in #note-10:
> We could also define `::TimeoutError` as base class, and modif... -
- > It doesn't seem relevant to the issue described in this ticket. Could you file another one?
Oh sorry for my mist... -
- It doesn't seem relevant to the issue described in this ticket. Could you file another one?
-
- I find some MJIT tests failing in `test/ruby/test_jit.rb` and `test/ruby/test_rubyvm_jit.rb` on gcc 11 on Ubuntu foca...
05/13/2022
-
- It seems I faced this issue on gcc 11 on Ubuntu focal on the latest master branch 708e839dee57bc5ef8f5b21fb4fa620e89c...
-
11:00 PM Bug #18780 (Closed): Incorrect binding receiver for C API rb_eval_string()
% ruby -v
ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) [x86_64-linux]
(Though looking at the source code this ...-
08:26 PM Revision 708e839d (git): Fix compiler warning when USE_RVARGC=0
-
- I am testing Samuel's PR: <https://github.com/ruby/ruby/pull/5895>.
To pass the security tool, `annocheck` with th... - 08:02 PM Revision 51fab060 (git): * 2022-05-14 [ci skip]
-
- Enhanced RDoc for Logger
https://github.com/ruby/logger/commit/c601ed0370
Co-authored-by: Peter Zhu <peter@peterzhu... -
02:47 PM Revision 09c72f41 (git): Print function name in backtrace when available
- If we don't have `saddr` but have `sname` we should output `sname`.
-
02:23 PM Misc #18747: DevMeeting-2022-05-19
- * [Feature #18742] Introduce a way to tell if a method invokes the `super` keyword or not
* It's currently possibl... -
- I received several bug report on native gems using `GC.verify_compaction_references` in their test suite.
Examples... -
- https://github.com/ruby/logger/commit/a5a2f2da4a
Co-authored-by: Peter Zhu <[email protected]> -
- https://github.com/ruby/logger/commit/e6f2c64fc6
Co-authored-by: Peter Zhu <[email protected]> -
- https://github.com/ruby/logger/commit/3dc5a8d7a4
Co-authored-by: Peter Zhu <[email protected]> -
- https://github.com/ruby/logger/commit/98919e09e5
Co-authored-by: Peter Zhu <[email protected]> -
- https://github.com/ruby/logger/commit/073a892ad9
Co-authored-by: Olle Jonsson <[email protected]> -
- https://github.com/ruby/logger/commit/6d91281f7f
Co-authored-by: Olle Jonsson <[email protected]> -
- https://github.com/ruby/logger/commit/34c0ba8baa
Co-authored-by: Olle Jonsson <[email protected]> -
- https://github.com/ruby/logger/commit/16556d06d1
-
- Thank you for the suggestion, and I apologize for the late reply.
This works remarquably well.
```ruby
class Unb... -
11:32 AM Feature #17316: On memoization
- I've been experimenting with doing memoization by passing a block to `attr_reader` / `attr_accessor`, e.g.
```ruby
a... -
09:54 AM Bug #18778 (Third Party's Issue): Crash on MacOS 12.1 (Monterey) , M1 Max CPU
- This is a duplicate of #18555 and many tickets. See https://github.com/ffi/ffi/issues/800#issuecomment-1008308614 for...
-
08:18 AM Bug #18778 (Third Party's Issue): Crash on MacOS 12.1 (Monterey) , M1 Max CPU
- This bug happens ALWAYS when I try to run CocoaPods.
-
- The lockfile is completely ignored in inline mode, yet the previous
output would suggest it wasn't.
https://github.c... -
- The other sources use `options` which reads better.
https://github.com/rubygems/rubygems/commit/a672f9d602 -
02:45 AM Bug #18777: NDEBUG macro defined after including ruby.h
- shyouhei (Shyouhei Urabe) wrote in #note-1:
> This is intentional. Devs hate assertions. See also https://bugs.ruby... -
01:43 AM Bug #18777 (Closed): NDEBUG macro defined after including ruby.h
- This is intentional. Devs hate assertions. See also https://bugs.ruby-lang.org/issues/16837 .
-
01:11 AM Feature #18776: Object Shapes
- > struct rb_id_table * edges;
and I understand `edges` manages the next transitions. Thanks.
-
- jemmai (Jemma Issroff) wrote in #note-5:
> When we add a new ivar, if there is no transition we have to find a new I...
05/12/2022
-
11:44 PM Revision 2d103207 (git): Stop `build_extensions` when DESTDIR set
- Try to fix `make install without root privilege` failures on snapshot CIs.
example: https://github.com/ruby/actions/... -
09:34 PM Revision ebaf56c0 (git): YJIT: Implement getblockparam
- This implements the getblockparam instruction.
There are two cases we need to handle depending on whether or not
VM_... -
- Hello,
When using ruby 3+, including `ruby.h` results in the `NDEBUG` macro becoming defined, which deactivates as... -
- > If you call memoized methods in a different order, would that cause instances of the same class to have multiple sh...
-
08:05 PM Feature #18776: Object Shapes
- If you call memoized methods in a different order, would that cause instances of the same class to have multiple shapes?
-
- byroot (Jean Boussier) wrote in #note-7:
> > it definitely would be easier if we had more than 16 bits
>
> Yeah... -
- > it definitely would be easier if we had more than 16 bits
Yeah, my worry is that while the Shopify monolith is... -
- byroot (Jean Boussier) wrote in #note-4:
> > We want object shapes to be enabled on 32 bit systems and 64 bit system... -
03:56 PM Feature #18776: Object Shapes
- Thanks for the feedback, Koichi.
ko1 (Koichi Sasada) wrote in #note-3:
> * how to use parent id?
The `rb_shape` ty... -
- > We want object shapes to be enabled on 32 bit systems and 64 bit systems so that limits us to the bottom 32 bits of...
-
- Great patch.
I'm looking forward to seeing evaluation results.
Questions:
* how to use parent id?
* how to fi... - 07:20 PM Revision 14ae97de (git): * remove trailing spaces. [ci skip]
-
07:19 PM Revision a6ce73ef (git): Add documentation section to README
- 07:08 PM Revision 30d0f08c (git): * 2022-05-13 [ci skip]
-
- Before this commit we were accidentally clobbering RAX. Additionally,
since this function had RAX hardcoded then the... -
05:45 PM Feature #9045 (Closed): URIに含まれるエンコードされたID/パスワードがデコードされない
- Applied in changeset commit:git|fbebfe1697938a684f460cd28af36cf1f056513c.
----------
[ruby/uri] Add URI::Generic#dec... -
01:44 PM Feature #18654: Enhancements to prettyprint
- @akr okay, thank you for the consideration. I'm going to maintain it as a separate project in this case as I don't se...
-
- To respond to your points @mame:
* It can live in a gem, and it is in https://github.com/ruby-syntax-tree/syntax_t... - 10:36 AM Revision 75223433 (git): .github/workflows/compilers.yml: Add configure --enable-mkmf-verbose case.
- 10:36 AM Revision 019cbded (git): mkmf: Add a configure option to set verbose mode (V=1 or 0) in mkmf.rb.
- Note this change is only for `configure.ac`, not for Windows using
`win32/configure.bat`.
```
$ ./configure --help |... -
- * Also add docs and mention current limitations.
* For reference, https://stackoverflow.com/a/3641782/388803 mentions... -
- URI::Generic#{user,password} return the encoded values, which are
not that useful if you want to do authentication wi... - 01:06 AM Revision 054ae999 (git): [ruby/uri] Update file.rb
- The module here is called `URI`, so it's probably reasonable to expect a requirement for the path to be RFC3986-compl...
-
01:04 AM Bug #18464: RUBY_INTERNAL_EVENT_NEWOBJ tracepoint causes an interpreter crash when combined with Ractors
- Just checked, this is still an issue with 3.2.0-preview1. Is there any feedback on the patch I posted? Any other way ...
05/11/2022
- 10:53 PM Revision 9f9a0940 (git): Quick markup fix
-
-
- # Object Shapes implementation
Aaron Patterson, Eileen Uchitelle and I have been working on an implementation of O... -
- > shouldn't we also consider a hypothetical Queue::TimeoutError
IMHO, consistency with closed queues is really mor... -
- If others feel strongly it should be an exception, I think it should be `Thread::TimeoutError` (we already have `Time...
-
- I also think `nil` can work, but shouldn't we also consider a hypothetical `Queue::TimeoutError` similar to how all o...
-
- Indeed, I forgot to mention that. I think returning `nil` is easiest, most consistent and convenient.
I believe it i... -
- In https://bugs.ruby-lang.org/issues/17363 there was some discussion on what the return value or exception should be ...
-
- This has been mentioned many times but somehow was never added.
It is useful for many different use cases:
* Implem... -
- Ref: https://github.com/ruby/ruby/pull/5892
cc @ioquatix
This bug can cause Ruby 3.1.2 to crash with a `[BUG] ... -
-
- I believe edf01d4e82d8e44ee30ec41fbcb7f802bc8b8c5d should be backported to Ruby 3.0
Ref: https://github.com/msgpac... -
- * [Feature #18774] Add Queue#pop(timeout:) (eregon)
* OK?
* Anyone wants to implement it for CRuby?
-
- - [Feature #14602] Version of `dig` that raises error if a key is not present
- Proposed names: in the issue `deep... - 07:13 PM Revision 26a07b8b (git): Add a separate doc for contributing to stdlibs [ci skip]
- co-authored-by: Peter Zhu <[email protected]>
-
- https://github.com/ruby/fileutils/commit/4771925fee
Co-authored-by: Peter Zhu <[email protected]> -
- https://github.com/ruby/fileutils/commit/a0ea474214
-
06:29 PM Feature #14602: Version of dig that raises error if a key is not present
- duerst (Martin Dürst) wrote in #note-2:
> Would a keyword parameter to dig work for you?
>
> E.g. `hash.dig!(:nam... -
06:12 PM Feature #14602: Version of dig that raises error if a key is not present
- Just a bit of "design space" analysis:
1. I think `dig!` is unusual for core Ruby. A lot of Rubyists are used that... -
- https://github.com/ruby/rdoc/commit/521c9ebd29
-
- Currently when you're pattern matching against a hash pattern, `deconstruct_keys` receives the keys that are being ma...
- 03:20 PM Revision 4978c486 (git): * 2022-05-12 [ci skip]
- 03:20 PM Revision e88ada46 (git): Ruby shovel operator (<<) speedup. (#5896)
- For string concat, see if compile-time encoding of strings matches.
If so, use simple buffer string concat at runtime... -
- co-authored-by: Peter Zhu <[email protected]>
co-authored-by: Stan Lo <[email protected]> -
- https://github.com/ruby/fileutils/commit/c38fd02372
-
- https://github.com/ruby/fileutils/commit/7b60f2d63b
-
- This issue has more details: https://github.com/postmodern/ruby-install/issues/412
So CRuby picks a mix of of 1.1 ... -
- FYI, related discussion in ruby-build: https://github.com/rbenv/ruby-build/pull/1974
I think Ruby 3.0 should suppo... - 07:56 AM Revision 6758b76b (git): * 2022-05-11 [ci skip]
-
- Previously we were removing not installable specs. However, if those are
the only ones, that would result in a bad er... -
- The follow a tweak on the yank message.
https://github.com/rubygems/rubygems/commit/f6817bfe58 -
- https://github.com/rubygems/rubygems/commit/66eae0ef1d
05/10/2022
-
- @ioquatix Thank you for your investigation! I prepared `make test-annocheck` command for your convenient, and for us ...
-
- As a (maybe useful) sidenote, if we'll try to think in "useful atomic constructs" instead of "making existing multi-p...
-
06:02 PM Feature #18690: Allow `Kernel#then` to take arguments
- For your scenarios, as written, I agree with Benoit's #note-2 suggestions. ;) I also agree that core/stdlib `#then` ...
-
05:37 PM Bug #18771 (Closed): IO.foreach/.readlines ignores the 4th positional argument
- The `IO.readlines` method has the following signature:
```
readlines(name, sep, limit [, getline_args, open_args]... -
- IO's and StringIO's `#each` method (and similar ones - `#gets`, `#readline` etc) behave in a different way in the fol...
-
- The mentioned StringIO method `#each` (as well as `#readlines` and `#each_line`) may hang up when passed a separator ...
-
- In IO, StringIO and String methods that return lines (e.g. `each`, `each_line`, `gets`, `readline`, `readlines`) beha...
-
- `IO.foreach` behaves in an unexpected way in a corner case when passes 0 as a limit parameter. It never stops and han...
-
- This makes me happy, thanks everyone!
-
-
-
Also available in: Atom