Activity
From 07/30/2023 to 08/05/2023
08/05/2023
-
10:40 PM Revision af13b038 (git): Remove unnecessarily copied document [ci skip]
-
05:30 PM Revision ac07d881 (git): [ruby/yarp] Add a Requirements section in Build System docs
- https://github.com/ruby/yarp/commit/298025314c
-
- https://github.com/ruby/yarp/commit/f9db0c282b
Co-authored-by: Mike Dalessio <[email protected]> -
- https://github.com/ruby/yarp/commit/0b174b76f1
Co-authored-by: Mike Dalessio <[email protected]> -
- https://github.com/ruby/yarp/commit/85ae0e2816
-
- https://github.com/nobu/ruby/tree/bugreport_path
Implemented `%%`, `%e`, `%E`, `%f`, `%F`, `%p`, `%t` and `%NNN`(octal).
When invoking pipe, the string is split with white spaces first without quoting, `%040` would be useful to repre... -
- If the required name is different from the found gem name, return the
gem name, instead of true that means the required name is an exact gem
name. -
03:50 AM Revision e176f841 (git): Just suppress a warning for non-Emscripten Wasm build
- Revert "Revert "Skip calling jit_exec on Wasm""
This reverts commit 2e94610f70baca4af004202f288a6b5dd10889ca.
It's not about whether it's optimized away or not. I just don't want to
leave and maintain the callsite (e.g. signature) in t... -
- This reverts commit e80752f9bbc5228dba3066cd95a81e2e496bd9d7.
RJIT and YJIT are never enabled on Wasm. When both are disabled,
`jit_exec` is defined to return `Qundef` constantly, and is optimized
away. -
02:39 AM Revision 4e7e9728 (git): Remove uneeded int2big property for Universal Parser
-
01:32 AM Revision f07ef1d5 (git): Lrama v0.5.3
08/04/2023
-
- We often break Wasm build when we modify how jit_exec works. I'm
planning to modify it again soon.
We actually don't support running Ruby JIT on Wasm, so it doesn't seem
worth the maintenance effort. -
06:57 PM Revision 8d7861e3 (git): YJIT: expand bitwise shift support in x86 assembler (#8174)
-
05:13 PM Revision c4066af3 (git): [ruby/irb] Store integration tests' envs in an ivar
- (https://github.com/ruby/irb/pull/668)
https://github.com/ruby/irb/commit/bbd20445ea -
- It doesn't feel elegant or concise to feed the element size to me.
For what use cases do you want it actually? -
07:42 AM Feature #19830: Allow `Array#transpose` to take an optional size argument
- nobu (Nobuyoshi Nakada) wrote in #note-1:
> Why not `ary.transpose[1]&.join`?
That avoids the exception but returns `nil` instead of taking advantage of `#join`’s knowledge of the “correct” result for an empty array, i.e. the empty s... -
- Why not `ary.transpose[1]&.join`?
-
- Avoid generating long dispatch chains for all array lengths seen.
-
01:13 PM Revision 61b76e74 (git): Revert "Tests to move between size pools are flaky on Windows too"
- This reverts commit c5abe0d08f8f7686422e6eef374cf8c78aefacb6.
-
- We don't need to check stack for moved objects after compaction because
the mutator cannot run between marking the stack and the end of
compaction. However, the stack may have moved objects leftover from
marking and sweeping phases. This... -
12:12 PM Revision 6b570ff2 (git): Display call location with bundled gems warning
-
-
-
-
- Also `flag_keyword_hash` sets to 0 or a hash object.
-
- (https://github.com/ruby/irb/pull/667)
https://github.com/ruby/irb/commit/79fc6dcf5f -
- Xcode 15 beta and macOS Sonoma beta show the following warnings with `make`
```
(snip)
linking miniruby
ld: warning: ignoring duplicate library '-lpthread'
miniruby: replacing existing signature
exe/ruby: replacing existing signa...
08/03/2023
-
-
- * YJIT: handle expandarray_rhs_too_small case
YJIT: fix csel bug in x86 backend, add test
Remove commented out lines
Refactor expandarray to use chain guards
Propagate Type::Nil when known
Update yjit/src/codegen.rs
Co-authored-by:... -
06:52 PM Revision 132f0971 (git): No computing embed_capa_max in str_subseq
- Fix str_subseq so that it does not attempt to predict the size of the
object returned by str_alloc_heap. -
- One benefit of supplying an initial value to `Enumerable#inject` is that it avoids an annoying edge case when the collection is empty:
```
>> [1, 2, 3].inject(:+)
=> 6 # good
> ...
=> nil # bad
>> [].inject(0, :+)
=> 0 # good... -
-
- Function prototype for gc_mode_transition is not needed as it's not
used before the implementation. -
- Hello @tamaron. There is no update as of yet. One of the challenges is that it's not easy for us to have access to windows machines, it would be kind of a pain for us to debug things in a VM. This would also add complexity to our CI test...
-
10:27 AM Feature #19325: YJIT: Windows support lacking.
- Hello, any progress here?
I am very new to the Ruby community but interested in working on this. -
- ary_make_partial now uses the actual embed_capa of an allocated heap
array to guide whether make an embedded copy or a slice view. -
10:45 AM Bug #19829 (Closed): Enumerator.product called with keyword arguments raises exception with not precise message
- The `Enumerator.product` method, added in Ruby 3.2, when it's called with keyword arguments (but it expects only a list of enums) raises `unknown keyword: ... (ArgumentError)` exception:
```ruby
Enumerator.product([], a: 1)
# (irb):... -
08:14 AM Bug #19792: arm の alpine 上でネストしたハッシュに長い文字列を入れると segmentation fault が発生する
- 以下の環境でも再現しました
- Docker version 24.0.2, build cb74dfc
- M1 Max
- Ventura 13.5 -
-
-
-
- assert_separately adds --disable=gems so we don't need to add
--disable-gems when calling assert_separately.
08/02/2023
- 11:43 PM Revision 29fd0503 (git): * remove trailing spaces. [ci skip]
-
-
11:25 PM Bug #19828 (Closed): Segfault when `OpenSSL::X509::Certificate#public_key=` is given a `OpenSSL::PKey::DH` object
- The OpenSSL bindings cause a SegFault when creating a new OpenSSL::X509::Certificate object and setting it's `public_key` to the `public_key` of a new `OpenSSL::PKey::DH` key-pair.
### Steps To Reproduce
```ruby
#!/usr/bin/env rub... -
- because EP could be escaped.
-
- @ko1 Thank you!
-
- (https://github.com/ruby/irb/pull/654)
* Deprecate multi-irb commands
- Print deprecated message when any of the commands are used
- Put related commands under `Multi-irb` category with a deprecated
label
* Update readme
https://gi... -
- tests
(https://github.com/ruby/irb/pull/660)
The ability to run a test case in a subprocess is useful for testing
many other features, like nested IRB sessions. So I think it's worth
extracting them into a new test case class.
https://... -
- 03:33 PM Revision e20f1e44 (git): YJIT: Fallback setivar if the receiver isn't T_OBJECT (#8160)
- Followup: https://github.com/ruby/ruby/pull/8152
If the receiver is a T_MODULE or T_CLASS and has a lot of
ivars, `get_next_shape_internal` will return `NULL`.
Co-authored-by: Jean Boussier <[email protected]> -
- * Follow-up of dbbc3583ba432c279f07b1fa0afb0a8a9ba50c91 which broke this.
-
-
-
-
-
01:32 PM Bug #19795: attr_accessor leading to nil values for re-assignment
- I got it in the end thanks to a peer. I misunderstood wrongly how this was working:
Running the following snippet helped me understand:
```ruby
# attr_accessor_nil.rb
class A
attr_accessor :a
def initialize
@a = 0
... -
- I guess that it is a local variable, but is it the expected behavior?
As a developer, I expect that I can access `a` without the `self.a`.
Since the following code works as expected without `self`:
```ruby
# attr_accessor_nil.rb
class... -
- This is an assignment to the local variable, not the accessor.
```ruby
a += 1
```
You have to write:
```ruby
self.a += 1
``` -
- ### Steps to reproduce:
- Create a class with an `attr_accessor` for an instance variable
- Create an instance method that reassign this variable using the current value stored in the variable
- Show that the variable is set to nil du... -
- Applied in changeset commit:git|1d096c1e53581ed9fe94694c9760babd1e12e580.
----------
Fix crash in NoMethodError for dummy frames
[Bug #19793]
Dummy frames are created at the top level when requiring another file.
While requiring a fil... -
- [Bug #19793]
Dummy frames are created at the top level when requiring another file.
While requiring a file, it will try to convert using encodings. Some of
these encodings will not respond to to_str. If method_missing is
redefined on Ob... -
-
-
- https://github.com/rubygems/rubygems/commit/6ed69223d4
- 09:18 AM Revision fd8dd719 (git): Implement StringIO#pread (#56)
- Both for being closer to real IOs and also because it's a convenient API
in multithreaded scenarios.
Co-authored-by: Jean Boussier <[email protected]> -
- (https://github.com/ruby/irb/pull/634)
Its method `IRB.default_src_encoding` was only used in `magic-file.rb`,
which has been removed.
https://github.com/ruby/irb/commit/ed98983b1f - 09:17 AM Revision fe255277 (git): [ruby/fiddle] Include stdbool.h explicitly
- https://github.com/ruby/fiddle/commit/c313a74632
- 09:17 AM Revision 673f4493 (git): [ruby/fiddle] Include stdbool.h explicitly
- https://github.com/ruby/fiddle/commit/69ff680bf6
- 09:17 AM Revision 15e8cf7a (git): [ruby/fiddle] Add support for bool
- GitHub: fix https://github.com/ruby/fiddle/pull/130
Reported by Benoit Daloze. Thanks!!!
https://github.com/ruby/fiddle/commit/bc6c66bbb9 - 09:17 AM Revision 10588fa1 (git): [ruby/fiddle] Use ifdef
- https://github.com/ruby/fiddle/commit/6cdf53726d
-
- This reverts commit 3b88a0bee841aee77bee306d9d34e587561515cf.
This commit break aarch64 platform and Apple Silicon -
- Needs more investigations.
-
05:08 AM Bug #19794 (Assigned): Ruby 3.2.2 fails to build on macOS Sonoma betas
- With Big Sur, Apple deprecated putting dylibs in /usr/local/lib. In Sonoma (beta 4), this directory has disappeared completely. However, ruby's configure script depends on its existence. So, virtually every ruby installer (RVM, rbenv, as...
-
- Recent GitHub Actions Windows containers seem having Strawberry tools.
-
- According to @naruse, this `kprintf` was to avoid some segfaults, but
turned out it seemed another issue after all. -
08/01/2023
-
11:22 PM Bug #19793: Segmentation fault when requiring files after defining Object#method_missing
- thanks, you all are fast :)
-
- Thank you for reporting this bug.
The following script is a minimal reproduction:
```ruby
GC.stress = true
class Object
public :method_missing
end
File.write("/tmp/empty.rb", "")
require "/tmp/empty.rb"
```
I have a... -
06:32 PM Bug #19793: Segmentation fault when requiring files after defining Object#method_missing
- So instead of `99130.times { array << "a string"}` you can just add `GC.start` and it will also crash.
I also tested it's still failing on master. I'll see if this can be reduced. -
- I was doing ruby koans to learn ruby and I got a segmentation fault when it gets to the part where it uses `Symbol.all_symbols`. I realized it happens with any large Array, but I cannot reproduce in a small test script, just when it runs...
-
- For some reason, there was a pull request that contains a YJIT change
but did not run Cirrus CI, which ended up failing Cirrus CI on master.
This `auto_cancellation` config seems suspicious. Now that we have
`only_if`, I don't think we ... -
-
- * YJIT: handle expandarray_rhs_too_small case
* YJIT: fix csel bug in x86 backend, add test
* Remove commented out lines -
-
03:31 PM Bug #19791: Debugger does not handle delete key correctly
- I just did `gem install reline` and upgraded it to 0.3.7, but the problem persists.
-
- `gem list` gives the following output:
```
*** LOCAL GEMS ***
abbrev (default: 0.1.1)
addressable (2.8.4)
angelo (0.5.1)
base64 (default: 0.1.1)
benchmark (default: 0.2.1)
bigdecimal (default: 3.1.3)
bundler (default: 2.4.17)
byebug (1... -
02:52 PM Bug #19791: Debugger does not handle delete key correctly
- Can you tell me what version of `debug` and `Reline` you are using? Using the latest version of `Reline` may solve the problem.
-
-
01:46 PM Feature #19572 (Closed): Add a new TracePoint event for rescued exceptions
- Applied in changeset commit:git|d68c01fd314ebd6dc1d89c95a2734fad4f0953b0.
----------
support `rescue` event for TracePoint
fix [Feature #19572] -
- fix [Feature #19572]
-
- (https://github.com/ruby/irb/pull/661)
* Create a new Workspace command category
* Update readme
https://github.com/ruby/irb/commit/310650c213 -
- Applied in changeset commit:git|382678d4112f4afc6272244c22924d2b004274b1.
----------
[Bug #19788] Use the result of `tCOLON2` event -
-
- ```ruby
def helper_cant_rescue
begin
raise SyntaxError
rescue
cant_rescue # here
end
end
```
on this case, a line event is reported on `cant_rescue` line
because of node structure. it should not be reported. -
- - Fix indentations of labeled lists.
- Mention performance category. -
05:24 AM Bug #19792: arm の alpine 上でネストしたハッシュに長い文字列を入れると segmentation fault が発生する
- k0kubun (Takashi Kokubun) wrote in #note-1:
> 私の手元の環境では再現させられないのですが、 `[BUG]` の出力を全行、最初から最後まで省略しないで投稿していただくことは可能でしょうか? `c:0001 p:0000 s:0003 E:000da0 DUMMY [FINISH]` で出力が停止してしまっていた場合は、そのように明示していただけると助かります。
早速ご確認いただきありがとうございます。
下記が出力... -
- 私の手元の環境では再現させられないのですが、 `[BUG]` の出力を全行、最初から最後まで省略しないで投稿していただくことは可能でしょうか? `c:0001 p:0000 s:0003 E:000da0 DUMMY [FINISH]` で出力が停止してしまっていた場合は、そのように明示していただけると助かります。
-
- ## 実行環境
Docker version: Docker version 24.0.2, build cb74dfc
Docker image: ruby:3.2.2-alpine3.18
ホスト環境
- chip: Apple M2 Max
- OS version: Version 13.4
## 発生した事象
上記の環境で下記のスクリプトを実行すると、segmentation faultが発生しました。
```
str = 'a'... -
01:44 AM Revision 533dcb8e (git): RDoc for module Process (#8141)
-
12:48 AM Revision 0b8045c9 (git): Supress warnings by Refinement#refined_class in test code
-
- https://github.com/rubygems/rubygems/commit/9be984f281
-
12:27 AM Revision 3f010d48 (git): [DOC] Fix a link [ci skip]
-
- Thanks. I confirmed to work with https://github.com/ruby/ruby/pull/8146
-
- This test is flaky on "SPARC Solaris 10 (gcc)" CI with this message:
TestGCCompact#test_moving_objects_between_size_pools [test/ruby/test_gc_compact.rb:378]:
Expected 499 to be >= 500.
07/31/2023
-
- When entering the debugger using `binding.debugger` or the `rdbg` command, pressing the delete key on the keyboard to delete characters at the REPL merely prints "^[[3~" to the console, and does not actually delete anything. This is **ve...
-
08:10 PM Revision 04f4e0ae (git): [ruby/yarp] Document building, more macro changes
- https://github.com/ruby/yarp/commit/4214f262d2
-
- (https://github.com/ruby/irb/pull/658)
* Decouple `edit` command from `show_source`
2 commands should not depend on each other. If `edit` command also needs
to find a source, the source finding logic should be extracted into a
separate... -
- Not setting a value to global_init_slots causes get_envparam_size to
output a broken default value. -
06:56 PM Revision 954b7ac8 (git): addr2line.c: fix `DW_FORM_ref_addr` parsing for DWARF 2 (#8146)
- addr2line.c: fix DW_FORM_ref_addr parsing for DWARF 2
This fixes a crash when retrieving backtrace info with YJIT enabled on
macOS with Rust 1.71.0. Since Rust 1.71.0, the DWARF info generated by
the Rust compiler uses DW_FORM_ref_addr ... -
- If the stack is not cleared (e.g. compiling with -O0), then `ary` could
remain on the stack, which would be marked. Clear the array first to
make sure all the objects can be GC'd. -
- These arguments can only be `true` or `false` now. Also add markups.
-
- It's not guaranteed that the first element will always be embedded.
-
- This commit stores the initial slots per size pool, configured with
the environment variables `RUBY_GC_HEAP_INIT_SIZE_%d_SLOTS`. This
ensures that the configured initial slots remains a low bound for the
number of slots in the heap, whic... -
- I made a fix for this issue: https://github.com/ruby/ruby/pull/8146
-
- I got some segmentation fault on macOS.
```
1) Failure:
TestVMDump#test_darwin_invalid_call [/Users/hsbt/Documents/github.com/ruby/ruby/test/ruby/test_vm_dump.rb:11]:
pid 35071 exit 1
| -e:1: [BUG] Bus Error at 0x0000000000000001
... -
02:50 PM Feature #19787: Add Enumerable#uniq_map, Enumerable::Lazy#uniq_map, Array#uniq_map and Array#uniq_map!
- joshuay03 wrote:
> What is the usual process for deciding on whether or not to accept a feature?
Ultimately you only have to convince matz. :)
However had, matz may also request additional information and/or use case and
"usefu... -
02:22 PM Feature #19787: Add Enumerable#uniq_map, Enumerable::Lazy#uniq_map, Array#uniq_map and Array#uniq_map!
- joshuay03 (Joshua Young) wrote in #note-4:
> > Is `.map { ... }.uniq` such a very frequent idiom?
> ...
Wouldn’t it make more sense, then, to do `uniq { … }.map { … }`? Yes, there’s a *small* bit of extra code, but it means that you’re i... -
10:13 AM Feature #19787: Add Enumerable#uniq_map, Enumerable::Lazy#uniq_map, Array#uniq_map and Array#uniq_map!
- mame (Yusuke Endoh) wrote in #note-3:
> Is `.map { ... }.uniq` such a very frequent idiom?
I work on a Rails codebase and it's most commonly used to iterate through foreign keys / associated records and get the unique values (quite oft... -
08:40 AM Feature #19787: Add Enumerable#uniq_map, Enumerable::Lazy#uniq_map, Array#uniq_map and Array#uniq_map!
- It does not make sense to me to provide `.foo_map { ... }` for all patterns like `.map { ... }.foo`.
`flat_map` was introduced for some reasons: https://blade.ruby-lang.org/ruby-core/26287
Is `.map { ... }.uniq` such a very frequen... -
-
- ### Use case
On our servers we set [`/proc/sys/kernel/core_pattern`](https://man7.org/linux/man-pages/man5/core.5.html) to point to a small utility that report all the crashes happening in production with the associated core dump into... -
- When matching an incompatible encoding, the Regexp needs to recompile.
If `usecnt == 0`, then we can reuse the `ptr` because nothing else is
using it. This avoids allocating another `regex_t`.
This speeds up matches that switch to incom... -
- > 36023d5cb751d62fca0c27901c07527b20170f4d - mark cc->cme_ if it is for super
for this SEGV. But other patches can be required. -
- @ko1 I don't see any more failures, thank you very much.
So overall the patch is all these commits?
```
c330037c1a38cc257dbe21022fcc7b13159c2821 - cc->cme should not be marked.
6391132c03ac08da0483adb986ff9a54e41f9e14 - fix typo... -
- Thanks,
Could you try current master (I hope it was fixed). -
- @ko1 of course, here you go:
```
Assertion Failed: vm_callinfo.h:339:vm_cc_class_check:cc->klass == 0 || RB_TYPE_P(cc->klass, T_CLASS) || RB_TYPE_P(cc->klass, T_ICLASS)
ruby 3.3.0dev (2023-07-30T08:05:58Z shopify b5c74d5488) [x86_64... -
- Applied in changeset commit:git|a542512b7c394847a488e9b94d9defebe26003ce.
----------
Add Refinement#target and deprecate Refinement#refined_class
[Feature #19714] -
- [Feature #19714]
-
- Applied in changeset commit:git|cfd7729ce7a31c8b6ec5dd0e99c67b2932de4732.
----------
use inline cache for refinements
From Ruby 3.0, refined method invocations are slow because
resolved methods are not cached by inline cache because of... -
- From Ruby 3.0, refined method invocations are slow because
resolved methods are not cached by inline cache because of
conservertive strategy. However, `using` clears all caches
so that it seems safe to cache resolved method entries.
Thi... -
- `struct rb_calling_info::cd` is introduced and `rb_calling_info::ci`
is replaced with it to manipulate the inline cache of iseq while
method invocation process. So that `ci` can be acessed with
`calling->cd->ci`. It adds one indirection ... - 06:59 AM Revision e40f8bbd (git): Update bundled gems list at 2023-07-31
- 06:25 AM Revision a3c0e9d9 (git): [rubygems/rubygems] update Magnus library in Rust extension gem template
- https://github.com/rubygems/rubygems/commit/19a92a3367
-
- `vm_search_super_method()` makes orphan CCs (they are not connected
from ccs) and `cc->cme_` can be collected before without marking. -
- https://github.com/ruby/optparse/commit/2940dbb65a
-
- https://github.com/ruby/ruby/pull/8144
07/30/2023
-
06:13 PM Bug #19788 (Closed): Ripper returns a symbol instead of a token as operator for "::"
- ```ruby
require 'ripper'
class BasicParser < Ripper
EVENTS.each do |event|
module_eval(<<~RUBY, __FILE__, __LINE__ + 1)
def on_#{event}(*args)
puts "#{event}(\#{args.inspect})"
args.unshift :#{event}
... -
-
- At the time this test first started using `assert_raise_with_message`,
it did not touch `Encoding.default_internal`. -
- https://github.com/ruby/optparse/commit/e8bee0be8f
-
- https://github.com/rubygems/rubygems/commit/965e54b8f1
-
- The dedicated method `File.path` to deal with pathname-like objects
has been provided since ruby 1.9.0.
Also adds a test for rubygems/rubygems#6837.
https://github.com/rubygems/rubygems/commit/258c6eda80 -