Revert "Migrate auto_request_review back to CODEOWNERS (#10133)" This reverts commit c5b568bab6a1401df385331e4b6ed6209fe4071d.k0kubun (Takashi Kokubun)
I think ```ruby END { break } ``` should also be a syntax error, as it seems to always result in a `LocalJumpError`, but I could be wrong.kddnewton (Kevin Newton)
Thank you for this ticket. I opened a PR that implements this feature: https://github.com/ruby/ruby/pull/10439peterzhu2118 (Peter Zhu)
`GC.stat` exposes a `heap_live_slots` metric that returns the number of live objects occupying eden slots. Because the slot size was fixed to `RVALUE_SIZE`, this allowed for some basic approximations of how many bytes were live/in-use...mk (Matthias Käppler)
On Linux, `siginfo_t` uses a union for each `si_code`, and the field corresponding to `si_pid` does not belong to the `_sigfault` field for SIGSEGV. It actually overlaps the `si_addr` field, which is usually non-zero on stack overflow. ...nobu (Nobuyoshi Nakada)
I am wondering how Regexp encoding modifiers (u, s, e, n) interfere in encoding negotiation of parts/fragments in an interpolated Regexp literal. Examples #1 ```ruby # encoding: us-ascii # Unicode: Ф - U+0424 # windows-1251: Ф...andrykonchin (Andrew Konchin)
* [Feature #20350] Return chilled string from Symbol#to_s * Since there are now chilled strings, it seems the perfect tool to transition to Symbol#to_s eventually returning a frozen String to avoid wasteful allocations. * OK to ret...Eregon (Benoit Daloze)
* [Feature #20396] Add `string_value: true/false` parameter to `ObjectSpace.dump_all` (byroot) * This method is often used in production to investigate memory leak and other memory related issues. * Because it dumps (pure ASCII) stri...byroot (Jean Boussier)
> It seems to behave a bit like string interpolation/concatenation here Specifically: ``` $ ruby -e '# encoding: EUC-JP p ("a" + "\xC3\xA9".force_encoding("UTF-8") + "c").encoding' #<Encoding:UTF-8> ``` But it seems very much unexpecte...Eregon (Benoit Daloze)
I found another case which does not seem to respect those rules: ``` $ ruby -ve 'p /#{"é".dup}/e.encoding' ruby 3.3.0 (2023-12-25 revision 5124f9ac75) [x86_64-linux] #<Encoding:UTF-8> $ ruby -e 'p /a#{"é".dup}b/e.encoding' #<Encod...Eregon (Benoit Daloze)
> By default, a regexp with only US-ASCII characters has US-ASCII encoding: I was wondering what kind of check is used for that and it seems to be checking the Regexp source when building it (makes sense): ``` $ ruby -e 'p /a/.encod...Eregon (Benoit Daloze)
prime is already extracted from ruby repository to https://github.com/ruby/prime. We should move to its place.hsbt (Hiroshi SHIBATA)
This is a global variable and may happen to be set to 4 elsewhere. http://ci.rvm.jp/logfiles/brlog.trunk.20240403-054356#L1707 ``` The if expression with a boolean range ('flip-flop' operator) warns when Integer literals are used instea...nobu (Nobuyoshi Nakada)
zverok (Victor Shepelev) wrote in #note-7: > When writing/reading in Ruby some math, there are several different irky things: One thing that irks me about Math::sin and friends is that these are not available as methods (on Float a...duerst (Martin Dürst)
> This proposal is half joke, half serious. There are several interesting things to unpack here (though I don’t see any actionable proposals). When writing/reading in Ruby some math, there are several different irky things: 1. `Math:...zverok (Victor Shepelev)
April Fools' Day is over. Closing. This proposal is half joke, half serious. I can think of some reasons why we should introduce `2pi`. ### There are some languages that provide not only `pi` but also commonly used values. @ko1 ...mame (Yusuke Endoh)
readline wrapper is extracted to https://github.com/ruby/readline-ext. Can you file your request to https://github.com/ruby/readline-ext ? Or we used reline that is pure ruby altanative of readline today. You may need to file this to ...hsbt (Hiroshi SHIBATA)
The C wrapper library of libreadline is extracted https://github.com/ruby/readline-ext from Ruby 3.3. If you still interest this, can you submit your proposal to upstream?hsbt (Hiroshi SHIBATA)
prime is maintained at https://github.com/ruby/prime today. If you still interest this, can you submit this to upstream repo? hsbt (Hiroshi SHIBATA)
I am wondering what are the rules to calculate Regexp literal encoding in case an encoding modifier is specified. From the documentstion: > By default, a regexp with only US-ASCII characters has US-ASCII encoding: > ... Looking ...andrykonchin (Andrew Konchin)
* YJIT: A64: Use ADDS/SUBS/CMP (immediate) when possible We were loading 1 into a register and then doing ADDS/SUBS previously. That was particularly bad since those come up in fixnum operations. ```diff # integer left shift with rh...alanwu (Alan Wu)
kjtsanaktsidis (KJ Tsanaktsidis) wrote in #note-13: > That's not a bad idea (avoid adding yet more combinations!) but do you know how widely these builds are currently used and what for? ASAN will make them a heck of a lot slower so tha...Eregon (Benoit Daloze)
This issue has been fixed at recent version of Bundler. https://github.com/rubygems/rubygems/pull/7016hsbt (Hiroshi SHIBATA)
Applied in changeset commit:git|8b55aaa85ca3b5333e6659f0f0b1eabdd0b9491b. ---------- [Feature #20345] Add `--target-rbconfig` option to mkmf Introduce a new mkmf option `--target-rbconfig` to specify the RbConfig file for the deploymen...katei (Yuta Saito)
Introduce a new mkmf option `--target-rbconfig` to specify the RbConfig file for the deployment target platform. This option is useful for cross-compiling Ruby extensions without faking the global top-level `RbConfig` constant.katei (Yuta Saito)
* [Feature #20347] Separate docs task from all * I would like to remove docs task from main. It works same as current behavior. * https://github.com/ruby/ruby/pull/10282/commits/b160083175aed062c320b8d76eafe1c8706309d4hsbt (Hiroshi SHIBATA)
Applied in changeset commit:git|799e854897856e431c03a5122252358e2c57aff2. ---------- [Feature #20331] Simplify parser warnings for hash keys duplication and when clause duplication This commit simplifies warnings for hash keys duplicat...yui-knk (Kaneko Yuichiro)
This commit simplifies warnings for hash keys duplication and when clause duplication, based on the discussion of https://bugs.ruby-lang.org/issues/20331. Warnings are reported only when strings are same to ohters.yui-knk (Kaneko Yuichiro)
> How about making ASAN enabled for ruby-debug builds That's not a bad idea (avoid adding yet more combinations!) but do you know how widely these builds are currently used and what for? ASAN will make them a heck of a lot slower so t...kjtsanaktsidis (KJ Tsanaktsidis)
kjtsanaktsidis (KJ Tsanaktsidis) wrote in #note-11: > * Could we get an ASAN build of ruby into setup-ruby? This would make it easier to use ASAN with github actions and the like. How about making ASAN enabled for ruby-debug builds a...Eregon (Benoit Daloze)
(https://github.com/ruby/reline/pull/647) * Refactor completion: split autocompletion and tabcompletion logic and state * Move completion candidate listup logic from dialog proc to LineEditor https://github.com/ruby/reline/commit/c3c0...tompng (tomoya ishida)
This has been brought up before to add the constant `tau` https://bugs.ruby-lang.org/issues/17496jzakiya (Jabari Zakiya)
The Tau Manifesto (https://tauday.com/) was introduced by Michael Hartl, a Rubyist, and handily `𝜏 == 2π` so it might be worth also considering the tau letter: 𝜏shan (Shannon Skipper)
I really like this proposal. But I think for most of the world, it was a few hours too early. A time around 2024-04-01 12:00:00 UTC may have been easier to understand for most of the world.duerst (Martin Dürst)
We just need to filter versions belonging to the range, but don't need anything else. https://github.com/rubygems/rubygems/commit/8355a225d7deivid (David Rodríguez)
So that we don't need to reverse the Array. https://github.com/rubygems/rubygems/commit/aeea5e2e00deivid (David Rodríguez)
We do that when first caching versions, and then it's no longer necessary. https://github.com/rubygems/rubygems/commit/ede15847dbdeivid (David Rodríguez)
And also so that it matches the method used by main PubGrub sample resolver class. https://github.com/rubygems/rubygems/commit/0e612361b8deivid (David Rodríguez)
vo.x (Vit Ondruch) wrote in #note-1: > I like this proposal. But there are other possibilities, such as: > ... Thank you for the comment, but you may know `(:` can conflict existing code. The reason I selected `(|` is that `/:|)` is u...nobu (Nobuyoshi Nakada)
I like this proposal. But there are other possibilities, such as: ~~~ (: This is comment :) ~~~ That would just underline Ruby as a "happy" language. Of course variants such as `(-: ... :-)` or even `(o: ... :o)` could even exte...vo.x (Vit Ondruch)
Applied in changeset commit:git|80bda107c84187d90eeff9497d465e086364b420. ---------- [ruby/resolv] Add an explicit with_udp_and_tcp helper to test_dns.rb This helper tries to bind UDP and TCP sockets to the same port, by retrying the b...Anonymous
The test TestResolvDNS#test_query_ipv4_address_truncated_tcp_fallback wants to make a TCP and UDP DNS server on the same port. It achieves this by binding to a random UDP port (with `:0`), and then trying to bind to that TCP port. Howeve...kjtsanaktsidis (KJ Tsanaktsidis)
This helper tries to bind UDP and TCP sockets to the same port, by retrying the bind if the randomly-assinged UDP port is already taken in TCP. This fixes a flaky test. [Bug #20403] https://github.com/ruby/resolv/commit/3d135f99d9KJ Tsanaktsidis
I propose a new Float literal: `2pi`. ```ruby p 2pi #=> 6.283185307179586 == 2 * Math::PI ``` I am not proposing `1pi`, `3pi` or `4pi`. I do only `2pi`. Because in most cases, all you need is `2pi`. Any other multiple of pi is r...mame (Yusuke Endoh)
OK! Everything required to make `make check` pass on my machine with ASAN enabled has been merged! I opened https://github.com/ruby/ruby/pull/10412 to update the documentation to include the correct incantation. The next things I woul...kjtsanaktsidis (KJ Tsanaktsidis)
Applied in changeset commit:git|9d0a5148ae062a0481a4a18fbeb9cfd01dc10428. ---------- Add missing RB_GC_GUARDs related to DATA_PTR I discovered the problem in `compile.c` from a failing TestIseqLoad#test_stressful_roundtrip test with AS...Anonymous
I discovered the problem in `compile.c` from a failing TestIseqLoad#test_stressful_roundtrip test with ASAN enabled. The other two changes in array.c and string.c I found by auditing similar usages of DATA_PTR in the codebase. [Bug #20402]KJ Tsanaktsidis
The changeset bb59696614083660241ef272f222628cbfa95844 cannot be merged into ruby_3_2 branch cleanly and hard to me to write a patch. @tompng Could you kindly create the patch for ruby_3_2 branch?nagachika (Tomoyuki Chikanaga)
Fix coderange of invalid_encoding_string.<<(ord) Appending valid encoding character can change coderange from invalid to valid. Example: "\x95".force_encoding('sjis')<<0x5C will be a valid string "\x{955C}" --- ...nagachika (Tomoyuki Chikanaga)
Memory leak with TracePoint on bmethod [Bug #20194] When disabling the TracePoint on bmethod, the hooks list is not freed. For example: obj = Object.new obj.define_singleton_method(:foo...nagachika (Tomoyuki Chikanaga)
If there is a shape cache, then we should believe the results instead of doing a linear search for non-existent items This fixes a case where checking the index of an undefined ivar would result in an O(n) search. Now we get O(log n). ...tenderlovemaking (Aaron Patterson)
Add a Ruby script mode to `tool/missing-baseruby.bat` that checks if `RUBY_VERSION` meets the required version. This will enable similar checks on mswin as well.nobu (Nobuyoshi Nakada)
With ASAN enabled, the TestIseqLoad#test_stressful_roundtrip fails with the following output: ``` 2/9] TestIseqLoad#test_stressful_roundtrip = 7.26 s 1) Failure: TestIseqLoad#test_stressful_roundtrip [/home/kj/ruby/test/-ext-/ise...kjtsanaktsidis (KJ Tsanaktsidis)
I agree, but I still think Ripper should match the parser's behavior here. Otherwise you can't get the AST of those kinds of files.kddnewton (Kevin Newton)
Shebang makes sense only in an executable script file. ```sh $ echo $'#!/bin/sh\np :sh' | ruby ruby: no Ruby script found in input (LoadError) bash: exit 1 $ ruby -e $'#!/bin/sh\np :sh' :sh ```nobu (Nobuyoshi Nakada)
I've opened a PR here https://github.com/ruby/ruby/pull/10406. I'm assuming no one has an objection based on the silence, so I'll merge once CI passes.kddnewton (Kevin Newton)
`BEGIN` blocks are: a. executed in the order they appeared in the same nesting level. b. executed in prior to outside the block. > ```ruby > ... "2" is first because it is in the inner `BEGIN` in the block for "1". > ```ruby ...nobu (Nobuyoshi Nakada)
This behavior was discovered and briefly discussed during the previous dev meeting. The actual warning is ``` test.rb:4: warning: duplicated 'when' clause with line 2 is ignored ``` According to @nobu, this reads "The 'when' clau...mame (Yusuke Endoh)
On the otherhand, if you have duplicated hash keys you get: ```ruby { bar: 1, baz: 1, bar: 1 } ``` For the warning: `warning: key :bar is duplicated and overwritten on line 4`. So this seems correct.kddnewton (Kevin Newton)
When you have a duplicated when clause, you get a warning for it. For example: ```ruby case foo when :bar when :baz when :bar end ``` you get ``warning: duplicated `when' clause with line 2 is ignored``. But the when claus...kddnewton (Kevin Newton)
In `jit_rb_int_lshift()`, we guard against the right hand side changing since we want to avoid generating variable length shifts. When control reaches a `putobject` and `opt_ltlt` pair, though, we know that the right hand side never chan...alanwu (Alan Wu)
byroot (Jean Boussier) wrote in #note-10: > `StringIO` isn't as convenient as you make it out to be. Maybe it could become that, but it isn't today. Hmm, it's not like it matters very much, but I get the weird feeling you misundersto...Dan0042 (Daniel DeLorme)
> but rest assured once we can start using IO::Buffer exclusively, I will do so. I'd be curious to see an HTTP1 parser using IO::Buffer. I don't see how you'd do it today.byroot (Jean Boussier)
My protocol gems have been around since Ruby 2.3+ so there are compatibility issues, but rest assured once we can start using `IO::Buffer` exclusively, I will do so. Using `String` for IO buffers is equally fraught with odd issues like e...ioquatix (Samuel Williams)
> What about IO::Buffer? It was introduced somewhat stealthily and its API is somewhat unique, and yet by its idea it seems to be exactly that. I'm aware of it, but it only offer binary oriented methods. Perhaps it could be extended t...byroot (Jean Boussier)
> I'd be all for a dedicated `Buffer` class that allow to efficiently parse text protocols like HTTP and RESP3, but right now all we got is String. What about [IO::Buffer](https://docs.ruby-lang.org/en/master/IO/Buffer.html)? It was i...zverok (Victor Shepelev)
> This interpretation mismatch could be a source of vulnerability. Good catch @mame, that does indeed make the `to_i` proposal much more problematic. I guess I don't really have much of a proposal anymore. > ... Not today no. You c...byroot (Jean Boussier)
I thought of a security concern. I suppose all methods proposed in this ticket would allow underscores as a digit separator. This is natural in Ruby, but usually an unnecessary feature outside of Ruby, including the Redis protocol. T...mame (Yusuke Endoh)
Right now there are specs for the order in which `BEGIN{}` should be executed, which is the order they appear in the file. For example: ```ruby BEGIN { print "1" } print "4" BEGIN { print "2" } print "5" BEGIN { print "3" } ``` ...kddnewton (Kevin Newton)
Most of the calls to `FormatError.new` pass `@gem` for the second argument, which has a `path` method. But in one case—on package.rb:691 in `verify_gz`, the `source` argument is a `String`. So if there's ever a GZip decode error when a...jez (Jake Zimmerman)
I found the following ASAN error in `TestRubyLiteral#test_integer`. It appears that this code is calling strdup on a non-null terminated string. ``` [1/1] TestRubyLiteral#test_integer==================================================...kjtsanaktsidis (KJ Tsanaktsidis)
For the given script: ```ruby #!/bin/sh # -*- ruby -*- exec "${RUBY-ruby}" "-x" "$0" "$@" && [ ] if false #!ruby # This needs ruby 2.0, Subversion and Git. # As a Ruby committer, run this in an SVN repository # to commit a chan...kddnewton (Kevin Newton)
"ioquatix (Samuel Williams) via ruby-core" <[email protected]> wrote: > Issue #19057 has been updated by ioquatix (Samuel Williams). > > > > Why don't you reconsider the "nested public interface" approach? > > My asses...Anonymous
* [Bug #19865] Segfault when calling user signal handlers during VM shutdown * Seems like the bug is well understood and there is a patch for it (https://github.com/nobu/ruby/tree/signal-at-cleanup), can it be merged?dentarg (Patrik Ragnarsson)
Any chance this could be backported into Ruby 3.2? It was a bit tricky because of the VWA-related changes in 3.3, but I did manage to open a PR to do this: https://github.com/ruby/ruby/pull/10394 I'm running into this problem with the...kjtsanaktsidis (KJ Tsanaktsidis)
We use the following site for that now: * https://tools.ietf.org/ or http * https://datatracker.ietf.org or http Today, IETF said the official site of RFC is www.rfc-editor.org. FYI: https://authors.ietf.org/en/references-in-rfcxml I...hsbt (Hiroshi SHIBATA)
11:44 PM Revision 60567731 (git): Move shareable_constant_value logic from parse.y to compile.c
09:34 PM Revision 4ef99905 (git): [PRISM] Enhance syntax error message extraction in test_literal_suffix btest
09:28 PM Revision 571bfc74 (git): YJIT: update code optimization tips in yjit.md (#10445)
07:49 PM Revision c7cda1ae (git): YJIT: Let sp_opnd take the number of slots (#10442)
03:40 PM Feature #20408: Add heap_live_slots to GC.stat_heap
02:24 PM Feature #20408 (Open): Add heap_live_slots to GC.stat_heap
02:14 PM Revision f928e60d (git): Check if a fatal signal is from kernel
11:50 AM Misc #20407 (Closed): Question about applying encoding modifier to an interpolated Regexp
10:45 AM Feature #20350: Return chilled string from Symbol#to_s
08:00 AM Misc #20336: DevMeeting-2024-04-17
06:10 AM Misc #20406: Question about Regexp encoding negotiation
09:07 AM Revision 25e28559 (git): Ignore warnings on the bundled gems repo
07:17 AM Revision 56ecd803 (git): Launchable: Add lineNumber field
07:04 AM Feature #20404: `2pi`
06:35 AM Feature #20404: `2pi`
01:16 AM Feature #20404 (Rejected): `2pi`
12:55 AM Revision b664590c (git): [DOC] Fix examples for `u` packing directive
04:29 PM Revision 3c4de946 (git): YJIT: A64: Use ADDS/SUBS/CMP (immediate) when possible (#10402)
12:53 PM Revision 5903fdf4 (git): [DOC] Fix wheather -> whether typos in configure.
05:26 AM Feature #20345 (Closed): Add `--target-rbconfig` option to mkmf
10:17 PM Misc #20387: Meta-ticket for ASAN support
06:12 PM Revision a531cac3 (git): [ruby/reline] Refactor completion
04:00 PM Feature #20404: `2pi`
02:26 PM Feature #20404: `2pi`
03:03 PM Revision e2a1d0b5 (git): [rubygems/rubygems] Improve error message when strict resolution filters out everything
08:41 AM Feature #20405: Inline comments
08:17 AM Bug #20231: Don't wait in io_binwrite_string if not necessary.
03:05 AM Revision 0774232b (git): Remove unnecessary macros and functions for Universal Parser
01:06 AM Revision e07178d5 (git): [DOC] Fix scope resolution operator typo in `Process#wait` docs
11:57 PM
Bug #20403 (Closed): TestResolvDNS#test_query_ipv4_address_truncated_tcp_fallback can flake if TCP port is in use
10:20 AM Bug #20245: Crash when checking symbol encoding
02:24 AM Revision 9579cf45 (git): If we have a shape cache we should use it
11:13 PM Revision 02d40b6c (git): Use ubf list on cygwin
07:13 PM Feature #20394: Add an offset parameter to `String#to_i`
03:54 PM Revision 97b2cc34 (git): Allow FormatError to take either String or Gem for source
06:52 AM Misc #20336: DevMeeting-2024-04-17