Activity
From 09/21/2024 to 09/27/2024
09/27/2024
-
05:45 PM Revision 027ef605 (git): [Bug #20763] Add tests
-
05:44 PM Bug #20763 (Closed): Stack consistency error with bare endless range
-
- Thanks @tompng — https://github.com/ruby/ruby/pull/11714 should fix this.
-
04:50 PM Bug #20763 (Closed): Stack consistency error with bare endless range
- `<compiled>: [BUG] Stack consistency error (sp: 7, bp: 6)` running these codes. No error with --parser=parse.y
~~~sh... -
- Fixes [Bug #20763]
-
-
04:49 PM Revision d1324170 (git): [rubygems/rubygems] Warning about PATH in `--user-install` mode is only necessary for gems with executables
- https://github.com/rubygems/rubygems/commit/2fe0f452a2
-
- I meant that I think in Ruby 3.4 (prior to my patch), the warning would also apply to non Bundler contexts that lead ...
-
03:33 PM Bug #20714: Handle optional dependencies in `bundled_gems.rb`
- deivid (David Rodríguez) wrote in #note-14:
> I think this would affect both Bundler and non Bundler usages. Current... -
11:08 AM Bug #20714: Handle optional dependencies in `bundled_gems.rb`
- I see that https://github.com/ruby/ruby/pull/11550 was merged which is great but I'm confused about https://github.co...
-
- I also really like @ioquatix 's suggestion in https://bugs.ruby-lang.org/issues/6012#note-13 and it is a lot more fle...
-
- It seems good to revisit this, the workarounds are pretty messy and CRuby-specific, e.g. https://github.com/rails/rai...
-
- * [Feature #6012] Proc#source_location also return the column (eregon)
* How about `{Proc,Method,UnboundMethod}.sou... -
- Thanks for the links, yes, that seems a perfect use case for more information in `#source_location`, going through `R...
-
- Eregon (Benoit Daloze) wrote in #note-7:
> @Earlopain Is there a reason you need this and cannot just use e.g. `Prism... -
- In general the entire `RubyVM::AbstractSyntaxTree` module should be considered deprecated (and maybe even removed), g...
-
- @Earlopain Is there a reason you need this and cannot just use e.g. `Prism.parse("proc {1 + 2}")`?
A cleaner and por... -
-
- These days, I believe there is no value to make `RubyVM::AbstractSyntaxTree` stable.
The official Ruby API to parse ... -
- Since #11698, `parser_str_new` makes `rb_parser_string_t` and `VALUE`
but discards the former, and then `STR_NEW3` ma... -
-
01:58 PM Revision 098649bc (git): [ruby/rdoc] Add home page link to output message
- (https://github.com/ruby/rdoc/pull/1165)
The link is clickable in the terminal and opens the home page in the browse... -
10:34 AM Revision 7f83bd37 (git): Reduce `is_ascii_string` function dependency for parser
- Changed to use `rb_parser_is_ascii_string` function instead of `is_ascii_string` function
-
09:39 AM Revision c1ee5ea2 (git): Avoid to unintentional Bundler definition by Bundler::Definition.no_lock
-
-
09:20 AM Revision eff16d93 (git): Implement OP_ASGN1 NODE locations
-
-
- https://github.com/ruby/ruby/actions/runs/11063957302/job/30741993035#step:8:1816
----
```
/github/workspace/s... -
-
-
-
05:39 AM Revision 52bb90f9 (git): sequential execution of some CI tasks
- reduced parallelism from some 50-ish to 10-ish so that other jobs
can run. -
-
- https://github.com/ruby/ruby/commits/master/.github/workflows/mingw.yml is available today.
-
04:31 AM Revision d7e5133d (git): [ruby/benchmark] Add example for Benchmark.realtime
- https://github.com/ruby/benchmark/commit/0f278be6c1
-
- https://github.com/ruby/benchmark/commit/388236685c
-
-
-
09/26/2024
-
- Yeah, I think it would make sense to update those docs to indicate that it only works when the instruction sequences ...
-
- This is great info, thank you! I'm aware about the non-guarantees for `RubyVM`, just something to live with. `Abstrac...
-
- Note that all the APIs under RubyVM are subject to change, so you're effectively calling internal APIs here. Just so ...
-
- For a proc you can mirror what `RubyVM::AbstractSyntaxTree.of` is doing under the hood using `RubyVM::InstructionSequ...
-
- kddnewton (Kevin Newton) wrote in #note-1:
> This is expected behavior. The instruction sequences will have differen... -
- This is expected behavior. The instruction sequences will have different node ids, so it's not possible to retrieve t...
-
- https://docs.ruby-lang.org/en/master/RubyVM/AbstractSyntaxTree.html#method-c-of
```rb
RubyVM::AbstractSyntaxTree.... -
- I think this would affect both Bundler and non Bundler usages. Currently the warnings recommends to install the gem f...
-
- https://github.com/ruby/ruby/pull/11550 seems a good solution to me.
I think it is expected to only get the LoadErro... -
- Maybe I have another solution alltogether:
```rb
begin
gem 'fiddle'
rescue LoadError
# Not available, no r... -
- @deivid Thanks for sharing. My concern is [here](https://github.com/ruby/ruby/pull/11550#issuecomment-2376573020)
... -
- @hsbt found an issue with the simpler approach. It will no longer show information about bundled gem extraction "afte...
-
- From duplicate code in `decl_branch_base` and `add_trace_branch_coverage`.
-
- 03:47 PM Revision 9a966a09 (git): [ruby/prism] Fix incorrect reference to AlternationPatternNode as non-void expressions
- https://github.com/ruby/prism/commit/68de31919e
- 03:47 PM Revision a73d80db (git): [ruby/prism] Add fields documentation for AliasMethodNode and AlternationPatternNode
- https://github.com/ruby/prism/commit/6953daebde
-
- https://github.com/ruby/prism/commit/976a3cd0a5
- 01:39 PM Revision e71f8905 (git): Update default gems list at 49057f36efd894663cc879be08ada0 [ci skip]
-
- (https://github.com/ruby/irb/pull/1009)
https://github.com/ruby/irb/commit/04cd2317ef -
-
-
-
- From duplicate code in `rb_CFString_class_initialize_before_fork` and
`rb_str_append_normalized_ospath`. -
-
-
-
-
- Turns out we were not running specs on JRuby, so we introduced a
failure. Seems fine to skip.
https://github.com/rub... -
07:38 AM Feature #20437: Could the licensing conditions be made less ambiguous?
- @Matz would you mind to comment on the license? How it should be properly applied? What (SPDX) identifiers should be ...
- 07:34 AM Revision 8cd295ec (git): regparse possible memory leak fix proposal
-
- * [Feature #10459] [PATCH] rfc3339 method for Time
* https://github.com/rails/rails/blob/b88d9af34fbc1c84ce2769ba02... -
- https://github.com/ruby/digest/commit/07a5db2f77
-
04:00 AM Bug #13831: error when try to install
- ruby_3_2 commit:2d62c5d3d9a565fe50a3582124e6d4a58d130084 merged revision(s) commit:0d16c36d0ab2afa2ec79b72b229e69c141...
-
- [win32/registry] Fallback to UTF-8 for unknown codepages
There are some codepages like cp708 for which no ru... - 02:58 AM Revision 7340c1ac (git): Bump actions/checkout in /.github/actions/setup/directories
- Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.7 to 4.2.0.
- [Release notes](https://github.c... -
- Ruby 3.0 is EOL now. We will not backport related changes into `ruby_3_0` branch.
-
09/25/2024
-
- `[email protected]` is not related for this build failure.
I could build applied https://bugs.ruby-lang.org/projects/rub... -
- Following commits will be needed to compile 3.0 with the recent Xcode:
- commit:4113862c0068a8a95d752f5fdf14980f92cd... -
02:22 PM Bug #20760 (Closed): Ruby 3.0.6 fails to build on macOS 15.0 24A335 arm64
- I support a Rails 6.1 project with Ruby 3.0.6 and am unable to build 3.0.6 on a new mac book pro running macOS 15.0 2...
-
-
- https://github.com/ruby/prism/commit/dc7164e21c
- 07:43 PM Revision fa7fef27 (git): [ruby/prism] Fix rendering of type overview docs
- https://github.com/ruby/prism/commit/d42bc309cc
-
- https://github.com/ruby/prism/commit/988ac82187
-
06:42 PM Revision 8bf55328 (git): [DOC] Tweaks for Array#find_index (#11686)
-
- https://github.com/ruby/prism/commit/84a9251915
-
- https://github.com/ruby/prism/commit/509ff88e92
-
-
-
-
-
- https://github.com/ruby/prism/commit/b624e09cc6
-
-
04:18 PM Revision 505206b8 (git): YJIT: Cache Context decoding (#11680)
-
- https://github.com/ruby/prism/commit/4daf58f7a0
-
- https://github.com/ruby/prism/commit/9fd0c0901e
-
- https://github.com/ruby/prism/commit/a474017bbe
-
03:14 PM Revision b7777249 (git): Don't check poisoned for immediates
-
- To debug this issue on CI:
http://ci.rvm.jp/logfiles/brlog.trunk_asan.20240922-002945 -
-
- * For Loader.java, do not deserialize the AST if there are errors, so then Java nodes only have non-error types for f...
-
- The allocated parser string is never freed, which causes a memory leak.
The following code leaks memory:
Ripper... -
- 02:45 AM Revision 76543a34 (git): Bump github/codeql-action from 3.26.8 to 3.26.9
- Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.8 to 3.26.9.
- [Release notes](https:... -
-
- I merged https://github.com/ruby/ruby/pull/7366 for this.
- 01:43 AM Revision 0d16c36d (git): [win32/registry] Fallback to UTF-8 for unknown codepages
- There are some codepages like cp708 for which no ruby encoding exists:
$ ruby -e "Encoding.find('cp708')"
Tr... -
-
-
09/24/2024
- 10:06 PM Revision 6b46060f (git): doc: Remove description of experimental warnings related pattern matching from documentation
- Ruby 3.2.0 has been released and all experimental warnings about pattern matching have been removed.
Experimental war... -
-
-
07:25 PM Revision d31378dc (git): [ruby/psych] Use `String#match?` over `String#=~` when applicable
- Save on allocating useless `MatchData` instances.
https://github.com/ruby/psych/commit/b2d9f16e58 -
- UNREACHABLE uses __builtin_unreachable which is not intended to be used
as an assertion. -
- The UNREACHABLE macro calls __builtin_unreachable, which according to
the [GCC docs](https://gcc.gnu.org/onlinedocs/g... -
- Note that there is another discussion around retrieving command line options given here: https://bugs.ruby-lang.org/i...
-
- This is on purpose. This should be a transparent change and not visible to the end user. If you need to access the pa...
-
06:17 PM Feature #20759 (Rejected): No good API to query which parser is being used
- Right now the best way I found is:
```ruby
parser = RUBY_DESCRIPTION =~ /prism/i ? "prism" : "parse.y"
```
Th... -
- Co-authored-by: Takashi Kokubun <[email protected]>
-
-
-
- This was introduced by https://github.com/rubygems/rubygems/commit/0b7be7bb7705, because
the original patch was not a... -
- (https://github.com/ruby/irb/pull/1008)
https://github.com/ruby/irb/commit/f6b06a9a40 -
- such as:
p = Proc.new
This now matches the RubyVM::AbstractSyntaxTree behavior, which is
not to highlight anythin... -
- https://github.com/ruby/prism/commit/098f1c4607
-
- add_adjust_info will increment the insns_info_index, so we need to set
the node_id to -1 to prevent a "Conditional ju... -
-
- https://github.com/ruby/prism/commit/a4fcd5339a
-
- * Otherwise it is invalid e.g. to call strlen() to the result,
or to assume the argument was a string.
* All caller... -
- I suspect someone could be setting this instance variable, and the
previous changes made that no longer effective.
A... -
- https://github.com/rubygems/rubygems/commit/6d627e0671
- 06:33 AM Revision 4b1e852d (git): [ruby/error_highlight] Prism added node_id and Node#breadth_first_search in the 1.0 release. These methods are required for Prism to be able to find the method from the backtrace.
- https://github.com/ruby/prism/blob/main/CHANGELOG.md#100---2024-08-28
In practice you will likely only end up in thi... -
06:12 AM Revision 373f679e (git): fix rb_memsearch() document
- ## Why?
The explanation of x and y is reversed.
https://github.com/ruby/ruby/blob/ddbd64400199fd408d23c85f9fb0d7f742... -
06:05 AM Revision 4956324a (git): mingw.yml - fixup to use ucrt, logging
- 05:18 AM Revision fac5aa05 (git): Bump github/codeql-action from 3.26.7 to 3.26.8
- Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.7 to 3.26.8.
- [Release notes](https:... -
05:06 AM Revision acf28e83 (git): Windows: Use Unicode aware WinAPI function for ENV[]=
- This only makes a difference when setting an empty value to a Unicode key.
-
- Windows Vista removed the limit to 32768 bytes environment block.
Also MINGW supports _wputenv_s() for years. -
- Using _wputenv_s simplifies the code and we can avoid code duplication by using rb_w32_home_dir() to initialize ENV['...
-
-
- The Xcode version had no effect on this.
In fact, the same error appeared on macOS 15.0 for binaries built with eith...
09/23/2024
-
-
- ../time.c:5247:50: warning: operand of ‘?:’ changes signedness from ‘int’ to ‘long unsigned int’ due to unsignedness ...
-
- enumerator's meth attribute is an ID, which is not a Ruby object, so we
should not apply the write barrier on it. -
- @hsbt is there any way you can open a pull request with a failing test? All of the windows environments I'm seeing on...
-
06:29 PM Bug #20745: IO::Buffer#copy triggers UB when src/dest buffers overlap
- After reviewing `memcpy` and `memmove` from open-source libc implementations, I found some optimize for small copies ...
-
04:53 PM Bug #20758 (Closed): Build failure with macOS Sequoia (15.0) and Xcode 16
- Closing this as a duplicate. My apologies.
-
- ## Observed behaviour
Test failures in `TestProcess#test_daemon_noclose`. Output as follows:
```
Run options:
... -
-
04:25 PM Revision 5b600987 (git): Ensure fiber scheduler is woken up when close interrupts read
- If one thread is reading and another closes that socket, the close
blocks waiting for the read to abort cleanly. This... -
- This reverts commit 69f28ab715a02692fb2a9128bed46044963cbb50.
This commit is being reverted because it does not fix ... -
- 12:23 PM Revision 4c3727c6 (git): Add anonymous module name spec.
-
12:20 PM Bug #20733: Build failure OpenSSL extension with FreeBSD 13.3
- It's good to know that the build failure was fixed. Can we close this issue ticket now?
-
- https://github.com/rubygems/rubygems/commit/1a7a3fdeb9
-
10:49 AM Revision d0925c07 (git): [rubygems/rubygems] Ensure refs directory in cached git source
- See https://github.com/rubygems/rubygems/issues/8046 for details
Prior to this commit a cached git source without a ... -
- It was printing incorrect output and returning incorrect status.
https://github.com/rubygems/rubygems/commit/96f5979c7d -
- And refine uncommon date cases.
# Iteration per second (i/s)
| |compare-ruby|built-ruby|... -
- Backport PR for 3.3 - https://github.com/ruby/ruby/pull/11664
No backport for 3.2 is required because this locking... -
-
-
- 12:11 AM Revision 02b36f75 (git): Unpoison page->freelist before trying to assert on it
- Otherwise trying to deref the pointer can cause an ASAN crash, even
though the only reason we're dereferencing it is ...
09/22/2024
-
11:36 AM Feature #20757: Make rb_tracearg_(parameters|eval_script|instruction_sequence) public C-API
- Actually it seems like retrieving the method object using the `method_id` does not work well for super-calls. See thi...
-
- This change is reduce Ruby C API dependency for Universal Parser.
Reuse dedent_string functions in rb_ruby_ripper_ded...
09/21/2024
-
06:00 PM Bug #20337 (Closed): Complex#inspect mutates the string returned by `real.inspect`
- Applied in changeset commit:git|9f574fa12f0cbe9d7aa4a11a6c7055ed32f02822.
----------
Make Complex#{inspect,to_s} wor... -
- Make static f_format function take a non-frozen string to append
to.
This does not result in an additional allocatio... -
- nobu (Nobuyoshi Nakada) wrote in #note-7:
> Sorry to be late.
> I updated the [PR](https://github.com/ruby/ruby/pul...
Also available in: Atom