Attachment #8727312 for bug #1248340

Attachment #8727312: Part 10: Add a flag for allowing or not to use StepMiddle in nsTimingFunction (v2) for bug #1248340

View | Details | Raw Unified | Return to bug 1248340
Collapse All | Expand All





      numTransitions = data.num;
  }

  return numTransitions;
}

/* static */ void
nsRuleNode::ComputeTimingFunction(const nsCSSValue& aValue,
                                  nsTimingFunction& aResult,
                                  bool aAllowStepMiddle)
{
  switch (aValue.GetUnit()) {
    case eCSSUnit_Enumerated:
      {
        int type = aValue.GetIntValue();
        if (type == NS_STYLE_TRANSITION_TIMING_FUNCTION_STEP_MIDDLE &&
            !aAllowStepMiddle) {
          type = NS_STYLE_TRANSITION_TIMING_FUNCTION_EASE;
        }
        aResult = nsTimingFunction(type);
      }
      break;
    case eCSSUnit_Cubic_Bezier:
      {
        nsCSSValue::Array* array = aValue.GetArrayValue();
        NS_ASSERTION(array && array->Count() == 4,
                     "Need 4 control points");
        aResult = nsTimingFunction(array->Item(0).GetFloatValue(),
                                   array->Item(1).GetFloatValue(),

                      array->Item(1).GetIntValue() ==
                       NS_STYLE_TRANSITION_TIMING_FUNCTION_STEP_MIDDLE ||
                      array->Item(1).GetIntValue() ==
                       NS_STYLE_TRANSITION_TIMING_FUNCTION_STEP_END ||
                      array->Item(1).GetIntValue() == -1),
                     "unexpected second value");
        nsTimingFunction::Type type =
          nsTimingFunction::GetStepFunctionType(array->Item(1).GetIntValue());
        if (type == nsTimingFunction::Type::StepMiddle && !aAllowStepMiddle) {
          aResult = nsTimingFunction(NS_STYLE_TRANSITION_TIMING_FUNCTION_EASE);
        } else {
          aResult = nsTimingFunction(type, array->Item(0).GetIntValue(),
                                     array->Item(1).GetIntValue() == -1 ?
                                       nsTimingFunction::Keyword::Implicit :
                                       nsTimingFunction::Keyword::Explicit);
        }
      }
      break;
    default:
      NS_NOTREACHED("Invalid transition property unit");
  }
}

static uint8_t





   */
  static bool ComputeColor(const nsCSSValue& aValue,
                           nsPresContext* aPresContext,
                           nsStyleContext* aStyleContext,
                           nscolor& aResult);

  static bool ParentHasPseudoElementData(nsStyleContext* aContext);

  // If aAllowStepMiddle is false, we will treat
  // nsTimingFunction::Type::StepMiddle as nsTimingFunction::Type::Ease.
  static void ComputeTimingFunction(const nsCSSValue& aValue,
                                    nsTimingFunction& aResult,
                                    bool aAllowStepMiddle = false);

private:
#ifdef DEBUG
  // non-inline helper function to allow assertions without incomplete
  // type errors
  bool ContextHasCachedData(nsStyleContext* aContext, nsStyleStructID aSID);
#endif

Return to bug 1248340