Paths

Table of Contentst

Bug 1521360 - ensure that Prio early cleanup runs correctly r?henrycg
ClosedPublic
Actions

Authored by • rhelmer on Jan 23 2019, 12:46 AM.

Details

Reviewers

Commits

rMOZILLACENTRALc5bcd3213da6: Bug 1521360 - Ensure that Prio early cleanup runs correctly. r=henrycg…
Restricted Diffusion Commit
Restricted Diffusion Commit
rMOZILLACENTRAL99c2a6b3e3bd: Bug 1521360 - ensure that Prio early cleanup runs correctly r=henrycg

Bugzilla Bug ID

1521360

Diff Detail

Repository: rMOZILLACENTRAL mozilla-central

Event Timeline

• rhelmer created this revision.Jan 23 2019, 12:46 AM

Herald added a project: secure-revision. · View Herald TranscriptJan 23 2019, 12:46 AM

phab-bot requested review of this revision.Jan 23 2019, 12:46 AM

phab-bot changed the visibility from "Custom Policy" to "Custom Policy".

phab-bot changed the edit policy from "Custom Policy" to "Custom Policy".

phab-bot added a project: Restricted Project.

phab-bot added subscribers: henrycg, • rhelmer, johannh.

Harbormaster completed remote builds in B34326: Diff 54231.Jan 23 2019, 12:46 AM

https://wiki.mozilla.org/Security/Bug_Approval_Process has the guidelines around handling security bugs.

This looks good to me. It passes tests and I didn't find other instances of this bug in prio/serial.c.

This revision is now accepted and ready to land.Jan 23 2019, 6:24 AM

phab-bot added a subscriber: Alex_Gaynor.Jan 24 2019, 6:23 PM

It if makes sense, we might this patch to also address the related bug in prio/client.c that I mentioned here:

https://bugzilla.mozilla.org/show_bug.cgi?id=1521360#c9

This revision now requires changes to proceed.Jan 25 2019, 12:09 AM

Revision updated.

Harbormaster completed remote builds in B35015: Diff 55138.Jan 25 2019, 7:00 AM

Looks good to me. Thanks for fixing the second set of bugs here!

This revision is now accepted and ready to land.Jan 25 2019, 7:43 AM

phab-bot added a subscriber: • abillings.Feb 8 2019, 10:52 PM

Closed by commit rMOZILLACENTRAL99c2a6b3e3bd: Bug 1521360 - ensure that Prio early cleanup runs correctly r=henrycg (authored by • rhelmer). · Explain WhyFeb 12 2019, 4:27 PM

This revision was automatically updated to reflect the committed changes.

phab-bot changed the visibility from "Custom Policy" to "Custom Policy".Feb 13 2019, 11:00 AM

phab-bot changed the edit policy from "Custom Policy" to "Custom Policy".

phab-bot added a project: Restricted Project.

phab-bot added a subscriber: RyanVM.Feb 21 2019, 12:55 AM

phab-bot added a subscriber: bogdan_maris.Feb 21 2019, 8:01 AM

phab-bot removed a subscriber: henrycg.Feb 21 2019, 4:16 PM

phab-bot added a subscriber: Wolfbeast.Mar 21 2019, 7:37 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Aug 8 2019, 12:25 AM

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed projects: Restricted Project, Restricted Project, secure-revision.

Revision Contents
Changeset List

Path

Size

third_party/

prio/

client.c

10 lines

serial.c

31 lines

Diff 61181

View Options

third_party/prio/prio/client.c