view-timeline-name: none | <custom-ident>#
view-timeline-axis: [ block | inline | vertical | horizontal ]#
Note:
Both view-timeline-name and scroll-timeline-name should accept auto.
We will fix it in this patch series.
Details
Details
Diff Detail
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Build Status
Buildable 504699 Build 601041: arc lint + arc unit
Event Timeline
Comment Actions
Code analysis found 1 defect in the diff 665798:
- 1 defect found by clang-tidy
WARNING: Found 1 issue (warning level) that can be dismissed.
You can run this analysis locally with:
- ./mach static-analysis check --outgoing (C/C++)
If you see a problem in this automated review, please report it here.
You can view these defects in the Diff Detail section of Phabricator diff 665798.
Comment Actions
1 issue closed compared to the previous diff 666428.
If you see a problem in this automated review, please report it here.
| servo/components/style/properties/gecko.mako.rs | ||
|---|---|---|
| 1916 | The only reason this code for animations is not autogenerated is that it needed specific conversions (e.g. animation-iteration-count needs to convert to / from float). Given these don't, I'd much rather have this autogenerated | |
| 1939 | So I know this is doing just what we do for transitions / animations, but maybe we don't need to? Is there any reason we need the struct and these shenanigans, and can't instead just keep the values separately? If not, can we at least share more code with the transitions / animations? | |
| servo/components/style/properties/longhands/ui.mako.rs | ||
| 344 | Should we remove these properties? What's the long term plan here? | |
| servo/components/style/properties/gecko.mako.rs | ||
|---|---|---|
| 1916 | I submitted bug 1810946 with some clean-ups that should make this something like impl_coordinated_property('view_timeline', 'name', 'Name') or so | |
| servo/components/style/properties/longhands/ui.mako.rs | ||
| 344 | Ah, I see this is on the spec but should also be a coordinated property. | |
| servo/components/style/properties/gecko.mako.rs | ||
|---|---|---|
| 1939 | Keeping the values separately may have issues. Therefore, we still have to manually create a list and assign the initial values. I will try to share this code with animations and transitions. | |
| servo/components/style/properties/longhands/ui.mako.rs | ||
| 344 | Yes, I will update scroll-timeline-{name|axis} in a separate patch so all of them are coordinated properties | |
| layout/style/nsStyleStruct.h | ||
|---|---|---|
| 1289 | Let's set mAxis to StyleScrollAxis::Block here, and avoid the uninitialized values? | |
| servo/components/style/properties/gecko.mako.rs | ||
| 1029–1031 | I'm confused, it seems impl_coordinated_property would work? If not, can you document why is this different? At a glance it seems the only difference is the take(input_len) and, for some reason, the order of the arguments to zip. But a.zip(b) iterates over the shortest, so I don't see why those differences are relevant? | |
| servo/components/style/properties/gecko.mako.rs | ||
|---|---|---|
| 1029–1031 | My bad. They are identical. I misread this iterator. impl_coordinated_property should work. | |