Page MenuHomePhabricator
Differential D173905

Bug 1808410 - Part 3: Create timeline for view().
ClosedPublic
Actions

Authored by boris on Mar 28 2023, 11:18 PM.
Tags
Referenced Files
Unknown Object (File)
Oct 15 2025, 9:03 AM
Unknown Object (File)
Oct 14 2025, 7:43 PM
Unknown Object (File)
Oct 14 2025, 7:03 AM
Unknown Object (File)
May 30 2025, 4:09 PM
Unknown Object (File)
May 28 2025, 1:56 AM
Unknown Object (File)
May 27 2025, 9:44 PM
Unknown Object (File)
May 24 2025, 10:34 AM
Unknown Object (File)
May 18 2025, 4:40 AM
View All 18 Files
Subscribers
emilio
reviewbot

Details

Reviewers
emilio
Commits
rMOZILLACENTRALc0074ece8dd2: Bug 1808410 - Part 3: Create timeline for view(). r=emilio
Bugzilla Bug ID
1808410
Summary

Also, I add some similar tests but they don't use Named Timeline Range, which
is not supported by Gecko now (Bug 1824875).

Diff Detail

Event Timeline

boris created this revision.Mar 28 2023, 11:18 PM
Herald added a project: secure-revision. · View Herald TranscriptMar 28 2023, 11:18 PM
Harbormaster completed remote builds in B521841: Diff 698540.Mar 28 2023, 11:18 PM
boris added a child revision: D173906: Bug 1814444 - Part 1: Update the syntax of scroll() to accept <scroller> and <axis> in any order..Mar 28 2023, 11:18 PM
phab-bot published this revision for review.Mar 28 2023, 11:18 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a subscriber: emilio. · View Herald TranscriptMar 28 2023, 11:18 PM
boris updated this revision to Diff 705731.Apr 17 2023, 9:39 PM
boris edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B528073: Diff 705731.Apr 17 2023, 9:39 PM
reviewbot added a subscriber: reviewbot.Apr 17 2023, 10:06 PM

Code analysis found 2 defects in the diff 705731:

  • 1 defect found by clang-format
  • 1 defect found by clang-format (Mozlint)
WARNING: Found 2 issues (warning level) that can be dismissed.

You can run this analysis locally with:

  • ./mach clang-format -p dom/animation/ViewTimeline.cpp
  • ./mach lint --warnings --outgoing

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 705731.

boris updated this revision to Diff 706202.Apr 18 2023, 7:16 PM

Fix clang-format warnings

boris edited the summary of this revision. (Show Details)Apr 18 2023, 7:16 PM
Harbormaster completed remote builds in B528443: Diff 706202.Apr 18 2023, 7:16 PM
boris removed a child revision: D173906: Bug 1814444 - Part 1: Update the syntax of scroll() to accept <scroller> and <axis> in any order..Apr 18 2023, 7:16 PM
boris added a reviewer: layout-reviewers.
reviewbot added a comment.Apr 18 2023, 7:36 PM

2 issues closed compared to the previous diff 705731.

If you see a problem in this automated review, please report it here.

boris updated this revision to Diff 707569.Apr 20 2023, 11:07 PM

Addressed comments

Harbormaster completed remote builds in B529672: Diff 707569.Apr 20 2023, 11:07 PM
emilio accepted this revision as: emilio.Apr 21 2023, 9:01 PM
emilio added a project: testing-approved.
This revision is now accepted and ready to land.Apr 21 2023, 9:01 PM
boris updated this revision to Diff 710683.May 1 2023, 7:29 PM

Rebased

Harbormaster completed remote builds in B532301: Diff 710683.May 1 2023, 7:29 PM
boris removed a reviewer: layout-reviewers.May 1 2023, 7:29 PM
boris updated this revision to Diff 711344.May 2 2023, 10:45 PM

Fix devtool css db

Harbormaster completed remote builds in B532840: Diff 711344.May 2 2023, 10:45 PM
Closed by commit rMOZILLACENTRALc0074ece8dd2: Bug 1808410 - Part 3: Create timeline for view(). r=emilio (authored by boris). · Explain WhyMay 2 2023, 10:56 PM
This revision was automatically updated to reflect the committed changes.
boris added a commit: rMOZILLACENTRALc0074ece8dd2: Bug 1808410 - Part 3: Create timeline for view(). r=emilio.

Revision Contents
Changeset List

PathSize
dom/
animation/
7 lines
20 lines
layout/
style/
7 lines
testing/
web-platform/
meta/
scroll-animations/
css/
9 lines
tests/
scroll-animations/
css/
211 lines

Diff 711352

View Options

dom/animation/ViewTimeline.h

Loading...
View Options

dom/animation/ViewTimeline.cpp

Loading...
View Options

layout/style/nsAnimationManager.cpp

Loading...
View Options

testing/web-platform/meta/scroll-animations/css/animation-timeline-view-functional-notation.tentative.html.ini

Loading...
View Options

testing/web-platform/tests/scroll-animations/css/animation-timeline-view-functional-notation.tentative.html

Loading...
Privacy · Cookies · Legal