Code analysis found 7 defects in diff 744098:

• 1 defect found by clang-format
• 1 defect found by clang-format (Mozlint)
• 5 build errors found by clang-tidy

You can run this analysis locally with:

• ./mach static-analysis check --outgoing (C/C++)
• ./mach clang-format -p dom/base/Document.cpp
• ./mach lint --warnings --outgoing

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 744098.

Code analysis found 1 defect in diff 745159:

• 1 defect found by clang-format

1 defect unresolved and 6 defects closed compared to the previous diff 744098.

You can run this analysis locally with:

• ./mach clang-format -p dom/base/Document.cpp

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 745159.

Or does this just need a tweak to the commit message?

The commit message is already "... speculative style preloads" though?

But what is preload there? There are speculative loads, but the preload part explicitly doesn't handle nonce, no?

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!