Page MenuHomePhabricator
Differential D218719

Bug 1903780 - Support directory names again in downloads.download
ClosedPublic
Actions

Authored by robwu on Aug 7 2024, 9:43 AM.
Tags
Referenced Files
Unknown Object (File)
Wed, Dec 31, 5:19 PM
Unknown Object (File)
Oct 15 2025, 9:19 PM
Unknown Object (File)
Jun 21 2025, 2:54 PM
Unknown Object (File)
Jun 21 2025, 2:54 PM
Unknown Object (File)
Jun 18 2025, 7:58 AM
Unknown Object (File)
May 31 2025, 12:26 AM
Unknown Object (File)
May 26 2025, 10:20 PM
Unknown Object (File)
Jan 23 2025, 12:01 PM
View All 10 Files
Subscribers
mak
mayhemer

Details

Reviewers
NeilDeakin
m_kato
Group Reviewers
geckoview-reviewers
Commits
rMOZILLACENTRAL7d1c243062c9: Bug 1903780 - Support directory names again in downloads.download r=geckoview…
Bugzilla Bug ID
1903780

Diff Detail

Event Timeline

robwu created this revision.Aug 7 2024, 9:43 AM
Herald added a project: secure-revision. · View Herald TranscriptAug 7 2024, 9:43 AM
Herald added a reviewer: necko-reviewers. · View Herald Transcript
Harbormaster completed remote builds in B690649: Diff 900075.Aug 7 2024, 9:43 AM
phab-bot published this revision for review.Aug 7 2024, 9:44 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a reviewer: geckoview-reviewers. · View Herald TranscriptAug 7 2024, 9:44 AM
Herald added subscribers: mak, mayhemer. · View Herald Transcript
robwu updated this revision to Diff 900076.Aug 7 2024, 9:45 AM
robwu added a reviewer: NeilDeakin.
Harbormaster completed remote builds in B690650: Diff 900076.Aug 7 2024, 9:45 AM
robwu removed a reviewer: Neil.Aug 7 2024, 9:45 AM
NeilDeakin accepted this revision.Aug 8 2024, 12:20 PM
kershaw removed a reviewer: necko-reviewers.Aug 13 2024, 9:39 AM
m_kato accepted this revision.Aug 20 2024, 12:07 PM
m_kato added a project: testing-approved.
This revision is now accepted and ready to land.Aug 20 2024, 12:07 PM
Closed by commit rMOZILLACENTRAL7d1c243062c9: Bug 1903780 - Support directory names again in downloads.download r=geckoview… (authored by robwu). · Explain WhyAug 20 2024, 6:58 PM
This revision was automatically updated to reflect the committed changes.
robwu added a commit: rMOZILLACENTRAL7d1c243062c9: Bug 1903780 - Support directory names again in downloads.download r=geckoview….
robwu mentioned this in rMOZILLACENTRALf3bf1705bfa0: Bug 1903780 - Support directory names again in downloads.download a=RyanVM.Aug 21 2024, 1:12 PM
robwu mentioned this in rMOZILLACENTRAL79e9d3eb5b1a: Bug 1903780 - Support directory names again in downloads.download a=RyanVM.Aug 21 2024, 1:15 PM
Harbormaster completed remote builds in B693980: Diff 903828.Aug 21 2024, 5:02 PM
robwu mentioned this in rMOZILLACENTRAL05050104ec0c: Bug 1903780 - Support directory names again in downloads.download a=RyanVM.Aug 21 2024, 5:07 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
mobile/
shared/
components/
extensions/
3 lines--
netwerk/
mime/
7 lines--
toolkit/
components/
downloads/
11 lines100%
Loading...
test/
unit/
8 lines--
extensions/
parent/
3 lines96%
Loading...
test/
mochitest/
6 lines--
xpcshell/
11 lines--
uriloader/
exthandler/
14 lines85%
Loading...
tests/
unit/
16 lines--

Diff 903828

View Options

mobile/shared/components/extensions/ext-downloads.js

Loading...
View Options

netwerk/mime/nsIMIMEService.idl

Loading...
View Options

toolkit/components/downloads/DownloadPaths.sys.mjs

Loading...
View Options

toolkit/components/downloads/test/unit/test_DownloadPaths.js

Loading...
View Options

toolkit/components/extensions/parent/ext-downloads.js

Loading...
View Options

toolkit/components/extensions/test/mochitest/test_ext_downloads_download.html

Loading...
View Options

toolkit/components/extensions/test/xpcshell/test_ext_downloads_download.js

Loading...
View Options

uriloader/exthandler/nsExternalHelperAppService.cpp

Loading...
View Options

uriloader/exthandler/tests/unit/test_filename_sanitize.js

Loading...
Privacy · Cookies · Legal