Closed Bug 1808409 Opened 2 years ago Closed 2 years ago

Implement view-timeline-{name|axis|inset} and view-timeline in style

Categories

(Core :: CSS Transitions and Animations, enhancement)

Product:
Core
Component:
CSS Transitions and Animations
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox111 --- fixed

People

(Reporter: boris, Assigned: boris)

References

(
URL
)

Details

Attachments

(4 files)

Bug 1808409 - Part 1: Support view-timeline-name and view-timeline-axis in style system.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1808409 - Part 2: Support view-timeline-inset in style system.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1808409 - Part 3: Support view-timeline shorthand.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1808409 - Part 4: Accept auto for {scroll|view}-timeline-name.
48 bytes, text/x-phabricator-request
Details | Review

Implement the view-timeline-name, view-timeline-axis, and the shorthand, view-timeline in style.

Summary: Implement view-timeline-name, view-timeline-axis, and the shorthand property, view-timeline in style → Implement view-timeline-name, view-timeline-axis, and view-timeline in style

Note: Both view-timeline-name and scroll-timeline-name should accept
auto. We will fix it later.

Summary: Implement view-timeline-name, view-timeline-axis, and view-timeline in style → Implement view-timeline-{name|axis|inset} and view-timeline in style

view-timeline shorthand includes view-timeline-name and
view-timeline-axis, but excludes view-timeline-inset.

Note: We will fix the test of "view-timeline-name: auto" in the next patch.

Pushed by bchiou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/412406551464 Part 1: Support view-timeline-name and view-timeline-axis in style system. r=emilio https://hg.mozilla.org/integration/autoland/rev/65a7fc0d9447 Part 2: Support view-timeline-inset in style system. r=emilio https://hg.mozilla.org/integration/autoland/rev/b50dbfe47f74 Part 3: Support view-timeline shorthand. r=emilio https://hg.mozilla.org/integration/autoland/rev/aea8be500e7a Part 4: Accept auto for {scroll|view}-timeline-name. r=emilio

Backed out for causing wpt failures on scroll-timeline-shorthand.tentative.html.

[task 2023-01-24T01:28:11.046Z] 01:28:11     INFO - TEST-START | /referrer-policy/4K/gen/top.http-rp/unset/script-tag.http.html
[task 2023-01-24T01:28:11.073Z] 01:28:11     INFO - Closing window dad0ab13-b85c-49bc-8de3-1c8c5b374ab1
[task 2023-01-24T01:28:11.144Z] 01:28:11     INFO - PID 19489 | [Child 20404, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp:3384
[task 2023-01-24T01:28:11.148Z] 01:28:11     INFO - PID 19489 | [Child 20404, Main Thread] WARNING: NS_ENSURE_TRUE(InitStaticMembers()) failed: file /builds/worker/workspace/obj-build/dist/include/mozilla/Preferences.h:129
[task 2023-01-24T01:28:11.158Z] 01:28:11     INFO - PID 19489 | [Child 20404, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4663
[task 2023-01-24T01:28:11.211Z] 01:28:11     INFO - PID 18470 | [Parent 18470, IPDL Background] WARNING: IPC Connection Error: [Parent][PBackgroundParent] RunMessage(msgname=PRemoteWorkerService::Msg___delete__) Channel closing: too late to send/recv, messages will be lost: file /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1927
[task 2023-01-24T01:28:11.214Z] 01:28:11     INFO - PID 18470 | [Parent 18470, CanvasRenderer] WARNING: FuncScope not on stack!: file /builds/worker/checkouts/gecko/dom/canvas/WebGLContext.cpp:1769
<...>
[task 2023-01-24T01:28:11.703Z] 01:28:11     INFO - PID 18470 | [Child 20360, Main Thread] WARNING: NS_ENSURE_TRUE(InitStaticMembers()) failed: file /builds/worker/workspace/obj-build/dist/include/mozilla/Preferences.h:129
[task 2023-01-24T01:28:11.751Z] 01:28:11     INFO - 
[task 2023-01-24T01:28:11.752Z] 01:28:11     INFO - TEST-UNEXPECTED-FAIL | /scroll-animations/css/scroll-timeline-shorthand.tentative.html | e.style['scroll-timeline'] = "none block" should set the property value - assert_equals: serialization should be canonical expected "none" but got "block"
[task 2023-01-24T01:28:11.752Z] 01:28:11     INFO - test_valid_value/<@http://web-platform.test:8000/css/support/parsing-testcommon.js:21:26
[task 2023-01-24T01:28:11.752Z] 01:28:11     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2591:25
[task 2023-01-24T01:28:11.752Z] 01:28:11     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2023-01-24T01:28:11.752Z] 01:28:11     INFO - test_valid_value@http://web-platform.test:8000/css/support/parsing-testcommon.js:12:9
[task 2023-01-24T01:28:11.752Z] 01:28:11     INFO - @http://web-platform.test:8000/scroll-animations/css/scroll-timeline-shorthand.tentative.html:11:17
[task 2023-01-24T01:28:11.752Z] 01:28:11     INFO - 
[task 2023-01-24T01:28:11.752Z] 01:28:11     INFO - TEST-UNEXPECTED-FAIL | /scroll-animations/css/scroll-timeline-shorthand.tentative.html | e.style['scroll-timeline'] = "none inline" should set the property value - assert_equals: serialization should be canonical expected "none inline" but got "inline"
[task 2023-01-24T01:28:11.752Z] 01:28:11     INFO - test_valid_value/<@http://web-platform.test:8000/css/support/parsing-testcommon.js:21:26
[task 2023-01-24T01:28:11.753Z] 01:28:11     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2591:25
[task 2023-01-24T01:28:11.753Z] 01:28:11     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2023-01-24T01:28:11.753Z] 01:28:11     INFO - test_valid_value@http://web-platform.test:8000/css/support/parsing-testcommon.js:12:9
[task 2023-01-24T01:28:11.753Z] 01:28:11     INFO - @http://web-platform.test:8000/scroll-animations/css/scroll-timeline-shorthand.tentative.html:12:17
[task 2023-01-24T01:28:11.753Z] 01:28:11     INFO - 
[task 2023-01-24T01:28:11.753Z] 01:28:11     INFO - TEST-UNEXPECTED-FAIL | /scroll-animations/css/scroll-timeline-shorthand.tentative.html | e.style['scroll-timeline'] = "abc horizontal" should set the property value - assert_equals: serialization should be canonical expected "abc horizontal" but got "horizontal abc"
[task 2023-01-24T01:28:11.753Z] 01:28:11     INFO - test_valid_value/<@http://web-platform.test:8000/css/support/parsing-testcommon.js:21:26
[task 2023-01-24T01:28:11.753Z] 01:28:11     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2591:25
[task 2023-01-24T01:28:11.753Z] 01:28:11     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2023-01-24T01:28:11.753Z] 01:28:11     INFO - test_valid_value@http://web-platform.test:8000/css/support/parsing-testcommon.js:12:9
[task 2023-01-24T01:28:11.754Z] 01:28:11     INFO - @http://web-platform.test:8000/scroll-animations/css/scroll-timeline-shorthand.tentative.html:13:17
[task 2023-01-24T01:28:11.754Z] 01:28:11     INFO - 
[task 2023-01-24T01:28:11.754Z] 01:28:11     INFO - TEST-UNEXPECTED-FAIL | /scroll-animations/css/scroll-timeline-shorthand.tentative.html | e.style['scroll-timeline'] = "abc inline" should set the property value - assert_equals: serialization should be canonical expected "abc inline" but got "inline abc"
[task 2023-01-24T01:28:11.754Z] 01:28:11     INFO - test_valid_value/<@http://web-platform.test:8000/css/support/parsing-testcommon.js:21:26
[task 2023-01-24T01:28:11.754Z] 01:28:11     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2591:25
[task 2023-01-24T01:28:11.754Z] 01:28:11     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2023-01-24T01:28:11.754Z] 01:28:11     INFO - test_valid_value@http://web-platform.test:8000/css/support/parsing-testcommon.js:12:9
[task 2023-01-24T01:28:11.756Z] 01:28:11     INFO - @http://web-platform.test:8000/scroll-animations/css/scroll-timeline-shorthand.tentative.html:14:17
[task 2023-01-24T01:28:11.759Z] 01:28:11     INFO - 
[task 2023-01-24T01:28:11.760Z] 01:28:11     INFO - TEST-UNEXPECTED-FAIL | /scroll-animations/css/scroll-timeline-shorthand.tentative.html | e.style['scroll-timeline'] = "aBc inline" should set the property value - assert_equals: serialization should be canonical expected "aBc inline" but got "inline aBc"
[task 2023-01-24T01:28:11.761Z] 01:28:11     INFO - test_valid_value/<@http://web-platform.test:8000/css/support/parsing-testcommon.js:21:26
<...>
Flags: needinfo?(boris.chiou)
Flags: needinfo?(boris.chiou)
Pushed by bchiou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/87651897efc3 Part 1: Support view-timeline-name and view-timeline-axis in style system. r=emilio https://hg.mozilla.org/integration/autoland/rev/226b2d6ef08a Part 2: Support view-timeline-inset in style system. r=emilio https://hg.mozilla.org/integration/autoland/rev/6c9e2a9c1a04 Part 3: Support view-timeline shorthand. r=emilio https://hg.mozilla.org/integration/autoland/rev/13130f1e1bba Part 4: Accept auto for {scroll|view}-timeline-name. r=emilio
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: