Require the |exit_code| parameter to GetTerminationStatus be non-null.
This simplifies the implementations at the cost of the few call-sites
that don't care about the actual exit-code needing to provide a dummy
out-parameter for the API to write to.
Bug:
Change-Id: Ia3e896c1c2b68ebb5b0977d211fbc55b6828a157
Reviewed-on: https://chromium-review.googlesource.com/617822
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Justin Schuh <[email protected]>
Commit-Queue: Wez <[email protected]>
Cr-Commit-Position: refs/heads/master@{#495186}diff --git a/base/process/kill.h b/base/process/kill.h
index 68bce951..61db31c43 100644
--- a/base/process/kill.h
+++ b/base/process/kill.h
@@ -70,9 +70,8 @@
// Get the termination status of the process by interpreting the
// circumstances of the child process' death. |exit_code| is set to
-// the status returned by waitpid() on POSIX, and from
-// GetExitCodeProcess() on Windows. |exit_code| may be NULL if the
-// caller is not interested in it. Note that on Linux, this function
+// the status returned by waitpid() on POSIX, and from GetExitCodeProcess() on
+// Windows, and may not be null. Note that on Linux, this function
// will only return a useful result the first time it is called after
// the child exits (because it will reap the child and the information
// will no longer be available).
