| commit | 146f34f8e6105b0b4fc6abbb46d030055185f1b3 | [log] [tgz] |
|---|---|---|
| author | Luc Nguyen <[email protected]> | Thu Aug 31 18:07:13 2023 |
| committer | Chromium LUCI CQ <[email protected]> | Thu Aug 31 18:07:13 2023 |
| tree | 9ba06634f9e7991db662e0551aba2007226ba9c6 | |
| parent | 5bdd9ae4b14219d687346300d0674463fe27142d [diff] |
Refactor PersistentSampleMap::ImportSamples() (no-op) ImportSamples(Sample until_value, bool import_everything) currently has two ways it can be used. If you want to import every samples in the persistent memory into the calling PersistentSampleMap, you set |import_everything| to true and |until_value| to anything else such as a dummy value of -1. If you want to import only up until a certain sample is found, you pass it to |until_value| and set |import_everything| to false. A pointer to the "first" sample found will be returned in this case (multiple samples could exist in the persistent memory due to a race condition -- this is not about emitting a sample multiple time; that case is optimized to only use one object on the persistent memory). In theory, there is a third way to use this function. It is to pass an |until_value|, and also set |import_everything| to true. This will import everything, and also return a pointer to the sample with the passed |until_value| (if found). But this way is never used. Refactor the function to just take one param, i.e. ImportSamples(absl::optional<Sample> until_value). If the param is a nullopt, then it just imports everything. Otherwise, import up until |until_value|. In preparation for a follow up CL. Bug: 1467656 Change-Id: Id9e0be2ab667df65d9702d15fea95db5dbb8c25d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4831953 Reviewed-by: Alexei Svitkine <[email protected]> Commit-Queue: Alexei Svitkine <[email protected]> Cr-Commit-Position: refs/heads/main@{#1190881}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.