Google Git
Sign in
chromium / chromium / src.git / 1c6dd3e20c0967a410220dcc1e8c75c12f008da9
commit1c6dd3e20c0967a410220dcc1e8c75c12f008da9[log] [tgz]
authorIan Vollick <[email protected]>Wed Apr 13 02:06:26 2022
committerChromium LUCI CQ <[email protected]>Wed Apr 13 02:06:26 2022
tree057aeb0522a1a08737a26140e7705f3bff549c6b
parentf35129d387ef31be4b3634c7ea150c2947ba6f58 [diff]
[mparch] Switch to FrameTreeNode::IsOutermostMainFrame

With MPArch, we can have nested frame trees and so FTN::IsMainFrame
cannot be used to determine if the frame is outermost. This CL changes
a number of simpler cases where semantics match outermost. This should
have no effect outside the use of MPArch-based nested frame trees (only
fenced frames at the moment).

A number of usages do not have tests included in this CL, but I have
added TODOs for these, similar to the approach taken in
crrev.com/c/2988476.

Bug: 1314749
Change-Id: I9fd91ef140318d2e3aa4f4da610aaa42b8a4b89a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3577677
Reviewed-by: Kevin McNee <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Reviewed-by: Hiroki Nakagawa <[email protected]>
Commit-Queue: Ian Vollick <[email protected]>
Cr-Commit-Position: refs/heads/main@{#991847}
19 files changed
tree: 057aeb0522a1a08737a26140e7705f3bff549c6b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.