Add debugging for crbug.com/1400009
Add crash keys to figure out the details that led to creating a subframe
proxy without an RVH.
Bug: 1400009
Change-Id: I3c3853fee607836fbe2162f84bc30969369cef93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4218831
Code-Coverage: Findit <[email protected]>
Commit-Queue: Rakina Zata Amni <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1102487}
diff --git a/content/browser/renderer_host/navigation_controller_impl.cc b/content/browser/renderer_host/navigation_controller_impl.cc
index 6f4aee4..07478fc6 100644
--- a/content/browser/renderer_host/navigation_controller_impl.cc
+++ b/content/browser/renderer_host/navigation_controller_impl.cc
@@ -2622,6 +2622,23 @@
request->SetNavigationClient(std::move(*navigation_client));
+ SCOPED_CRASH_KEY_STRING256(
+ "Bug1400009", "req_url",
+ request->GetURL().GetWithEmptyPath().possibly_invalid_spec());
+ SCOPED_CRASH_KEY_NUMBER(
+ "Bug1400009", "nav_entry_si",
+ entry->site_instance() ? ((int)entry->site_instance()->GetId()) : -1);
+ SCOPED_CRASH_KEY_NUMBER("Bug1400009", "fne_si",
+ frame_entry->site_instance()
+ ? ((int)frame_entry->site_instance()->GetId())
+ : -1);
+ bool has_sig =
+ (frame_entry->site_instance() && frame_entry->site_instance()->group());
+ SCOPED_CRASH_KEY_BOOL("Bug1400009", "fne_sig_exists", has_sig);
+ SCOPED_CRASH_KEY_BOOL("Bug1400009", "fne_sig_has_rvh",
+ has_sig ? (!!frame_tree_->GetRenderViewHost(
+ frame_entry->site_instance()->group()))
+ : false);
render_frame_host->frame_tree_node()->navigator().Navigate(std::move(request),
ReloadType::NONE);
