Google Git
Sign in
chromium / chromium / src.git / 1d15cfbb98ab33a324bb96304b78c652a53a464c
commit1d15cfbb98ab33a324bb96304b78c652a53a464c[log] [tgz]
authorRakina Zata Amni <[email protected]>Wed Aug 05 02:32:55 2020
committerCommit Bot <[email protected]>Wed Aug 05 02:32:55 2020
tree9412931010c905f2ec6c5b643e639f9db014b8a6
parent90ec3ea8494439da8fe0b924a24aea3cb9c1d2dd [diff]
Update navigation content_unittests to handle same-site BrowsingInstance swap

With crrev.com/c/2121522, some main-frame same-site navigations will
result in a new BrowsingInstance, SiteInstance, RenderFrameHost,
RenderView, etc. This CL updates expectations of content_unittests
that didn't expect a change of RenderFrameHosts etc. on same-site main
frame navigations.

This CL does not include:
- Updates for content_browsertests and non-navigation-specific tests,
which are handled in crrev.com/c/2195872 and crrev.com/c/2210174.
- Updates for tests under chrome/, components/ and layout tests (fixed
in other CLs))
- Fix to ensure order of unload handlers on same-site cross-RFH
navigations (will be fixed on a future CL)
- Fix to ensure WebPreferences are carried over for cross-RFH same-site
navigations (will be fixed on a future CL)

For more details, see doc: https://docs.google.com/document/d/1lHdkKLUe8H6ZP6ALwj-dsus7oYcuc93HkSCHCcerItg/edit?usp=sharing

Bug: 977562
Change-Id: I8cddb7e5caceea380ec413dbb446142811f0f62f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210035
Commit-Queue: Rakina Zata Amni <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/heads/master@{#794822}
5 files changed
tree: 9412931010c905f2ec6c5b643e639f9db014b8a6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.