Google Git
Sign in
chromium / chromium / src.git / 33e2e2c10eb65271ef13a22f73acd6498248420a
commit33e2e2c10eb65271ef13a22f73acd6498248420a[log] [tgz]
authorAlexander Timin <[email protected]>Thu Mar 03 04:21:33 2022
committerChromium LUCI CQ <[email protected]>Thu Mar 03 04:21:33 2022
treeb8f16b033b2ba3b6f54309bf16a9183bbf19cb2b
parent205fc0c99200f9bd75335bc185b82e5bf7bb7cd6 [diff]
Make FrameTreeNode::WriteIntoTrace(TracedProto) const.

The absence of const qualifier causes the overload selection logic in
Perfetto to fail, as without it choice between
WriteIntoTrace(TracedValue) const and WriteIntoTrace(TracedProto)
becomes non-ambigious, as the first one requires const-cast and the
latter requires calling an implicit constructor. When both are
const-qualified, WriteIntoTrace(TracedValue) const becomes strictly better
than WriteIntoTrace(TracedProto) const.

This caused the failure and revert of r.android.com/1699768, which added
implicit constructor to TracedProto.

[email protected]
BUG=1137154, b/184558843

Change-Id: Ib510897c72a11cbdd0c3465dd6adc2e185b0ef32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3500621
Auto-Submit: Alexander Timin <[email protected]>
Reviewed-by: Rakina Zata Amni <[email protected]>
Commit-Queue: Rakina Zata Amni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#976954}
2 files changed
tree: b8f16b033b2ba3b6f54309bf16a9183bbf19cb2b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.