Revert 239921 "Revert 239759 "The comment in base64.h implies th..."
*****************
Reverting the revert. Congrats, the original CL wasn't the cause for the failure; sorry for the mess.
*****************
> Revert 239759 "The comment in base64.h implies that base::Base64..."
>
> > The comment in base64.h implies that base::Base64Encode() can return false, but
> > this cannot happen in practice. Fix the comment.
> >
> > The implementation of Base64Encode() attempts to check for the return value
> > MODP_B64_ERROR as a failure, but modp_b64_encode() cannot return this
> > value. Remove the check.
> >
> > Remove unneeded integer cast.
> >
> > Change the return type to void.
> >
> > BUG=323357
> > TEST=base_unittests, compile all
> > [email protected],[email protected],[email protected],[email protected],[email protected]
> >
> > Review URL: https://codereview.chromium.org/86913002
>
> [email protected]
>
> Review URL: https://codereview.chromium.org/101113004
[email protected]
Review URL: https://codereview.chromium.org/111883004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239944 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/chrome/browser/metrics/metrics_log.cc b/chrome/browser/metrics/metrics_log.cc
index 72d738b..9ebf3bc 100644
--- a/chrome/browser/metrics/metrics_log.cc
+++ b/chrome/browser/metrics/metrics_log.cc
@@ -803,8 +803,8 @@
std::string serialied_system_profile;
std::string base64_system_profile;
- if (system_profile->SerializeToString(&serialied_system_profile) &&
- base::Base64Encode(serialied_system_profile, &base64_system_profile)) {
+ if (system_profile->SerializeToString(&serialied_system_profile)) {
+ base::Base64Encode(serialied_system_profile, &base64_system_profile);
PrefService* local_state = GetPrefService();
local_state->SetString(prefs::kStabilitySavedSystemProfile,
base64_system_profile);
