Google Git
Sign in
chromium / chromium / src.git / 3774b000d5389354551e2eac42441ef27c22bd8b
commit3774b000d5389354551e2eac42441ef27c22bd8b[log] [tgz]
authorSky Malice <[email protected]>Fri Oct 21 19:18:40 2022
committerChromium LUCI CQ <[email protected]>Fri Oct 21 19:18:40 2022
treef32e6f860cb1413b6a9add8c224c6ebd3d65304b
parenta49107d0e9a6cfb6633bbb7a7bf756a05d337771 [diff]
UpdateBrowserControlsState without proxy.

Trying to react to touch events by locking browser controls is
problematic on websites with high usage on the renderer main thread.
However the UpdateBrowserControlsState doesn't actually do any useful
work on the renderer main thread, it's just a proxy.

This change adds a feature flag to route UpdateBrowserControlsState
calls directly to the compositor thread.

is just 1 line that is being added and not covered.

Bug: 1374427
Low-Coverage-Reason: No convenient unit test for page_impl.cc, and it
Change-Id: I1a285cd5844b184f1f752fc2d7c4d4e5f9829f92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3953901
Reviewed-by: Stephen Nusko <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Reviewed-by: David Bokan <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Commit-Queue: Sky Malice <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1062292}
21 files changed
tree: f32e6f860cb1413b6a9add8c224c6ebd3d65304b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.