| commit | 424d8a3baa6ff01bd06913381b16705445348b46 | [log] [tgz] |
|---|---|---|
| author | Bartek Nowierski <[email protected]> | Fri Jun 07 04:58:41 2024 |
| committer | Chromium LUCI CQ <[email protected]> | Fri Jun 07 04:58:41 2024 |
| tree | dd5949d9b64fbeea0873242bcd443d6f5d0e44c2 | |
| parent | 4dc2ed22c11d864c46db014d8e4aa9fe1dad6c60 [diff] [blame] |
[BRP] Add more raw_ptr/ref exclusions based on recent perf work Reorganize manual-fields-to-ignore.txt a little bit, and update some RAW_PTR_EXCLUSION comments. Bug: 335556942, 332743723 Change-Id: Ibd8bff6a9df753bc8e23686c941a17a8951d6d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5606544 Commit-Queue: Keishi Hattori <[email protected]> Reviewed-by: Keishi Hattori <[email protected]> Auto-Submit: Bartek Nowierski <[email protected]> Owners-Override: Keishi Hattori <[email protected]> Cr-Commit-Position: refs/heads/main@{#1311751}
diff --git a/base/metrics/persistent_memory_allocator.h b/base/metrics/persistent_memory_allocator.h index 5323249..b6977d6c 100644 --- a/base/metrics/persistent_memory_allocator.h +++ b/base/metrics/persistent_memory_allocator.h
@@ -689,9 +689,8 @@ // Implementation of Flush that accepts how much to flush. virtual void FlushPartial(size_t length, bool sync); - // This field is not a raw_ptr<> because it always points to a mmap'd region - // of memory outside of the PA heap. Thus, there would be overhead involved - // with using a raw_ptr<> but no safety gains. + // RAW_PTR_EXCLUSION: Never allocated by PartitionAlloc (always mmap'ed), so + // there is no benefit to using a raw_ptr, only cost. RAW_PTR_EXCLUSION volatile char* const mem_base_; // Memory base. (char so sizeof guaranteed 1) const MemoryType mem_type_; // Type of memory allocation.