| commit | 4bc5dfc048bcae8ff2bb0f1cef278c4d685051f9 | [log] [tgz] |
|---|---|---|
| author | Alex Moshchuk <[email protected]> | Fri Jun 06 17:23:00 2025 |
| committer | Chromium LUCI CQ <[email protected]> | Fri Jun 06 17:23:00 2025 |
| tree | 47952e9bff4239268ae87403dcc50bfe9b05b8a6 | |
| parent | c56bba62c804c6b6054c56b1a56045d6a3b21d0b [diff] [blame] |
Fix expectations for a few more tests for DefaultSiteInstanceGroups This CL is relanding just the test expectation updates from https://chromium-review.googlesource.com/c/chromium/src/+/6625492. It updates expectations for a few remaining tests to work properly with default SiteInstanceGroups. These are mostly about no longer checking for default SiteInstance (or its unisolated.invalid site URL) when default SiteInstanceGroups are enabled, since they produce SiteInstances with meaningful site URLs. This is most easily accomplished by using AreStrictSiteInstancesEnabled() to account for both strict site isolation and default SiteInstanceGroups. All these updates are test expectation changes rather than product behavior updates, apart from the slight difference in how one metric is reported for COOP process reuse (see PS3..PS4 diffs). Bug: 390571607 Change-Id: I07d6eb1582d952c2479d8c15c7c8543fb050efc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6626983 Commit-Queue: Lei Zhang <[email protected]> Auto-Submit: Alex Moshchuk <[email protected]> Reviewed-by: Charlie Reis <[email protected]> Reviewed-by: Lei Zhang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1470626}
diff --git a/content/browser/renderer_host/cookie_browsertest.cc b/content/browser/renderer_host/cookie_browsertest.cc index f121b35..8ccad04 100644 --- a/content/browser/renderer_host/cookie_browsertest.cc +++ b/content/browser/renderer_host/cookie_browsertest.cc
@@ -198,7 +198,7 @@ static_cast<WebContentsImpl*>(shell2->web_contents()); WebContentsImpl* web_contents_http = static_cast<WebContentsImpl*>(shell()->web_contents()); - if (AreAllSitesIsolatedForTesting()) { + if (AreStrictSiteInstancesEnabled()) { EXPECT_EQ("http://a.test/", web_contents_http->GetSiteInstance()->GetSiteURL().spec()); // Create expected site url, including port if origin isolation is enabled.