| commit | 541196559fa83bb1abe11cedbca23d410a8b00d9 | [log] [tgz] |
|---|---|---|
| author | Peter Boström <[email protected]> | Thu Nov 14 00:16:38 2024 |
| committer | Chromium LUCI CQ <[email protected]> | Thu Nov 14 00:16:38 2024 |
| tree | 8a70c11b4dd9b4c6069bc62b8f58774fed0407e0 | |
| parent | 588cc5a1cbc93a923adee2bad1a3c084594ea924 [diff] [blame] |
Replace CHECK(false) in base/ In most cases NOTREACHED() is now a better option. Also performs dead-code removal. Bug: 40122554, 40580068 Change-Id: I5d0ef0b0c05a913a040905f7bebbbbf22985fef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6011172 Reviewed-by: Lei Zhang <[email protected]> Commit-Queue: Peter Boström <[email protected]> Code-Coverage: [email protected] <[email protected]> Cr-Commit-Position: refs/heads/main@{#1382693}
diff --git a/base/numerics/safe_conversions_impl.h b/base/numerics/safe_conversions_impl.h index 38d9dc2..f176baa2c 100644 --- a/base/numerics/safe_conversions_impl.h +++ b/base/numerics/safe_conversions_impl.h
@@ -74,7 +74,7 @@ inline constexpr bool kEnableAsmCode = false; #endif -// Forces a crash, like a CHECK(false). Used for numeric boundary errors. +// Forces a crash, like a NOTREACHED(). Used for numeric boundary errors. // Also used in a constexpr template to trigger a compilation failure on // an error condition. struct CheckOnFailure {