commit | 5e2945caceae1dc826b4b362f3abd8a84e4264a9 | [log] [tgz] |
---|---|---|
author | Sky Malice <[email protected]> | Tue Jul 09 17:38:25 2024 |
committer | Chromium LUCI CQ <[email protected]> | Tue Jul 09 17:38:25 2024 |
tree | 1de08366d54ee30d27e91d27a8d8a26d1c223176 | |
parent | 7ef925c8360a24bff17c3c46a596bb19e6401dd9 [diff] |
Support moving in NavigationEntry::SetTitle. ::SetTitle wants to set a member filed to hold the string. So it either needs to copy or move. Previously the const& argument always resulted in a copy. Now some call sites should be able to move the string, especially from WebContentsImpl::UpdateTitleForEntryImpl which seems to be the main way to set titles. Bug: 350987379 Change-Id: I90a4fbe504b61c9fca81ecbd87bf9a34902e2931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5675857 Reviewed-by: David Trainor <[email protected]> Reviewed-by: Rakina Zata Amni <[email protected]> Reviewed-by: Nate Fischer <[email protected]> Commit-Queue: Sky Malice <[email protected]> Cr-Commit-Position: refs/heads/main@{#1324938}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.