Manually fix remaining clang-tidy errors in base/.
These were written by hand.
Bug: none
Change-Id: Ia151eca9b8a42baac4ed71f839a20b5742bc7d05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6122751
Owners-Override: Lei Zhang <[email protected]>
Code-Coverage: [email protected] <[email protected]>
Reviewed-by: Yuki Shiino <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1404702}
diff --git a/base/scoped_generic_unittest.cc b/base/scoped_generic_unittest.cc
index 9c36d43..913a516 100644
--- a/base/scoped_generic_unittest.cc
+++ b/base/scoped_generic_unittest.cc
@@ -75,7 +75,8 @@
ScopedInt a(kFirst, traits);
ScopedInt b(std::move(a));
EXPECT_TRUE(values_freed.empty()); // Nothing should be freed.
- ASSERT_EQ(IntTraits::InvalidValue(), a.get());
+ ASSERT_EQ(IntTraits::InvalidValue(),
+ a.get()); // NOLINT(bugprone-use-after-move)
ASSERT_EQ(kFirst, b.get());
}
@@ -90,7 +91,8 @@
b = std::move(a);
ASSERT_EQ(1u, values_freed.size());
EXPECT_EQ(kSecond, values_freed[0]);
- ASSERT_EQ(IntTraits::InvalidValue(), a.get());
+ ASSERT_EQ(IntTraits::InvalidValue(),
+ a.get()); // NOLINT(bugprone-use-after-move)
ASSERT_EQ(kFirst, b.get());
}