Mostly cleanup.
* Use temporary variables when we're going to call AsWebContents() repeatedly
* Remove some NOTREACHED()s that don't really help debugging (and none of the surrounding code checks)
* Try and simplify or make clearer some bits of code
Also enables/disables some commands more selectively: IDC_GO is now enabled only when the go button is visible (i.e. when we're not loading), and several commands whose UI is only available in normal windows are now only enabled in normal windows. This last change fixes a number of weird effects where you could hit different shortcuts in web app and popup windows and trigger commands with little or no UI feedback.
Review URL: http://codereview.chromium.org/14182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7141 0039d316-1c4b-4281-b951-d872f2087c98
3 files changed