Google Git
Sign in
chromium / chromium / src.git / 687a3b4cdcbd6c3850e06868d9aaaca6e1b83df3
commit687a3b4cdcbd6c3850e06868d9aaaca6e1b83df3[log] [tgz]
authorMario Bianucci <[email protected]>Wed Jun 05 18:11:48 2019
committerCommit Bot <[email protected]>Wed Jun 05 18:11:48 2019
tree5880b1891060fbcc7d11de3004d4d557b3dbe63f
parent9e6b9549664c2f3c192d2f1a0994ecc0c9d4a506 [diff]
Show cursors only for available scrolling directions when autoscrolling

This change adds two new cursors for auto scrolling, one that shows only
vertical directions, and the other that shows only horizontal. (This has
the unfortunate side effect of causing cascading small changes to many
files, sorry!) These new cursors are then used in autoscrolling so that
when a user is on a page that can only scroll vertically, if they middle
click it will then show an autoscroll cursor that reflects the available
directions, i.e. up and down only. Similar results for horizontal
scrolling only pages.

This change caches the directions available to scroll when the middle
mouse button is clicked and uses those to determine which cursors to show
when handling mouse move events. This unfortunately means that if a user
middle clicks somewhere that can only scroll vertically, and later that
changes to being able to scroll horizontally exclusively without user
input, the cursor will still only show vertical directions. However, this
matches what Firefox and non-Chromium-based Edge do right now, so this
seems fine to me. A file up bug to fix this issue should be filed though.

Bug: 11437
Change-Id: I68e083d1e0b9e14071f67f9268e826a40cebd783
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638924
Reviewed-by: David Bokan <[email protected]>
Reviewed-by: Bill Budge <[email protected]>
Reviewed-by: Sadrul Chowdhury <[email protected]>
Reviewed-by: Bret Sepulveda <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Mario Bianucci <[email protected]>
Cr-Commit-Position: refs/heads/master@{#666361}
24 files changed
tree: 5880b1891060fbcc7d11de3004d4d557b3dbe63f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .