Migrate //gin from base::Callback to base::{Once,Repeating}Callback
This updates //gin to use base::OnceCallback or base::RepeatingCallback
instead of legacy base::Callback. No intended functional change is included.
This reduces the number of 'base::Bind' in //gin from 8 to 1
as tracked at http://goo.gl/LUVhDj
Bug: 714018
Change-Id: I5c4bb758181c09e2d7b0e2fec5c51a4e1eec24bb
Reviewed-on: https://chromium-review.googlesource.com/952646
Reviewed-by: Jeremy Roman <[email protected]>
Commit-Queue: Taiju Tsuiki <[email protected]>
Cr-Commit-Position: refs/heads/master@{#541664}diff --git a/gin/arguments_unittest.cc b/gin/arguments_unittest.cc
index 6b6809a..f1506dd 100644
--- a/gin/arguments_unittest.cc
+++ b/gin/arguments_unittest.cc
@@ -31,8 +31,9 @@
// |creation_context|.
v8::Local<v8::ObjectTemplate> object_template =
ObjectTemplateBuilder(isolate)
- .SetMethod("checkCreationContext",
- base::Bind(check_creation_context, creation_context))
+ .SetMethod(
+ "checkCreationContext",
+ base::BindRepeating(check_creation_context, creation_context))
.Build();
v8::Local<v8::Object> object =
@@ -100,9 +101,12 @@
// |creation_context|.
v8::Local<v8::ObjectTemplate> object_template =
ObjectTemplateBuilder(isolate)
- .SetMethod("check1", base::Bind(check_arguments, &list1, &called1))
- .SetMethod("check2", base::Bind(check_arguments, &list2, &called2))
- .SetMethod("check3", base::Bind(check_arguments, &list3, &called3))
+ .SetMethod("check1",
+ base::BindRepeating(check_arguments, &list1, &called1))
+ .SetMethod("check2",
+ base::BindRepeating(check_arguments, &list2, &called2))
+ .SetMethod("check3",
+ base::BindRepeating(check_arguments, &list3, &called3))
.Build();
v8::Local<v8::Object> object =
