Migrate to NOTREACHED() in c/b/extensions/
NOTREACHED() and NOTREACHED_IN_MIGRATION() are both CHECK-fatal now.
The former is [[noreturn]] so this CL also performs dead-code removal
after the NOTREACHED().
This CL does not attempt to do additional rewrites of any surrounding
code, like:
if (!foo) {
NOTREACHED();
}
to CHECK(foo);
Those transforms take a non-trivial amount of time (and there are
thousands of instances). Cleanup can be left as an exercise for the
reader.
Bug: 40580068
Change-Id: I8566436eba05e2bebeec30f0daa54f8bb0b37bb5
Cq-Include-Trybots: luci.chromium.try:linux-dcheck-off-rel
Low-Coverage-Reason: OTHER Should-be-unreachable code
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5992690
Commit-Queue: Peter Boström <[email protected]>
Reviewed-by: Devlin Cronin <[email protected]>
Reviewed-by: Giovanni Ortuno Urquidi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1378726}
diff --git a/chrome/browser/extensions/launch_util.cc b/chrome/browser/extensions/launch_util.cc
index a439ffa..183bb3f 100644
--- a/chrome/browser/extensions/launch_util.cc
+++ b/chrome/browser/extensions/launch_util.cc
@@ -112,7 +112,7 @@
// If a new value for app.launch.container is added, logic for it should be
// added here. apps::LaunchContainer::kLaunchContainerWindow is not
// present because there is no way to set it in a manifest.
- NOTREACHED_IN_MIGRATION() << static_cast<int>(manifest_launch_container);
+ NOTREACHED() << static_cast<int>(manifest_launch_container);
}
// All paths should set |result|.
