| commit | 758e5e482e7cbbfd64073768da3f24c2788ffa42 | [log] [tgz] |
|---|---|---|
| author | Nate Chapin <[email protected]> | Tue May 02 00:22:55 2023 |
| committer | Chromium LUCI CQ <[email protected]> | Tue May 02 00:22:55 2023 |
| tree | 452df056dab04a080cf047e7b86d33809b5d549c | |
| parent | d1ef412039d70e0009632a3141bf83ad34555886 [diff] |
Don't bounds-check a history API navigation's offset in the renderer When a history API navigation occurs (e.g., history.go(-2)), we currently check whether the given offset is in-bounds before sending the navigation to the browser. The spec and WPT expect an async step to occur (i.e., going to the browser) so that we can take into account any pending back/forward navigations in offset calculation. However, when a history API navigation begins, we pause virtual time if the navigation is in-bounds only. If we can't check that in the renderer, we need of notifying the renderer that a history API navigation was out of bounds so that we can unpause virtual time. Add a case to the TraverseCancelled() message to unpause virtual time and call it for out-of-bounds history API navigations. (Note that TraverseCancelled() is currently only used for navigation API traversals, but there's nothing stopping us from using the same plumbing for this case). This change gives us the correct behavior when history.back() and history.forward() are called in rapid succession while at the front of the back/forward list. The forward() should be calculated from the pending entry for the back() navigation, resulting in the two navigations cancelling each other out. The renderer doesn't know what the pending offset is, so it thinks the forward() is trying to go out-of-bounds and incorrectly rejects that navigation. Change-Id: I36bfbe8211df5cad9f6cefeee659514299805434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4496257 Reviewed-by: Nasko Oskov <[email protected]> Commit-Queue: Nate Chapin <[email protected]> Reviewed-by: Andrey Kosyakov <[email protected]> Cr-Commit-Position: refs/heads/main@{#1138110}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.