commit | 7b7f672086ec9fb1f8c67225e49bfe75c7977a2e | [log] [tgz] |
---|---|---|
author | Matt Amert <[email protected]> | Thu Oct 03 00:27:42 2019 |
committer | Commit Bot <[email protected]> | Thu Oct 03 00:27:42 2019 |
tree | 9eb273d1d83da6627d88ef1de0ad4f1499e38d2d | |
parent | ef75841af7f5779f83dd98eae1d9044e3104478f [diff] |
Refactored WebMouseWheelEvent to use ScrollGranularity. WebMouseWheelEvent currently uses two bools to represent the units of the delta; one for precise pixel units and one for page units. However, it is undefined for them to both be true, and adding new units would not be trivial; as such, it should instead be represented as an enum. ScrollGranularity already includes this information, and so is used as the enum. However, since some of the other units (e.g. line) were previously not supported, a DCHECK has been added to the mouse wheel event queue to check that we aren't getting units we weren't expecting. This refactoring work is done on behalf of the CL http://crrev.com/c/1776898, which will be adding percentage units to ScrollGranularity. Bug: 1008132 Change-Id: I3972a375edfceefd29bbb05254c810d60706e3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812330 Reviewed-by: Daniel Cheng <[email protected]> Reviewed-by: Bill Budge <[email protected]> Reviewed-by: Ken Buchanan <[email protected]> Reviewed-by: Avi Drissman <[email protected]> Reviewed-by: Daniel Libby <[email protected]> Reviewed-by: David Bokan <[email protected]> Commit-Queue: Matt Amert <[email protected]> Cr-Commit-Position: refs/heads/master@{#702259}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .