| commit | 84d6c71edab97b2708a07ce7cbed9ae12af16796 | [log] [tgz] |
|---|---|---|
| author | mikt <[email protected]> | Wed Mar 27 13:29:03 2024 |
| committer | Chromium LUCI CQ <[email protected]> | Wed Mar 27 13:29:03 2024 |
| tree | c6e6c88c428c5cffc59c9164eb9e1dfa826b00b7 | |
| parent | 66587df8e953753669c9727090d516c11cd7047d [diff] |
[PA] Exclude PA from toplevel PRESUBMIT.py include guard check Currently, all PartitionAlloc headers are include-guarded with a guard name like `BASE_ALLOCATOR_PARTITION_ALLOCATOR_SRC_PARTITION_ALLOC_ PARTITION_ALLOC_H_`. This does not match with the fact that recent update, https://crbug.com/40276913, made it possible to include PA headers like: ``` #include "partition_alloc/partition_alloc_for_testing.h" ``` This chain of CLs will rewrite these include guards in three steps. 1. Allow-list PA directory from the top-level `PRESUBMIT.py` check for include guard names. [[ This CL ]] 2. Rewrite existing PA headers to use new guard names. [[ https://crrev.com/c/5384737 ]] 3. Add PA-level PRESUBMIT.py to enforce new guard names. [[ https://crrev.com/c/5384659 ]] Bug: 40276913 Change-Id: Iedbbce834fdfe36f48d3d062e42450cbb77bd8c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5384972 Reviewed-by: Daniel Cheng <[email protected]> Reviewed-by: Arthur Sonzogni <[email protected]> Commit-Queue: Mikihito Matsuura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1278910}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.