clang/win: Let some chromium_code targets build with -Wextra.
To make warning flags between Windows and non-Windows clang consistent,
I'd like to build chromium_code targets with -Wextra enabled. This fixes
-Wextra warnings in about 14k of 31k build steps.
Most of the warnings were about signed/unsigned mismatches; some were about
"const"s that had no effect.
(This CL does not contain the change to actually turn on -Wextra, only
cleanups.)
BUG=567877
TBR=content/common/sandbox
Review URL: https://codereview.chromium.org/1507413003
Cr-Commit-Position: refs/heads/master@{#364232}
diff --git a/base/file_version_info_win.cc b/base/file_version_info_win.cc
index ca3e4b1..a7dc216 100644
--- a/base/file_version_info_win.cc
+++ b/base/file_version_info_win.cc
@@ -149,7 +149,7 @@
bool FileVersionInfoWin::GetValue(const wchar_t* name,
std::wstring* value_str) {
WORD lang_codepage[8];
- int i = 0;
+ size_t i = 0;
// Use the language and codepage from the DLL.
lang_codepage[i++] = language_;
lang_codepage[i++] = code_page_;