Remove PAGE_TYPE_INTERSTITIAL enum value.
Interstitial pages no longer work as overlays, they are just regular
error pages. This makes the PAGE_TYPE_INTERSTITIAL value in PageType
obsolete, therefore this CL removes it from the codebase.
Bug: 1077074
Change-Id: I9487bc97018b0f832f6d5b70cda04ea217bc8031
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570126
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Carlos IL <[email protected]>
Commit-Queue: Nasko Oskov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#833861}
diff --git a/content/browser/renderer_host/navigation_controller_impl.cc b/content/browser/renderer_host/navigation_controller_impl.cc
index 30eb7b40..44a9cde 100644
--- a/content/browser/renderer_host/navigation_controller_impl.cc
+++ b/content/browser/renderer_host/navigation_controller_impl.cc
@@ -3748,16 +3748,11 @@
NavigationControllerImpl* source,
int max_index) {
DCHECK_LE(max_index, source->GetEntryCount());
- size_t insert_index = 0;
for (int i = 0; i < max_index; i++) {
- // When cloning a tab, copy all entries except interstitial pages.
- if (source->entries_[i]->GetPageType() != PAGE_TYPE_INTERSTITIAL) {
- // TODO(creis): Once we start sharing FrameNavigationEntries between
- // NavigationEntries, it will not be safe to share them with another tab.
- // Must have a version of Clone that recreates them.
- entries_.insert(entries_.begin() + insert_index++,
- source->entries_[i]->Clone());
- }
+ // TODO(creis): Once we start sharing FrameNavigationEntries between
+ // NavigationEntries, it will not be safe to share them with another tab.
+ // Must have a version of Clone that recreates them.
+ entries_.insert(entries_.begin() + i, source->entries_[i]->Clone());
}
DCHECK(pending_entry_index_ == -1 ||
pending_entry_ == GetEntryAtIndex(pending_entry_index_));
