| commit | 938c875021b54c024136af2f61d9917d5c4dc3be | [log] [tgz] |
|---|---|---|
| author | Samuel Huang <[email protected]> | Fri Nov 04 14:37:31 2022 |
| committer | Chromium LUCI CQ <[email protected]> | Fri Nov 04 14:37:31 2022 |
| tree | 55139cbef2864efebdd2bd3c4c92463bd79e0969 | |
| parent | 4d3ca0654531806da6350c85aaaeb6a6a713a35d [diff] |
[Build] Update version.txt generation for high-end ARM64 Android devices.
High-end ARM64 build will be a build variant for Android Chrome
(Trichrome only). Supporting this requires new version number to be
allotted. This CL updates android_chrome_version.py to generate the
new version number, and updates related build files to accommodate.
The approach taken is to consider high-end ARM64 as yet another ABI, on
equal footing as {32, 32_64, 64_32, 64}, as "64_high" (given 9 for the
final digit). The addition breaks symmetry between ARM vs. Intel cases,
requiring additional CPU-based conditionals.
The TRICHROME vs. TRICHROME_BETA distinction also requires duplication
of the flag.
Details:
* During "gn_gen", for arm64 Android, write new items to
android_chrome_versions.txt:
TrichromeChrome64High: ???????39
TrichromeChrome64HighOpenBeta: ???????49
* android_chrome_version.py: Generate version code (only for
arm64) and return then as keys them in
TRICHROME_64_HIGH_VERSION_CODE
TRICHROME_64_HIGH_BETA_VERSION_CODE
* version.gni: |_version_dictionary_template| with the above, write
to values to android_chrome_versions.txt, and forward them as:
trichrome_64_high_version_code
trichrome_64_high_beta_version_code
* Context: Build flag |is_high_end_android| (defined in
chrome_build.gni) to True (only for |target_cpu| = "arm64") indicates
intent to generate hign-end ARM64 build.
* In multiple .gni files: Copy |is_high_end_android| to decision var
|_use_high_package_name_for_64bit_only_trichrome|, and uses it to
to assign |_version_code| to the high-end ARM64 codes if specified
(including TRICHROME_BETA case), in 4 instances.
Bug: 1291808
Change-Id: I11afe918a43e1a4b6b925751c50221ea58c60ade
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3938487
Commit-Queue: Samuel Huang <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1067530}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.